Jim Graham
8089a309a9
Remove obsolete drawShadow bounds workaround ( #127052 )
...
This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).
Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654
2023-05-18 00:17:33 +00:00
Loïc Sharma
718f444bc3
[Windows] Improve version migration message ( #127048 )
...
This also migrates the platform channel example to stamp version information on Windows.
2023-05-17 23:07:16 +00:00
dependabot[bot]
a3a0ef0393
Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb ( #127056 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb.
<details>
<summary>Commits</summary>
<ul>
<li><a href="6b107e7a7ehttps://redirect.github.com/actions/labeler/issues/565 ">#565</a>)</li>
<li><a href="d93c73a681https://redirect.github.com/actions/labeler/issues/566 ">#566</a>)</li>
<li><a href="b6f708799chttps://redirect.github.com/actions/labeler/issues/559 ">#559</a>)</li>
<li><a href="2d89bd5059https://redirect.github.com/actions/labeler/issues/560 ">#560</a>)</li>
<li><a href="581d1100aahttps://redirect.github.com/actions/labeler/issues/558 ">#558</a>)</li>
<li><a href="8bb4872750https://redirect.github.com/actions/labeler/issues/543 ">#543</a>)</li>
<li><a href="9c4ae1e112https://redirect.github.com/actions/labeler/issues/553 ">#553</a>)</li>
<li><a href="228fdad71dhttps://redirect.github.com/actions/labeler/issues/544 ">#544</a>)</li>
<li><a href="377691d3d6https://redirect.github.com/actions/labeler/issues/554 ">#554</a>)</li>
<li>See full diff in <a href="9471598e3b...6b107e7a7e
2023-05-17 22:57:48 +00:00
Renzo Olivares
d44d657ade
Remove deprecated fixTextFieldOutlineLabel ( #125893 )
...
The deprecation period has elapsed. The method was made obsolete in https://github.com/flutter/flutter/pull/87281 .
2023-05-17 22:56:14 +00:00
engine-flutter-autoroll
45179a62c8
Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) ( #127053 )
...
331c5769e2...d970370779skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo... (flutter/engine#42100 )
2023-05-17 jonahwilliams@google.com [Impelller] fix flickering due to synchronization issues in compute tessellator. (flutter/engine#42076 )
2023-05-17 rmolivares@renzo-olivares.dev [Android] Do not collapse text selection on shift key up (flutter/engine#42075 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YrEDYUB9NKhi to SDKw1RvH0dWi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 22:52:28 +00:00
Christopher Fujino
aa0a1a7ae1
shard windows build tests 3 -> 4 ( #127057 )
...
Time outs are currently making the tree red.
Fixes https://github.com/flutter/flutter/issues/127004
2023-05-17 15:49:35 -07:00
engine-flutter-autoroll
dad561f44c
Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) ( #127049 )
...
0ae3719d70...331c5769e2mdebbar@google.com [web] Simplify handling of custom url strategy (flutter/engine#42043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 21:21:56 +00:00
Sam Rawlins
7a32504531
Ignore unused_element_parameter ( #126926 )
...
When the analyzer detects an unused parameter, it reports `unused_element` which can be ignored with an inline ignore like `// ignore: unused_element`. The analyzer will start reporting instead, `unused_element_parameter`. There are ignores in flutter/flutter that need to be updated to the new code. In order to incrementally migrate, they can be changed to `// ignore: unused_element, unused_element_parameter`.
After flutter/flutter is using a new enough analyzer, we can then change those to `// ignore: unused_element_parameter`.
Work towards https://github.com/flutter/flutter/issues/126924
2023-05-17 21:16:24 +00:00
engine-flutter-autoroll
9657289f4a
Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) ( #127043 )
...
47fd496c6f...0ae3719d70dnfield@google.com Report displays for macOS (flutter/engine#41998 )
2023-05-17 dnfield@google.com Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 19:12:06 +00:00
engine-flutter-autoroll
1f09a8662d
Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) ( #127041 )
...
400a26ad83...47fd496c6f103135467+sealesj@users.noreply.github.com Re-Enable Vulnerability 3p Scanning Workflow (flutter/engine#42049 )
2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from c3473c32bb35 to ffa425bacfc4 (14 revisions) (flutter/engine#42095 )
2023-05-17 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (#39801 ) (flutter/engine#41965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 18:19:32 +00:00
Christopher Fujino
05af460790
[flutter_tools] unpin and roll camera_android ( #126945 )
...
camera_android was pinned because of https://github.com/flutter/flutter/issues/126710 , which was fixed upstream in release 0.10.8+1.
2023-05-17 18:07:20 +00:00
Michael Goderbauer
acbfb40f05
Handle null return from WillPopCallback ( #127039 )
...
Partial revert of https://github.com/flutter/flutter/pull/126647 to work around issue in google3.
See b/283046390
2023-05-17 17:50:36 +00:00
engine-flutter-autoroll
c08b9accbc
Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) ( #127036 )
...
6048360c18...400a26ad83skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dIATtSiPf8KE25MMF... to wNfsef5we4l8hxEII... (flutter/engine#42094 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from dIATtSiPf8KE to wNfsef5we4l8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 17:06:20 +00:00
Michael Goderbauer
0bd275fe66
Remove unused (and untested) parameters from private _MasterDetailFlow ( #126935 )
...
Follow-up to https://github.com/flutter/flutter/pull/126926 .
2023-05-17 17:06:18 +00:00
Justin McCandless
9d882983ff
Autocomplete async examples ( #126283 )
...
Added examples clarifying how to fetch Autocomplete options asynchronously.
2023-05-17 09:46:26 -07:00
JellyO1
561169ec67
Expose callback that allows focus traversal customization ( #120235 )
...
This PR exposes a requestFocusCallback on `FocusTraversalPolicy` and it's inheritors.
Fixes #83175 .
2023-05-17 16:43:50 +00:00
engine-flutter-autoroll
1a76859cd6
Roll Packages from b9718302b30f to 5c6991400e91 (5 revisions) ( #127034 )
...
b9718302b3...5c6991400eflutter/packages#3770 )
2023-05-17 JeroenWeener@users.noreply.github.com [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752 )
2023-05-17 stuartmorgan@google.com [ci] Re-enable Windows repo tool tests (flutter/packages#4007 )
2023-05-16 stuartmorgan@google.com [ci] Allow simctl shutdown to fail (flutter/packages#4024 )
2023-05-16 stuartmorgan@google.com [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 16:12:53 +00:00
engine-flutter-autoroll
05390851c9
Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) ( #127032 )
...
ea3f27383a...6048360c18skia-flutter-autoroll@skia.org Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) (flutter/engine#42093 )
2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) (flutter/engine#42090 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 16:11:33 +00:00
Taha Tesser
160618b103
Add missing Switch.onFocusChange test ( #126685 )
2023-05-17 08:36:24 -07:00
joshualitt
d021109d93
Remove 'url_launcher' from pubspec.yaml. ( #126939 )
2023-05-17 08:31:37 -07:00
engine-flutter-autoroll
e2aafd4554
Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) ( #126994 )
...
4b7c37532e...ea3f27383askia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... (flutter/engine#42086 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from D_EOM3rJ8AMk to YrEDYUB9NKhi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 07:37:22 -07:00
engine-flutter-autoroll
45e3039a45
Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) ( #126985 )
...
170b45bae5...4b7c37532eskia-flutter-autoroll@skia.org Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) (flutter/engine#42085 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 04:56:25 +00:00
engine-flutter-autoroll
4be65314d5
Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) ( #126981 )
...
28b9dc993c...170b45bae5skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N4LwCRxg0oIevhQ_O... to dIATtSiPf8KE25MMF... (flutter/engine#42084 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N4LwCRxg0oIe to dIATtSiPf8KE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 04:02:29 +00:00
engine-flutter-autoroll
abdf1f463f
Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) ( #126974 )
...
87a03e107d...28b9dc993cskia-flutter-autoroll@skia.org Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) (flutter/engine#42082 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 01:55:17 +00:00
engine-flutter-autoroll
790897c6a2
Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) ( #126968 )
...
1c775e34e2...87a03e107dbdero@google.com [Impeller] Use 32 bit Gaussian function in the 2-pass blur (flutter/engine#42069 )
2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) (flutter/engine#42081 )
2023-05-16 jacksongardner@google.com Use client ICU data with skwasm. (flutter/engine#42018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 00:56:41 +00:00
Sigurd Meldgaard
788ceb34a3
Fix style issues ( #122586 )
...
Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.
2023-05-16 23:56:21 +00:00
engine-flutter-autoroll
5df903a013
Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) ( #126961 )
...
Manual roll requested by zra@google.com
fe2476743b...1c775e34e2zanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080 )
2023-05-16 gspencergoog@users.noreply.github.com [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753 )
2023-05-16 gspencergoog@users.noreply.github.com [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782 )
2023-05-16 jacksongardner@google.com Initial support for images in
Skwasm (flutter/engine#42019 )
2023-05-16 jacksongardner@google.com Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991 )
2023-05-16 jason-simmons@users.noreply.github.com Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945 )
2023-05-16 737941+loic-sharma@users.noreply.github.com [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061 )
2023-05-16 godofredoc@google.com Fix drone_dimension
host_engine_builder. (flutter/engine#42068 )
2023-05-16 godofredoc@google.com Add linux_clang_tidy builder.
(flutter/engine#41990 )
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 16:00:08 -07:00
Ian Hickson
027bb84444
Make SlottedMultiChildRenderObjectWidgetMixin a concrete class ( #126108 )
...
This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class.
I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox.
I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...
2023-05-16 22:28:54 +00:00
Ian Hickson
5235a0f092
Add ScrollMetrics.extentTotal for completeness ( #126607 )
...
When implementing scrollbars, I found that it would be useful and idiomatic to be able to do `m.extentInside / m.extentTotal` to get the scrollbar thumb size.
2023-05-16 22:24:03 +00:00
godofredoc
25a9efe994
Fix drone_dimensions. ( #126953 )
...
Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.
2023-05-16 22:11:21 +00:00
Mitchell Goodwin
678f40cf04
Add checkmark style to CupertinoRadio ( #126480 )
...
Fixes : #102813
Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.
This is how it looks in action:
https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e
2023-05-16 21:54:20 +00:00
keyonghan
3f01c7e019
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to prod ( #126941 )
...
Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164 , and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50 .
Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.
The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.
Context: https://github.com/flutter/flutter/issues/103542
2023-05-16 21:46:06 +00:00
Jason Simmons
e24c64d8ee
Fix DataTableThemeData.copyWith handling of dataRowHeight ( #126943 )
...
Fixes https://github.com/flutter/flutter/issues/126676
2023-05-16 21:44:24 +00:00
Mushaheed Syed
60751ca519
Fix copyWith method of ActionIconThemeData ( #126763 )
...
Fixes copyWith method of ActionIconThemeData, now using blank copyWith on [ActionIconThemeData] object that isn't `const ActionIconThemeData()` returns object with same values.
*List which issues are fixed by this PR.*
Fixes https://github.com/flutter/flutter/issues/126762
2023-05-16 21:38:23 +00:00
Zachary Anderson
99464341f0
Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" ( #126954 )
...
Reverts flutter/flutter#126934
Bad Engine roll.
2023-05-16 21:30:53 +00:00
engine-flutter-autoroll
d0d1feb628
Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions) ( #126934 )
...
fe2476743b...5cf141f7c0godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990 )
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 18:44:41 +00:00
Michael Goderbauer
1ca183d55b
Remove outdated comment ( #126927 )
...
Follow-up to https://github.com/flutter/flutter/pull/126647#discussion_r1195417860 .
2023-05-16 17:39:12 +00:00
yaakovschectman
130944e785
Alert engine upon registering ServiceBinding ( #126075 )
...
Send a platform message to the engine when the `ServiceBinding` is
registered. Framework side of
https://github.com/flutter/engine/pull/41733
Addresses https://github.com/flutter/flutter/issues/126033
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2023-05-16 13:37:12 -04:00
engine-flutter-autoroll
cc44359bd0
Roll Flutter Engine from 525a53eb58ed to fe2476743b59 (1 revision) ( #126925 )
...
525a53eb58...fe2476743bskia-flutter-autoroll@skia.org Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) (flutter/engine#42072 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 17:02:28 +00:00
Victoria Ashworth
2b3cd7f4d9
Replace rsync when unzipping artifacts on a Mac ( #126703 )
...
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785 ), delete the file/directory/link prior to moving it.
Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files
Part of https://github.com/flutter/flutter/issues/126016 .
2023-05-16 16:58:06 +00:00
Jason Simmons
a3b38aa8f3
Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class ( #126570 )
...
See https://github.com/flutter/flutter/issues/123756
2023-05-16 16:41:11 +00:00
st merlhin
6753a852d0
expose CupertinoDatePicker and CupertinoTimerPicker itemExtent … ( #125852 )
...
â¦property
This PR expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` property to allow setting custom one depending on `tMediaQuery.of(context).textScaleFactor`.
Fixes : #125127
2023-05-16 16:30:08 +00:00
engine-flutter-autoroll
856fcc304a
Roll Flutter Engine from d7a5de672d1e to 525a53eb58ed (1 revision) ( #126923 )
...
d7a5de672d...525a53eb58skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... (flutter/engine#42071 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 38Oyy28qgYCd to D_EOM3rJ8AMk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 09:22:05 -07:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint ( #126647 )
2023-05-16 16:14:23 +00:00
engine-flutter-autoroll
b45f9b36e8
Roll Packages from 6608b604b0e7 to b9718302b30f (2 revisions) ( #126921 )
...
6608b604b0...b9718302b3stuartmorgan@google.com [camera] Fix Android lint issues (flutter/packages#3993 )
2023-05-15 stuartmorgan@google.com [various] Update min macOS versions (flutter/packages#3987 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 15:51:46 +00:00
Taha Tesser
2f5ed33912
Updated the Drawer API doc to link to NavigationDrawer ( #126915 )
...
fixes https://github.com/flutter/flutter/issues/124887
2023-05-16 15:45:09 +00:00
engine-flutter-autoroll
e62e5c4191
Roll Flutter Engine from c4d4b40c6596 to d7a5de672d1e (4 revisions) ( #126919 )
...
c4d4b40c65...d7a5de672dskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JCoP2Fekj3MBIqskE... to N4LwCRxg0oIevhQ_O... (flutter/engine#42070 )
2023-05-16 zhangzhijian.123@bytedance.com [Impeller] Fix issue about
saveLayer ignoring opacity of paint with advanced blend mode
(flutter/engine#41972 )
2023-05-16 ychris@google.com [ios_platform_view] Only remove platform
views from flutter view in reset. (flutter/engine#41709 )
2023-05-16 godofredoc@google.com Add drone_dimensions as top level
target property. (flutter/engine#42064 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JCoP2Fekj3MB to N4LwCRxg0oIe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 08:13:28 -07:00
Polina Cherkasova
ea5eddb5a9
Upgrade leak_tracker to 5.0.0 ( #126367 )
...
Fixes https://github.com/flutter/flutter/issues/126259
Updated pubspec:
345f0bffbf/packages/flutter/pubspec.yaml
2023-05-16 04:39:26 +00:00
Ian Hickson
2919572fb3
Minor documentation fixes ( #126609 )
...
Fixes for grammar, tone, and clarity.
2023-05-16 02:01:28 +00:00
engine-flutter-autoroll
6b6c4bdb6b
Roll Flutter Engine from 027ca797985f to c4d4b40c6596 (6 revisions) ( #126894 )
...
027ca79798...c4d4b40c65ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056 )
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057 )
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055 )
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 01:05:42 +00:00
