firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5,944 Commits 1 Branch 0 Tags
Commit Graph

5944 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Adam Barth
639532bd51 Don't pick up Android SDK from local engine (#4801) 
It can cause trouble if the user has a newer Android SDK installed normally.
Instead, just use the normal Android SDK.
 2016-06-30 15:47:56 -07:00
Hans Muller
107cbd3185 Refresh Indicator fine tuning (#4800) 2016-06-30 15:36:06 -07:00
Matt Perry
6298a1aeb1 Fix a bug where ScrollableGrid/ScrollableList would flicker when (#4794) 
navigating away.

Details are in the bug, but when we navigate away, the overscroll
indicator around the Scrollable would change the widget hierarchy. This
would trigger the Scrollable to rebuild, which would cause its
scrollOffset to be clamped to 0 for a frame.

BUG=https://github.com/flutter/flutter/issues/4597
 2016-06-30 15:43:47 -04:00
Todd Volkert
f410ca80b7 Include target in revision string, since it affects the xcode config (#4795) 2016-06-30 11:33:36 -07:00
Phil Quitslund
14c5321129 Merge pull request #4793 from pq/analyzer_0.27.4-alpha.15 
Update to latest analyzer (w/ cleanup).
 2016-06-30 11:05:31 -07:00
pq
ec256c5ee4 Removed trampoline. 2016-06-30 10:50:38 -07:00
pq
a417786d77 Update to latest analyzer (w/ cleanup). 
Bye-bye `@protected `trampolines! :)
 2016-06-30 10:39:45 -07:00
Phil Quitslund
fa7f271448 Merge pull request #4790 from pq/1.18.0-dev.3.0 
Update to latest Dart SDK (1.18.0-dev.3.0).
 2016-06-30 10:08:09 -07:00
Hans Muller
d9b9983e1a Refresh indicator (#4788) 2016-06-30 10:07:28 -07:00
pq
a185d3749f Update to latest Dart SDK (1.18.0-dev.3.0). 2016-06-30 07:43:01 -07:00
Adam Barth
63eedb7677 Semantics debugger shouldn't crash when reparenting nodes (#4782) 
Our previous approach to detecting when we needed to remove semantics nodes
didn't account for reparenting.
 2016-06-28 14:44:02 -07:00
Phil Quitslund
05bcbb6cd0 Merge pull request #4785 from pq/empty_statement_cleanup 
Cleanup empty statements.
 2016-06-28 14:02:05 -07:00
pq
543f705adb Cleanup empty statements. 
The new `empty_statements` lint (in the next DEV roll), flags these empty statements.  Harmless, except the one in `basic.dart` that fixes a real-life bug. :)
 2016-06-28 13:42:22 -07:00
Todd Volkert
fbab25be59 Remove errant xcuserdata file from project templates (#4784) 2016-06-28 13:39:07 -07:00
Chinmay Garde
1a5ca2f675 Fix failing tooltip_test.dart by avoiding floating point comparisons. (#4781) 2016-06-28 12:49:11 -07:00
Chinmay Garde
b8bcd62e54 Remove counters used to tag variables and symbols in the solver for debugging purposes. (#4780) 2016-06-28 11:58:24 -07:00
Hans Muller
77cd8ee40e Reproduce the Shrine home page portrait grid layout (#4779) 2016-06-28 11:05:18 -07:00
Adam Barth
41d6303570 Improve test coverage for material.dart (#4776) 
Previously these widget had zero test coverage. Also, improve the
coverage tooling Mac.
 2016-06-28 08:48:48 -07:00
Adam Barth
14f42a6a48 Improve test coverage in rendering.dart (#4775) 2016-06-27 17:38:53 -07:00
Adam Barth
bb0c41f2a6 Improve test coverage for gestures.dart (#4773) 
This patch adds tests for some code paths we weren't hitting before and removes
some dead code that couldn't be tested because it was unreachable.
 2016-06-27 14:42:41 -07:00
Adam Barth
2898768dde Add some missing docs (#4772) 
These docs complete the dartdocs for their respective libraries.
 2016-06-27 14:42:25 -07:00
Adam Barth
2af668f832 Change how navigator prevents redundant operations (#4769) 
* Change how navigator prevents redundant operations

Instead of requiring transactions, we now cancel all active pointers that are
interacting with the navigator and absorb future pointers until we get a chance
to build. This approach isn't perfect (e.g., events that trigger off the
cancelled pointers could still interact with the navigator), but it should be
better than the current transaction-based approach.

Fixes #4716

* Remove openTransaction

* test

* fixup
 2016-06-27 13:07:47 -07:00
Hans Muller
08bf1b6bce Scrollable dropdown, dropdown underline cosmetics (#4766) 2016-06-27 10:28:20 -07:00
Adam Barth
5fc04dab74 Document State (#4762) 
This patch documents State in detail because it's a very common class
for developers to work with and it has a number of subtles.
 2016-06-26 16:22:20 -07:00
Kaiyuan Wang
ccf87bd083 Fix the issue that flutter driver does not close _peer (#4755) 
* Fix the issue that flutter driver does not close _peer when
driver.close() is invoked.  The problem introduces the following
unexpected behavior:

  1. Launch an app using "flutter run ..." command
  2. Run the flutter driver test using "dart flutter_test.dart"

The test will not exit after running.  The problem will be solved
if _peer is closed.

* Fix formatting issue
 2016-06-25 12:58:46 -07:00
Adam Barth
2fa6a709c9 Improve documentation for framework.dart (#4758) 2016-06-25 12:22:14 -07:00
Adam Barth
9c0c0225a6 Add a test for GridPaper (#4754) 
Previously this widget was completely untested.
 2016-06-24 20:46:17 -07:00
Hans Muller
0a4f96e2b6 Gallery about box: state Flutter's status and link to our website (#4746) 2016-06-24 17:54:21 -07:00
Chinmay Garde
ae835f08df Document the public members of the Cassowary package. (#4744) 2016-06-24 17:31:47 -07:00
Adam Barth
9850fe1861 Test all but one line in animation.dart (#4751) 
The one line we don't test is the private constructor for the Curves class,
which exists to ensure that no one constructs the Curves class.
 2016-06-24 16:33:04 -07:00
Adam Barth
b00efda7fc Improve change notifier (#4747) 
This patch improves some subtle behaviors about the change notifier.
 2016-06-24 15:53:48 -07:00
Chinmay Garde
490622b4da Add a wrapper for accessing the URL launcher service. (#4688) 2016-06-24 14:51:03 -07:00
Chinmay Garde
e41527a898 Update the engine to pull in changes related to url_launcher.mojom. (#4745) 2016-06-24 12:26:05 -07:00
Devon Carew
6cdfd86ad1 send the reload source command for ios simulators (#4731) 
* send the reload source command for ios simulators

* review changes

* rewrite w/ a completer
 2016-06-24 10:26:43 -07:00
Devon Carew
aa364a082d don't rewrite the console in non-ansi mode (#4735) 2016-06-24 09:56:04 -07:00
Adam Barth
46da9e8498 Add a simple way of merging coverage data (#4726) 
`flutter test` now has a `--merge-coverage` flag that can be used to merge
coverage data from previous runs, enabling faster iteration cycles.
 2016-06-23 18:02:55 -07:00
Devon Carew
4dd48882ef Update CONTRIBUTING.md (#4730) 2016-06-23 17:47:03 -07:00
Adam Barth
10931af0d3 Simplify coverage workflow (#4725) 
We now download the base coverage file automatically.
 2016-06-23 16:31:25 -07:00
Adam Barth
f20546a1d7 Remove drudge spam (#4724) 
Stop spamming the console about drudge by pinning an earlier version of
json_scheme that doesn't spam.
 2016-06-23 15:37:51 -07:00
Adam Barth
7b99ecff35 Use relative paths in lcov.info (#4722) 
Using relative paths makes it easier to share lcov.info files across machines.
 2016-06-23 15:29:54 -07:00
Hans Muller
68efa6a3fc Correct scrolling tabbar tab indicator size (#4723) 2016-06-23 15:17:17 -07:00
Adam Barth
05eef4a9b2 Get to 100% test coverage for src/animation/animations.dart (#4721) 2016-06-23 15:15:31 -07:00
Ian Hickson
8409526433 Update README.md 2016-06-23 14:03:26 -07:00
Ian Hickson
e53d3c2648 Update README.md 2016-06-23 14:02:56 -07:00
Adam Barth
56039c0e64 Improve test coverage for animation.dart (#4718) 
We now have 100% coverage of animation.dart and animation_controller.dart.
Also, add some basic tools for working with lcov files. These tools need much
more polish.
 2016-06-23 13:43:42 -07:00
Adam Barth
74761265bc Add dartdoc for tabs and text selection handles (#4715) 2016-06-23 13:43:16 -07:00
Adam Barth
4be730ac9a Only download cloud SDK if we need it on Travis 2016-06-23 11:56:20 -07:00
Hans Muller
c12c179a72 Make DataTable readable with the dark theme (#4717) 2016-06-23 10:59:07 -07:00
Ian Hickson
e5fb2fb0d3 An API for tracking software licenses. (#4711) 2016-06-23 10:34:11 -07:00
Adam Barth
bbf31cd3b7 Upload lcov.info to Google Storage (#4712) 
Uploading the coverage data file to Google Storage will make it easier
for folks to get current coverage data quickly.
 2016-06-23 10:23:13 -07:00