5944 Commits

Author SHA1 Message Date
Phil Quitslund
55b51ee549 Merge pull request #4697 from pq/analyzer_0.27.4-alpha.14
Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
2016-06-23 10:03:49 -07:00
pq
1cad4f4705 Fallback to a standard SDK if no embedders are found. 2016-06-22 19:30:46 -07:00
Adam Barth
4f133a6775 Don't run coverage on pull requests (#4710)
It's not reliable enough yet.
2016-06-22 17:52:08 -07:00
Adam Barth
73cd70f776 Add test coverage for lastElapsedDuration (#4705)
Also, fix the bug where apps would assert when you change the time dilation.
Use that mechanism to fix the animation controller tests.
2016-06-22 17:14:55 -07:00
Todd Volkert
e91f3eef46 Don't uninstall before installing in flutter run (#4699)
#4672
2016-06-22 15:43:57 -07:00
pq
b2fed16454 _BuildFunction => WidgetBuilder 2016-06-22 15:39:27 -07:00
pq
dcc7b144af Updated closure trampolines. 2016-06-22 15:25:25 -07:00
Hans Muller
bb2e7b5250 Add AppBar iconTheme parameter (#4693) 2016-06-22 15:19:31 -07:00
Adam Barth
e5eabf24fa Add Coveralls badge to README.md (#4700) 2016-06-22 15:11:24 -07:00
Adam Barth
ed2c24ba2b Add coveralls support to Travis (#4690)
This patch causes us to upload a coverage report to coveralls.io.
2016-06-22 14:47:41 -07:00
pq
352e2f573b Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
* brings in analyzer version (`0.27.4-alpha.14`) corresponding to current Dart SDK (`1.18.0-dev.2.0`).
* updates analysis to use prefered API for embedder URI resolution
* adds trampolines to `State` and `StatelessWidget` to allow for warning-free within-library @protected access (needed since we closed off access to @protected closures from outside subclasses).
* turns off cache dependency tracking for analysis (in DDC this amounted to a 10% speed improvement).
2016-06-22 14:34:30 -07:00
Todd Volkert
0f2c3dc07f Fix multi-line colors on Linux (#4691) 2016-06-22 12:53:07 -07:00
Adam Barth
b094fa6dd3 Add support for --coverage to flutter test (#4679)
We need https://github.com/dart-lang/coverage/issues/100 to be fixed before
this will be useful.

Fixes #2342
2016-06-22 12:22:01 -07:00
Phil Quitslund
6c0b88aad6 Merge pull request #4683 from pq/1.18.0-dev.2.0
Bump Dart SDK to `1.18.0-dev.2.0`.
2016-06-22 11:32:47 -07:00
Todd Volkert
bc5a66f9e5 Color coding (#4687) 2016-06-22 11:30:21 -07:00
Ian Hickson
cd89e867ef About box API (#4677)
This API is the front-end part of the work on showing licenses.

Future patches will:

* Provide an API for registering what licenses should be shown here,
  which will be used by this feature to shown licenses but could also be
  used by custom code for showing licenses (e.g. for people not using
  the Material widgets).

* Actually populate this license API from all the licenses we currently
  use in the engine, in the framework, and from any pub packages that
  are used (directly or indirectly) by the application.
2016-06-22 10:42:02 -07:00
Todd Volkert
ef49e28ecf Update engine to pick up crash fix in DBC (#4684) 2016-06-22 10:40:50 -07:00
Todd Volkert
84bdb326b4 dev/bots/test.sh += robustness (#4682) 2016-06-22 10:18:24 -07:00
pq
f452551d16 Bump Dart SDK to 1.18.0-dev.2.0.
Gets a bunch of fixes.  Most notably a VM that has background compilation re-enabled (and stable).  This should win us (back) a ~17% improvement of analysis times (CLI and server).

See: https://github.com/dart-lang/sdk/issues/26697 for more context.
2016-06-22 10:01:48 -07:00
Adam Barth
bf740cf46b Restore SystemChrome.setEnabledSystemUIOverlays (#4680)
I erroneously removed this function in an earlier patch. Also, export
SystemUiOverlayStyle because we expose that enum in the SystemChrome
API.
2016-06-22 16:45:47 +02:00
Hans Muller
7c3a943548 Remove the gallery Live Demo buttons, etc (#4678) 2016-06-21 17:28:41 -07:00
Adam Barth
a8f6f44a55 Update engine to include new version of Mojo (#4668)
This required switching from the Future-based bindings to the callback-based
bindings.
2016-06-21 15:53:47 -07:00
Jason Simmons
f307735edc Remove the assembleFlx accessor and FLX asset path overrides (#4671)
This is now obsolete
2016-06-21 15:29:34 -07:00
Hans Muller
b81229b5f1 DropdownButton layout (#4582) 2016-06-21 15:20:35 -07:00
Hans Muller
0e38cba95f Make the limit that defines Row/Column free space configurable (#4646) 2016-06-21 14:29:22 -07:00
Jason Simmons
fad7cf59e3 Update hello_services for a change to the message listener API (#4670) 2016-06-21 14:26:30 -07:00
Adam Barth
97c1f0b7b2 Route.didMount should throw a useful error message (#4665)
The error code path wasn't actually getting the point where it would throw the
useful error message. Also, fix error recovery when runApp fails.

Fixes #4655
2016-06-21 14:10:13 -07:00
Jason Simmons
c823acc345 Pass a package map to gen_snapshot instead of a packages symlink directory (#4666) 2016-06-21 13:47:24 -07:00
Jason Simmons
d4ecd0235d Update engine version (#4663) 2016-06-21 12:44:43 -07:00
Todd Volkert
db0efec505 Make bots.sh print failure for when it's run locally (#4654) 2016-06-21 10:50:05 -07:00
Ali Ghassemi
14f8d91803 Fixing sprites' image map regression. (#4628)
* Fixing sprites' image map regression.
* Smoke tests for ImageMap
2016-06-21 10:42:12 -07:00
Adam Barth
4a79d6f1f4 Update engine.version (#4658) 2016-06-21 10:06:46 -07:00
Todd Volkert
2e48c1a1bb Simplify SystemChrome.setSystemUIOverlayStyle() (#4653)
* Only schedule overlay style update microtask if needed

* Simplify API
2016-06-21 08:28:29 -07:00
Ian Hickson
e502e9c8f8 ImageIcon (#4649)
Anywhere that accepted IconData now accepts either an Icon or an
ImageIcon.

Places that used to take an IconData in an `icon` argument, notably
IconButton and DrawerItem, now take a Widget in that slot. You can wrap
the value that used to be passed in in an Icon constructor to get the
same result.

Icon itself now takes the icon as a positional argument, for brevity.

ThemeData now has an iconTheme as well as a primaryIconTheme, the same
way it has had a textTheme and primaryTextTheme for a while.

IconTheme.of() always returns a value now (though that value itself may
have nulls in it). It defaults to the ThemeData.iconTheme.

IconThemeData.fallback() is a new method that returns an icon theme data
structure with all fields filled in.

IconTheme.merge() is a new constructor that takes a context and creates
a widget that mixes in the new values with the inherited values.

Most places that introduced an IconTheme widget now use IconTheme.merge.

IconThemeData.merge and IconThemeData.copyWith act in a way analogous to
the similarly-named members of TextStyle.

ImageIcon is introduced. It acts like Icon but takes an ImageProvider
instead of an IconData.

Also: Fix the analyzer to actually check the stocks app.
2016-06-20 21:04:45 -07:00
Adam Barth
e071f0bafd Nesting MaterialApps should not assert (#4636)
Turns out we weren't managing focus correct between navigator routes because we
were missing a Focus widget above the routes. However, adding this widget
caused us to explode at startup because the initial route was trying to move
focus during the build phase.

This patch teaches Focus to have an initiallyFocusedScope, which can be use to
initialize the child focus scope.

Fixes #4065
2016-06-20 17:01:34 -07:00
Adam Barth
b3780ebc16 Fix asserts in Draggable dismounting (#4644)
In writing a test for #1927, I found a number of bugs in how Draggable shuts
down. Previously it would leak its recongizer. Now it disposes its recognizer
and the recognizer knows how to be disposed cleanly.

Fixes #1927
2016-06-20 15:58:20 -07:00
Ian Hickson
cff31a3f6d IconThemeData.size (#4633) 2016-06-20 14:21:28 -07:00
Todd Volkert
5809a0cb71 Move Brightness back to the material library (#4635) 2016-06-20 13:16:03 -07:00
Jason Simmons
3b9d8c5eb5 Call onPostResume to restart the animator in the example Android activity (#4634)
(onResume is now a no-op)

Fixes https://github.com/flutter/flutter/issues/4506
2016-06-20 13:06:10 -07:00
Hans Muller
c707b53f01 AppBar bottom widget, not necessarily a TabBar (#4631) 2016-06-20 12:45:20 -07:00
Todd Volkert
ef6a4faa8d System chrome overlay style fixes (#4627)
* System chrome overlay style fixes

1) Add a cache to avoid superfluous calls to the embedder
2) Coalesce calls to the embedder that are made in the same event loop
3) Move call site to material's AppBar from Title widget

#4461
2016-06-20 11:53:19 -07:00
Hans Muller
327d974dc5 Added shopping cart and sorting to Shrine (#4616) 2016-06-20 09:47:58 -07:00
Devon Carew
415324f2f0 bump our dep on the test package (#4625)
* bump out dep on the test package

* add other pubspecs
2016-06-19 08:10:03 -07:00
Adam Barth
ba4f1e02c2 Add an example of listening to app lifecycle events (#4623)
Fixes #4553
2016-06-18 10:43:38 -07:00
Ian Hickson
833b121664 Fix Switch (#4622)
I broke them when refactoring images. Oops.
2016-06-17 15:36:53 -07:00
Ali Ghassemi
94c4222f2b Few overscroll glow fixes. (#4610)
Fixes #4169 and also now overscroll indicator is dismissed the moment
user scrolls in the opposite direction (#4603) but the bounce overscroll
that happens behind the scene and is clamped in the indicator is still
problematic and needs to be fixed. However these fixes are orthogonal to that.

Also closes #4127 as I verified the timeout feature (reduced the duration
to 500ms to be closer to Android behaviour)
2016-06-17 14:44:00 -07:00
Jason Simmons
d89823be2a Remove packages/flx and the FLX code signing scheme (#4612) 2016-06-17 12:35:30 -07:00
Ian Hickson
3a88a973a3 Trivial but confusing typo in SynchronousFuture docs (#4599) 2016-06-17 10:42:57 -07:00
Hans Muller
2de2ce35bb It is not easy being green (#4606) 2016-06-16 17:33:12 -07:00
Hans Muller
69b4bcaff5 Use an ellipsis to clip wide cards_demo titles (#4604) 2016-06-16 17:20:54 -07:00