11531 Commits

Author SHA1 Message Date
amirh
83f3b7db87
Rename OnPlatformViewCreated to PlatformViewCreatedCallback (#20189) 2018-08-07 09:51:47 -07:00
Ian Hickson
9e9ac1a16c
Refactor analysis benchmark and collect more data (#20282)
* Refactor analysis benchmark and collect more data (#20169)

This does some code cleanup to avoid duplication, improves the logs,
and records min and max values as well as the mean.

* Fix typo that led to infinite loop
2018-08-06 18:15:44 -07:00
Greg Spencer
77645df72c
Try again to switch docs and gallery deployment to Cirrus (#20276)
This switches docs and gallery build and deployment to use Cirrus CI instead of Travis, reapplying the changes from #19925, but updating the Firebase tokens for upload, and refining docs.sh some to limit retries to five times (instead of indefinitely).
2018-08-06 17:33:31 -07:00
Michael R Fairhurst
e77b186abd Enable lint unnecessary_statements. Codebase is compliant. (#20099)
* Enable lint unnecessary_statements. Codebase is compliant.

* Fix mega_gallery generated code to not generate unecessary statements

* Fix lint in mega gallery changes

* Enable unnecessary_statements for users as well as repo.
2018-08-06 16:31:57 -07:00
Ian Hickson
b81e361192
Revert "Refactor analysis benchmark and collect more data" (#20280)
* Revert "increase size of user account drawer headers to 48 by 48 (#20266)"

This reverts commit 4a7b4a4dde26af64e949388fe8e06d37337ed887.

* Revert "EditableText Cursor can be set to not blink for testing (#20004)"

This reverts commit d041b319e8bda5d02b4d83197eecd3f4ff8a97cf.

* Revert "Refactor analysis benchmark and collect more data (#20169)"

This reverts commit 5ea0a13598697df94937f691783a16b42535b47e.
2018-08-06 15:34:08 -07:00
Jonah Williams
4a7b4a4dde
increase size of user account drawer headers to 48 by 48 (#20266) 2018-08-06 13:56:15 -07:00
sandrasandeep
d041b319e8
EditableText Cursor can be set to not blink for testing (#20004)
* no blinking cursor

* debugDeterministicCursor: private -> public

* added documentation

* whitespace
2018-08-06 12:51:22 -07:00
Ian Hickson
5ea0a13598
Refactor analysis benchmark and collect more data (#20169)
This does some code cleanup to avoid duplication, improves the logs,
and records min and max values as well as the mean.
2018-08-06 12:47:09 -07:00
Ian Hickson
872e88cec7
Reduce noise on the memory benchmarks (#19630) (#20163)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-06 12:46:51 -07:00
liyuqian
8b0a3be8b5
Roll engine to ecbb2b28d48a3854aba846da38053cf381cced25 (#20230)
ecbb2b28d Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a50849 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64ee3 Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc852 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a573e Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20d9 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f95 Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)

Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.
2018-08-06 10:47:43 -07:00
Devon Carew
53bd0e20da
move where the mega_gallery benchmark code is generated by default (#20157)
* move where the mega_gallery benchmark code is generated by default

* generate into a temporary diectory
2018-08-06 09:26:32 -07:00
Hans Muller
81458c7925
Added TweenSequence, TweenSequenceItem, ConstantTween (#20056)
Make it possible to define an animation by stringing together a sequence of tweens.
2018-08-06 08:53:06 -07:00
Régis Crelier
f6ef9f0cc1
flutter/engine@3f46cd2 Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (#20186)
flutter/engine@76ec93d Add an explicit `-[FlutterViewController init]` implementation
flutter/engine@4893b07 Roll src/third_party/skia e43024a5bab7..64cc576b1fa7 (1 commits)
flutter/engine@aa7326a Roll src/third_party/skia ed8bc196bd56..e43024a5bab7 (1 commits)
2018-08-06 08:44:22 -07:00
Matteo Crippa
8c02b8f889 Fix issue for iOS to build any app and run on simulator #19618 (#19863)
A different approach to get the url from the string and avoid any interference by extra chars not allowed in url

Fixes #19618
2018-08-04 12:06:56 -07:00
Jonah Williams
a0b5448b84
Add route/routeName to search page (#20190) 2018-08-04 08:50:10 -07:00
Mikkel Nygaard Ravn
d1f446e559
Support flutter run/build of module on Android (#20197) 2018-08-04 13:52:09 +02:00
Jonah Williams
ddd7e4ead1
improve semantics of chip demo (#20121) 2018-08-03 21:10:33 -07:00
Greg Spencer
47bdb54e22
Revert "Move docs and gallery deployment to Cirrus, add Docker image for Linux (#20097)" (#20209)
This reverts commit a5c2ddddaabab16c4fb970dfaf1a8ccde6440cc1.
Docs push requires different auth options... Will reland shortly.
2018-08-03 18:16:51 -07:00
Greg Spencer
a5c2ddddaa
Move docs and gallery deployment to Cirrus, add Docker image for Linux (#20097)
This adds a Docker image for the linux builds, replacing a lot of the setup code with a Docker build.

Added a docker image build step that has the right gcloud credentials in it.

Also, this finally moves the gallery deployment and docs publishing steps to Cirrus. They were dependent upon some environment setup that was a lot easier to do in Docker than in a setup bash script.
2018-08-03 17:28:34 -07:00
Ian Hickson
75960f35d4
Cleanup in localizations code (#20018)
The following changes are made by this PR:

 * Translation bundles now implement MaterialLocalizations directly,
   and are public so that they can be directly extended.

 * The list of supported languages is now a generated constant.

 * The icuShortTimePattern/TimeOfDayFormat values are now pre-parsed.

 * Various other changes for consistency with the style guide and the
   rest of the codebase, e.g. the class names don't use `_`, the
   `path` library is imported as such, more dartdocs, fewer `//
   ignore`s, validation using exceptions.

This reduces our technical debt benchmark.
2018-08-03 16:41:21 -07:00
Ian Hickson
a96fb44911
Increase the precision of the performance benchmarks. (#20159) 2018-08-03 16:41:06 -07:00
Jonah Williams
a29c6d9bb2
kick bots (#20200) 2018-08-03 14:49:16 -07:00
liyuqian
9ffa1c5174
Add Clip enum to Material and related widgets (#18576)
See details in our proposal for this breaking API change and #18057. This PR setup all code paths to allow the change but doesn't change the clip behavior by itself. We'll change `defaultClipBehavior` from `Clip.antiAlias` to `Clip.none` in the following PR to change the clip behavior and update tests.
2018-08-03 09:56:23 -07:00
Christian Mürtz
ad163749b7 Extend InputDecoration with prefix/suffix padding (#19514)
Add widget valued prefix and suffix properties to InputDecoration.  These new properties are alternatives to prefixText and suffixText.
2018-08-03 09:51:34 -07:00
Mikkel Nygaard Ravn
8dd06a1190
Revert " Support flutter run on Android module project (#19600)" (#20182)
This reverts commit cacd291c5c8cf88125885846e392032d675a41f7.
2018-08-03 17:10:17 +02:00
Sarah Zakarias
cacd291c5c Support flutter run on Android module project (#19600) 2018-08-03 15:13:28 +02:00
Michael Goderbauer
9e832121d0
Roll engine to 4893b0760df08cecd8ee97bdf03856c296a6df14 (#20160)
flutter/engine@4893b07 Roll src/third_party/skia e43024a5bab7..64cc576b1fa7 (1 commits)
flutter/engine@aa7326a Roll src/third_party/skia ed8bc196bd56..e43024a5bab7 (1 commits)

This roll also switches flutter_tester to use the new minimal ICU data config, which are already in use for app builds. This unifies the ICU data in use. Everything now uses the flutter-specific minimal configuration.
2018-08-02 17:07:36 -07:00
liyuqian
b6cd38d8df
Add tiles_scroll_perf__timeline_summary to devicelab (#20105) 2018-08-02 16:47:58 -07:00
amirh
60d223c20c
Support touch in AndroidViewController. (#19907)
Adds a sendMotionEvent method to AndroidViewController.
2018-08-02 16:33:48 -07:00
Devon Carew
3ead9c0f0c
reduce the number of runs on the analyze benchmakr (#20155) 2018-08-02 16:13:05 -07:00
Ian Hickson
a2ca14d71e
Revert "Reduce noise on the memory benchmarks" (#20158)
* Revert "Add pub cache, artifacts, pkgs to Cirrus cache (#20080)"

This reverts commit 07e93b385c3c861aab859d34d761fd29e416b831.

* Revert "Reduce noise on the memory benchmarks (#19630)"

This reverts commit 8eb5cb7dc0816f8d9ad620e8933efccf5b8d0551.
2018-08-02 13:56:44 -07:00
Danny Tuppeny
07e93b385c Add pub cache, artifacts, pkgs to Cirrus cache (#20080)
This adds:
 - pub's cache to the Cirrus cache. It caches based on the checksums in the pubspec (although pub has things in versioned folders, this'll prevent the cache just getting bigger over time).
 - bin/cache/pkg. I think this only includes sky_engine. It caches based on the engine checksum.
 - bin/cache/artifacts. This includes engine, gradle_wrapper, material_fonts. Also caches based on the engine checksum.
2018-08-02 12:45:07 -07:00
Ian Hickson
8eb5cb7dc0
Reduce noise on the memory benchmarks (#19630)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-02 12:22:15 -07:00
Jonah Williams
1f7082dbd8
remove const (#20151) 2018-08-02 10:37:17 -07:00
Jonah Williams
55c7e6e3f8
Support customizing standard accessibility action hints on Android. (#19665) 2018-08-02 10:20:47 -07:00
Mikkel Nygaard Ravn
651c5ab374
Fix latent type error in Flutter manifest (#20143) 2018-08-02 19:16:32 +02:00
Fedor Korotkov
8380e20f28 Run macOS builds only if analyze task passed (#20119)
This will reduce load on macOS community cluster.
2018-08-02 09:58:23 -07:00
asiva
35d50a0e16 Fix issues found running tests
//mobile/flutter/tests/app:basic_runner_test_*
during a google3 roll.

The following exception was being thrown

_TypeError: type 'String' is not a subtype of type 'File'

```
8)
<asynchronous suspension>
utter_command.dart:347:18)
<asynchronous suspension>
/flutter_command.dart:282:33)
<asynchronous suspension>
xt.dart:142:29)
<asynchronous suspension>
2018-08-02 08:03:03 -07:00
Mikkel Nygaard Ravn
b280074815
Move async from member access to construction (#20035) 2018-08-02 14:12:25 +02:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
Danny Tuppeny
ffbaa97b50
Remove SHARD env that was overriding matrix (#20134) 2018-08-02 10:39:33 +01:00
Michael Goderbauer
02e9afef64
Der Datumsauswahldialog spricht jetzt deutsch (#20115) 2018-08-02 01:13:53 -07:00
Michael Goderbauer
47d7a7201e Roll engine to a76054f4b6fd2869e5635b83ed83e492e087dcba (1 commit) 2018-08-02 01:13:16 -07:00
Michael Goderbauer
3dabc47571 Roll engine to 04aa0d44db0d785b0087a1c75374a85a4c8e6ec2 (1 commit) 2018-08-02 01:13:16 -07:00
Michael Goderbauer
c43cd5304e Roll engine to 69293264b1e39527ae317537406bc3c0ae12bfcb
flutter/engine@6929326 Roll ICU to 62.1 and harfbuzz to 1.8.4
2018-08-02 01:13:16 -07:00
Michael Goderbauer
8a983fe2e5 Roll engine to de5f535e508ec7cead7098630f41ec145ab47a11
flutter/engine@de5f535 Make FML task runner methods virtual so that FXL adaptors in Fuchsia are possible.
flutter/engine@33b4123 Fix sundry Fuchsia build issues after the tonic/fxl migration.
flutter/engine@03a4e53 Update license script & analyze it on CI
flutter/engine@9f9a564 Change CI badge from travis to cirrus
flutter/engine@a61fae0 Dart SDK roll for 8/1/2018
flutter/engine@97e7c6e Roll src/third_party/skia fd98c2c87164..afea9c32acd9 (1 commits)
flutter/engine@1a35c51 Roll src/third_party/skia f4bf7fc35d83..fd98c2c87164 (1 commits)
flutter/engine@8cb0f6d Roll src/third_party/skia 6cfa29738295..f4bf7fc35d83 (2 commits)
flutter/engine@dcd2956 Initial support for more finely-grained a11y features on Window
flutter/engine@83da727 Roll src/third_party/skia 1935aa3d27cd..6cfa29738295 (7 commits)
2018-08-02 01:13:16 -07:00
Michael Goderbauer
bf44b9cab0
Revert "Fix docs.sh to be more idomatic Bash, runnable from any dir" (#20129)
This reverts commit 724b92499edeb400afca36ebe9675b53890493e5.
2018-08-01 22:56:49 -07:00
Aart Bik
724b92499e
Dart SDK roll for 8/1/2018 (#20120)
* Dart SDK roll for 8/1/2018

Dart SDK roll and disabling of return warnings as errors.

List of commits included in this roll:

8bad5c7b29 [vm/compiler] Non-speculative X64 long division/remainder.
918cda18c5 Add docs about sourcemap extensions
329e029bd6 Fixes dart-lang/sdk#34035
12326c10e1 Store constructor field initializera when the target is not a field.
50da4b8d92 Skip ShadowInvalidFieldInitializer while resynthesizing constructor initializers.
8810b6ecc7 Translate kernel.Instantiation in constant expressions.
cb7341fceb Initial support for inlining-data in source-maps.
4206131030 Fix tracking of onStep position of arguments to new expression
384b0a9a73 Issue 34038. Fix resynthesizing imports when mixed with exports.
ba7dbcf412 Update the test output processor to produce more useful analysis
4b2ee8e9a5 Improve catch clause recovery
66500de4dc More fixes to the CFE integration tests
3f2251986d CC sra also in changes to compiler files and tests
4734c55882 Report error on unsupported operators
00e3109368 [VM] Adjust flags for creating depfiles
07c462b471 [vm] Refactoring: extract BaseFlowGraphBuilder to a separate file
ff9167ff7b Fix parseDirectives to recognize metadata
079bebb78b [ VM ] Added missing token position for assert statements
174649b9be [gardening] Update status of dissasemble_test on Windows
8c5aca7d4d Remove the Factory interface
3dc201e168 Update ChangeBuilder to not include empty edits (Take 2)
18047b2757 Refactor test.dart by changing class Configuration to TestConfiguration
7373d38a31 Update status for Dart2js minified CSP on Chrome with fast startup
61148eade8 Update mixin-declaration feature specification.
a98feb0f01 [VM interpreter] Fix exception handling. Convert bytecode indices to pc offsets ....
da2ed2fd59 Don't ignore runtime cast failures on Map<K,V>.
3d8ca8e566 [gardening] Increase debug app-jitk timeout
0313f7bd66 [gardening] Update status file for failing test
6c39bc38f3 Clear ShadowX references that are not required after compilation.
05b9bbd2b5 Remove the dart1 version of the analysis server snapshot.
9107399190 Add back in the analysis server training.
9fb6c09015 Store reference/type for invalid types.
21db860271 Remove non-strong dart2js builders from test_matrix.json
2e7b0a13f1 Add support for accessing all of the created contexts
73663ae7c6 Allow void on the RHS of null coalescing expressions
17cb6d95d1 Don't remember TypeEnvironment in resolution results.
72960de5f9 [VM] Fix one more place where bound error allocation happened on BG thread in new space
6ad79ff4bd Update status file for tests passing under CFE
23ba527735 [VM] Ensure to alloate bound errors in old space on BG compiler
fe8052428b Remove CONTENT_MODIFIED from spec/test for getSignature
c4c847a45c Revert "[CQ] Remove pkg-linux-release from the CQ trybots until it is fixed"
beaf05efa3 [vm] When generating JITDUMP also dump IR and attach it as source to code.
24158b773d [vm/compiler] Do not LICM LoadStaticField for uninitialized fields.
68bfaf3ac3 [vm/compiler] Avoid crashes when canonicalizing unreachable AssertAssignable.
5a45b2a62b [infra] Upgrade homebrew dependencies to work on Dart 2
8e287dc037 [VM] Only add direct implementor when reading script snapshots if ....
6e81d74fcc [VM] Optimize generation of type testing stubs in JIT mode.
058510eeab fix #28233, add hint for missing returns to function expressions
4482d13ff7 [vm/compiler] Bug fix in 64-bit MOD (%) operator.

* Try ignore instead of commenting out.

* Also disable this in package analysis options.
2018-08-01 21:57:53 -07:00
Jonah Williams
ffdd6e1bf1
Toggle whether label or hint contribute to text field semantics when unfocused/focused (#19790) 2018-08-01 21:02:40 -07:00
Greg Spencer
6dc18525c2
Fix docs.sh to be more idomatic Bash, runnable from any dir (#19922) 2018-08-01 21:00:48 -07:00