35161 Commits

Author SHA1 Message Date
Midori
87324ec09d
[Refactor] fix quote style in template (#127762)
*Just replaced double quote to single.*

*this looks weird to me.*
![screenshot](https://github.com/flutter/flutter/assets/50433979/0bed4730-7fce-411e-b12f-24d478be13c3)
2023-06-02 16:11:51 +00:00
engine-flutter-autoroll
5e5966d8af
Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (#128089)
3a453f2ccb...02d6fbb68b

2023-06-01 jonahwilliams@google.com [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484)
2023-06-01 john@johnmccutchan.com Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491)
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496)
2023-06-01 leroux_bruno@yahoo.fr [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244)
2023-06-01 zanderso@users.noreply.github.com Revert "Move clang tidy v2 build to prod." (flutter/engine#42495)
2023-06-01 linxunfeng@yeah.net Add myself to AUTHORS (flutter/engine#42406)
2023-06-01 bdero@google.com [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411)
2023-06-01 jinhe.zjh@alibaba-inc.com Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153)
2023-06-01 smartercallum@gmail.com Fix crash getting spell-check suggestions (flutter/engine#42466)
2023-06-01 bdero@google.com Fix lint in rectangle packer (flutter/engine#42489)
2023-06-01 jason-simmons@users.noreply.github.com Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438)
2023-06-01 mdebbar@google.com Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486)
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487)
2023-06-01 kjlubick@users.noreply.github.com Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 15:23:09 +00:00
Michael Goderbauer
5bbd866762
Fix typos in labels (#128093) 2023-06-02 14:39:17 +00:00
Zachary Anderson
fdb71de7a0
Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (#128117)
Reverts flutter/flutter#126698

There are a bunch of tool crashes on CI that start with this commit. I'm
not sure this PR is the cause because there is no backtrace from the
tool on the crashes. The only error message is `Oops; flutter has exited
unexpectedly: "Null check operator used on a null value`.
2023-06-02 07:31:07 -07:00
Michael Goderbauer
60a87d0798
Sync Lints (#127976)
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml:
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
2023-06-02 04:27:17 +00:00
Hans Muller
4464d09db0
Updated TabBar and ToggleButtons examples (#128088)
Updated the ToggleButtons example and test to M3.

Updated the nested tabs test to avoid warnings like:
```
Warning: A call to tap() with finder "exactly one widget with type "Tab" which is an ancestor of text "Explore": Tab(text: "Explore", icon: Icon)" derived an Offset (Offset(666.7, 92.0)) that would not hit test on the specified widget.
```
2023-06-02 01:05:31 +00:00
Qun Cheng
ab70aea3ee
Text should still be centered when search bar height is less than 48 (#128068)
Fixes #127092

This fix can solve the alignment issue in `SearchBar` but we still need to investigate the root cause for the `TextField`. The 
text baseline of `TextField` doesn't change when the height is less than 48 and greater than 40. The problem should be related to the `minContainerHeight` which is 48 by default but the `contentHeight` has become smaller than this min value already. Setting `isDense`/`isCollapsed` to true gives the `minContainerHeight` a smaller number which is 0.0: ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L1086)

Since [`isDense`](ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L3907)) is used for the case where the text field has less vertical space, I just use this property in SearchBar.

https://github.com/flutter/flutter/assets/36861262/6ddc8e90-1b47-4dd5-9a57-59b86cafec6d

This is a demo to show the text baseline that doesn't change when we set the text field height under 48.
https://github.com/flutter/flutter/assets/36861262/ce2ee815-f1f5-493a-930e-0540a627bec8
2023-06-02 00:27:22 +00:00
Flutter GitHub Bot
4a8780d228
Roll pub packages (#128053)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-06-02 00:23:16 +00:00
Taha Tesser
513ff44bce
Add FilterChip.elevated, ChoiceChip.elevated, & ActionChip.elevated variants (#128049) 2023-06-01 16:29:28 -07:00
Hans Muller
14136ae319
Updated custom ListTile examples (#128071) 2023-06-01 16:21:42 -07:00
Ben Konyi
35174cc2b7
Fix issue where DevTools would not be immediately available when using --start-paused (#126698)
Service extensions are unable to handle requests when the isolate they were registered on is paused. The DevTools launcher logic was waiting for some service extension invocations to complete before advertising the already active DevTools instance, but when --start-paused was provided these requests would never complete, preventing users from using DevTools to resume the paused isolate.

Fixes https://github.com/flutter/flutter/issues/126691
2023-06-01 22:35:02 +00:00
Kate Lovett
acf5a259e4
Add error message when sliver overlap absorber is missing (#128075)
Adds an error message where we previously would crash without any help.
Came across this while working on https://github.com/flutter/flutter/pull/127718
Fixes https://github.com/flutter/flutter/issues/128074
2023-06-01 22:29:08 +00:00
Hans Muller
f0e32fc6ca
Updated Menu examples (#128080) 2023-06-01 15:27:34 -07:00
fzyzcjy
ffe94a2267
Add retry flag to flutter_test (#125851)
Closes https://github.com/flutter/flutter/issues/125920

I will add tests, polish code, etc, if this change looks generally OK!
2023-06-01 22:25:52 +00:00
Christopher Fujino
7f1f765521
[flutter_tools] Use process matcher for multidex test (#127996)
Part of https://github.com/flutter/flutter/issues/127135
Part of https://github.com/flutter/flutter/issues/125115
2023-06-01 22:24:08 +00:00
Hans Muller
420f442e5c
Updated InputDecoratorExamples for M3 (#128065) 2023-06-01 15:22:03 -07:00
engine-flutter-autoroll
ef843b5fe4
Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (#128064)
7c0a639efd...3a453f2ccb

2023-06-01 flar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42330)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 22:21:12 +00:00
Christopher Fujino
0d2772238e
migrate the package_autoroller from querying by label to title (#128066)
Fixes https://github.com/flutter/flutter/issues/128067
2023-06-01 22:16:50 +00:00
Hans Muller
1a098ae8eb
Revised Floating Action Button examples (#128058)
Of the original 4 examples, the first 3 mostly covered the same API features and occupied quite a bit of real-estate at the top of https://api.flutter.dev/flutter/material/FloatingActionButton-class.html.  Additionally the illustrations and the code samples didn't match in some cases.

Replaced examples 0,1,2 with one example that changes attributes of the FAB when it's pushed. 

Fixes https://github.com/flutter/flutter/issues/128048
2023-06-01 22:16:48 +00:00
engine-flutter-autoroll
ff33555b23
Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (#128056)
fdd39c421f...7c0a639efd

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 934d90ab7370 to f5bc3d12f0eb (1 revision) (flutter/engine#42482)
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from htio0wC3kDb9tB1Wd... to X4Pkixxtt3BkjRW9P... (flutter/engine#42481)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from htio0wC3kDb9 to X4Pkixxtt3Bk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 17:48:17 +00:00
engine-flutter-autoroll
96734538f9
Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (#128050)
c8e1a8d6fb...fdd39c421f

2023-06-01 skia-flutter-autoroll@skia.org Roll ICU from a2961dc659b4 to 1eea59cabae0 (2 revisions) (flutter/engine#42479)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 16:45:40 +00:00
Casey Hillers
51cb871986
[labeler] Remove use of any (#128011)
https://github.com/flutter/flutter/issues/127722
2023-06-01 16:34:07 +00:00
Jonah Williams
47c0454a15
[framework] remove reference to closed issue. (#128007)
Shaders are supported everywhere but HTML backend. We missed this doc update.
2023-06-01 16:16:06 +00:00
engine-flutter-autoroll
82b8d906a9
Roll Packages from 95bb7930e12b to f0513ae199e1 (3 revisions) (#128045)
95bb7930e1...f0513ae199

2023-05-31 54558023+keyonghan@users.noreply.github.com Remove legacy xcode properties and dependencies (flutter/packages#4093)
2023-05-31 43054281+camsim99@users.noreply.github.com [camerax] Correct missing features list in `README` (flutter/packages#4123)
2023-05-31 JeroenWeener@users.noreply.github.com [image_picker] Move disk accesses to background thread (flutter/packages#4058)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 15:53:22 +00:00
Vasiliy Ditsyak
114f05cef6
Add fallback font to IconData class (#127269)
This PR adds an ability to specify `fallbackFont` for `Icon` class via `IconData` props.

Read detailed description here https://github.com/flutter/flutter/issues/126670
2023-06-01 15:43:18 +00:00
Mouad Debbar
764f4cc8c2
[web] Assert route names start with / if using PathUrlStrategy (#127986)
To avoid confusion and unpredictable errors (e.g. https://github.com/flutter/flutter/issues/127462), I'm adding this assert to disallow this pattern.

Fixes https://github.com/flutter/flutter/issues/127462
2023-06-01 15:31:24 +00:00
Andrew Kolos
13db2e4a76
[tool] In flutter doctor -v, warn when Android Studio version could not be detected. (#126395)
Fixes #122081.

When validating an Android Studio installation, add a warning validation message when we are unable to detect the version. This is because we have logic throughout the tool (JDK/JRE-searching) that is at higher risk of failing when we don't know the version.
2023-06-01 14:51:30 +00:00
engine-flutter-autoroll
a3ac142f26
Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (#128035)
8339c71a96...c8e1a8d6fb

2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WbvKb2sKXw0MUnSsC... to yqJfBsLdfLP4_vbFu... (flutter/engine#42478)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WbvKb2sKXw0M to yqJfBsLdfLP4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 11:33:26 +00:00
engine-flutter-autoroll
225c2c485c
Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (#128034)
bc81133892...8339c71a96

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 6c7e1bccb539 to 934d90ab7370 (1 revision) (flutter/engine#42477)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 10:47:24 +00:00
engine-flutter-autoroll
c00cc32b31
Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (#128026)
e235f47164...bc81133892

2023-06-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 78d09b5874fa to 0d3c310fd6d9 (1 revision) (flutter/engine#42476)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 09:55:24 +00:00
Tomasz Gucio
2520838afb
Fixes in Cupertino translations (#127872) 2023-06-01 11:17:36 +02:00
engine-flutter-autoroll
f607bfd1cc
Roll Flutter Engine from a9ed2dec45ff to e235f47164fa (1 revision) (#128024)
a9ed2dec45...e235f47164

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 1573bd65a399 to 6c7e1bccb539 (2 revisions) (flutter/engine#42475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 08:49:37 +00:00
engine-flutter-autoroll
1889aa2246
Roll Flutter Engine from 65938065a118 to a9ed2dec45ff (1 revision) (#128017)
65938065a1...a9ed2dec45

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from a83c633d39ba to 1573bd65a399 (1 revision) (flutter/engine#42474)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 07:01:57 +00:00
engine-flutter-autoroll
b7293e021e
Roll Flutter Engine from ec321ba0740b to 65938065a118 (1 revision) (#128016)
ec321ba074...65938065a1

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f4f569aa5236 to a83c633d39ba (1 revision) (flutter/engine#42472)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 05:29:26 +00:00
Andrew Kolos
06e2b18173
[tools] use Java class for all java-searching behavior (#127354)
Fixes #124252, finishing work on the umbrella tracking issue, #126126.

Essentially, after this PR, no (non-test) code should be be referencing/invoking the java home or binary paths.
2023-06-01 04:19:19 +00:00
engine-flutter-autoroll
2bba614af3
Roll Flutter Engine from 6db2f3e9857c to ec321ba0740b (1 revision) (#128013)
6db2f3e985...ec321ba074

2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from d9f959926dad to f4f569aa5236 (7 revisions) (flutter/engine#42470)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 04:15:31 +00:00
engine-flutter-autoroll
3df72eddba
Roll Flutter Engine from f9bc342c84e2 to 6db2f3e9857c (4 revisions) (#128009)
f9bc342c84...6db2f3e985

2023-06-01 jonahwilliams@google.com Revert "[web] Remove the JS API for url strategy" (flutter/engine#42468)
2023-06-01 skia-flutter-autoroll@skia.org Roll Dart SDK from e0caea366989 to 78d09b5874fa (4 revisions) (flutter/engine#42465)
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lSKDoGVypQfTMYUZe... to htio0wC3kDb9tB1Wd... (flutter/engine#42463)
2023-05-31 mdebbar@google.com [web] Remove the JS API for url strategy (flutter/engine#42134)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lSKDoGVypQfT to htio0wC3kDb9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 03:22:11 +00:00
Ian Hickson
3c61b9d834
add link to design doc wiki page (#127442) 2023-06-01 02:39:15 +00:00
Loïc Sharma
071ea49248
[Windows] Address feedback for show window comment (#127998)
Address Tong's feedback here: https://github.com/flutter/flutter/issues/127695#issuecomment-1564884872

Follow-up to: https://github.com/flutter/flutter/pull/127046
2023-05-31 23:42:54 +00:00
engine-flutter-autoroll
bf17c9eab6
Roll Flutter Engine from e817c3b128a4 to f9bc342c84e2 (1 revision) (#127995)
e817c3b128...f9bc342c84

2023-05-31 skia-flutter-autoroll@skia.org Roll Skia from cb883f64681b to d9f959926dad (11 revisions) (flutter/engine#42458)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-31 22:45:37 +00:00
Tae Hyung Kim
5596a0cdab
Fix gen-l10n format: true so that it applies to when it gets called via build target (#127886) 2023-05-31 15:25:54 -07:00
Greg Spencer
a257efc284
Fix handling of AppLifecycleState.hidden (#127987)
## Description

This fixes the parsing of `AppLifecycleState` in the services binding so that it knows what it is.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/127974

## Tests
 - Added a test that causes parsing of all the different app lifecycle states.
2023-05-31 22:03:06 +00:00
Tae Hyung Kim
5fd9ef4240
Fix SliverPersistentHeader interactions with SliverCrossAxisGroup (#127338)
This PR fixes `SliverCrossAxisGroup` so that once we calculate the total `scrollExtent` of the `SliverCrossAxisGroup`, we ensure that any child sliver is not painted outside of the "scroll extent" of the sliver group.

https://github.com/flutter/flutter/assets/2004742/670dc6f9-a3c6-4bcc-85d3-576cf7f33c6a

https://github.com/flutter/flutter/assets/2004742/0c9cd951-c133-4a8b-9e5e-89d0a69a4f59

Fixes #126958.
Fixes #126957.
2023-05-31 22:01:06 +00:00
engine-flutter-autoroll
25360aed6b
Roll Flutter Engine from b9860dcc8ddd to e817c3b128a4 (1 revision) (#127988)
b9860dcc8d...e817c3b128

2023-05-31 kjlubick@users.noreply.github.com Register codecs with Skia explicitly (flutter/engine#42320)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-31 21:59:12 +00:00
Renzo Olivares
83f19be250
Fix bottom sheet rebuilding when tapping (#127526)
This fixes an issue where the bottom sheet would rebuild when `enableDrag` is set to true on every tap. This is because `DragGestureRecognizer` would win the arena by default and dispatch the `drag` callbacks (in `acceptGesture`) even though it had not met the drag threshold. This changes keep the default behavior of `DragGestureRecognizer` the same, but adds a parameter `onlyAcceptDragOnThreshold` that a user can use to stop drag callbacks from being fired when the drag threshold has not been met.

Fixes #126833
2023-05-31 20:21:55 +00:00
Flutter GitHub Bot
347e304ef6
Roll pub packages (#127977)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-05-31 20:18:25 +00:00
hangyu
a829b579d6
Add a FocusSemanticEvent (#126171)
issue: #94523
engine pr: https://github.com/flutter/engine/pull/41777
2023-05-31 20:15:52 +00:00
engine-flutter-autoroll
19719e33c8
Roll Flutter Engine from 8e67cc3d6ea4 to b9860dcc8ddd (1 revision) (#127979)
8e67cc3d6e...b9860dcc8d

2023-05-31 kjlubick@users.noreply.github.com Replace use of Skia's private GrRectanizer with a copy of the equivalent code (flutter/engine#42430)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-31 19:54:26 +00:00
engine-flutter-autoroll
59b6e32bac
Roll Flutter Engine from ee53c0499732 to 8e67cc3d6ea4 (2 revisions) (#127975)
ee53c04997...8e67cc3d6e

2023-05-31 skia-flutter-autoroll@skia.org Roll Skia from f475d4f5e080 to cb883f64681b (6 revisions) (flutter/engine#42452)
2023-05-31 kjlubick@users.noreply.github.com Fix bugprone-unchecked-optional-access errors in image_generator_apng (flutter/engine#42450)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-31 18:35:16 +00:00
Mouad Debbar
7eecf8874f
[web] Use PlatformLocation from ui_web (#126851)
Remove the following APIs and export them directly from `dart:ui_web`:
- `urlStrategy` getter and setter
- `HashUrlStrategy`
- `PlatformLocation` and `BrowserPlatformLocation` (keep the façades for non-web platforms)

Depends on https://github.com/flutter/engine/pull/42043
Depends on https://github.com/flutter/engine/pull/42252

Part of https://github.com/flutter/flutter/issues/126831
2023-05-31 17:35:50 +00:00