13833 Commits

Author SHA1 Message Date
Kate Lovett
8861e9f3dc Cleanup 2019-04-25 14:51:59 -07:00
Kate Lovett
e332ab859a Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well. 2019-04-25 12:18:56 -07:00
Kate Lovett
a38311e6c8 Fixing duplicate test names. 2019-04-25 10:05:13 -07:00
Kate Lovett
ba011fd353 nits 2019-04-24 15:35:48 -07:00
Kate Lovett
1fcd1b02de Changes for uploading baseline images. 2019-04-24 13:38:49 -07:00
Kate Lovett
95d74481d0 Removed unused imports 2019-04-24 10:58:03 -07:00
Kate Lovett
c5ba689e41 Commented out skips in golden framework tests and transitioned from matchesGoldenFile to matchesSkiaGoldFile. 2019-04-24 10:37:31 -07:00
Kate Lovett
8c59c524c9 Swapping out matchesGoldenFile for matchesSkiaGoldFile for framework tests. 2019-04-23 17:18:23 -07:00
Kate Lovett
beebd5c4a7 Progress. 2019-04-19 15:00:13 -07:00
Kate Lovett
7e542fc334 Committing progress. 2019-04-19 14:33:49 -07:00
Kate Lovett
9e3e44ee3d Committing test progress. 2019-04-19 11:32:16 -07:00
Kate Lovett
4f29c31048 Updating inline documentation 2019-04-19 10:19:31 -07:00
Kate Lovett
b6a2efb7ab Committing progress. Documentation and testing incomplete/in progress. Code cleanup needed as well. 2019-04-18 16:08:09 -07:00
engine-flutter-autoroll
efe744a360
Roll engine 388124f948e6..fdd427241b77 (3 commits) (#31179)
388124f948...fdd427241b

git log 388124f948e685fd545c4363bcecbaeae911b4c5..fdd427241b7790a1ad86794725b311245ed3b470 --no-merges --oneline
fdd427241 Roll src/third_party/skia 70ed05e53ad2..652b007a4cbb (1 commits) (flutter/engine#8601)
3b016106c Check that TransformLayer has a finite matrix (flutter/engine#8585)
4805d72a4 Implement StandardMethodCodec for C++ shells (flutter/engine#8598)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-17 10:43:19 -04:00
engine-flutter-autoroll
ca46fc03de
388124f94 Roll src/third_party/skia db13d3874846..70ed05e53ad2 (6 commits) (flutter/engine#8599) (#31170)
b819b62bed...388124f948

git log b819b62bed3ffedf729ac1daddcc8bf7885e9982..388124f948e685fd545c4363bcecbaeae911b4c5 --no-merges --oneline
388124f94 Roll src/third_party/skia db13d3874846..70ed05e53ad2 (6 commits) (flutter/engine#8599)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 22:27:18 -04:00
engine-flutter-autoroll
b963c15efb
b819b62be Variant type for C++ client wrapper (flutter/engine#8592) (#31168)
db36d28ed0...b819b62bed

git log db36d28ed074b8b4f018ce6f7cb93b4e8ffcf456..b819b62bed3ffedf729ac1daddcc8bf7885e9982 --no-merges --oneline
b819b62be Variant type for C++ client wrapper (flutter/engine#8592)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 21:23:18 -04:00
engine-flutter-autoroll
4f1bbf5d71
db36d28ed Roll src/third_party/dart a8f3a5dae6..8e73b3c006 (92 commits) (#31163)
c0ee647ca4...db36d28ed0

git log c0ee647ca4226fcb38a5af178a97ce8ba9129184..db36d28ed074b8b4f018ce6f7cb93b4e8ffcf456 --no-merges --oneline
db36d28ed Roll src/third_party/dart a8f3a5dae6..8e73b3c006 (92 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 20:25:17 -04:00
Gary Qian
0f5de8725e
Revert "Use full height of the glyph for caret height on Android" (#31159)
* Revert "Use full height of the glyph for caret height on Android (#30991)"

This reverts commit 96e1fc9c34a2c3a11e0dd98ceccb6fbea7ce3460.
2019-04-16 16:49:39 -07:00
engine-flutter-autoroll
c4e1662976
Roll engine 7af3f2b9e7c5..c0ee647ca422 (2 commits) (#31160)
7af3f2b9e7...c0ee647ca4

git log 7af3f2b9e7c5f911ef4b1cff37aa5088fad6dbf5..c0ee647ca4226fcb38a5af178a97ce8ba9129184 --no-merges --oneline
c0ee647ca Roll src/third_party/skia 68aeec07de4a..db13d3874846 (16 commits) (flutter/engine#8595)
28a46d51a Composite Embedded Views with the correct GrContext

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 19:32:28 -04:00
engine-flutter-autoroll
81913321f3
Roll engine 7d1da567434a..7af3f2b9e7c5 (2 commits) (#31153)
7d1da56743...7af3f2b9e7

git log 7d1da567434a820853ed6fae1f6ed65b9de5ba4f..7af3f2b9e7c5f911ef4b1cff37aa5088fad6dbf5 --no-merges --oneline
7af3f2b9e Roll buildroot to ce7b5c786a12927c9e0b4543af267d48c52e0b3a (flutter/engine#8593)
d2eeceb94 Roll src/third_party/skia 6c431d52020c..68aeec07de4a (7 commits) (flutter/engine#8590)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 18:20:18 -04:00
Sam Rawlins
24158686df Bump dartdoc to 0.28.3+2 (#31148)
This version of dartdoc properly escapes fenced code block "info strings."
2019-04-16 15:02:18 -07:00
Jonah Williams
5228a7851a
Fuchsia step 1: add SDK version file and artifact download (#31073) 2019-04-16 13:24:58 -07:00
Gary Qian
96e1fc9c34
Use full height of the glyph for caret height on Android (#30991) 2019-04-16 10:42:36 -07:00
Dima Rostopira
e6f33e92a9 Add sorting to flutter version command (#31064) 2019-04-16 10:23:56 -07:00
engine-flutter-autoroll
975d2f113c
Roll engine 9970fb550071..7d1da567434a (2 commits) (#31129)
9970fb5500...7d1da56743

git log 9970fb5500710471c031cb86f899bfc3f4a6bafd..7d1da567434a820853ed6fae1f6ed65b9de5ba4f --no-merges --oneline
7d1da5674 Roll src/third_party/skia 5bee533ef3a3..6c431d52020c (1 commits) (flutter/engine#8589)
d8a2a55a6 Roll src/third_party/skia 9d10206b7add..5bee533ef3a3 (4 commits) (flutter/engine#8587)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 12:59:21 -04:00
Greg Spencer
857fe320e0
Update keycodes, fix a comment. (#30938)
Updates the keycodes by regenerating them using the script, and fixed a comment in the template to conform to style.
2019-04-16 08:02:11 -07:00
engine-flutter-autoroll
a18226d066
9970fb550 Roll src/third_party/skia d51d00745b1d..9d10206b7add (1 commits) (flutter/engine#8586) (#31106)
0575a9b46e...9970fb5500

git log 0575a9b46e994170ce1290f0025623138411dd13..9970fb5500710471c031cb86f899bfc3f4a6bafd --no-merges --oneline
9970fb550 Roll src/third_party/skia d51d00745b1d..9d10206b7add (1 commits) (flutter/engine#8586)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-16 00:16:17 -04:00
Alexander Aprelev
d775908c7e
Download and handle product version of flutter patched sdk (#31063)
* Support release/debug flavors of flutter_patched_sdk

* Use [anyNamed] instead of [any] for mocking named arguments

* Fix use of local engine in release mode
2019-04-15 21:02:20 -07:00
Tom Robiquet
4ef0292790 Added opacity to cupertino switch when disabled (#29451) 2019-04-15 20:58:03 -07:00
David Worsham
4dd152533b
[scenic] Remove dead view_manager ref (#31005) 2019-04-15 19:33:18 -07:00
engine-flutter-autoroll
4524447bb2
0575a9b46 Roll src/third_party/skia bf15b6676843..d51d00745b1d (6 commits) (flutter/engine#8584) (#31098)
324b8403e8...0575a9b46e

git log 324b8403e8a67db7376f85ed29e0a5792174cca0..0575a9b46e994170ce1290f0025623138411dd13 --no-merges --oneline
0575a9b46 Roll src/third_party/skia bf15b6676843..d51d00745b1d (6 commits) (flutter/engine#8584)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-15 20:43:17 -04:00
Jonah Williams
1c779442a0
Add null checks to coverage collection (#31092) 2019-04-15 17:33:28 -07:00
xster
364d73c7d8
Make CupertinoNavigationBarBackButton correctly return an assert error (#30815) 2019-04-15 15:33:33 -07:00
engine-flutter-autoroll
d628537172
Roll engine c3824f06933a..324b8403e8a6 (13 commits) (#31082)
c3824f0693...324b8403e8

git log c3824f06933af54b54d1094594c0159828dd1a45..324b8403e8a67db7376f85ed29e0a5792174cca0 --no-merges --oneline
324b8403e Remove the flutter_aot GN argument. (flutter/engine#8581)
571ce945b Roll src/third_party/skia 1875353110d1..bf15b6676843 (8 commits) (flutter/engine#8582)
b7d484e4f Roll src/third_party/skia 1fe0b86f17f3..1875353110d1 (5 commits) (flutter/engine#8580)
73f455a3c Roll src/third_party/skia e1c5ea6779f4..1fe0b86f17f3 (1 commits) (flutter/engine#8579)
42d06b370 Roll src/third_party/skia 3611ee1bb157..e1c5ea6779f4 (3 commits) (flutter/engine#8578)
eb575e24a Roll src/third_party/skia c9f55de2ed39..3611ee1bb157 (1 commits) (flutter/engine#8577)
40473d39a Roll src/third_party/skia b5e57e9a3d0f..c9f55de2ed39 (1 commits) (flutter/engine#8576)
dc952bcd4 Roll src/third_party/skia 5c6b565bdfb9..b5e57e9a3d0f (1 commits) (flutter/engine#8575)
14a1db2b6 Roll src/third_party/skia 12cf258193dc..5c6b565bdfb9 (1 commits) (flutter/engine#8573)
dcd0209bd Roll src/third_party/skia 33233a09fef8..12cf258193dc (1 commits) (flutter/engine#8572)
e0b9bc18f Roll src/third_party/skia 69f54f8f0f22..33233a09fef8 (1 commits) (flutter/engine#8571)
9f9d5d6da Roll src/third_party/skia 990bfc785891..69f54f8f0f22 (1 commits) (flutter/engine#8570)
7c7df0d58 Add null check in FLETextInputPlugin (flutter/engine#8538)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-15 18:16:18 -04:00
Justin McCandless
ec7f3f0956
2d transforms UX improvements (#30932)
Small usability fixes for pan and zoom demo. Title and instruction dialog.
2019-04-15 15:11:26 -07:00
liyuqian
a8116e9ea3
Allow profile widget builds in profile mode (#30990)
## Description

Previously, such function is only available in the debug mode. But the
performance information is very noisy in debug mode with JIT. I feel
that such function is as important and useful as the performance overlay
and the `--trace-skia` option for the GPU thread.  So we should give it
the same ability to run in both profile and debug mode.

I've tested it using flutter_gallery in the profile mode. There's no
observable difference in the performance overlay between toggling widget
build profiling.

## Related Issues

https://github.com/flutter/flutter/issues/30984
2019-04-15 13:57:43 -07:00
Dan Field
330dc94c0f Check that ErrorWidget.builder is not modified after test (#30898) 2019-04-15 12:38:51 -07:00
Jonah Williams
28cb589cd3
make flutterProject option of CoverageCollector optional (#31074) 2019-04-15 12:26:43 -07:00
liyuqian
b0937a1e89
Fix the warning test by checking stderr (#30997)
Previously, I used the Android emulator for testing and everything
seemed to work fine with stdout (if I remember correctly). But our
devicelab uses real Android devices and the warnings are routed to
stderr. Hence change stdout to stderr in the test.
2019-04-15 10:19:36 -07:00
Christopher Fujino
be5f345f33
New flag to flutter drive to skip installing fresh app on device (#30818)
* add a --build/--no-build flag to flutter drive command
2019-04-15 09:31:51 -07:00
engine-flutter-autoroll
259fe4494d
Roll engine 9aa7c9a48e93..c3824f06933a (13 commits) (#31002)
9aa7c9a48e...c3824f0693

git log 9aa7c9a48e9342a450c3078e15c8d7923a338ede..c3824f06933af54b54d1094594c0159828dd1a45 --no-merges --oneline
c3824f069 Roll src/third_party/skia e62bf561638c..990bfc785891 (2 commits) (flutter/engine#8569)
49a72e1e4 Roll src/third_party/skia 8be917af4313..e62bf561638c (5 commits) (flutter/engine#8568)
7292d62ef Revert Versions API (flutter/engine#7828)
9336671a8 Revert "Roll src/third_party/dart a8f3a5dae6..c2eb9a9860 (8 commits)" (flutter/engine#8567)
a54354349 Roll src/third_party/dart a8f3a5dae6..c2eb9a9860 (8 commits)
23b0e02ec Android Embedding PR29: Improve FlutterFragment construction API + engine config API. (flutter/engine#8540)
e6c822db9 Roll src/third_party/skia 25071cc52b4b..8be917af4313 (6 commits) (flutter/engine#8564)
1bb2c0cf0 Remove unused import in FlutterActivityDelegate (flutter/engine#8563)
ad04340e5 Add missing <memory> include to text_input_model.h (flutter/engine#8562)
fcd717e28 Update README.md to point to flutter.dev (flutter/engine#8557)
501892a92 Roll src/third_party/skia 35f1c154c5e5..25071cc52b4b (7 commits) (flutter/engine#8560)
db99c86ab Roll src/third_party/skia 41476708db86..35f1c154c5e5 (1 commits) (flutter/engine#8559)
a88cd8032 Roll src/third_party/skia f74fff660084..41476708db86 (1 commits) (flutter/engine#8558)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-15 12:03:24 -04:00
Dan Field
99bd2795b0 Add rrect contains microbenchmark (#30985) 2019-04-15 09:01:40 -07:00
Jonah Williams
715cb5132e
Fix bugs in contrast guideline and improve heuristic (#31000) 2019-04-15 09:01:09 -07:00
Jonah Williams
301eaa8c32
Make coverage, like, really fast (#30811) 2019-04-15 08:59:28 -07:00
Jonah Williams
27b058a414
Revert "revert last 2 engine rolls (#30995)" (#30998) 2019-04-12 17:42:25 -07:00
Jonah Williams
a3a3623027
revert last 2 engine rolls (#30995) 2019-04-12 17:04:20 -07:00
engine-flutter-autoroll
6c7b6833c9
9aa7c9a48 Export extern constants in embedder.h (flutter/engine#8550) (#30951)
f804c293f3...9aa7c9a48e

git log f804c293f3baaec9ccec1e251293f6a3509223b8..9aa7c9a48e9342a450c3078e15c8d7923a338ede --no-merges --oneline
9aa7c9a48 Export extern constants in embedder.h (flutter/engine#8550)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-04-12 10:40:18 -04:00
engine-flutter-autoroll
404f66d968
Roll engine 72986c39ea36..f804c293f3ba (23 commits) (#30948)
72986c39ea...f804c293f3

git log 72986c39ea3669ef26d4d7d7cd0c44f513fcd117..f804c293f3baaec9ccec1e251293f6a3509223b8 --no-merges --oneline
f804c293f Roll src/third_party/skia 3b60397fd35d..f74fff660084 (3 commits) (flutter/engine#8556)
1b448e555 Roll Dart 15b11b018364ce032eae50d78fc8a52b541e2bce...a8f3a5dae6203d1064726a5953cf06a7d484249c (flutter/engine#8555)
99259aef5 Roll src/third_party/skia 36477b49c2ef..3b60397fd35d (6 commits) (flutter/engine#8554)
f37220d40 Roll src/third_party/skia c33e6dcc700b..36477b49c2ef (8 commits) (flutter/engine#8552)
d84d204c7 Android Embedding PR30: Make FlutterView focusable so that the keyboard can interact with it. (flutter/engine#8551)
a344015e9 [fuchsia] Add flutter:: to scene_host.cc (flutter/engine#8549)
711d8431d Roll src/third_party/skia 76e626d9bb55..c33e6dcc700b (4 commits) (flutter/engine#8547)
82e6d6899 Eliminate unused write to local (flutter/engine#8541)
f53e477a6 Correct nullability for FlutterStandardReader (flutter/engine#8537)
c00364a6c [font_collection] Add missing semicolon (flutter/engine#8546)
ae4df6fd1 Revert "Change Rect internal representation from Float32List to Float64List (#8524)" (flutter/engine#8545)
ffdddb07e Roll src/third_party/skia 6d60534e95d8..76e626d9bb55 (1 commits) (flutter/engine#8544)
5ac728eb6 Roll src/third_party/skia 4d657d5e894a..6d60534e95d8 (3 commits) (flutter/engine#8543)
ee462ff68 Roll src/third_party/skia 99d792276740..4d657d5e894a (1 commits) (flutter/engine#8542)
18816c50f Roll src/third_party/skia 42280f8961fa..99d792276740 (8 commits) (flutter/engine#8539)
892591da8 Android Embedding PR28: Report app is active to Flutter in FlutterFragment.onResume() instead of onPostResume() forwarded from Activity. (flutter/engine#8536)
330c6c168 Use code cache dir for engine cache on API >= 21 (#14704). (flutter/engine#8534)
c10ae2be2 Add an option to build the GLFW shell on macOS (flutter/engine#8531)
29aa5fca0 Roll src/third_party/skia b5c685991faa..42280f8961fa (32 commits) (flutter/engine#8535)
0a2869e5c Added support for authentication codes for the VM service (flutter/engine#8527)
36d2135ad Redo a fix for cull rect calculation on TransformLayers with a perspective transform (flutter/engine#8528)
0b36d3e2f Change Rect internal representation from Float32List to Float64List (flutter/engine#8524)
b1ae0ccb7 Roll src/third_party/skia 10bf7020aa15..b5c685991faa (3 commits) (flutter/engine#8526)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-04-12 03:01:18 -04:00
Emily Fortuna
ce6fbcea20
Allow mouse hover to only respond to some mouse events but not all. (#30886)
* Allow mouse hover to only respond to some mouse events but not all.
2019-04-11 16:29:21 -07:00
chunhtai
fbeb5e0cf5
Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (#30809) 2019-04-11 16:23:11 -07:00