engine-flutter-autoroll
257c4eed43
Roll Flutter Engine from b6d37f8f74ad to 4571695f9e76 (6 revisions) ( #128350 )
...
b6d37f8f74...4571695f9ejacksongardner@google.com Use proper sampling options in Skwasm's drawAtlas. (flutter/engine#42595 )
2023-06-06 zanderso@users.noreply.github.com Revert "[Impeller] Reland: Add Impeller Metal support in the embedder API (#42411 )" (flutter/engine#42593 )
2023-06-06 zanderso@users.noreply.github.com Fix raster cache optional value check logic (flutter/engine#42592 )
2023-06-06 zhangzhijian.123@bytedance.com [Impeller] Fix the rendering issue when the tile mode of gradient is set to 'decal' (flutter/engine#42591 )
2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from e8a71c76b88f to 4065e92bf577 (1 revision) (flutter/engine#42587 )
2023-06-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAwdggqMrL1yoH_Zn... to lpbkSRJBMkPs0FM7_... (flutter/engine#42590 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from vAwdggqMrL1y to lpbkSRJBMkPs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 20:08:07 +00:00
fzyzcjy
eb2d9de07e
Fix Null check operator used on a null value on TextField with contextMenuBuilder ( #128114 )
...
Close #128113
Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app!
Without the fix, the test fails as expected:
<details>
```
(base) â flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default'
00:06 +0: context menu contextMenuBuilder changes from default to null
âââ¡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
The following _TypeError was thrown building
_OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state:
_OverlayEntryWidgetState#7666a):
Null check operator used on a null value
When the exception was thrown, this was the stack:
#0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43)
#1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36)
#2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54)
#3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36)
#4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27)
#5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15)
#6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32)
#11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17)
#12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14)
#278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11)
#283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
#308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5)
#310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
#314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
#316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
#318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
#319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16)
#320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5)
#321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7)
#322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
#323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19)
#324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19)
#325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5)
#326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15)
#327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9)
#328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9)
#331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
#332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27)
#333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20)
#334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14)
#337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41)
#338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27)
#339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20)
<asynchronous suspension>
<asynchronous suspension>
(elided 5 frames from dart:async and package:stack_trace)
ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E]
Test failed. See exception logs above.
The test description was: contextMenuBuilder changes from default to null
To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null'
00:06 +0 -1: Some tests failed.
(base) â flutter git:(feat/text-field-npe)
```
</details>
2023-06-06 19:37:57 +00:00
engine-flutter-autoroll
7e87650d07
Roll Packages from db4e5c26ed3f to da72219048fc (10 revisions) ( #128348 )
...
db4e5c26ed...da7221904842692766+dimabran@users.noreply.github.com remove unnecessary typed_data imports (flutter/packages#4136 )
2023-06-06 43054281+camsim99@users.noreply.github.com [local_auth_android] Bump androidx.fragment to 1.5.7 and androidx.core to 1.10.1 (flutter/packages#4142 )
2023-06-05 ditman@gmail.com [google_maps] Endorses package:google_maps_flutter_web. (flutter/packages#4124 )
2023-06-05 ditman@gmail.com [ci] Removes bespoke web scripts. (flutter/packages#4129 )
2023-06-05 arteevraina@gmail.com [webview_flutter]: fix typo (flutter/packages#4070 )
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#4116 )
2023-06-05 stuartmorgan@google.com [tools] Fix OOB test error (flutter/packages#4144 )
2023-06-05 46547604+dsambuk@users.noreply.github.com [path_provider] Allow win32 up to version 5.x (flutter/packages#4125 )
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4112 )
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/video_player/video_player_android/android (flutter/packages#4053 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 19:35:23 +00:00
yusuf-goog
c2e62002ed
Updating cirrus docker image to ubuntu focal. ( #128291 )
...
Bug:https://bugs.chromium.org/p/chromium/issues/detail?id=1446086
2023-06-06 19:23:20 +00:00
Leigha Jarett
32a1c275df
Adding example for migrating to navigation drawer ( #128295 )
...
Fixes https://github.com/flutter/flutter/issues/127214
2023-06-06 19:23:19 +00:00
engine-flutter-autoroll
42cf3e371a
Roll Flutter Engine from 722aad83e5fe to b6d37f8f74ad (2 revisions) ( #128341 )
...
722aad83e5...b6d37f8f74skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from tCxDcZ3yi0rnKGVHt... to atrYtfHWi2cmV9B_C... (flutter/engine#42589 )
2023-06-06 zhangzhijian.123@bytedance.com [Impeller] Make conical gradient work as expected (flutter/engine#42567 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from tCxDcZ3yi0rn to atrYtfHWi2cm
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 18:10:33 +00:00
Michael Goderbauer
4c5db40ff5
Clean-up viewId casts in flutter_test ( #128256 )
...
Follow-up to https://github.com/flutter/engine/pull/42493 .
2023-06-06 17:23:17 +00:00
Kevin Chisholm
ffab83e6f3
Update cherry-pick issue template to more uniform labels. ( #128333 )
...
There are some snake case labels (issue_link) and some sentence case labels (Commit Hash).
This creates inconsistencies in the visual output of the template and when creating automations.
2023-06-06 16:32:48 +00:00
Hans Muller
e72b4717bf
Use Material3 in the 2D viewport tests ( #128155 )
...
Set `useMaterial3: true' for the MaterialApp used in the 2D tests to enable making `useMaterial3: true' the default for ThemeData in a future PR.
2023-06-06 16:28:31 +00:00
Nate Bosch
d095f10b44
Use a show over a hide for test_api exports ( #128298 )
...
The members which are currently hidden may get removed from `package:test_api` because they have no uses.
https://github.com/dart-lang/test/pull/2030
Switch to a `show` and list all the exported APIs. This is currently a no-op change, and is forward compatible with the breaking change when it lands.
A `show` is also safer than a `hide` when exporting across package boundaries. Adding a new member to a library _can be_ breaking, but is often treated as non-breaking. If a new member is added to `package:test_api/scaffolding.dart` it will need to be manually added to the list to be usable from `package:flutter_test`, but we anyways want to add a CHANGELOG entry for user facing changes.
2023-06-06 16:23:14 +00:00
engine-flutter-autoroll
24e411f49b
Roll Flutter Engine from aaa7574375a6 to 722aad83e5fe (1 revision) ( #128307 )
...
aaa7574375...722aad83e5matej.knopp@gmail.com [macOS] Force clipping to path when platform view clip rect is rotated (flutter/engine#42539 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 05:08:26 +00:00
Leigha Jarett
6c8cf3a9d0
Migration guide for moving from BottomNavigationBar to NavigationBar ( #128263 )
...
Fixes https://github.com/flutter/flutter/issues/127213
2023-06-06 03:52:07 +00:00
Mouad Debbar
d87656559c
[web] Use 'Uri' instead of 'dart:html' to extract pathname ( #127983 )
...
- Use `Uri.parse()` to extract pathname.
- Remove unused code from `utils.dart`.
- Add test for URL encoding.
(need to wait for https://github.com/flutter/flutter/pull/126851 to make it into Google3)
2023-06-06 03:46:02 +00:00
engine-flutter-autoroll
9753223932
Roll Flutter Engine from 2b353ae90731 to aaa7574375a6 (4 revisions) ( #128301 )
...
2b353ae907...aaa7574375skia-flutter-autoroll@skia.org Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582 )
2023-06-05 goderbauer@google.com Remove onSemanticsAction (flutter/engine#42579 )
2023-06-05 godofredoc@google.com Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 03:44:08 +00:00
engine-flutter-autoroll
a89d475ca2
Roll Flutter Engine from 220ece4d9faa to 2b353ae90731 (1 revision) ( #128293 )
...
220ece4d9f...2b353ae907bdero@google.com [Impeller] Reland: Add Impeller Metal support in the embedder API (#42411 ) (flutter/engine#42545 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 23:34:09 +00:00
dependabot[bot]
c792a1721c
Bump actions/labeler from 4.0.4 to 4.1.0 ( #128290 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 4.0.4 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases ">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, the <code>dot</code> input was added by <a href="https://github.com/kachkaev "><code>@âkachkaev</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/316 ">actions/labeler#316</a>. It allows patterns to match paths starting with a period. This input is set to <code>false</code> by default.</p>
<h3>Usage</h3>
<pre lang="yml"><code>name: "Pull Request Labeler"
on:
- pull_request_target
<p>jobs:
triage:
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v4
with:
dot: true
</code></pre></p>
<p>This release also includes the following changes:</p>
<ul>
<li>Simplify globbing examples in README by <a href="https://github.com/Youssef1313 "><code>@âYoussef1313</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/451 ">actions/labeler#451</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/577 ">actions/labeler#577</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/578 ">actions/labeler#578</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Youssef1313 "><code>@âYoussef1313</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/451 ">actions/labeler#451</a></li>
<li><a href="https://github.com/kachkaev "><code>@âkachkaev</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/316 ">actions/labeler#316</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.1.0 ">https://github.com/actions/labeler/compare/v4...v4.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="9fcb2c2f55https://redirect.github.com/actions/labeler/issues/578 ">#578</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="0d06c504351d399c3ab6https://redirect.github.com/actions/labeler/issues/577 ">#577</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="82a4f6fc25https://redirect.github.com/actions/labeler/issues/316 ">#316</a> from kachkaev/dot-option</li>
<li><a href="d40596e5db3cbc54c641https://redirect.github.com/actions/labeler/issues/451 ">#451</a> from Youssef1313/patch-1</li>
<li><a href="639ba81ab171d2484daa59d3310a72a78a6c7eb70776a67936...9fcb2c2f55https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.0.4&new-version=4.1.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-06-05 22:59:09 +00:00
engine-flutter-autoroll
68b18918db
Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) ( #128282 )
...
7f12e34974...220ece4d9fzanderso@users.noreply.github.com Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576 )
2023-06-05 chillers@google.com Run dependabot in off peak hours (flutter/engine#42572 )
2023-06-05 flar@google.com fix bounds of inverted rendered rectangles (flutter/engine#42556 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574 )
2023-06-05 kjlubick@users.noreply.github.com Add missing #include of SkCFObject.h (flutter/engine#42573 )
2023-06-05 matej.knopp@gmail.com Improve getting non-overlapping rectangles from RTree (flutter/engine#42399 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fgfgAhpxFpse to tCxDcZ3yi0rn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 22:18:37 +00:00
Jonah Williams
9881aa69e8
[framework] attempt non-key solution ( #128273 )
...
Adds a special opacity widget that does not act like a repaint boundary.
Better solution for https://github.com/flutter/flutter/pull/128138
2023-06-05 21:24:51 +00:00
Casey Hillers
2be476d401
[labeler] Fix adding labels when name is directory ( #128243 )
...
https://github.com/flutter/flutter/issues/126002
2023-06-05 21:23:05 +00:00
Kate Lovett
a3ddead1a4
Remove scrollbar deprecations isAlwaysShown and hoverThickness ( #127351 )
...
The deprecated `[RawScrollbar/Scrollbar/CupertinoScrollbar/ScrollbarThemeData].isAlwaysShown` has expired and is removed in thi PR.
Also, `Scrollbar.hoverThickness` is also removed after having expired.
The replacement for `isAlwaysShown` is `thumbVisibility`. This deprecation was introduced in #96957 . The name change came from new behaviors like a track that is conditionally visible. Since the original API only referred to the thumb, the name was changed to reflect this intention. This change is supported by dart fix. â
The replacement for `hoverThickness` is `ScrollbarThemeData.thickness`, which is a MaterialStateProperty that allows for the thickness to respond to multiple states including hover. This deprecation was introduced in #97173 . This change is not supported by dart fix. ð
Part of https://github.com/flutter/flutter/issues/127042
2023-06-05 21:15:32 +00:00
Kate Lovett
9a263466ae
Fix update drag error that made NestedScrollView un-scrollable ( #127718 )
...
#### (plus some more docs)
Fixes https://github.com/flutter/flutter/issues/76760
Fixes https://github.com/flutter/flutter/issues/82391
Fixes https://github.com/flutter/flutter/issues/45619
Fixes #117316
Fixes #110956
Fixes #127282
Fixes #32563
Fixes #46089
Fixes #79077
Part of fixing #62833
This fixes (a bunch of) issues that have been reported differently over the years, but all have the same root cause. Sometimes the NestedScrollView would incorrectly calculate whether or not there is enough content to allow scrolling. This would only apply to drag scrolling (not mouse wheel scrolling for example). This did not relate to how the extent of the NestedScrollView is computed, but just the logic that enabled the actual drag gestures. This fixes that. :)
2023-06-05 21:14:22 +00:00
engine-flutter-autoroll
270b3d487c
Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) ( #128271 )
...
f9f72388a4...7f12e34974matej.knopp@gmail.com Fix clang tidy error and crash (flutter/engine#42564 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570 )
2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569 )
2023-06-05 zanderso@users.noreply.github.com Check more optional accesses (flutter/engine#42528 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gp1k1agqxQIz to vAwdggqMrL1y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 19:11:25 +00:00
Michael Goderbauer
17f86df8bd
Migrate SemanticsBinding to onSemanticsActionEvent ( #128254 )
...
Follow-up to https://github.com/flutter/engine/pull/42493 .
2023-06-05 18:16:06 +00:00
engine-flutter-autoroll
130e84ecd2
Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) ( #128252 )
...
c838a1b059...f9f72388a4zanderso@users.noreply.github.com Revert Dart SDK to
3.1.0-166.0.dev (flutter/engine#42568 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a10e944601cf to
a226cfbd6cc7 (1 revision) (flutter/engine#42562 )
2023-06-05 kjlubick@users.noreply.github.com Add missing includes of
GrBackendSurface.h (flutter/engine#42563 )
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 2.3.5 to 2.3.6 (flutter/engine#42561 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from 210ad9cde42b to
a10e944601cf (3 revisions) (flutter/engine#42560 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
sk-SFXAARqkT7wGmf... to fgfgAhpxFpse7Xi4i... (flutter/engine#42558 )
2023-06-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d00a370c1fd3 to 5144119b99c8 (2 revisions) (flutter/engine#42557 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
839LDf0p1Q4wyszA5... to gp1k1agqxQIz0oTXV... (flutter/engine#42553 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
5pFMQIRHNENhekRDO... to sk-SFXAARqkT7wGmf... (flutter/engine#42551 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 8ca7bad9158f to
210ad9cde42b (1 revision) (flutter/engine#42549 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 611132d6ab8c to
8ca7bad9158f (1 revision) (flutter/engine#42548 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Bb9z8SjSCzRN6SVee... to 839LDf0p1Q4wyszA5... (flutter/engine#42544 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
vVgQ12wNh2DIT_hV7... to 5pFMQIRHNENhekRDO... (flutter/engine#42543 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 0e80a97ccee3 to
611132d6ab8c (2 revisions) (flutter/engine#42542 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 98da8d7a299d to
0e80a97ccee3 (1 revision) (flutter/engine#42541 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
VtLnfLmVda1_h1AtM... to Bb9z8SjSCzRN6SVee... (flutter/engine#42538 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 656de7fc6994 to
98da8d7a299d (1 revision) (flutter/engine#42537 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
gcm-vsCu6IPUZZnN0... to vVgQ12wNh2DIT_hV7... (flutter/engine#42536 )
2023-06-03 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VtLnfLmVda1_ to gp1k1agqxQIz
fuchsia/sdk/core/mac-amd64 from gcm-vsCu6IPU to fgfgAhpxFpse
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 10:17:02 -07:00
Jonah Williams
b3f32004d4
[framework] force flexible space background to rebuild. ( #128138 )
...
Fixes https://github.com/flutter/flutter/issues/127836
The flexible scroll bar needs to rebuild even if the child/opacity hasn't changed. Force this with a value key.
2023-06-05 15:51:49 +00:00
engine-flutter-autoroll
1e70c52b4e
Roll Packages from 75085edb54fe to db4e5c26ed3f (4 revisions) ( #128246 )
...
75085edb54...db4e5c26edengine-flutter-autoroll@skia.org Roll Flutter from 3db9504dcda2 to 0b7415356e07 (108 revisions) (flutter/packages#4135 )
2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9cd3d0d9ff05 to f92f44110e87 (4 revisions) (flutter/packages#4133 )
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter from ee162e4b7f4f to 3db9504dcda2 (31 revisions) (flutter/packages#4098 )
2023-06-02 43054281+camsim99@users.noreply.github.com [many] Bump most robolectric dependencies to version 4.10.3 (flutter/packages#4128 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 15:48:31 +00:00
engine-flutter-autoroll
0b7415356e
Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) ( #128161 )
...
5429372181...c838a1b059skia-flutter-autoroll@skia.org Roll Skia from daf2219fec54 to 656de7fc6994 (23 revisions) (flutter/engine#42534 )
2023-06-03 bdero@google.com Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411 )" (flutter/engine#42532 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-03 11:16:37 +00:00
engine-flutter-autoroll
39adf1b32a
Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) ( #128158 )
...
8769e9ce3a...5429372181jonahwilliams@google.com [Impeller] Fix 1-d grid computation
for compute (flutter/engine#42516 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
PuYA-6NVHeHPlkCdk... to VtLnfLmVda1_h1AtM... (flutter/engine#42529 )
2023-06-02 chris@bracken.jp [macOS] Top-left origin for PlatformView
container (flutter/engine#42523 )
2023-06-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
9d8df2a5210b to d198f84f5e4e (1 revision) (flutter/engine#42527 )
2023-06-02 flar@google.com Revert "Reland "add non-rendering operation
culling to DisplayListBuilder" (#41463 )" (flutter/engine#42525 )
2023-06-02 godofredoc@google.com Move benchmarks no upload to staging.
(flutter/engine#42524 )
2023-06-02 mdebbar@google.com [web] Support platform view creation
params (flutter/engine#42255 )
2023-06-02 goderbauer@google.com MultiView changes for dart:ui
(flutter/engine#42493 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PuYA-6NVHeHP to VtLnfLmVda1_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 21:59:50 -07:00
Michael Goderbauer
dffd0c3a9d
Prefix for dart:ui multiview change ( #128152 )
...
For https://github.com/flutter/engine/pull/42493 .
2023-06-02 19:08:05 -07:00
Alexander Aprelev
581ebe2965
Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. ( #128124 )
...
The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as https://github.com/flutter/flutter/pull/128084 .
BUG=https://github.com/dart-lang/sdk/issues/52522
2023-06-02 23:31:07 +00:00
engine-flutter-autoroll
af5a9614bb
Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) ( #128149 )
...
f3f6a02059...8769e9ce3agodofredoc@google.com Use json for json blocks in docs. (flutter/engine#42521 )
2023-06-02 mdebbar@google.com [web] New platform view API to get view by ID (flutter/engine#41784 )
2023-06-02 jason-simmons@users.noreply.github.com Generate a unique temporary directory name in the iOS scenario test script (flutter/engine#42520 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 23:00:06 +00:00
engine-flutter-autoroll
6b69a74dc6
Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) ( #128147 )
...
b4250acbf3...f3f6a02059jason-simmons@users.noreply.github.com Wrap concurrent message loop tasks in an autorelease pool on iOS/Mac platforms (flutter/engine#42459 )
2023-06-02 godofredoc@google.com Update engine build config docs. (flutter/engine#41468 )
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Bump unit test robolectric version to 4.10.3 (flutter/engine#42454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 22:14:08 +00:00
Jim Graham
6f6611359c
Reland "Remove obsolete drawShadow bounds workaround ( #127052 )" ( #127231 )
...
This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).
Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654
2023-06-02 22:03:07 +00:00
engine-flutter-autoroll
0845d0d76c
Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) ( #128142 )
...
c6e9383f21...b4250acbf3737941+loic-sharma@users.noreply.github.com Manually roll ANGLE (flutter/engine#42169 )
2023-06-02 jason-simmons@users.noreply.github.com [Impeller] Fix a bugprone-unchecked-optional-access warning in SurfaceMTL (flutter/engine#42518 )
2023-06-02 amyles@google.com [web] Move announcement live elements to the end of the DOM and make them `div`s instead of `label`s. (flutter/engine#42432 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JQRQ1nH1ILNA--N_b... to gcm-vsCu6IPUZZnN0... (flutter/engine#42515 )
2023-06-02 godofredoc@google.com Add cpu as drone dimension to mac ios build. (flutter/engine#42514 )
2023-06-02 godofredoc@google.com Move benchmarks no upload to a test. (flutter/engine#42356 )
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Change Linux Android Emulator Tests to run on a device running API 33 (flutter/engine#42492 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 47b0db43f6a4 to daf2219fec54 (1 revision) (flutter/engine#42513 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JQRQ1nH1ILNA to gcm-vsCu6IPU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 21:28:08 +00:00
Michael Goderbauer
e50b2507bf
Pre-migration for dart:ui multi view changes ( #128092 )
...
For https://github.com/flutter/engine/pull/42493 .
2023-06-02 20:51:09 +00:00
Michael Goderbauer
4cf89cc278
Remove LiveTestRenderView ( #127882 )
...
In the multi view world, `RenderViews` are created by the `View` widget and no longer owned by the binding. Prior to this change, the `LiveTestWidgetsFlutterBinding` owned and managed a special subclass of `RenderView`, the `_LiveTestRenderView`. In the new world, where `RenderView`s can be created anywhere in the widget tree where a `View` widget is used, this setup is no longer feasible. This change removes this special `_LiveTestRenderView` and instead adds debug hocks to `RenderView` to allow the `LiveTestWidgetsFlutterBinding` to draw a debug overlay on top of the content of any `RenderView`.
2023-06-02 20:41:05 +00:00
engine-flutter-autoroll
6f8ef1a197
Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) ( #128119 )
...
02d6fbb68b...c6e9383f21jason-simmons@users.noreply.github.com [Impeller] clang-tidy fixes (flutter/engine#42503 )
2023-06-02 103135467+sealesj@users.noreply.github.com Allow for optional label to trigger vuln scan on patch PRs (flutter/engine#42494 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 881a8df6f9e9 to 47b0db43f6a4 (1 revision) (flutter/engine#42512 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from X4Pkixxtt3BkjRW9P... to PuYA-6NVHeHPlkCdk... (flutter/engine#42511 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 7777ee2bf7ef to 881a8df6f9e9 (1 revision) (flutter/engine#42510 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d4d29d8f16b to 9d8df2a5210b (2 revisions) (flutter/engine#42509 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 02e706e9761b to 7777ee2bf7ef (2 revisions) (flutter/engine#42508 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 0c75f1877b37 to 02e706e9761b (2 revisions) (flutter/engine#42506 )
2023-06-02 dkwingsmt@users.noreply.github.com Revert "[Rasterizer] Make resubmit information temporary" (flutter/engine#42455 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from f4854a3d009d to 0c75f1877b37 (1 revision) (flutter/engine#42505 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0d3c310fd6d9 to 3d4d29d8f16b (3 revisions) (flutter/engine#42502 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 082a7d1f72f7 to f4854a3d009d (4 revisions) (flutter/engine#42500 )
2023-06-01 godofredoc@google.com Do not retry lint or clang tidy tests. (flutter/engine#42498 )
2023-06-01 dnfield@google.com [Impeller] Compute in Vulkan (flutter/engine#42294 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yqJfBsLdfLP4_vbFu... to JQRQ1nH1ILNA--N_b... (flutter/engine#42499 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from X4Pkixxtt3Bk to PuYA-6NVHeHP
fuchsia/sdk/core/mac-amd64 from yqJfBsLdfLP4 to JQRQ1nH1ILNA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 20:39:24 +00:00
fzyzcjy
de368fca94
Tiny remove unnecessary method in text_selection.dart ( #127480 )
...
I come across this when migrating my codebase. There is indeed a linter rule for it: unnecessary_overrides (see screenshot below for an example). I can help enabling the rule (as well as other rules, and/or dart formatter, etc) for Flutter codebase if needed.
2023-06-02 20:19:12 +00:00
Victoria Ashworth
cd18c8c02f
Workaround for Dart VM timeout ( #127875 )
...
Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.
Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 , when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.
Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133 .
However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: 1dc26f80f0/dev/devicelab/lib/framework/devices.dart (L998-L1006)
2023-06-02 17:17:57 +00:00
Michael Goderbauer
95cd3c0340
Make --flutter-repo analyze whole repo ( #127990 )
...
Fixes https://github.com/flutter/flutter/issues/127989 .
2023-06-02 17:17:54 +00:00
engine-flutter-autoroll
7febf62c83
Roll Packages from f0513ae199e1 to 75085edb54fe (3 revisions) ( #128121 )
...
f0513ae199...75085edb5443054281+camsim99@users.noreply.github.com [camerax] Mock `InstanceManager` in unit tests (flutter/packages#4121 )
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.9.0 to 1.10.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3991 )
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 1.8.21 in /packages/image_picker/image_picker_android/android (flutter/packages#4054 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 16:57:05 +00:00
Midori
87324ec09d
[Refactor] fix quote style in template ( #127762 )
...
*Just replaced double quote to single.*
*this looks weird to me.*
2023-06-02 16:11:51 +00:00
engine-flutter-autoroll
5e5966d8af
Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) ( #128089 )
...
3a453f2ccb...02d6fbb68bjonahwilliams@google.com [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484 )
2023-06-01 john@johnmccutchan.com Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496 )
2023-06-01 leroux_bruno@yahoo.fr [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244 )
2023-06-01 zanderso@users.noreply.github.com Revert "Move clang tidy v2 build to prod." (flutter/engine#42495 )
2023-06-01 linxunfeng@yeah.net Add myself to AUTHORS (flutter/engine#42406 )
2023-06-01 bdero@google.com [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411 )
2023-06-01 jinhe.zjh@alibaba-inc.com Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153 )
2023-06-01 smartercallum@gmail.com Fix crash getting spell-check suggestions (flutter/engine#42466 )
2023-06-01 bdero@google.com Fix lint in rectangle packer (flutter/engine#42489 )
2023-06-01 jason-simmons@users.noreply.github.com Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438 )
2023-06-01 mdebbar@google.com Reland "[web] Remove the JS API for url strategy (#42134 )" (flutter/engine#42486 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487 )
2023-06-01 kjlubick@users.noreply.github.com Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 15:23:09 +00:00
Michael Goderbauer
5bbd866762
Fix typos in labels ( #128093 )
2023-06-02 14:39:17 +00:00
Zachary Anderson
fdb71de7a0
Revert "Fix issue where DevTools would not be immediately available when using --start-paused" ( #128117 )
...
Reverts flutter/flutter#126698
There are a bunch of tool crashes on CI that start with this commit. I'm
not sure this PR is the cause because there is no backtrace from the
tool on the crashes. The only error message is `Oops; flutter has exited
unexpectedly: "Null check operator used on a null value`.
2023-06-02 07:31:07 -07:00
Michael Goderbauer
60a87d0798
Sync Lints ( #127976 )
...
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml :
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
2023-06-02 04:27:17 +00:00
Hans Muller
4464d09db0
Updated TabBar and ToggleButtons examples ( #128088 )
...
Updated the ToggleButtons example and test to M3.
Updated the nested tabs test to avoid warnings like:
```
Warning: A call to tap() with finder "exactly one widget with type "Tab" which is an ancestor of text "Explore": Tab(text: "Explore", icon: Icon)" derived an Offset (Offset(666.7, 92.0)) that would not hit test on the specified widget.
```
2023-06-02 01:05:31 +00:00
Qun Cheng
ab70aea3ee
Text should still be centered when search bar height is less than 48 ( #128068 )
...
Fixes #127092
This fix can solve the alignment issue in `SearchBar` but we still need to investigate the root cause for the `TextField`. The
text baseline of `TextField` doesn't change when the height is less than 48 and greater than 40. The problem should be related to the `minContainerHeight` which is 48 by default but the `contentHeight` has become smaller than this min value already. Setting `isDense`/`isCollapsed` to true gives the `minContainerHeight` a smaller number which is 0.0: ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L1086)ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L3907)https://github.com/flutter/flutter/assets/36861262/6ddc8e90-1b47-4dd5-9a57-59b86cafec6d
This is a demo to show the text baseline that doesn't change when we set the text field height under 48.
https://github.com/flutter/flutter/assets/36861262/ce2ee815-f1f5-493a-930e-0540a627bec8
2023-06-02 00:27:22 +00:00
Flutter GitHub Bot
4a8780d228
Roll pub packages ( #128053 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-06-02 00:23:16 +00:00
Taha Tesser
513ff44bce
Add FilterChip.elevated, ChoiceChip.elevated, & ActionChip.elevated variants ( #128049 )
2023-06-01 16:29:28 -07:00
