Jason Simmons
8a84437989
Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x ( #131371 )
...
Dart SDK 3.2.x requires a new version of the dart_internal package.
2023-07-27 17:33:07 +00:00
Seiya Kokushi
dd9764ec34
Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. ( #131306 )
...
Can configure modal barriers in Flutter's built-in dialogs.
2023-07-27 09:57:27 -07:00
Daco Harkes
4e609f1abb
Fix ios_add2app Podfile ( #131263 )
...
Fixes:
* https://github.com/flutter/flutter/issues/131261
2023-07-27 18:37:41 +02:00
keyonghan
cfafb9105f
Add DeviceLab build+test separation doc ( #131365 )
...
This PR add instructions to separate DeviceLab tasks to build and test model.
2023-07-27 15:16:09 +00:00
Ian Hickson
48f08e3db2
IgnoreBaseline widget ( #131220 )
...
Fixes https://github.com/flutter/flutter/issues/7037
2023-07-27 05:59:17 +00:00
Chris Evans
2240649358
Add 'vm:keep-name' pragmas to platform channel classes ( #131271 )
...
Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication
@Hixie
2023-07-27 01:30:23 +00:00
Loïc Sharma
61fd11db2b
Add the 'a: desktop' label to labeler.yml ( #130933 )
...
The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc ) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop ) pull requests.
2023-07-26 23:58:55 +00:00
Ian Hickson
33e9fd8934
ImageDecoration.lerp ( #130533 ) ( #131349 )
...
This primarily implements DecorationImage.lerp().
It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.
Fixes https://github.com/flutter/flutter/issues/12452
This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347 .
2023-07-26 23:48:08 +00:00
Kate Lovett
bb0c3172f8
Minor adjustments on 2D APIs ( #131358 )
...
These tweaks came from https://github.com/flutter/packages/pull/4536
- The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0
- The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate
I'd like to cherry pick this so https://github.com/flutter/packages/pull/4536 will not have to wait for it to reach stable.
2023-07-26 23:21:05 +00:00
Loïc Sharma
f359d9e27a
Revert "Update Unit Tests for M2/M3" ( #131368 )
...
Reverts flutter/flutter#131292
This PR is affected by https://g-issues.skia.org/issues/40045533 .
See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076 ):
> The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
2023-07-26 22:46:20 +00:00
Qun Cheng
5d76d1a561
Update Unit Tests for M2/M3 ( #131292 )
...
Updated golden tests in
* ink_sparkle_test.dart
* material_test.dart
* page_test.dart
* progress_indicator_test.dart
to have M2 and M3 versions.
More info in #127064
2023-07-26 21:24:29 +00:00
Loïc Sharma
81b0e9f111
Revert "Run benchmarks with --omit-type-checks" ( #131353 )
...
Reverts flutter/flutter#131102 as it closed the tree due to `Linux web_benchmarks_skwasm` failures. The test seems to be timing out without completing.
Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/1/overview
2023-07-26 19:23:37 +00:00
Ian Hickson
27e912316f
Revert "ImageDecoration.lerp" ( #131347 )
...
Reverts flutter/flutter#130533
Tree breakage.
2023-07-26 11:09:59 -07:00
Ian Hickson
bae1ac2f6f
ImageDecoration.lerp ( #130533 )
...
This primarily implements DecorationImage.lerp().
It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.
Fixes https://github.com/flutter/flutter/issues/12452
2023-07-26 17:31:23 +00:00
Ian Hickson
552700999d
Document the Flow/Opacity/hit-test issues ( #131239 )
...
Closes https://github.com/flutter/flutter/issues/6100 .
2023-07-26 17:31:21 +00:00
Jackson Gardner
8046e13373
Run benchmarks with --omit-type-checks ( #131102 )
...
We've decided to use the `--omit-type-checks` flag for our dart2wasm benchmarks. Right now, many of the benchmark results are dominated by type checks and most of what we are actually trying to measure get drowned out in the noise.
2023-07-26 17:10:07 +00:00
engine-flutter-autoroll
d4d57546fd
Roll Flutter Engine from ba83c144f84e to faf1121d010c (2 revisions) ( #131339 )
...
ba83c144f8...faf1121d01skia-flutter-autoroll@skia.org Roll Skia from 5ace549dfae6 to ca48e45a0262 (4 revisions) (flutter/engine#44038 )
2023-07-26 mdebbar@google.com [web] Provide convenient default factories for platform views (flutter/engine#43828 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 17:06:06 +00:00
engine-flutter-autoroll
21d7eeeb5f
Roll Packages from 406eac1ad976 to a99fc8765de9 (1 revision) ( #131336 )
...
406eac1ad9...a99fc8765dstuartmorgan@google.com [tool/ci] Add iOS/macOS and Dart support to `fetch-deps` (flutter/packages#4562 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 15:52:06 +00:00
Xilai Zhang
9bd87ec984
[flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" ( #131303 )
...
Reverts flutter/flutter#129274
temporarily putting up a revert in case a fix is difficult
context: [b/293202068](http://b/293202068 ) youtube integration tests failed
2023-07-26 13:31:29 +00:00
engine-flutter-autoroll
285f901eba
Roll Flutter Engine from 89203002f455 to ba83c144f84e (1 revision) ( #131329 )
...
89203002f4...ba83c144f8skia-flutter-autoroll@skia.org Roll Skia from 826e38ba8db3 to 5ace549dfae6 (2 revisions) (flutter/engine#44034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 11:12:40 +00:00
engine-flutter-autoroll
110c8a41c0
Roll Flutter Engine from b3cd1c599abe to 89203002f455 (1 revision) ( #131323 )
...
b3cd1c599a...89203002f4skia-flutter-autoroll@skia.org Roll ANGLE from a09773110c4a to 58cb5c8396a3 (1 revision) (flutter/engine#44033 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 09:57:35 +00:00
engine-flutter-autoroll
35e4e2a241
Roll Flutter Engine from 4bdceccff964 to b3cd1c599abe (1 revision) ( #131317 )
...
4bdceccff9...b3cd1c599aleroux_bruno@yahoo.fr [macOS] Return keyboard pressed state (flutter/engine#42878 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 08:39:12 +00:00
engine-flutter-autoroll
532a84cd15
Roll Flutter Engine from df12fff329a1 to 4bdceccff964 (2 revisions) ( #131316 )
...
df12fff329...4bdceccff9dnfield@google.com [Impeller] Remove duplicated code. (flutter/engine#44024 )
2023-07-26 bdero@google.com [Impeller] Only strip the translation from backdrop filter effect transforms. (flutter/engine#44029 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 07:24:30 +00:00
engine-flutter-autoroll
618ef7f236
Roll Flutter Engine from 43f727e4748a to df12fff329a1 (3 revisions) ( #131314 )
...
43f727e474...df12fff329ditman@gmail.com [web] Preserve canvaskit variant during tests. (flutter/engine#43868 )
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 28773cec6e8d to 826e38ba8db3 (5 revisions) (flutter/engine#44031 )
2023-07-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0StTjIqUxGkc3nOWT... to d6O9t74z-k2svOmvz... (flutter/engine#44030 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 0StTjIqUxGkc to d6O9t74z-k2s
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 06:31:08 +00:00
engine-flutter-autoroll
af08b11aaa
Roll Flutter Engine from 7f3b0d6b7250 to 43f727e4748a (1 revision) ( #131311 )
...
7f3b0d6b72...43f727e474skia-flutter-autoroll@skia.org Roll ANGLE from 84f5295c9782 to a09773110c4a (1 revision) (flutter/engine#44028 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 04:12:07 +00:00
engine-flutter-autoroll
9ea520b46f
Roll Flutter Engine from db711f14842b to 7f3b0d6b7250 (4 revisions) ( #131309 )
...
db711f1484...7f3b0d6b72jacksongardner@google.com Roll fallback fonts. (flutter/engine#44000 )
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 12d41b6f66ed to 28773cec6e8d (2 revisions) (flutter/engine#44011 )
2023-07-26 paulberry@google.com Prepare flutter engine for enabling private final field promotion. (flutter/engine#43959 )
2023-07-26 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 61ab5422fb7b to b1e82e2e55b2 (3 revisions) (flutter/engine#44018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 03:24:28 +00:00
Caffeinix
a4f7906692
Reorders menu item button shortcuts on Mac-like platforms ( #129309 )
...
The Apple Human Interface Guidelines give a specific ordering of the symbols
used as modifier keys in menu shortcuts. These guidelines are encoded into
the native Cocoa or UIKit menu classes, and are intended to ensure that symbols
are always aligned into columns of like symbols and do not move around in the
case of dynamic menu items (for example, holding Option will transform certain
menu items into different versions that take the Option key, so the Option key
symbol appears to the left of most other symbols to avoid reordering).
The Material spec says to use symbols for modifier keys on Mac and iOS, as this
is what users there are familiar with. It stands to reason that we should
follow the platform guidelines fully, so this changes the MenuItemButton class
to honor the HIG-compliant symbol ordering on Mac and iOS.
Fixed : #129308
2023-07-26 03:07:27 +00:00
engine-flutter-autoroll
76fe7e86ca
Roll Flutter Engine from 9e00c11eb519 to db711f14842b (3 revisions) ( #131307 )
...
9e00c11eb5...db711f1484matanlurey@users.noreply.github.com [Impeller] ToColor should produce a DlColor, not SkColor. (flutter/engine#43987 )
2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from b0b71d59391c to 84f5295c9782 (3 revisions) (flutter/engine#44025 )
2023-07-25 smartercallum@gmail.com Uncap framerate for `iOSAppOnMac` (flutter/engine#43840 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-26 02:29:09 +00:00
Sam Rawlins
aab5747fc4
Ignore unused parameters in snippet code ( #131068 )
...
Add `unused_element_parameter` to the codes ignored while analyzing snippets.
Fixes https://github.com/flutter/flutter/issues/131067
2023-07-26 00:07:07 +00:00
engine-flutter-autoroll
548aa6fa10
Roll Flutter Engine from 3fff7316dc8d to 9e00c11eb519 (1 revision) ( #131299 )
...
3fff7316dc...9e00c11eb5skia-flutter-autoroll@skia.org Roll ANGLE from 2d5fb09d7f0a to b0b71d59391c (2 revisions) (flutter/engine#44009 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 23:41:15 +00:00
Dan Field
efa69ba95b
Add example for locking screen orientation in a letterboxing environment ( #131266 )
...
Android may choose to letterbox applications that lock orientation. This gets particularly bad on foldable devices, where a developer may want to lock orientation when the devices is folded and unlock when unfolded. However, if the app is letterboxed when unfolded, the `MediaQuery.of(context).size` will never report the full display size, only the letterboxed window size. This may result in an application getting "stuck" in portrait mode.
/cc @TytaniumDev
2023-07-25 23:07:51 +00:00
Bruno Leroux
eb4891226e
Update BottomAppBar and BottomAppBarTheme tests for M3 ( #130983 )
...
This PR updates `BottomAppBar` and `BottomAppBarTheme` tests for M3 migration.
More info in https://github.com/flutter/flutter/issues/127064
- Some tests are M2 or M3 only.
- Added several M3 tests.
- One golden change.
2023-07-25 22:56:49 +00:00
engine-flutter-autoroll
147e12d13d
Roll Flutter Engine from f5fbfa859b63 to 3fff7316dc8d (4 revisions) ( #131286 )
...
f5fbfa859b...3fff7316dcskia-flutter-autoroll@skia.org Roll Skia from 7cec4e4e6f6e to 12d41b6f66ed (2 revisions) (flutter/engine#44008 )
2023-07-25 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 8662af7d9aa3 to 61ab5422fb7b (12 revisions) (flutter/engine#44007 )
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from eb5b5bc4fb86 to 7cec4e4e6f6e (1 revision) (flutter/engine#44003 )
2023-07-25 kjlubick@users.noreply.github.com Reland "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 22:49:47 +00:00
Sabin Neupane
0a092daa22
Add Sabin Neupane to AUTHORS ( #131237 )
...
Reference: [author:sabin26](https://github.com/flutter/flutter/issues?q=author%3Asabin26 )
2023-07-25 22:49:45 +00:00
engine-flutter-autoroll
fb7a763c64
Roll Packages from 8028cafa1f0c to 406eac1ad976 (4 revisions) ( #131285 )
...
8028cafa1f...406eac1ad9engine-flutter-autoroll@skia.org Roll Flutter from d7ed5dc2e212 to 9def8f6bc56b (21 revisions) (flutter/packages#4561 )
2023-07-25 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes bug where `PlatformWebViewWidget` doesn't rebuild when the controller changes (flutter/packages#4533 )
2023-07-24 stuartmorgan@google.com [ci] Enable Android emulator-based tests (flutter/packages#4494 )
2023-07-24 rexios@rexios.dev [google_maps_flutter_web] Options to disable tilt controls and configure gesture handling (flutter/packages#3258 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 19:51:05 +00:00
engine-flutter-autoroll
35a6fc8acf
Roll Flutter Engine from 0a5c6cdd5d02 to f5fbfa859b63 (8 revisions) ( #131283 )
...
0a5c6cdd5d...f5fbfa859bjonahwilliams@google.com [Impeller] round scale for glyph atlas cache to 2 decimal places. (flutter/engine#43752 )
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 7ae6458b664f to 2d5fb09d7f0a (2 revisions) (flutter/engine#44002 )
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 04ab62b4f8c9 to eb5b5bc4fb86 (2 revisions) (flutter/engine#44001 )
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from e8c8c5651223 to 7ae6458b664f (1 revision) (flutter/engine#43999 )
2023-07-25 bdero@google.com [Impeller] Use basis of effect transform in MatrixFilter. (flutter/engine#43990 )
2023-07-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DO73K2Twew-a51xHm... to 0StTjIqUxGkc3nOWT... (flutter/engine#43996 )
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 1b17c91e4231 to e8c8c5651223 (2 revisions) (flutter/engine#43997 )
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 81ea617ee386 to 04ab62b4f8c9 (1 revision) (flutter/engine#43994 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DO73K2Twew-a to 0StTjIqUxGkc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 19:49:24 +00:00
Alex Li
9f374f12ea
🚀 Expose scrollControlDisabledMaxHeightRatio to the modal bottom sheet ( #129688 )
...
Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking.
Resolves #129690 .
2023-07-25 18:24:43 +00:00
Loïc Sharma
300c5d8285
Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog." ( #131278 )
...
Reverts flutter/flutter#130484 . /cc @ronnnnn
Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/12185/overview
<details>
<summary>Failure logs...</summary>
```
04:51 +5379 ~18: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart: Barrier dismissible Barrier is dismissible with default parameter
âââ¡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK âââââââââââââââââââââââââââââââââââââââââââââââââââââ
The following TestFailure was thrown running a test:
Expected: <1>
Actual: <2>
When the exception was thrown, this was the stack:
#4 main.<anonymous closure>.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart:776:7)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:165:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1008:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart line 776
The test description was:
Barrier is dismissible with default parameter
ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
04:51 +5379 ~18 -1: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart: Barrier dismissible Barrier is dismissible with default parameter [E]
Test failed. See exception logs above.
The test description was: Barrier is dismissible with default parameter
To run this test again: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart -p vm --plain-name 'Barrier dismissible Barrier is dismissible with default parameter'
```
</details>
2023-07-25 18:20:31 +00:00
engine-flutter-autoroll
2da3bdd472
Roll Flutter Engine from 036c58f79307 to 0a5c6cdd5d02 (1 revision) ( #131256 )
...
036c58f793...0a5c6cdd5dskia-flutter-autoroll@skia.org Roll ANGLE from 2d999f744809 to 1b17c91e4231 (1 revision) (flutter/engine#43993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 15:37:19 +00:00
Taha Tesser
62adfcf737
Fix RawChip doesn't use ChipTheme.showCheckmark value ( #131257 )
...
fixes [`RawChip` doesn't use `ChipThemeData.showCheckmark` value](https://github.com/flutter/flutter/issues/119163 )
### Description
`RawChip.showCheckmark` is nullable yet the constructor falsely assigns a default which breaks `ChipTheme` support. This PR removes the falsely assigned default value.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true,
chipTheme: const ChipThemeData(
showCheckmark: false,
)
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Sample'),
),
body: Center(
child: Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const RawChip(
selected: true,
label: Text('RawChip'),
),
FilterChip(
selected: true,
label: const Text('RawChip'), onSelected: (bool value) { },
),
],
),
),
);
}
}
```
</details>
### Before
### After
2023-07-25 15:37:17 +00:00
Seiya Kokushi
9def8f6bc5
Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. ( #130484 )
...
### Overview
Add `barrierDismissible`, `barrierColor` and `barrierLabel` parameters to `showDatePicker`, `showTimePicker` and `showAboutDialog` which calls `showDialog` internally.
We can change these parameters with `showDialog` and Dialog widgets (like `DatePickerDialog`, `TimePickerDialog` or `AboutDialog`) directly. But, I think it is prefer to provide interfaces same as `showDialog` to keep application wide unified looks if it is used internally.
Fixes #130971
2023-07-25 15:32:20 +00:00
engine-flutter-autoroll
c8b9b15e4c
Roll Flutter Engine from a7a842ee9ccd to 036c58f79307 (1 revision) ( #131244 )
...
a7a842ee9c...036c58f793skia-flutter-autoroll@skia.org Roll Skia from 1d55f968ca23 to 81ea617ee386 (1 revision) (flutter/engine#43992 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 09:24:25 +00:00
engine-flutter-autoroll
e8e10b143b
Roll Flutter Engine from 3baca2fe55c8 to a7a842ee9ccd (1 revision) ( #131243 )
...
3baca2fe55...a7a842ee9cskia-flutter-autoroll@skia.org Roll Skia from 4bfaf9944a68 to 1d55f968ca23 (1 revision) (flutter/engine#43991 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 08:34:08 +00:00
engine-flutter-autoroll
018876631f
Roll Flutter Engine from 9a0192d965e0 to 3baca2fe55c8 (1 revision) ( #131241 )
...
9a0192d965...3baca2fe55skia-flutter-autoroll@skia.org Roll Skia from e99aea2cffef to 4bfaf9944a68 (2 revisions) (flutter/engine#43989 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 07:33:22 +00:00
engine-flutter-autoroll
0733c96e7d
Roll Flutter Engine from ceb2674e82b4 to 9a0192d965e0 (3 revisions) ( #131230 )
...
ceb2674e82...9a0192d965skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hUgYN9tEps515M1lg... to DO73K2Twew-a51xHm... (flutter/engine#43981 )
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 4554d1b35b6e to e99aea2cffef (2 revisions) (flutter/engine#43980 )
2023-07-25 bdero@google.com [Impeller] Skip rect clips that do nothing. (flutter/engine#43948 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hUgYN9tEps51 to DO73K2Twew-a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 01:55:24 +00:00
engine-flutter-autoroll
9c6ee77f88
Roll Flutter Engine from 4fded78e5a01 to ceb2674e82b4 (2 revisions) ( #131229 )
...
4fded78e5a...ceb2674e82jonahwilliams@google.com [Impeller] presentKHR from background worker. (flutter/engine#43976 )
2023-07-24 bdero@google.com Revert "[Impeller] Fix MatrixFilter multiplication ordering for subpasses." (flutter/engine#43978 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 01:01:23 +00:00
engine-flutter-autoroll
b1a25bd4a1
Roll Flutter Engine from ff02fa72acce to 4fded78e5a01 (2 revisions) ( #131225 )
...
ff02fa72ac...4fded78e5askia-flutter-autoroll@skia.org Roll Skia from 6c219acc30a5 to 4554d1b35b6e (4 revisions) (flutter/engine#43973 )
2023-07-24 bdero@google.com [Impeller] Fix MatrixFilter multiplication ordering for subpasses. (flutter/engine#43943 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-25 00:08:24 +00:00
engine-flutter-autoroll
e06c023822
Roll Flutter Engine from a489c7496268 to ff02fa72acce (1 revision) ( #131221 )
...
a489c74962...ff02fa72ac233583+mossmana@users.noreply.github.com Replace deprecated [UIScreen mainScreen] in FlutterViewController.mm and FlutterViewControllerTest.mm (flutter/engine#43690 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-24 22:25:46 +00:00
engine-flutter-autoroll
660ce07b67
Roll Flutter Engine from 815b97157dc7 to a489c7496268 (3 revisions) ( #131218 )
...
815b97157d...a489c74962skia-flutter-autoroll@skia.org Roll Skia from 99e8dc51ba53 to 6c219acc30a5 (4 revisions) (flutter/engine#43970 )
2023-07-24 ian@hixie.ch add ColorFilter.toString to web_ui (flutter/engine#43874 )
2023-07-24 skia-flutter-autoroll@skia.org Roll ANGLE from 5e21d7f02425 to 2d999f744809 (1 revision) (flutter/engine#43968 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-24 21:34:40 +00:00
engine-flutter-autoroll
2efd0719ba
Roll Flutter Engine from 2b8d83fa20e3 to 815b97157dc7 (5 revisions) ( #131214 )
...
2b8d83fa20...815b97157dfindyou795@gmail.com Fix missing dispose VirtualDisplayController (flutter/engine#43807 )
2023-07-24 jonahwilliams@google.com [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961 )
2023-07-24 bdero@google.com [Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. (flutter/engine#43946 )
2023-07-24 skia-flutter-autoroll@skia.org Roll ANGLE from e28575f66ae5 to 5e21d7f02425 (4 revisions) (flutter/engine#43964 )
2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from a56bc23bfec7 to 99e8dc51ba53 (5 revisions) (flutter/engine#43963 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-24 20:40:15 +00:00
