Loïc Sharma
8d54abfc22
Roll pub packages manually ( #145170 )
...
The automated roll failed as a test needs to be updated: https://github.com/flutter/flutter/pull/145167
Fixes: https://github.com/flutter/flutter/issues/139861
2024-03-15 14:12:22 +00:00
engine-flutter-autoroll
985576dbfd
Roll Flutter Engine from 995d8903e074 to 1e199ce6239d (1 revision) ( #145196 )
...
995d8903e0...1e199ce62368449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove the use of //build/ in fuchsia (flutter/engine#51072 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-15 04:18:41 +00:00
engine-flutter-autoroll
9b276be7fe
Roll Flutter Engine from 622b37282f20 to 995d8903e074 (8 revisions) ( #145191 )
...
622b37282f...995d8903e0matanlurey@users.noreply.github.com Add some header-goodies for et. (flutter/engine#51434 )
2024-03-14 jonahwilliams@google.com [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428 )
2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429 )" (flutter/engine#51432 )
2024-03-14 flar@google.com Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429 )
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430 )
2024-03-14 matanlurey@users.noreply.github.com Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426 )
2024-03-14 zanderso@users.noreply.github.com [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404 )
2024-03-14 matej.knopp@gmail.com Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-15 01:46:36 +00:00
engine-flutter-autoroll
60674fa334
Roll Flutter Engine from 7b49dc9dd073 to 622b37282f20 (2 revisions) ( #145179 )
...
7b49dc9dd0...622b37282fjonahwilliams@google.com [Impeller] revert round out. (flutter/engine#51395 )
2024-03-14 kjlubick@users.noreply.github.com Remove always-true skia_enable_flutter_defines (flutter/engine#51423 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-15 00:52:23 +00:00
auto-submit[bot]
7f1c93d732
Reverts "Platform view devicelab ad banner scroll list real ads ( #144745 )" ( #145189 )
...
Reverts: flutter/flutter#144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.
Original PR Author: hellohuanlin
Reviewed By: {jmagman, jonahwilliams}
This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement.
It is similar to https://github.com/lucalooz/flutter_ads_list_perf
There's still a pending issue https://github.com/flutter/flutter/issues/144339
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 00:21:25 +00:00
hellohuanlin
be78542d6c
Platform view devicelab ad banner scroll list real ads ( #144745 )
...
This benchmark is to measure the platform view performance improvement.
It is similar to https://github.com/lucalooz/flutter_ads_list_perf
There's still a pending issue https://github.com/flutter/flutter/issues/144339
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-14 21:41:07 +00:00
Nate
17a27358a6
Implementing switch expressions in flutter/test/ ( #144580 )
...
Migrates test code to new `switch` syntax.
2024-03-14 14:20:44 -07:00
Yegor
dff0343251
Remove autofocus from the a11y_assessments app ( #145117 )
...
As of https://github.com/flutter/engine/pull/47727 the web engine is able to find a default widget to focus on when a new route it pushed. The mobile engine already did that for some time. So `autofocus` is no longer necessary.
2024-03-14 20:13:19 +00:00
engine-flutter-autoroll
5fb962722a
Roll Flutter Engine from cc1e7d145067 to 7b49dc9dd073 (3 revisions) ( #145176 )
...
cc1e7d1450...7b49dc9dd0skia-flutter-autoroll@skia.org Roll Dart SDK from 749988e4d748 to 2bc8b222d01f (1 revision) (flutter/engine#51421 )
2024-03-14 110993981+htoor3@users.noreply.github.com [web] - fix text editing IME composition interruption on geometry updates (flutter/engine#51323 )
2024-03-14 flar@google.com Avoid unnecessary transform resets for pixel snapping (flutter/engine#51337 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 20:09:07 +00:00
engine-flutter-autoroll
2c5d3b05fa
Roll Flutter Engine from 41fce3f010c9 to cc1e7d145067 (1 revision) ( #145164 )
...
41fce3f010...cc1e7d145030870216+gaaclarke@users.noreply.github.com [Impeller] started asserting golden test runner has fatal impeller validations (flutter/engine#51357 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 18:23:22 +00:00
auto-submit[bot]
bc611f565b
Reverts "Fix TextField helper top padding on M3 ( #145087 )" ( #145168 )
...
Reverts: flutter/flutter#145087
Initiated by: Jasguerrero
Reason for reverting: failing on accessibility checks b/329548765
Original PR Author: bleroux
Reviewed By: {justinmc}
This change reverts the following previous change:
## Description
`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57 .
This PR sets the correct values for M3 without changing the value for M2.
| Before | After | M3 Spec |
|--------|--------|--------|
|  | |  |
If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/144984
## Tests
Updates a value used by several existing tests.
2024-03-14 18:00:26 +00:00
engine-flutter-autoroll
20889dd816
Roll Flutter Engine from 46993c1bf5bb to 41fce3f010c9 (1 revision) ( #145160 )
...
46993c1bf5...41fce3f010matanlurey@users.noreply.github.com Remove or replaced unused or duplicate code in `SkiaGoldClient`. (flutter/engine#51399 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 17:19:24 +00:00
LouiseHsu
9f5fd75e54
[framework] fix incorrect chinese localizations for Search Web and Share in selection controls ( #144857 )
...
Fixes https://github.com/flutter/flutter/issues/144825
Corresponding translation suggestions:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW
(I accidentally pressed submit 3 times :( )
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2024-03-14 10:14:20 -07:00
LongCatIsLooong
a69567a36f
Asserts if a TextPainter gets disposed more than once ( #145124 )
...
The overflow indicator was sharing the same `TextPainter`.
2024-03-14 16:43:00 +00:00
engine-flutter-autoroll
51d59a7d1e
Roll Flutter Engine from 562d7a6e2861 to 46993c1bf5bb (2 revisions) ( #145154 )
...
562d7a6e28...46993c1bf5skia-flutter-autoroll@skia.org Roll Skia from f4ce9fc2ec45 to 52bb1539c5cf (1 revision) (flutter/engine#51415 )
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d006b668dcb2 to 749988e4d748 (1 revision) (flutter/engine#51414 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 16:24:33 +00:00
engine-flutter-autoroll
5b7d5cadc1
Roll Packages from 38711aca66fa to b21c5424783a (5 revisions) ( #145152 )
...
38711aca66...b21c542478pageli328@gmail.com Support overriding `ErrorWidget.builder` (flutter/packages#6302 )
2024-03-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 61812ca3eb13 to 394269f9ea2e (6 revisions) (flutter/packages#6320 )
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/packages#6309 )
2024-03-13 magder@google.com Replace deprecated UIGraphicsBeginImageContextWithOptions with UIGraphicsImageRenderer (flutter/packages#6285 )
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.6 to 3.24.7 (flutter/packages#6310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 15:46:58 +00:00
engine-flutter-autoroll
3d5f786416
Roll Flutter Engine from 8fcff7b44480 to 562d7a6e2861 (1 revision) ( #145148 )
...
8fcff7b444...562d7a6e28skia-flutter-autoroll@skia.org Roll Skia from 21186e265c39 to f4ce9fc2ec45 (1 revision) (flutter/engine#51413 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 15:01:25 +00:00
engine-flutter-autoroll
826e47e061
Roll Flutter Engine from 5c147a9f8fa6 to 8fcff7b44480 (1 revision) ( #145142 )
...
5c147a9f8f...8fcff7b444skia-flutter-autoroll@skia.org Roll Skia from 804d0ed22179 to 21186e265c39 (1 revision) (flutter/engine#51412 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 13:22:16 +00:00
engine-flutter-autoroll
4fa44339f9
Roll Flutter Engine from 03d2af1d7a46 to 5c147a9f8fa6 (2 revisions) ( #145135 )
...
03d2af1d7a...5c147a9f8fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mYZPzdM3hCE1TA91s... to da-siZ7wPDA0Z0wXJ... (flutter/engine#51411 )
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from e175e61d6259 to 804d0ed22179 (1 revision) (flutter/engine#51410 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from mYZPzdM3hCE1 to da-siZ7wPDA0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 09:31:40 +00:00
engine-flutter-autoroll
7bf36ae7c5
Roll Flutter Engine from f3bd39808a74 to 03d2af1d7a46 (1 revision) ( #145133 )
...
f3bd39808a...03d2af1d7askia-flutter-autoroll@skia.org Roll Skia from cac09f152d9b to e175e61d6259 (2 revisions) (flutter/engine#51408 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 08:54:30 +00:00
engine-flutter-autoroll
822f55b3bb
Roll Flutter Engine from 1da1597ec60d to f3bd39808a74 (1 revision) ( #145131 )
...
1da1597ec6...f3bd39808askia-flutter-autoroll@skia.org Roll Dart SDK from b1e31a41fb17 to d006b668dcb2 (1 revision) (flutter/engine#51409 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 08:09:50 +00:00
engine-flutter-autoroll
fbf2692de3
Roll Flutter Engine from bdf66af6ff0b to 1da1597ec60d (1 revision) ( #145130 )
...
bdf66af6ff...1da1597ec6matanlurey@users.noreply.github.com Remove `--enable-impeller-{backend}` flags (always `True`). (flutter/engine#51402 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 06:55:41 +00:00
engine-flutter-autoroll
d7dcd5caa5
Roll Flutter Engine from 599dbd7382ec to bdf66af6ff0b (1 revision) ( #145129 )
...
599dbd7382...bdf66af6ffskia-flutter-autoroll@skia.org Roll Dart SDK from abc8988e9dac to b1e31a41fb17 (1 revision) (flutter/engine#51403 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 06:02:25 +00:00
engine-flutter-autoroll
fa2f64ad1a
Roll Flutter Engine from 6710d10ad703 to 599dbd7382ec (3 revisions) ( #145123 )
...
6710d10ad7...599dbd7382737941+loic-sharma@users.noreply.github.com [Embedder API] Add multi-view present callback (flutter/engine#51267 )
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from a315e4572f4e to cac09f152d9b (10 revisions) (flutter/engine#51398 )
2024-03-14 dkwingsmt@users.noreply.github.com Multi-view View Metrics (flutter/engine#46174 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 02:10:38 +00:00
engine-flutter-autoroll
5ab9188265
Roll Flutter Engine from cb9dead25ef9 to 6710d10ad703 (1 revision) ( #145121 )
...
cb9dead25e...6710d10ad7yjbanov@google.com [web] make text more crawlable; fix a JAWS bug (flutter/engine#50794 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 01:30:21 +00:00
engine-flutter-autoroll
a769ef483a
Roll Flutter Engine from d29383cc8122 to cb9dead25ef9 (1 revision) ( #145120 )
...
d29383cc81...cb9dead25ejohn@johnmccutchan.com Disable cleaning up ImageReaders in memory pressure callback (flutter/engine#51391 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-14 00:30:24 +00:00
Loïc Sharma
349cbb4a1e
Reduce Windows_arm64 plugin_test_windows test timeout ( #145110 )
...
Windows Defender sometimes kills the `Windows_arm64 plugin_test_windows` test process, causing the test to hang until it times out after 30 minutes. This reduces the test timeout to 900 seconds (15 minutes) to recover from this scenario faster.
Test timeout duration was chosen by looking at successful duration percentiles in the last 100 days:
duration_seconds_p90 | duration_seconds_p99 | duration_seconds_max
-- | -- | --
532 | 545 | 576
BigQuery SQL:
```sql
WITH
successful_steps AS (
SELECT
b.id,
TIMESTAMP_DIFF(s.end_time, s.start_time, SECOND) AS duration_seconds,
FROM cr-buildbucket.flutter.builds AS b, UNNEST(steps) AS s
WHERE
create_time > TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 100 DAY)
AND regexp_substr(input.gitiles_commit.project, '[^\\/]+$') = 'flutter'
AND builder.project || '/' || builder.bucket || '/' || builder.builder
= 'flutter/prod/Windows_arm64 plugin_test_windows'
AND name = 'run plugin_test_windows'
AND s.status = 'SUCCESS'
)
SELECT
percentiles[offset(90)] AS duration_seconds_p90,
percentiles[offset(99)] AS duration_seconds_p99,
duration_seconds_max
FROM (
SELECT
APPROX_QUANTILES(duration_seconds, 100) AS percentiles,
MAX(duration_minutes) AS duration_seconds_max
FROM successful_steps
);
```
`test_timeout_secs` is documented here: https://github.com/flutter/cocoon/blob/main/CI_YAML.md
Part of https://github.com/flutter/flutter/issues/145072
2024-03-14 00:14:06 +00:00
engine-flutter-autoroll
0e126f3fd5
Roll Flutter Engine from d65c7e41f89a to d29383cc8122 (1 revision) ( #145116 )
...
d65c7e41f8...d29383cc81skia-flutter-autoroll@skia.org Roll Dart SDK from 18ec60df0774 to abc8988e9dac (1 revision) (flutter/engine#51388 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 23:21:58 +00:00
engine-flutter-autoroll
b246f587fc
Roll Flutter Engine from c88934422419 to d65c7e41f89a (2 revisions) ( #145113 )
...
c889344224...d65c7e41f8john@johnmccutchan.com Small improvements to et lint command (flutter/engine#51372 )
2024-03-13 jonahwilliams@google.com [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 22:35:22 +00:00
Lau Ching Jun
3dba3f2a0f
Update proxied devices to handle connection interface and diagnostics. ( #145061 )
...
Also improve the performance of daemon device discovery by parallelizing the calls.
2024-03-13 22:24:25 +00:00
Matej Knopp
19087442ce
RenderViewport max layout cycles should depend on number of slivers ( #144104 )
...
Fixes https://github.com/flutter/flutter/issues/144102
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-03-13 22:28:43 +01:00
engine-flutter-autoroll
fd73a9a0c6
Roll Flutter Engine from 9551b49b3fa1 to c88934422419 (2 revisions) ( #145108 )
...
9551b49b3f...c889344224skia-flutter-autoroll@skia.org Roll Skia from 1ad0d0fabe7a to a315e4572f4e (7 revisions) (flutter/engine#51377 )
2024-03-13 matej.knopp@gmail.com Reland "Reland: [macOS] Use CVDisplayLink to drive repaint" (flutter/engine#51210 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 20:29:03 +00:00
Jenn Magder
6f175f1fcb
Mark Mac_arm64_ios module_test_ios not flaky ( #145044 )
...
Revert https://github.com/flutter/flutter/pull/144861
https://github.com/flutter/flutter/issues/144860 was resolved by https://github.com/openid/AppAuth-iOS/pull/825
I'm just going to mark this as unflaky instead of waiting for the bot.
2024-03-13 20:17:09 +00:00
LongCatIsLooong
4f786841f9
Revert "Add FocusNode.focusabilityListenable ( #144280 )" since the feature is no longer needed ( #145102 )
...
This reverts commit 726e5d28c088260b507067a6890a69b6ccb0f103.
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-13 20:17:07 +00:00
Bruno Leroux
33fbb75a95
Fix TextField helper top padding on M3 ( #145087 )
...
## Description
`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57 .
This PR sets the correct values for M3 without changing the value for M2.
| Before | After | M3 Spec |
|--------|--------|--------|
|  | |  |
If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/144984
## Tests
Updates a value used by several existing tests.
2024-03-13 19:56:49 +00:00
engine-flutter-autoroll
247580c748
Roll Flutter Engine from 6ceccf894c41 to 9551b49b3fa1 (9 revisions) ( #145106 )
...
6ceccf894c...9551b49b3fjonahwilliams@google.com [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262 )
2024-03-13 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355 )
2024-03-13 30870216+gaaclarke@users.noreply.github.com [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368 )
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373 )
2024-03-13 tugorez@users.noreply.github.com Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535 )
2024-03-13 jonahwilliams@google.com [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341 )
2024-03-13 skia-flutter-autoroll@skia.org Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374 )
2024-03-13 jonahwilliams@google.com [scenario app] make image matching fuzzier. (flutter/engine#51376 )
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 19:50:00 +00:00
Dhikshith
f91614a4b9
Fix Cupertino Context Menu Container to Remove White Corners ( #144883 )
...
Fixes a visual glitch when CupertinoContextMenu is on a non-white background.
2024-03-13 12:38:28 -07:00
engine-flutter-autoroll
122849311f
Roll Packages from d1aeb26e1b43 to 38711aca66fa (1 revision) ( #145099 )
...
d1aeb26e1b...38711aca66engine-flutter-autoroll@skia.org Roll Flutter from 1ca88730a0c1 to 61812ca3eb13 (1 revision) (flutter/packages#6305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 18:12:59 +00:00
Jonah Williams
e4c79841a3
[Impeller] remove unstable debug checked banner for zoom test. ( #145097 )
...
These tests have been flaky for impeller since it has rotated text.
2024-03-13 18:07:59 +00:00
Nate
b9e537336f
Turning if chains into shorter switch statements ( #144977 )
...
This pull request is part of the effort to solve issue #144903 .
In the past, my efforts to reduce line length involved refactoring away from switch statements, but unlike [yesterday's PR](https://github.com/flutter/flutter/pull/144905 ), this one is full of switch statements that make things more concise!
2024-03-13 17:16:17 +00:00
engine-flutter-autoroll
017f33df6c
Roll Flutter Engine from 2871c2601135 to 6ceccf894c41 (2 revisions) ( #145094 )
...
2871c26011...6ceccf894cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UR-nKoLidl7cVLrrN... to mYZPzdM3hCE1TA91s... (flutter/engine#51370 )
2024-03-13 flar@google.com Add a comparative benchmark for SkM44 vs SkMatrix vs impeller::Matrix (flutter/engine#51332 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UR-nKoLidl7c to mYZPzdM3hCE1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 16:58:25 +00:00
Victoria Ashworth
825e901e00
Set cacheExtent for SliverFillRemaining widget ( #143612 )
...
When a Sliver with items is outside of the Viewport, but within the Viewport's `cacheExtent`, the framework should create SemanticNodes for the items even though they are out of view. However, for this to work, the Sliver's geometry must have a `cacheExtent` (how much space the sliver took up of the Viewport's `cacheExtent`) greater than 0, otherwise it is [excluded](f01ce9f4cb/packages/flutter/lib/src/rendering/viewport.dart (L311-L315)https://github.com/flutter/flutter/issues/142065 .
Definitions:
* `RenderViewport.cacheExtent`:
```dart
/// The viewport has an area before and after the visible area to cache items
/// that are about to become visible when the user scrolls.
///
/// Items that fall in this cache area are laid out even though they are not
/// (yet) visible on screen. The [cacheExtent] describes how many pixels
/// the cache area extends before the leading edge and after the trailing edge
/// of the viewport.
///
/// The total extent, which the viewport will try to cover with children, is
/// [cacheExtent] before the leading edge + extent of the main axis +
/// [cacheExtent] after the trailing edge.
///
/// The cache area is also used to implement implicit accessibility scrolling
/// on iOS: When the accessibility focus moves from an item in the visible
/// viewport to an invisible item in the cache area, the framework will bring
/// that item into view with an (implicit) scroll action.
```
* `SliverGeometry.cacheExtent`:
```dart
/// How many pixels the sliver has consumed in the
/// [SliverConstraints.remainingCacheExtent].
```
* `SliverContraints.remainingCacheExtent`:
```dart
/// Describes how much content the sliver should provide starting from the
/// [cacheOrigin].
///
/// Not all content in the [remainingCacheExtent] will be visible as some
/// of it might fall into the cache area of the viewport.
///
/// Each sliver should start laying out content at the [cacheOrigin] and
/// try to provide as much content as the [remainingCacheExtent] allows.
```
2024-03-13 16:34:25 +00:00
Qun Cheng
1ccad1a2a7
Remove showTrackOnHover from Scrollbar and ScrollbarTheme ( #144180 )
...
This PR is to remove deprecated `Scrollbar.showTrackOnHover` and `ScrollbarThemeData.showTrackOnHover`.
These parameters are made obsolete in https://github.com/flutter/flutter/pull/111706 .
Part of https://github.com/flutter/flutter/issues/143956
2024-03-13 16:31:50 +00:00
engine-flutter-autoroll
59da4dea15
Roll Flutter Engine from 285b9fb287a3 to 2871c2601135 (2 revisions) ( #145067 )
...
285b9fb287...2871c26011john@johnmccutchan.com Add et lint command (flutter/engine#51238 )
2024-03-13 matanlurey@users.noreply.github.com Refactor `golden_tests_harvester`, throw when not `--dry-run`, add tests. (flutter/engine#51364 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 16:14:26 +00:00
Bruno Leroux
34b454f42d
InputDecorator M3 tests migration - Step5 - Helper/Counter/Error ( #144932 )
...
## Description
This PR migrates `InputDecorator` helper/counter/error related tests to M3 and adds some missing tests.
It is the fifth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
fixes https://github.com/flutter/flutter/issues/138213
2024-03-13 07:16:18 +00:00
xubaolin
c83237f37c
[New feature]Introduce iOS multi-touch drag behavior ( #141355 )
...
Fixes #38926
This patch implements the iOS behavior pointed out by @dkwingsmt at #38926 , which is also consistent with the performance of my settings application on the iPhone.
### iOS behavior (horizontal or vertical drag)
## Algorithm
When dragging: delta(combined) = max(i of n that are positive) delta(i) - max(i of n that are negative) delta(i)
It means that, if two fingers are moving +50 and +10 respectively, it will move +50; if they're moving at +50 and -10 respectively, it will move +40.
~~TODO~~
~~Write some test cases~~
2024-03-13 07:10:48 +00:00
engine-flutter-autoroll
1da48594bc
Roll Flutter Engine from ea848c3b2443 to 285b9fb287a3 (3 revisions) ( #145062 )
...
ea848c3b24...285b9fb287bdero@google.com Copy the flutter_gpu package into the engine artifacts. (flutter/engine#51365 )
2024-03-13 chinmaygarde@google.com [Impeller] Make masks type safe. (flutter/engine#51369 )
2024-03-12 bdero@google.com Remove early Flutter GPU prototype from ui/experiments. (flutter/engine#51367 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 07:03:07 +00:00
LongCatIsLooong
8270872f86
Reland "Add a microbenchmark for text intrinsic height layout ( #145007 )" ( #145037 )
...
Add the missing `Directionality` widget and `await test.pump()` call: commit: 0fd7712fa7
2024-03-13 00:52:24 +00:00
engine-flutter-autoroll
2fde3ac38b
Roll Flutter Engine from e25e977a0222 to ea848c3b2443 (6 revisions) ( #145042 )
...
e25e977a02...ea848c3b24jason-simmons@users.noreply.github.com Fix some races in the platform isolate tests (flutter/engine#51358 )
2024-03-12 skia-flutter-autoroll@skia.org Roll Skia from 187488b64570 to bbe453e3525d (1 revision) (flutter/engine#51366 )
2024-03-12 pavel.mazhnik@gmail.com [web] make addView/removeView functions sync (flutter/engine#51103 )
2024-03-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f26f32f374f to b19e0995f317 (1 revision) (flutter/engine#51363 )
2024-03-12 737941+loic-sharma@users.noreply.github.com [dart:ui] Add view ID to `PointerData.toString` (flutter/engine#51352 )
2024-03-12 flar@google.com Fix null filter NOP case in DlLocalMatrixImageFilter (flutter/engine#51340 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-13 00:05:35 +00:00
engine-flutter-autoroll
4dc2ea3e35
Roll Flutter Engine from f1db33f48070 to e25e977a0222 (2 revisions) ( #145035 )
...
f1db33f480...e25e977a02skia-flutter-autoroll@skia.org Roll Skia from 47baa55b4669 to 187488b64570 (1 revision) (flutter/engine#51362 )
2024-03-12 chinmaygarde@google.com [Impeller] Add utility for type safe masks. (flutter/engine#51361 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-12 23:09:08 +00:00
