Gary Qian
8d658d4fa2
uncaught_image_error_linux is no longer particularly flaky ( #33596 )
2019-05-30 12:23:51 -07:00
Todd Volkert
cba41ca2ec
Remove assert from Image._handleImageFrame() ( #33602 )
...
Tickers being disabled and re-enabled can cause the
condition of a synchronous notification happening after
image frames have been delivered, which is valid in that
case. As such, this removes the assert.
https://github.com/flutter/flutter/issues/32374
2019-05-30 12:04:01 -07:00
chunhtai
170309d6fb
fix 23723 rounding error ( #33473 )
2019-05-30 11:59:07 -07:00
Greg Spencer
c7c0965cc5
Add DiagnosticableMixin ( #33595 )
...
This adds DiagnosticableMixin as a mixin class that provides the implementaion for Diagnosticable, so that we can now add diagnostics to classes which already have a base class.
2019-05-30 11:36:38 -07:00
Jonah Williams
f38ee15286
add daemon command to enumerate supported platforms ( #33472 )
2019-05-30 10:14:23 -07:00
Gary Qian
2cb5b24b02
Fix text scaling of strut style ( #33462 )
2019-05-30 10:13:17 -07:00
Tong Mu
fa3fbc89a3
Material allows "select all" when not collapsed ( #32950 )
...
This PR enables "Select all" on MaterialTextSelection when text is partially selected.
2019-05-30 10:03:31 -07:00
Greg Spencer
07aede4c31
Fix onExit calling when the mouse is removed. ( #33477 )
...
This PR solves two problems: currently, the onExit is called for a mouse pointer the moment the removal message is received, except that by the time it actually calls it, there is no _lastEvent for it in the mouse tracker (it's already been removed), resulting in an event being passed to the onExit that contains nulls for the position. Also, removePointer events don't actually get created with a position, although they easily could be, so that even the the _lastEvent in the mouse tracker were still populated, it would still give a null position and delta.
This PR adds support for the position and delta in a PointerRemovedEvent, and populates them. In addition, when a remove event is received, it doesn't actually remove the pointer until the mouse position check that gets scheduled actually happens.
2019-05-30 09:55:38 -07:00
chunhtai
bfc6df0e4f
fixed 33347 fill the gap during performLayout in SliverGrid and SliverFixedExtentList ( #33467 )
2019-05-30 09:24:02 -07:00
Jonah Williams
6feedcc6a4
use toFixedAsString and DoubleProperty in diagnosticProperties ( #33488 )
2019-05-30 08:57:10 -07:00
Dan Field
0df3ec6bcb
Remove obsolete TOODs ( #33554 )
2019-05-30 08:09:15 -07:00
engine-flutter-autoroll
7d3ff77501
58eff77ef Roll src/third_party/skia 2f0f5fb37d74..69aaee0ff927 (2 commits) (flutter/engine#9138) ( #33574 )
...
061d615bc7...58eff77ef2flutter/engine#9138 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-30 09:54:56 -04:00
engine-flutter-autoroll
6bd8fc5181
061d615bc Roll src/third_party/skia 859f7108a5af..2f0f5fb37d74 (2 commits) (flutter/engine#9137) ( #33564 )
...
22fcb2e8d1...061d615bc7flutter/engine#9137 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-30 06:25:19 -04:00
engine-flutter-autoroll
af56b36777
22fcb2e8d Roll buildroot to pick up fixed create_updated_flutter.deps.py (flutter/engine#9129) ( #33556 )
...
7dd62d6b3c...22fcb2e8d1flutter/engine#9129 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-30 04:00:20 -04:00
engine-flutter-autoroll
ec65f8a434
Roll engine fa9b5bd0e286..7dd62d6b3ca4 (3 commits) ( #33555 )
...
fa9b5bd0e2...7dd62d6b3c#25391 ). (flutter/engine#9122 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-30 02:59:17 -04:00
Todd Volkert
986d036fab
Mark flutter_gallery__back_button_memory as flaky ( #33549 )
2019-05-29 23:29:18 -07:00
Jonah Williams
7263c127ed
Add local overrides to testbed and provide more defaults ( #33264 )
2019-05-29 22:49:53 -07:00
Jonah Williams
da600bacfe
Reland - Wire up hot restart and incremental rebuilds for web ( #33533 )
2019-05-29 22:46:28 -07:00
engine-flutter-autoroll
381fec583c
Roll engine 4c4c0f82825d..fa9b5bd0e286 (2 commits) ( #33551 )
...
4c4c0f8282...fa9b5bd0e2flutter/engine#9132 )
d4794122a Change the virtual display size restriction to warning (flutter/engine#9110 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-30 00:28:17 -04:00
Emmanuel Garcia
3bbdf017c4
Add to app measurement ( #33458 )
2019-05-29 20:56:28 -07:00
engine-flutter-autoroll
abca5038a8
Roll engine 8dc3a4cde207..4c4c0f82825d (47 commits) ( #33546 )
...
8dc3a4cde2...4c4c0f8282#33478 ). (flutter/engine#9120 )
e8c2b1787 Added support for transparent FlutterActivitys (#32740 ). (flutter/engine#9115 )
19c5029b9 Roll src/third_party/skia 29e013deb476..1013ecfb3421 (3 commits) (flutter/engine#9130 )
45d39e137 Revert "Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (#9127 )" (flutter/engine#9135 )
44f1b440a Revert "Use track-widget-creation transformer included in the sdk. (#9085 )" (flutter/engine#9134 )
ae14c5a24 Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (flutter/engine#9127 )
3ea7ac8d9 Roll src/third_party/skia 633db4db7672..29e013deb476 (3 commits) (flutter/engine#9128 )
8ad0e2f8e Roll src/third_party/skia 25b63f91b3b4..633db4db7672 (4 commits) (flutter/engine#9125 )
37e6e0c90 Roll src/third_party/skia 8f88b2da05d5..25b63f91b3b4 (2 commits) (flutter/engine#9121 )
37b367e4d Allow specifying both Dart and non-Dart fixtures in engine unit-tests. (flutter/engine#9113 )
28f2c05a6 Roll src/third_party/skia 1f02e8488551..8f88b2da05d5 (3 commits) (flutter/engine#9116 )
093200848 Remove outdated TODOs (flutter/engine#9114 )
c880ca215 Roll src/third_party/dart 50b0d85804..fee615c5a5 (4 commits)
6e5151359 Removing unused imports (flutter/engine#9108 )
9ee269721 Roll src/third_party/skia d04aaa3a841a..1f02e8488551 (8 commits) (flutter/engine#9109 )
fa2e2d9fc Add checks to constructors and add missing constructor members (flutter/engine#9106 )
7e1788acd Fix unopt variants of profile and release builds. (flutter/engine#9107 )
867120c0c Better help message. (flutter/engine#9097 )
e27c6e890 Forward custom IDE flags to GN. (flutter/engine#9023 )
6b4ca8da5 Roll src/third_party/skia 176b214f91bc..d04aaa3a841a (7 commits) (flutter/engine#9105 )
a20731870 Roll src/third_party/dart ec4d48e241..50b0d85804 (87 commits)
0a6aeb347 Roll src/third_party/skia 213aa46af167..176b214f91bc (2 commits) (flutter/engine#9100 )
f2e22aa3c Roll src/third_party/skia 7730d7cb8fb2..213aa46af167 (3 commits) (flutter/engine#9098 )
557db42ad Roll src/third_party/skia de7e074e8190..7730d7cb8fb2 (2 commits) (flutter/engine#9096 )
64a4a0eaa Roll src/third_party/skia f06b6d5469a5..de7e074e8190 (1 commits) (flutter/engine#9094 )
fdee6256a Roll src/third_party/skia 7e5a64f517e4..f06b6d5469a5 (2 commits) (flutter/engine#9093 )
daf47f0b4 Roll src/third_party/skia dc01a84ae098..7e5a64f517e4 (1 commits) (flutter/engine#9092 )
41e10f07f Fix internal break since listing contents can return null (flutter/engine#9078 )
cf1b20318 Roll src/third_party/skia f33c95cd6f55..dc01a84ae098 (3 commits) (flutter/engine#9091 )
2404cdc90 Rename macOS FLEPlugin* to FlutterPlugin* (flutter/engine#9074 )
509a43fe2 Apply minor cleanups to Android embedding (flutter/engine#9088 )
0a0f3305b Removed outdated deprecation comments (flutter/engine#9087 )
a44cbbf49 Delete BSDiff sources (flutter/engine#9086 )
0f1ff3bdb Correct typos, adopt US spellings (flutter/engine#9081 )
651c90409 Use track-widget-creation transformer included in the sdk. (flutter/engine#9085 )
cfa524fcd New Plugin API PR4: Adds Lifecycle support to the new plugin system. (flutter/engine#9049 )
6b8ac18b8 Roll src/third_party/skia d9430297e74a..f33c95cd6f55 (5 commits) (flutter/engine#9082 )
11408effd Update macOS podspec version requirement (flutter/engine#9077 )
66c6ae48e Roll src/third_party/skia a4b837971c4b..d9430297e74a (30 commits) (flutter/engine#9080 )
9151b377e Roll src/third_party/skia 9339a8a61af0..a4b837971c4b (34 commits) (flutter/engine#9076 )
ee6a9c404 Fix unchecked operation warnings in FlutterMain (flutter/engine#9073 )
333042cf3 Roll third_party/dart/tools/sdks to 2.3.0 (flutter/engine#9072 )
01b8c078c Roll src/third_party/skia f77dbd04b926..9339a8a61af0 (12 commits) (flutter/engine#9065 )
26b4fb57f Roll src/third_party/dart e3edfd36b2..ec4d48e241 (7 commits)
9d2d58a3c Add mouse button support to the macOS shell (flutter/engine#9054 )
...
2019-05-29 23:28:18 -04:00
Todd Volkert
ca13add9c8
Fix/update several HTML links ( #33539 )
2019-05-29 20:14:52 -07:00
Jason Simmons
311cde98a6
Reland "Clean up some flutter_tools tests and roll dependencies" ( #33225 )
...
This relands flutter/flutter#33163 with a fix to the integration_ui test.
2019-05-29 19:04:35 -07:00
LongCatIsLooong
22ea031e28
Fix ScrollbarPainter thumbExtent calculation and add padding ( #31763 )
...
- Fixed extentInside calculation in ScrollMetrics
- Added asserts to extentInside getter, as well as ScrollPosition.applyContentDimensions to enforce minScrollExtent <= maxScrollExtent
- Added padding to ScrollbarPainter, updated implementation. Took care of some edge cases.
- Changed some scroll bar constants on Cupertino side.
2019-05-29 16:52:21 -07:00
Ben Konyi
c926aae4c7
Fixed broken link in debugProfileBuildsEnabled documentation ( #33531 )
2019-05-29 15:53:12 -07:00
Zachary Anderson
b84ac50dfe
[flutter_tool] Misc. fixes for Fuchsia ( #33466 )
2019-05-29 15:37:07 -07:00
Zachary Anderson
c1d448f3ec
Update Fuchsia SDK ( #33526 )
2019-05-29 15:35:36 -07:00
Darren Austin
252a14ba2f
Fixed for DropdownButton crashing when a style was used that didn't include a fontSize ( #33474 )
...
Fixed an issue with a DropdownButton crashing when a style was used that didn't include a fontSize.
2019-05-29 13:18:34 -07:00
stuartmorgan
79ae04d4ed
Build the solution on Windows ( #33528 )
...
Switch from building Runner.vcxproj to Runner.sln on Windows, to allow
for multiple-project builds (e.g., separate plugin projects).
2019-05-29 13:17:23 -07:00
Todd Volkert
6884146925
Add loading support to Image ( #33369 )
...
This adds two new builders to the `Image` class:
* `frameBuilder`, which allows callers to control the widget
created by an [Image].
* `loadingBuilder`, which allows callers fine-grained control
over how to display loading progress of an image to the user.
`FadeInImage` can be simplified by migrating to the new API.
This is done in a follow-on commit.
https://github.com/flutter/flutter/issues/32374
2019-05-29 12:52:05 -07:00
Jonah Williams
925f5f1c53
Revert "Wire up hot restart and incremental rebuilds for web ( #33197 )" ( #33529 )
...
This reverts commit 52ae99682e4ced7e6f9575a571d3feaf5a2cec84.
2019-05-29 12:09:01 -07:00
Zachary Anderson
8139a368ea
[flutter_tool] Use product runner in Fuchsia release build ( #33282 )
2019-05-29 10:08:58 -07:00
Jonah Williams
52ae99682e
Wire up hot restart and incremental rebuilds for web ( #33197 )
2019-05-29 09:49:16 -07:00
Mehmet Fidanboylu
27bdb11030
Expose service client and app isolate in driver ( #33431 )
2019-05-29 09:29:24 -07:00
Jonah Williams
0c517aecbb
remove empty file ( #33489 )
2019-05-29 09:24:36 -07:00
stuartmorgan
aecf053ee0
Use vswhere to find Visual Studio ( #33448 )
...
Rather than hard-coding a set of locations to check, use vswhere (which
is installed by VS 2017 and later), and construct the vcvars64.bat path
relative to that. This will allow Windows builds to work without special
configuration for people who have VS installed at a custom path.
Also adds error logging with different messages for each failure point,
so that rather than the not-very-informative 'failed to find
vcvars64.bat' message, the failure will provide feedback about what to
do.
This is an interim solution; later this will be replaced by a
VisualStudio class with associated validator to match the structure of
the other toolchains.
Fixes #33249
2019-05-29 09:17:17 -07:00
stuartmorgan
e1a784ae3f
Wrap Windows build invocation in a batch script ( #33443 )
...
Invoking msbuild with runInShell makes handling path escaping more
error-prone, and substantially increases the chances of running into
maximum path limits. This replaces the direct call with a .bat wrapper
that calls vsvars64.bat then msbuild, and uses relative paths within the
script to keep command lengths short.
Fixes https://github.com/flutter/flutter/issues/32792
2019-05-28 21:53:03 -07:00
Jonah Williams
c56b455180
ensure unpack declares required artifacts ( #33454 )
2019-05-28 17:35:05 -07:00
Jason Simmons
786d9cee50
Fix a missing_return analyzer error in a code example ( #33468 )
...
This will fix a failure in dev/bots/analyze-sample-code.dart when using
the tip of tree Dart SDK.
2019-05-28 16:32:09 -07:00
Jonah Williams
d729e70e0c
correctly pin build_daemon ( #33463 )
2019-05-28 15:28:24 -07:00
Jason Simmons
f9e28e7df7
Do not return null from IosProject.isSwift ( #33450 )
2019-05-28 14:27:38 -07:00
Jonah Williams
8e3e0a89f4
Revert "Instrument add to app flows ( #33297 )" ( #33449 )
...
This reverts commit faec4ca3617a11fec8728262d90b9e030d9e030d.
2019-05-28 12:52:58 -07:00
Jonah Williams
2d9b158faf
Revert "Framework support for font features in text styles ( #33230 )" ( #33444 )
...
This reverts commit 841286d652379a6e9f1e95d54c8c9e628f4f1d5c.
2019-05-28 11:35:03 -07:00
Harry Terkelsen
13e9bfcc94
Add binaryMessenger constructor argument to platform channels ( #30406 )
...
* Deprecates `BinaryMessages` in favor of a default instance of `BinaryMessenger`, called `defaultBinaryMessenger`
* Platform channels use the `defaultBinaryMessenger` for their binaryMessenger default argument.
2019-05-28 11:18:22 -07:00
Emmanuel Garcia
faec4ca361
Instrument add to app flows ( #33297 )
2019-05-28 11:11:20 -07:00
Jason Simmons
841286d652
Framework support for font features in text styles ( #33230 )
...
See https://github.com/flutter/flutter/issues/31691
2019-05-28 11:06:54 -07:00
Greg Spencer
7c811b6a66
Fix first focus determination. ( #33279 )
...
Replacing the algorithm for finding the first focusable item in the focus tree. Somehow it was a kind of gibberish before, and really didn't work or make sense.
2019-05-28 10:19:19 -07:00
Luiz Dubas
841e1cf0af
Add mustRunAfter on mergeAssets task to force task ordering ( #33272 )
...
Co-authored-by: Miguel Lemos <miguelslemos@gmail.com>
2019-05-28 10:01:19 -07:00
Jonah Williams
a656bcf54f
rename test file that misnamed ( #33361 )
2019-05-28 09:56:13 -07:00
Yegor
8217f4bc8c
remove Layer.replaceWith due to no usage and no tests ( #33164 )
2019-05-28 09:55:32 -07:00
