Jenn Magder
91f0878fed
Move iOS content validation devicelab test into tool integration test ( #142272 )
...
The archiving was running in devicelab because certs are needed to codesign (see #73577 ). However now the certs are available in chromium bots. Move the archiving test into the existing tool integration test, and delete the devicelab variant.
arm64:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624673/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6074_4
x64:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624689/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6389_2
Part of https://github.com/flutter/flutter/issues/142070
2024-01-26 18:04:09 +00:00
engine-flutter-autoroll
cd60dd921d
Roll Flutter Engine from 61d841cf6c6d to 525bd7dcf7f3 (1 revision) ( #142308 )
...
61d841cf6c...525bd7dcf7skia-flutter-autoroll@skia.org Roll Skia from ea260ac426c3 to ae73baacb793 (2 revisions) (flutter/engine#50084 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 17:21:25 +00:00
engine-flutter-autoroll
91068c89b9
Roll Flutter Engine from de64dff38b10 to 61d841cf6c6d (1 revision) ( #142306 )
...
de64dff38b...61d841cf6cskia-flutter-autoroll@skia.org Roll Skia from cc5124317c18 to ea260ac426c3 (10 revisions) (flutter/engine#50083 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 16:38:05 +00:00
Polina Cherkasova
0b686be36e
Fix not disposed ImageInfo in tests. ( #142287 )
2024-01-26 08:02:41 -08:00
engine-flutter-autoroll
827c94c4af
Roll Packages from 21b5abba7958 to cbe810031b88 (2 revisions) ( #142303 )
...
21b5abba79...cbe810031bbarpac02@gmail.com Update README of `package:process` (flutter/packages#5475 )
2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter from 19b06f4ee9a0 to a8efa771d6a3 (38 revisions) (flutter/packages#5969 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 15:45:08 +00:00
engine-flutter-autoroll
242facbcb9
Roll Flutter Engine from bf0cda33122b to de64dff38b10 (1 revision) ( #142301 )
...
bf0cda3312...de64dff38bskia-flutter-autoroll@skia.org Roll Dart SDK from 6ff9926232bd to 5636e338e0b9 (1 revision) (flutter/engine#50081 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 15:13:59 +00:00
engine-flutter-autoroll
988db6ba57
Roll Flutter Engine from 8a81e53e60a2 to bf0cda33122b (1 revision) ( #142293 )
...
8a81e53e60...bf0cda3312skia-flutter-autoroll@skia.org Roll Dart SDK from 6f8bcd5b48ab to 6ff9926232bd (1 revision) (flutter/engine#50079 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 10:56:37 +00:00
Bartek Pacia
370f40e6df
flutter.groovy: update for Gradle Kotlin DSL compatibility ( #142144 )
...
This PR fixes 2 small mistakes in `FlutterExtension`:
- all fields must be `public` in order to be used in Gradle Kotlin DSL the same as in Gradle Groovy DSL
- using `logger` instead of `project.logger` throws an error when executed
This PR re-adds a subset of changes from #141541 which broke the tree and has been reverted.
2024-01-26 09:46:18 +00:00
engine-flutter-autoroll
236461161a
Roll Flutter Engine from 9142fc4f16a5 to 8a81e53e60a2 (8 revisions) ( #142290 )
...
9142fc4f16...8a81e53e60skia-flutter-autoroll@skia.org Roll Dart SDK from 00784f1f22b5 to 6f8bcd5b48ab (1 revision) (flutter/engine#50074 )
2024-01-26 ditman@gmail.com [web] Add `views` proxy and `getInitialData`. (flutter/engine#49320 )
2024-01-26 ditman@gmail.com [web] Prevent re-rendering disposed views when the engine hot restarts. (flutter/engine#49958 )
2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fb950853f06 to 00784f1f22b5 (3 revisions) (flutter/engine#50068 )
2024-01-26 matanlurey@users.noreply.github.com Avoid sizing `ImageReaderSurfaceProducer` smaller than 1x1 (flutter/engine#50066 )
2024-01-26 jonahwilliams@google.com Use clamp sampling mode in external texture. (flutter/engine#50063 )
2024-01-26 john@johnmccutchan.com Reland Optimizations for TLHC frame rate and jank (flutter/engine#50065 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Igt2rE-R6rgfmTRaF... to WHlwlOwznFknNm5IS... (flutter/engine#50059 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Igt2rE-R6rgf to WHlwlOwznFkn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 07:10:24 +00:00
engine-flutter-autoroll
2b2b37e2d3
Manual roll Flutter Engine from 4b145d041560 to 9142fc4f16a5 (12 revisions) ( #142278 )
...
Manual roll requested by zra@google.com
4b145d0415...9142fc4f16flutter/engine#50062 )
2024-01-25 bdero@google.com [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035 )
2024-01-25 127441427+eitanliu@users.noreply.github.com Fix android new engine in group (flutter/engine#49659 )
2024-01-25 103135467+sealesj@users.noreply.github.com Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054 )
2024-01-25 leroux_bruno@yahoo.fr Fix a typo in ChannelBuffers documentation (flutter/engine#49928 )
2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898 )
2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424 )
2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865 )
2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883 )
2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-26 02:16:24 +00:00
Matan Lurey
2f6fdf2650
Start renaming by adding a new bringup: true as an Android emulator. ( #142257 )
...
Part 2 of https://github.com/flutter/flutter/issues/142178 .
Supersedes https://github.com/flutter/flutter/pull/142078 .
Feedback welcome to avoid reverts!
2024-01-26 01:07:08 +00:00
Polina Cherkasova
15fa68ab1d
Instrument ImageInfo. ( #141411 )
2024-01-25 17:02:17 -08:00
Qun Cheng
7ff5f81a2e
Fix SegmentedButton default size and default tappable size ( #142243 )
...
fix https://github.com/flutter/flutter/issues/121493
`SegmentedButton` uses `TextButton` for each segments. When we have `MaterialTapTargetSize.padded` for `TextButton`, we make sure the minimum tap target size is 48.0( this value can be adjusted by visual density), even tough the actual button size is smaller. When `SegmentedButton` paints segments by using `MultiChildRenderObjectWidget`, it also includes the tap target size so the button that it actually draws always has the same height as the height of the tap target size.
To fix it, this PR firstly calculate the actual height of a text button in `SegmentedButton` class, then we can get the height delta if there is. Then the the value of (Segmented button render box height - the delta) would be the actual button size that we should see.
For now, we are not able to customize the min, max, fixed size in [`SegmentedButton` style](https://api.flutter.dev/flutter/material/SegmentedButton/style.html ). So the standard button height is always 40 and can only be customized by `style.visualDensity` and `style.tapTargetSize`; `SegmentedButton` only simulates the `TextButton` behavior when `TextButton`'s height is its default value.
https://github.com/flutter/flutter/assets/36861262/15ca6034-e6e0-4cc6-8fe3-808b4bd6a920
2024-01-26 00:20:21 +00:00
godofredoc
a6c3ad2310
Update name for android_defines_test. ( #142273 )
...
This is to reuse the global emulator configurations and make it easier to identify this test is running on an emulator.
2024-01-26 00:16:36 +00:00
Pierrick Bouvier
37c3978b34
Enable native compilation for windows-arm64 ( #141930 )
...
It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows.
This is available only for master channel (on other channels, it fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
2024-01-26 00:08:20 +00:00
auto-submit[bot]
d5bd2fe5ad
Reverts "Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions)" ( #142274 )
...
Reverts flutter/flutter#142264
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
4b145d0415...44f26274bfdnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898 )
2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424 )
2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865 )
2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883 )
2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 23:29:17 +00:00
godofredoc
8cc944d776
Run a few mac tests only on arm. ( #142188 )
...
Note: some benchmarks will require to be rebaselined.
2024-01-25 23:05:20 +00:00
derdilla
e342667954
fix Ink not updating on TextField newline ( #140700 )
...
Fixes a layout bug when using an EditableText and something containing an Ink widget.
2024-01-25 14:51:54 -08:00
dependabot[bot]
ab30122f6b
Bump codecov/codecov-action from 3.1.4 to 3.1.5 ( #142259 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.4 to 3.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>action.yml: Update to Node.js 20 by <a href="https://github.com/hallabro "><code>@âhallabro</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228 ">codecov/codecov-action#1228</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/hallabro "><code>@âhallabro</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228 ">codecov/codecov-action#1228</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5 ">https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="4fe8c5f0039140fdcf54https://redirect.github.com/codecov/codecov-action/issues/1228 ">#1228</a>)</li>
<li>See full diff in <a href="eaaf4bedf3...4fe8c5f003https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.4&new-version=3.1.5 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-25 22:51:06 +00:00
engine-flutter-autoroll
56c499cc7b
Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions) ( #142264 )
...
4b145d0415...44f26274bfdnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898 )
2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424 )
2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865 )
2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883 )
2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 22:41:51 +00:00
auto-submit[bot]
db25540919
Reverts "Reverts "Rename integration_tests/external_ui but do not touch anything else..."" ( #142268 )
...
Reverts flutter/flutter#142265
Initiated by: matanlurey
This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#142238
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/142178 .
2024-01-25 22:28:27 +00:00
auto-submit[bot]
f8544df0ea
Reverts "Rename integration_tests/external_ui but do not touch anything else..." ( #142265 )
...
Reverts flutter/flutter#142238
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/142178 .
2024-01-25 22:10:17 +00:00
engine-flutter-autoroll
4589f4c4e2
Roll Flutter Engine from b2167a93c1a0 to 4b145d041560 (3 revisions) ( #142256 )
...
b2167a93c1...4b145d0415jonahwilliams@google.com [Impeller] Fix mipmap generation for Vulkan render target textures. (flutter/engine#49848 )
2024-01-25 jason-simmons@users.noreply.github.com [Impeller] Do not emit metadata for structs that are not part of the shader's interface (flutter/engine#50029 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from de46a989e0ca to 29b545e4356b (1 revision) (flutter/engine#50047 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 21:49:02 +00:00
Nate
497f912d6e
Implementing switch expressions in the cupertino/ directory ( #141591 )
...
Refactors code to use the new `switch` expressions.
2024-01-25 13:29:28 -08:00
Matan Lurey
f61d2f53c6
Rename integration_tests/external_ui but do not touch anything else... ( #142238 )
...
Part of https://github.com/flutter/flutter/issues/142178 .
2024-01-25 13:08:16 -08:00
engine-flutter-autoroll
f037b7ae7a
Roll Flutter Engine from 55eefd5bd255 to b2167a93c1a0 (2 revisions) ( #142252 )
...
55eefd5bd2...b2167a93c1jonahwilliams@google.com [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741 )
2024-01-25 jonahwilliams@google.com Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 21:00:25 +00:00
engine-flutter-autoroll
2be86dbee3
Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) ( #142245 )
...
3b4779324b...55eefd5bd2skia-flutter-autoroll@skia.org Roll Skia from bcc2e8b6105a to de46a989e0ca (1 revision) (flutter/engine#50046 )
2024-01-25 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042 )
2024-01-25 jonahwilliams@google.com [Impeller] call shutdown method in Android context. (flutter/engine#49992 )
2024-01-25 maRci002@users.noreply.github.com [web] add support for AppLifecycleState changes (flutter/engine#44720 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 20:06:20 +00:00
LouiseHsu
caba667ed4
Fix incorrect zh-cn translation for Look Up Label in selection controls ( #142158 )
...
Fixes https://github.com/flutter/flutter/issues/141764
Translation suggestion here:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2024-01-25 10:24:42 -08:00
Justin McCandless
204a8848a6
PopScope example improvements ( #142163 )
...
Attempting to help users understand how to build a confirmation dialog when exiting a route.
2024-01-25 10:14:49 -08:00
engine-flutter-autoroll
e985c29f31
Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) ( #142225 )
...
1d3f16b0d6...3b4779324bskia-flutter-autoroll@skia.org Roll Skia from 699ee2b7cf34 to 416d7b0e5ba1 (2 revisions) (flutter/engine#50039 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:59:06 +00:00
engine-flutter-autoroll
ff01022017
Roll Packages from 8fbdf65d0235 to 21b5abba7958 (6 revisions) ( #142224 )
...
8fbdf65d02...21b5abba79pageli328@gmail.com Add rfw widgets (flutter/packages#5661 )
2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586 )
2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796 )
2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659 )
2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967 )
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c28e4ac to 19b06f4ee9a0 (21 revisions) (flutter/packages#5968 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:45:19 +00:00
Sigurd Meldgaard
a0e43d3053
Don't show legacy welcome message when analytics are disabled ( #140956 )
...
The legacy welcome message would be printed even if `CI=true` confusing
parsers of the output.
This fixes: https://github.com/flutter/flutter/issues/139737
---------
Co-authored-by: eliasyishak <42216813+eliasyishak@users.noreply.github.com>
2024-01-25 16:29:42 +01:00
engine-flutter-autoroll
1e24c41c0f
Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) ( #142223 )
...
7c4ed15cb2...1d3f16b0d6skia-flutter-autoroll@skia.org Roll Dart SDK from beb003009a4d to 2fb950853f06 (1 revision) (flutter/engine#50037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:10:05 +00:00
engine-flutter-autoroll
a8efa771d6
Roll Flutter Engine from e2014f007f61 to 7c4ed15cb271 (1 revision) ( #142221 )
...
e2014f007f...7c4ed15cb268449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 13:22:25 +00:00
engine-flutter-autoroll
bd5db0daaf
Roll Flutter Engine from 5fa2e2920274 to e2014f007f61 (1 revision) ( #142213 )
...
5fa2e29202...e2014f007fskia-flutter-autoroll@skia.org Roll Skia from 21c53af2e9f5 to 699ee2b7cf34 (1 revision) (flutter/engine#50034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 08:56:25 +00:00
Andrew Kolos
295a9a2031
provide command to FakeCommand::onRun ( #142206 )
...
Part of work on [#101077 ](https://github.com/flutter/flutter/pull/141194 ). This is done as a separate PR to avoid a massive diff.
## Context
1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename.
2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question.
## Issue
In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched.
Example:
```dart
FakeCommand(
command: <Pattern>[
artifacts.getArtifactPath(Artifact.engineDartBinary),
'run',
'vector_graphics_compiler',
RegExp(r'--input=/.*\.temp'),
RegExp(r'--output=/.*\.temp'),
],
onRun: (List<String> command) {
final outputPath = (() {
// code to parse `--output` from `command`
})();
testFileSystem.file(outputPath).createSync(recursive: true);
},
)
```
2024-01-25 07:51:25 +00:00
engine-flutter-autoroll
535ce79a99
Roll Flutter Engine from c346fd3d9ca1 to 5fa2e2920274 (1 revision) ( #142212 )
...
c346fd3d9c...5fa2e29202skia-flutter-autoroll@skia.org Roll Dart SDK from 6211fedca10c to beb003009a4d (1 revision) (flutter/engine#50032 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 07:41:23 +00:00
engine-flutter-autoroll
20e8f5b910
Roll Flutter Engine from d4d8f668159b to c346fd3d9ca1 (1 revision) ( #142209 )
...
d4d8f66815...c346fd3d9cskia-flutter-autoroll@skia.org Roll Skia from c0544410fc8e to 21c53af2e9f5 (1 revision) (flutter/engine#50031 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 06:54:38 +00:00
engine-flutter-autoroll
1c3f386568
Roll Flutter Engine from 499ed00bbda2 to d4d8f668159b (2 revisions) ( #142205 )
...
499ed00bbd...d4d8f66815skia-flutter-autoroll@skia.org Roll Skia from 571873c31056 to c0544410fc8e (1 revision) (flutter/engine#50030 )
2024-01-25 71952488+johnstiles-google@users.noreply.github.com Use top-level GN arg for Skottie instead of CanvasKit-specific arg. (flutter/engine#50019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 06:10:37 +00:00
engine-flutter-autoroll
d2a2d83876
Roll Flutter Engine from 4880592ca5ba to 499ed00bbda2 (6 revisions) ( #142202 )
...
4880592ca5...499ed00bbdskia-flutter-autoroll@skia.org Roll Skia from 3b7accdf8ed8 to 571873c31056 (1 revision) (flutter/engine#50026 )
2024-01-25 jonahwilliams@google.com [Impeller] round up subpass coverage when it is close to (and smaller) than root pass size. (flutter/engine#49925 )
2024-01-25 mzhou620@gmail.com Adding DDC module system targets to web SDK artifacts. (flutter/engine#47783 )
2024-01-25 hasan@hasali.dev [Windows] Set cursor immediately when framework requests update (flutter/engine#49784 )
2024-01-25 737941+loic-sharma@users.noreply.github.com [Windows] Introduce `egl::Surface` and `egl::WindowSurface` (flutter/engine#49983 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 588caf1ceddd to 3b7accdf8ed8 (1 revision) (flutter/engine#50025 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 04:10:26 +00:00
David Iglesias
703e12f524
[ci] Adds test for web hot restart with const App. ( #141824 )
...
This PR adds a test that reproduces the problem described in the linked issue: hot restart on the web seems to not update if the app being run is `const`.
The new test is expected to fail, until the `const` issue with hot restart in the web is resolved.
Expected failure mode is a 15s timeout in the following test:
```
02:31 +3 ~1 -1: Hot reload (index.html: Default) (with `const MyApp()`)): newly added code executes during hot restart [E]
TimeoutException after 0:00:15.000000: Future not completed
dart:async _startMicrotaskLoop
...
```
(And then a bunch of output that I'm not 100% sure is intended :))
## Issues
* #141588
2024-01-25 01:49:08 +00:00
godofredoc
3165fa30be
Migrate android_view to linux_android_emu platform. ( #142184 )
...
A new top level platform configuration was created for android emulator tests running on linux vms.
This is also a preparation step to remove adhoc recipes created to run emulator tests.
2024-01-25 01:15:12 +00:00
Matan Lurey
b3da19f879
Refactor external_ui without making any name changes (I think) ( #142192 )
...
Work towards https://github.com/flutter/flutter/issues/142178 .
---
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)
2024-01-24 17:14:16 -08:00
Renzo Olivares
eba38c4b77
Fix text selection edge scrolling when inside a horizontal scrollable ( #140250 )
...
Fixes #129590
* Consider `AxisDirection` when calculating scroll offset used in determining TextSelection during a drag/long press drag. Previously it seems that we were assuming the direction was always vertical 30cc831985/packages/flutter/lib/src/widgets/text_selection.dart (L2842-L2844)
2024-01-25 00:59:06 +00:00
engine-flutter-autoroll
d83eff4459
Roll Flutter Engine from d7bf5ec1dcdd to 4880592ca5ba (2 revisions) ( #142186 )
...
d7bf5ec1dc...4880592ca5skia-flutter-autoroll@skia.org Roll Dart SDK from e0bf6a261895 to 6211fedca10c (1 revision) (flutter/engine#50021 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 247a61a5496d to 588caf1ceddd (2 revisions) (flutter/engine#50020 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 00:42:25 +00:00
engine-flutter-autoroll
d12b36de02
Roll Flutter Engine from 6a7f963dc751 to d7bf5ec1dcdd (2 revisions) ( #142185 )
...
6a7f963dc7...d7bf5ec1dcskia-flutter-autoroll@skia.org Roll Skia from 7d69d275afd8 to 247a61a5496d (1 revision) (flutter/engine#50018 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 643160445720 to 7d69d275afd8 (3 revisions) (flutter/engine#50016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 23:56:25 +00:00
Polina Cherkasova
47d8252a85
Reland "Remove hack from PageView." ( #142172 )
...
Original PR: https://github.com/flutter/flutter/pull/141533
Failure: https://fusion2.corp.google.com/presubmit/601217743/OCL:601217743:BASE:601219708:1706132224874:9a4bcab3/targets
Fix: [b/321743868](https://b.corp.google.com/321743868 ), http://cl/601219001 (added as g3 fix.
2024-01-24 23:44:11 +00:00
Polina Cherkasova
a522b38e96
Upgrade leak_tracker. ( #142162 )
2024-01-24 15:33:17 -08:00
godofredoc
d51858c2e1
Migrate android views to devicelab. ( #142081 )
...
Migrate android view out of recipes.
2024-01-24 23:11:12 +00:00
engine-flutter-autoroll
30cc831985
Roll Flutter Engine from ed498f111d53 to 6a7f963dc751 (4 revisions) ( #142176 )
...
ed498f111d...6a7f963dc7skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kYC2-fFgjbb36mukB... to Igt2rE-R6rgfmTRaF... (flutter/engine#50015 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 9ea7cb490804 to 643160445720 (6 revisions) (flutter/engine#50014 )
2024-01-24 robert.ancell@canonical.com Add custom FlValue types and support their en/decoding via FlStandardMessageCodec (flutter/engine#49162 )
2024-01-24 matanlurey@users.noreply.github.com Do not double-increment `nextId` when using `createSurfaceProducer` with `SurfaceTexture`s (flutter/engine#50011 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kYC2-fFgjbb3 to Igt2rE-R6rgf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 22:41:13 +00:00
