37159 Commits

Author SHA1 Message Date
engine-flutter-autoroll
9427b77376
Roll Flutter Engine from 310ad4666445 to fff38de45ef7 (1 revision) (#135830)
310ad46664...fff38de45e

2023-10-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Et_e4YYLaN6JyhtnC... to xavNitWHYl39nmCPT... (flutter/engine#46447)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Et_e4YYLaN6J to xavNitWHYl39

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-01 15:22:06 +00:00
engine-flutter-autoroll
d42313c04b
Roll Flutter Engine from e8c834be50bb to 310ad4666445 (1 revision) (#135829)
e8c834be50...310ad46664

2023-10-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rZzd2cREE1_AwHJK8... to WKLlWqrdEL9WmoxzI... (flutter/engine#46446)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from rZzd2cREE1_A to WKLlWqrdEL9W

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-01 14:13:23 +00:00
engine-flutter-autoroll
9e161a490f
Roll Flutter Engine from 6f511aec0795 to e8c834be50bb (1 revision) (#135817)
6f511aec07...e8c834be50

2023-10-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DEmzJ6vnZAAUzsm81... to Et_e4YYLaN6JyhtnC... (flutter/engine#46445)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from DEmzJ6vnZAAU to Et_e4YYLaN6J

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-01 03:12:07 +00:00
engine-flutter-autoroll
19af27cb74
Roll Flutter Engine from 3ac5785c976b to 6f511aec0795 (2 revisions) (#135816)
3ac5785c97...6f511aec07

2023-10-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZDxyy9-hcaVyv65as... to rZzd2cREE1_AwHJK8... (flutter/engine#46444)
2023-09-30 jonahwilliams@google.com [Impeller] disable texture to texture blit in GLES. (flutter/engine#46443)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ZDxyy9-hcaVy to rZzd2cREE1_A

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-01 02:11:35 +00:00
engine-flutter-autoroll
d34fa811e1
Roll Flutter Engine from 01fc3c6624ce to 3ac5785c976b (1 revision) (#135814)
01fc3c6624...3ac5785c97

2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from c4e955c13ed5 to c9b521394392 (1 revision) (flutter/engine#46441)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 23:25:25 +00:00
engine-flutter-autoroll
d3df8f6bbf
Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (#135808)
68fc1a5671...01fc3c6624

2023-09-30 matanlurey@users.noreply.github.com [Impeller] Make some Open GL errors non-fatal, check in debug mode (not unopt). (flutter/engine#46434)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 18:35:41 +00:00
engine-flutter-autoroll
0a89630954
Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (#135807)
4ed733d99c...68fc1a5671

2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 4574906880c1 to c4e955c13ed5 (1 revision) (flutter/engine#46439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 17:44:31 +00:00
engine-flutter-autoroll
8e3b7a9cb5
Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (#135801)
d814c69abe...4ed733d99c

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vSGsxh_81aaf5CdfW... to DEmzJ6vnZAAUzsm81... (flutter/engine#46438)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from vSGsxh_81aaf to DEmzJ6vnZAAU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 14:07:30 +00:00
engine-flutter-autoroll
d0a5bc6271
Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (#135799)
f726438d4d...d814c69abe

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from U0lgvzao-MdzfEvoT... to ZDxyy9-hcaVyv65as... (flutter/engine#46437)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from U0lgvzao-Mdz to ZDxyy9-hcaVy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 12:52:59 +00:00
engine-flutter-autoroll
ba1d6147ba
Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (#135796)
0b96a82cc8...f726438d4d

2023-09-30 skia-flutter-autoroll@skia.org Roll Skia from a063eaeaf1e0 to 20a431090e24 (1 revision) (flutter/engine#46436)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 08:52:24 +00:00
engine-flutter-autoroll
10e9b63ba5
Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (#135793)
f3a4cab699...0b96a82cc8

2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 9aca08d40398 to 4574906880c1 (1 revision) (flutter/engine#46435)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 06:50:09 +00:00
engine-flutter-autoroll
f6e3dae014
Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (#135792)
e719b79577...f3a4cab699

2023-09-30 jason-simmons@users.noreply.github.com [Impeller] Apply the transform to PointFieldGeometry coverage (flutter/engine#46428)
2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 0931bb8a43c8 to 9aca08d40398 (1 revision) (flutter/engine#46432)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 03:34:40 +00:00
engine-flutter-autoroll
853bd95dcb
Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (#135789)
8939f9c1f4...e719b79577

2023-09-30 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed subpass filter coverage with image filters (flutter/engine#46431)
2023-09-30 john@johnmccutchan.com Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views (flutter/engine#46430)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 02:50:34 +00:00
engine-flutter-autoroll
f7dface99c
Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (#135788)
6a13607008...8939f9c1f4

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mR_mhiacGiD-ObsoG... to vSGsxh_81aaf5CdfW... (flutter/engine#46427)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from mR_mhiacGiD- to vSGsxh_81aaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 02:04:31 +00:00
Ricardo Amador
4e5e47e76a
Add device ready check (#135526)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/121420

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-30 01:58:52 +00:00
Ricardo Amador
d7739dff68
Temporarily disable NexusLowRes, version=29 (#135785)
There are too many flakes to leave this version enabled. Temporarily disabled and following up with FTL.

*List which issues are fixed by this PR. You must list at least one issue.*
Related to https://github.com/flutter/flutter/issues/135784

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-30 01:57:05 +00:00
Kostia Sokolovskyi
95eae5f967
Cover more test/widgets tests with leak tracking #12. (#135385) 2023-09-29 17:47:04 -07:00
Kostia Sokolovskyi
fdde24195f
DraggableScrollableController should dispatch creation in constructor. (#135423) 2023-09-29 17:45:35 -07:00
engine-flutter-autoroll
0f5cc2c0ae
Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (#135780)
d203e34978...6a13607008

2023-09-29 chillers@google.com Disable enableHardwareBufferRenderingTarget (flutter/engine#46425)
2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vbw3Gwj-6eN7rSqb4... to U0lgvzao-MdzfEvoT... (flutter/engine#46424)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from vbw3Gwj-6eN7 to U0lgvzao-Mdz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-30 00:34:36 +00:00
engine-flutter-autoroll
e736821383
Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (#135776)
48973d7f9b...d203e34978

2023-09-29 dkwingsmt@users.noreply.github.com Multi-view Rasterizer  (flutter/engine#45512)
2023-09-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (flutter/engine#46423)
2023-09-29 jonahwilliams@google.com [Impeller] Redo simplify invert colors. (flutter/engine#46416)
2023-09-29 jacksongardner@google.com Use `dart:_wasm` constructs to avoid dependence on `WebAssembly.Function` (flutter/engine#46388)
2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (flutter/engine#46420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 23:32:19 +00:00
Kostia Sokolovskyi
a11b21dba8
ViewportOffset should dispatch creation in constructor. (#135420) 2023-09-29 14:08:39 -07:00
Jackson Gardner
9f4f6c4756
Use platform dill from the engine when compiling with dart2wasm. (#134970)
This is the final change needed to address https://github.com/flutter/flutter/issues/133467

This allows us to use the platform dill that is built by the engine when compiling apps. This also fixes the `--local-web-sdk` flag when compiling to wasm (which previously didn't work without some serious tweaking of the engine build output).
2023-09-29 20:21:24 +00:00
engine-flutter-autoroll
878a48fafd
Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (#135765)
d5fcd78a87...48973d7f9b

2023-09-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (flutter/engine#46412)
2023-09-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." (flutter/engine#46414)
2023-09-29 jonahwilliams@google.com [Impeller] simplify invert colors flag by supporting composed color filters. (flutter/engine#46391)
2023-09-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 077d768accfa to e042e83c85a5 (3 revisions) (flutter/engine#46409)
2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 9f8242377455 to 2d4045f55fd5 (3 revisions) (flutter/engine#46408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 20:19:33 +00:00
Polina Cherkasova
9d9f213eed
Upgrade leak_tracker to fix flackiness. (#135760)
Fixes: https://github.com/flutter/flutter/issues/135716
leak_tracker is left pinned because future updates are going to be breaking.
2023-09-29 18:55:21 +00:00
engine-flutter-autoroll
46ba498320
Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (#135755)
c52251a8b2...d5fcd78a87

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from a80c164ffb8a to 9f8242377455 (1 revision) (flutter/engine#46406)
2023-09-29 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements canvas recorder with trace serializer (flutter/engine#46376)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 18:33:56 +00:00
Taha Tesser
ebaf160391
Update Drawer tests for M2/M3 (#135752)
Updated unit tests for `Drawer` to have M2 and M3 versions.

More info in #127064
2023-09-29 18:15:53 +00:00
Kate Lovett
7c9feea835
Expose onAttach and onDetach in ScrollController subclasses (#135721)
Fixes https://github.com/flutter/flutter/issues/135574
This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.
2023-09-29 17:47:36 +00:00
Jackson Gardner
0f947a09ed
Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (#135723)
Some upcoming engine changes will bind to a function provided by the emscripten JS wrapper around skwasm, rather than just the wasm module itself. This will make sure not to break the benchmarks when those engine changes land. See https://github.com/flutter/engine/pull/46388
2023-09-29 17:41:45 +00:00
Elias Yishak
ba1416954a
Update logic for getting Analytics instance from package:unified_analytics (#134756)
Part of:
- https://github.com/flutter/flutter/issues/128251

Currently, when we want to use the analytics instance from `package:unified_analytics`, we are just grabbing it from globals. However, with the legacy analytics instance, there are some things we check to return a no-op version of the instance.. for example, if we are running on bots or a non standard branch, we use a no-op instance

This PR uses the same previous checks for the new analytics instance
2023-09-29 16:20:16 +00:00
engine-flutter-autoroll
57b5c3cda0
Roll Packages from c070b0a7a80a to d0e9a0e1b3ac (5 revisions) (#135753)
c070b0a7a8...d0e9a0e1b3

2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c7b846 to ff4a0f676f41 (107 revisions) (flutter/packages#5011)
2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda59847 to ead455963c12 (1 revision) (flutter/packages#5022)
2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 16:10:29 +00:00
engine-flutter-autoroll
cfdaf1e593
Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (#135748)
db4d3b5b3f...c52251a8b2

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ta8wiQnzbBc7fAGeR... to mR_mhiacGiD-ObsoG... (flutter/engine#46403)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Ta8wiQnzbBc7 to mR_mhiacGiD-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 13:26:11 +00:00
engine-flutter-autoroll
3d003f9fb4
Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (#135745)
8b4e633c65...db4d3b5b3f

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from l2RxJKPfYn7QzGOoL... to vbw3Gwj-6eN7rSqb4... (flutter/engine#46401)
2023-09-29 49699333+dependabot[bot]@users.noreply.github.com Bump webdriver from 3.0.2 to 3.0.3 in /lib/web_ui (flutter/engine#46400)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from l2RxJKPfYn7Q to vbw3Gwj-6eN7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 12:11:18 +00:00
engine-flutter-autoroll
e4fbb6d35b
Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (#135744)
09130bf5be...8b4e633c65

2023-09-29 matej.knopp@gmail.com [macOS] Ensure first responder is consistent during and after text input (flutter/engine#46032)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 11:05:25 +00:00
engine-flutter-autoroll
e891516051
Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (#135741)
ccb30585d3...09130bf5be

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 75033613a49f to a80c164ffb8a (3 revisions) (flutter/engine#46399)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 09:38:52 +00:00
engine-flutter-autoroll
fc9fef299c
Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (#135737)
2052515c44...ccb30585d3

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 08485e753e3a to 75033613a49f (2 revisions) (flutter/engine#46396)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 07:36:00 +00:00
godofredoc
938bb217fb
Update localizations. (#135691)
Updates the localization files.
2023-09-29 04:11:31 +00:00
engine-flutter-autoroll
96e6f18cf3
Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (#135732)
485543c676...2052515c44

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4WW3KRrAbuY7VeGT0... to Ta8wiQnzbBc7fAGeR... (flutter/engine#46387)
2023-09-28 jonahwilliams@google.com [Impeller] revert stencil config changes. (flutter/engine#46386)
2023-09-28 bdero@google.com Bump impeller-cmake to head (flutter/engine#46385)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from 33502f9b0c7d to 08485e753e3a (1 revision) (flutter/engine#46384)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 4WW3KRrAbuY7 to Ta8wiQnzbBc7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-29 03:19:12 +00:00
keyonghan
951653a1c0
Add arch property for windows_arm64 platform (#135725)
Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.

Part of https://github.com/flutter/flutter/issues/135722
2023-09-29 00:57:06 +00:00
Jonah Williams
d13cd8846e
[flutter_tools] remove VmService screenshot for native devices. (#135462)
* This is completely broken on the Impeller renderer, see: https://github.com/flutter/flutter/issues/135052
* Even on the Skia renderer, this gives a software rasterized screenshot which will absolutely look different from a native rendering screenshot.

I plan to remove this functionality from the engine.
2023-09-29 00:21:14 +00:00
Polina Cherkasova
e5d3b704da
Pin leak_tracker before publishing breaking change. (#135720) 2023-09-28 17:03:23 -07:00
engine-flutter-autoroll
de20e74a9a
Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (#135717)
cc7c3c1f0f...485543c676

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Remove opacity layer dcheck. (flutter/engine#46160)
2023-09-28 matanlurey@users.noreply.github.com Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381)
2023-09-28 matej.knopp@gmail.com Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377)
2023-09-28 matej.knopp@gmail.com [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Removed unnecessary dynamic dispatch (flutter/engine#46369)
2023-09-28 joel.winarske@gmail.com [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287)
2023-09-28 ajihyf@gmail.com Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 23:42:11 +00:00
Kate Lovett
3509a1dfb7
Remove assertions on getOffsetToReveal (#135634) 2023-09-28 18:01:46 -05:00
Flutter GitHub Bot
55c7a2efc4
Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (#135565)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22).
This test can be marked as unflaky.
2023-09-28 22:44:52 +00:00
engine-flutter-autoroll
4968963290
Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (#135701)
dbb60932a6...cc7c3c1f0f

2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 22:37:17 +00:00
Yegor
371aadd822
[tool] fallback to sigkill when closing Chromium (#135521)
This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257, namely:

Make `Chromium.close` more robust:

* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.

Bonus: a few nullability fixes and extra `-v` logging.

Fixes https://github.com/flutter/flutter/issues/132654
2023-09-28 22:28:31 +00:00
flutter-pub-roller-bot
b5c8fd11e4
Roll pub packages (#135455)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-09-28 21:00:28 +00:00
engine-flutter-autoroll
97847e099a
Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (#135694)
9789dbc2ec...dbb60932a6

2023-09-28 chris@bracken.jp Revert "[macOS] performKeyEquivalent cleanup (#45946)" (flutter/engine#46374)
2023-09-28 matej.knopp@gmail.com [macOS] performKeyEquivalent cleanup (flutter/engine#45946)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 20:10:11 +00:00
Bruno Leroux
e61f9e0ce5
Fix TabBarView.viewportFraction change is ignored (#135590)
## Description

This PR updates `_TabBarViewState.didUpdateWidget` in order to react to `TabBarView.viewportFraction`change.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/135557.

## Tests

Adds 1 test.
2023-09-28 19:56:15 +00:00
engine-flutter-autoroll
8860dd21d8
Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (#135688)
d9eaebd058...9789dbc2ec

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from bcbcb109bad6 to d8a71d549262 (1 revision) (flutter/engine#46367)
2023-09-28 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7c3588c05f87 to 077d768accfa (11 revisions) (flutter/engine#46366)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 19:01:12 +00:00
Matheus Kirchesch
9fdb167183
Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (#132361)
This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled.

As the issue states this PR is the NavigationBar's version of these two PRs (https://github.com/flutter/flutter/pull/132349 and https://github.com/flutter/flutter/pull/127113)

* https://github.com/flutter/flutter/issues/132359
2023-09-28 18:41:18 +00:00