Yegor
9502cb1576
increase Linux build_test shard count from 3 to 5 ( #154444 )
...
Fixes https://github.com/flutter/flutter/issues/154443
2024-08-30 15:05:55 -07:00
John McDole
7aace1c5f9
Run all microbenchmarks (part trois) ( #154446 )
...
**Three things**
Re-lands #154374
New: fix `platform_channels_benchmarks` to print the "done" key. Updated notes for the microbenchmark parser. There are no other users of `microbenchmarks.readJsonResults`.
Re-Re-land: Uninstall microbenchmarks before running them.
Flakes in https://github.com/flutter/flutter/issues/153828 stem from adb saying the app isn't installed, but then failing to install wtih -r. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution https://github.com/flutter/flutter/issues/153828
Re-land Make things go fast
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 20:55:16 +00:00
engine-flutter-autoroll
8c1a93508b
Roll Flutter Engine from 94487cc5765b to eff1b76cf297 (2 revisions) ( #154435 )
...
94487cc576...eff1b76cf230870216+gaaclarke@users.noreply.github.com Reland: Framework wide color (#54415 ) (#54737 ) (flutter/engine#54905 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from f3811180e7df to 2727e4e5d7ec (3 revisions) (flutter/engine#54904 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 20:17:12 +00:00
auto-submit[bot]
8c264775bf
Reverts "Run all microbenchmarks ( #154374 )" ( #154440 )
...
Reverts: flutter/flutter#154374
Initiated by: jtmcdole
Reason for reverting: A different benchmark was using the microbenchmark parser and timing out.
Original PR Author: jtmcdole
Reviewed By: {zanderso}
This change reverts the following previous change:
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 19:44:19 +00:00
Dimil Kalathiya
620d1ea729
Expose long press in ``CupertinoButton`` ( #154052 )
...
Adds long press as per https://github.com/flutter/flutter/issues/153956 request
Fixes #153956
2024-08-30 18:56:00 +00:00
John McDole
9fc160b11c
Run all microbenchmarks ( #154374 )
...
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 18:22:06 +00:00
hangyu
0d8247eb7d
Add a RegExp for iOS domain when reading domains from xcodeProject ( #154201 )
...
Append the string `?mode=<alternate mode>` to the associated domain to
enable alternate mode in some use cases is recommended in apple
developer guide
(https://developer.apple.com/documentation/xcode/configuring-an-associated-domain#Enable-alternate-mode-for-unreachable-servers )
So when reading these domains from xcode settings, we should consider
this case and trim it.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-08-30 11:17:29 -07:00
Dishank Jindal
01e8ecaea6
Added support for elevation on refresh indicator ( #154182 )
...
Refresh Indicator Elevation:
- Added elevation to the refresh indicator using elevation attribute.
- This change improves the indicator's visibility against various background colors and enhances overall UI consistency.
- If we want to get rid of shadow effect from the indicator itself.
The refresh indicator did not provide the control over depth of the progress indicator. This change addresses that issue by adding elevation to the indicator, creating a subtle depth effect that makes it more visually prominent and provides better feedback to the user.
No breaking changes.
| Before | After |
| --- | --- |
|  |  |
Pre-launch Checklist
2024-08-30 17:50:08 +00:00
engine-flutter-autoroll
e48a45ff5e
Roll Flutter Engine from c851c58019e9 to 94487cc5765b (2 revisions) ( #154427 )
...
c851c58019...94487cc576skia-flutter-autoroll@skia.org Roll Skia from 2b633f7626ea to f3811180e7df (2 revisions) (flutter/engine#54900 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from DtxLvjJOVzo_oZGui... to p5MYp7o9Tt0sossYJ... (flutter/engine#54899 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 17:15:21 +00:00
Justin McCandless
995a1da104
Android predictive back should work after returning to the app from a notification ( #154313 )
...
Fixes a bug where the app would exit on a back gesture when there were still routes in the navigation stack after returning to the app from a notification.
2024-08-30 09:36:10 -07:00
engine-flutter-autoroll
357704aeb2
Roll Flutter Engine from 9c3f66d822e4 to c851c58019e9 (7 revisions) ( #154416 )
...
9c3f66d822...c851c58019#54886 )" (flutter/engine#54902 )
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896 )" (flutter/engine#54901 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 16:23:19 +00:00
engine-flutter-autoroll
08c3970f2b
Roll Packages from 2a0f25419c52 to c9c000430163 (6 revisions) ( #154411 )
...
2a0f25419c...c9c000430110687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371 )
2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473 )
2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428 )
2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521 )
2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529 )
2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 15:52:21 +00:00
engine-flutter-autoroll
967286b386
Roll Flutter Engine from da87db6d55e3 to 9c3f66d822e4 (2 revisions) ( #154385 )
...
da87db6d55...9c3f66d822#54415 ) (#54737 )" (flutter/engine#54885 )
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (#54567 )" (flutter/engine#54884 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 06:13:13 +00:00
engine-flutter-autoroll
3541a83a8e
Roll Flutter Engine from dc7eefb0f18a to da87db6d55e3 (2 revisions) ( #154381 )
...
dc7eefb0f1...da87db6d55jonahwilliams@google.com [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879 )
2024-08-29 30870216+gaaclarke@users.noreply.github.com Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 02:38:29 +00:00
engine-flutter-autoroll
2bcd6055d7
Roll Flutter Engine from 2ed08d7ea315 to dc7eefb0f18a (2 revisions) ( #154379 )
...
2ed08d7ea3...dc7eefb0f1skia-flutter-autoroll@skia.org Roll Skia from 82e12bf2991a to 9ce15f8b2c7e (4 revisions) (flutter/engine#54881 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from e6ccd7185482 to 139867e57ba9 (1 revision) (flutter/engine#54880 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 01:02:37 +00:00
Andrew Kolos
a8528c70b6
catch StateError thrown from Chromium.close ( #154366 )
...
Fixes crasher https://github.com/flutter/flutter/issues/154203 .
Also does a little refactoring to move exception handling into the `getChromeTabGuarded` utility function.
I plan on cherry-picking a subset of this change. This would be included in the custom CP patch for https://github.com/flutter/flutter/issues/153064 .
2024-08-30 00:01:12 +00:00
Mairramer
680f33d238
fix:: elevation and scrollUnderElevation depends on scrolling drawers on issue #120083 ( #150793 )
...
fixes https://github.com/flutter/flutter/issues/120083
Description
This PR addresses the following issues:
- Resolves the unexpected scrolledUnderElevation trigger that occurs when scrolling within the Drawer and NavigationDrawer.
2024-08-29 23:06:20 +00:00
Matan Lurey
712cf654d1
Remove --disable-dart-dev across flutter/flutter. ( #154280 )
...
As per the Dart CLI team and @bkonyi, this is no longer providing value and we shouldn't cargo-cult it.
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-08-29 22:50:04 +00:00
Christopher Fujino
eed0b71c20
unpin path_provider_android ( #154369 )
...
Fixes https://github.com/flutter/flutter/issues/140796
2024-08-29 22:46:19 +00:00
engine-flutter-autoroll
facae75629
Roll Flutter Engine from 30750940b60a to 2ed08d7ea315 (3 revisions) ( #154367 )
...
30750940b6...2ed08d7ea3skia-flutter-autoroll@skia.org Roll Skia from 1d16eab57a8e to 82e12bf2991a (6 revisions) (flutter/engine#54876 )
2024-08-29 jbauman@google.com Use fuchsia.scheduler.RoleManager protocol (flutter/engine#54587 )
2024-08-29 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Remove duplicate gn_configs (flutter/engine#54855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 22:30:25 +00:00
Qun Cheng
1501e9eee0
CupertinoSlidingSegmentedControl is able to have proportional layout based on segment content (#153125 )
2024-08-29 15:06:44 -07:00
Michael Goderbauer
de3d174050
Make ViewAnchor a LookupBoundary ( #154300 )
...
So, uhm, 2 years ago in https://github.com/flutter/flutter/pull/116429 we introduced this concept of a lookup boundary to hide certain InheritedWidgets in widget subtrees who belong to a different render tree than the InheritedWidget itself. This is for example needed for the Material widget: Buttons reach out to their Material ancestor to draw ink splashes on its associated render object. This only produces the desired effect if the button render object is a descendant of the Material render object (the two need to be in the same render tree). Overlay widgets have a similar problem.
Lookup boundaries were specifically designed for multi view support, where a sub view would be powered by a separate and independent render tree. Ergo, widgets in the sub view shouldn't see these InheritedWidgets if they are part of the parent view. After all, it would be strange if clicking on a button in a subview draws the ink splash effect into the parent view. Unfortunately, we (and by that I really mean I) forgot to put a LayoutBoundary into the relevant multi view widgets when those were introduced in https://github.com/flutter/flutter/pull/125003 . This PR addresses that by wrapping the `ViewAnchor.view` child in a LookupBoundary so that its subtree (which bootstraps a separate render tree) cannot see these InheritedWidgets in the parent view.
2024-08-29 21:49:25 +00:00
Valentin Vignal
15904ef9be
Add tests for sliver grid delegate with fixed cross axis count examples ( #153500 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/rendering/sliver_grid/sliver_grid_delegate_with_fixed_cross_axis_count.0.dart`
- `examples/api/lib/rendering/sliver_grid/sliver_grid_delegate_with_fixed_cross_axis_count.1.dart`
I also fixed a mistake in the documentation
2024-08-29 21:41:21 +00:00
engine-flutter-autoroll
8f80d14e35
Roll Flutter Engine from 6d4cb16395ca to 30750940b60a (2 revisions) ( #154364 )
...
6d4cb16395...30750940b6skia-flutter-autoroll@skia.org Roll Skia from 10e44e318a72 to 1d16eab57a8e (3 revisions) (flutter/engine#54874 )
2024-08-29 30870216+gaaclarke@users.noreply.github.com Reland: Framework wide color (#54415 ) (flutter/engine#54737 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 21:24:57 +00:00
engine-flutter-autoroll
77a17873be
Roll Flutter Engine from 8c2789185956 to 6d4cb16395ca (1 revision) ( #154362 )
...
8c27891859...6d4cb16395skia-flutter-autoroll@skia.org Roll Dart SDK from 3c1bb8338b79 to e6ccd7185482 (2 revisions) (flutter/engine#54872 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 20:28:25 +00:00
Christopher Fujino
7be9e5558b
validate and commit after regenerating gradle lockfiles from pub autoroller ( #154152 )
...
Fixes https://github.com/flutter/flutter/issues/154151
Validate the git diff generated by the regenerate gradle lockfile script and then commit the changes.
2024-08-29 20:22:24 +00:00
Ben Konyi
04595bc088
Launch DDS using DartDevelopmentServiceLauncher ( #154015 )
...
`DartDevelopmentServiceLauncher` was created to share the DDS launch
logic from flutter_tools with other Dart tooling.
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-08-29 16:16:27 -04:00
flutter-pub-roller-bot
055350f84a
Roll pub packages ( #154360 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-29 14:56:39 -04:00
engine-flutter-autoroll
f42a5f11ac
Roll Flutter Engine from 27a04c95859d to 8c2789185956 (3 revisions) ( #154358 )
...
27a04c9585...8c27891859matanlurey@users.noreply.github.com Fix `build/dart/rules.gni` which contains erroneous code after my refactor. (flutter/engine#54867 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 20b3af58d4a5 to 10e44e318a72 (1 revision) (flutter/engine#54869 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZL8AvfXX5LFIH1LYN... to ohUS2y1HixZYziUtX... (flutter/engine#54868 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZL8AvfXX5LFI to ohUS2y1HixZY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 18:29:42 +00:00
Kate Lovett
1c6defcbff
Add verbose logging for customer testing shard ( #154356 )
2024-08-29 13:27:54 -05:00
flutter-pub-roller-bot
5e285635a8
Roll pub packages ( #154352 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-29 17:46:09 +00:00
engine-flutter-autoroll
7806c796ac
Roll Flutter Engine from 815d6ac935e5 to 27a04c95859d (3 revisions) ( #154353 )
...
815d6ac935...27a04c9585matanlurey@users.noreply.github.com Migrate another big chunk of the engine repo to `package:test` (flutter/engine#54853 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 31406e74142b to 20b3af58d4a5 (2 revisions) (flutter/engine#54866 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 0caad7938587 to 3c1bb8338b79 (1 revision) (flutter/engine#54864 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 17:34:56 +00:00
PurplePolyhedron
48b7a5a38f
Make Scrollable.ensureVisible document clearer that it would scroll all enclosing Scrollable ( #154321 )
...
Current documentation for `Scrollable.ensureVisible` could sometimes be misunderstood as if it only scroll the closest `Scrollable`.
2024-08-29 17:14:11 +00:00
Jason Simmons
9bf7d7bb35
Do not paint a description label when rendering an integration test ( #153875 )
...
Fixes https://github.com/flutter/flutter/issues/153624
2024-08-29 17:08:38 +00:00
jesswrd
05c454c28c
Agp Java Compatability Custom Error ( #154142 )
...
Catches gradle error and throws a helpful error message that indicates
an incompatability between Java and AGP versions and how to fix the
issue.
Related issue:
[128524](https://github.com/flutter/flutter/issues/128524 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
2024-08-29 10:06:48 -07:00
flutter-pub-roller-bot
f9351fae7e
Roll pub packages ( #154267 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-29 16:28:08 +00:00
engine-flutter-autoroll
911f2ff923
Roll Packages from d862279f291f to 2a0f25419c52 (14 revisions) ( #154341 )
...
d862279f29...2a0f25419c10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager` (flutter/packages#7437 )
2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523 )
2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511 )
2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369 )
2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513 )
2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515 )
2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421 )
2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500 )
2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498 )
2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487 )
2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands #6456 : Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497 )
2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands #6456 : Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989 )
2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467 )
2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext ⦠(flutter/packages#7337 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 15:48:10 +00:00
Zachary Anderson
d01b9a4f8c
Increase timeout for customer_testing test step ( #154339 )
...
Related: https://github.com/flutter/flutter/issues/154251
Successful runs are bumping right up against the timeout
See https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84496/overview which succeeded in 29 minutes vs. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84497/overview which failed with a timeout at 30 minutes.
2024-08-29 15:34:25 +00:00
Gabriel Terwesten
f0860d83f5
[native assets] Rewrite install names for relocated native libraries ( #153054 )
...
Native libraries that are contributed by native asset builders can depend on each other. For macOS and iOS, native libraries are repackaged into Frameworks, which renders install names that have been written into dependent libraries invalid.
With this change, a mapping between old and new install names is maintained, and install names in dependent libraries are rewritten as a final step.
Related to https://github.com/dart-lang/native/issues/190
2024-08-29 14:51:23 +00:00
engine-flutter-autoroll
033e9b7912
Roll Flutter Engine from 98bdb2312779 to 815d6ac935e5 (1 revision) ( #154337 )
...
98bdb23127...815d6ac935skia-flutter-autoroll@skia.org Roll Skia from 253b10915d32 to 31406e74142b (2 revisions) (flutter/engine#54863 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 14:25:16 +00:00
Tirth
a73ab15fbf
Minor Formatting ( #154210 )
...
Minor Formatting.
2024-08-29 13:04:18 +00:00
engine-flutter-autoroll
f478276222
Roll Flutter Engine from f1a90d1c0521 to 98bdb2312779 (1 revision) ( #154327 )
...
f1a90d1c05...98bdb23127skia-flutter-autoroll@skia.org Roll Dart SDK from fed5ce7ea2ad to 0caad7938587 (1 revision) (flutter/engine#54862 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 10:44:25 +00:00
engine-flutter-autoroll
270bc02ab4
Roll Flutter Engine from a0c2da548962 to f1a90d1c0521 (1 revision) ( #154324 )
...
a0c2da5489...f1a90d1c05skia-flutter-autoroll@skia.org Roll Skia from dac455fdf502 to 253b10915d32 (1 revision) (flutter/engine#54860 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 09:16:26 +00:00
engine-flutter-autoroll
f7804404b8
Roll Flutter Engine from bad94641d24f to a0c2da548962 (1 revision) ( #154322 )
...
bad94641d2...a0c2da5489skia-flutter-autoroll@skia.org Roll Skia from e37b6b198016 to dac455fdf502 (1 revision) (flutter/engine#54859 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 07:55:21 +00:00
Taha Tesser
9d971fada1
Fix IconButton doesn't show Tooltip when hovering within the button area but outside the Icon ( #153691 )
...
Fixes [Tooltip is not shown consistently on entire IconButton](https://github.com/flutter/flutter/issues/153544 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(
MaterialApp(
home: Scaffold(
body: Center(
child: Row(
spacing: 20.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
IconButton(
padding: const EdgeInsets.all(20.0),
icon: const ColoredBox(
color: Color(0xFFFF0000),
child: Icon(Icons.add),
),
onPressed: () {},
tooltip: 'Tooltip',
),
IconButton.filled(
padding: const EdgeInsets.all(20.0),
icon: const ColoredBox(
color: Color(0xFFFF0000),
child: Icon(Icons.add),
),
onPressed: () {},
tooltip: 'Tooltip',
),
IconButton.filledTonal(
padding: const EdgeInsets.all(20.0),
icon: const ColoredBox(
color: Color(0xFFFF0000),
child: Icon(Icons.add),
),
onPressed: () {},
tooltip: 'Tooltip',
),
IconButton.outlined(
padding: const EdgeInsets.all(20.0),
icon: const ColoredBox(
color: Color(0xFFFF0000),
child: Icon(Icons.add),
),
onPressed: () {},
tooltip: 'Tooltip',
),
],
),
),
),
),
);
}
```
</details>
### Before (Hover outside the red box but within the `IconButton`)
<img width="579" alt="Screenshot 2024-08-19 at 15 30 35" src="https://github.com/user-attachments/assets/fd2a65f1-f30d-4907-a2d9-c11dc59efb2b ">
### Before (Hover outside the red box but within the `IconButton`)
<img width="579" alt="Screenshot 2024-08-19 at 15 30 09" src="https://github.com/user-attachments/assets/b2b4dba7-4d0a-44c9-b1e1-742a900ffd8a ">
### Demo
https://github.com/user-attachments/assets/129eb8ee-e132-45c9-80b7-165486c02951
2024-08-29 07:02:23 +00:00
engine-flutter-autoroll
e9a0f60171
Roll Flutter Engine from f48ecf5b49f6 to bad94641d24f (1 revision) ( #154319 )
...
f48ecf5b49...bad94641d2jonahwilliams@google.com [engine] add an ios noop context. (flutter/engine#54856 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 06:58:26 +00:00
engine-flutter-autoroll
7e9a622420
Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions) ( #154316 )
...
Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions)
8d248aead3...f48ecf5b49jonahwilliams@google.com [Impeller] Use multiple command
buffers for blur submission. (flutter/engine#54846 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 0d8d9d2974fa to
e37b6b198016 (1 revision) (flutter/engine#54854 )
2024-08-29 matanlurey@users.noreply.github.com Remove
`--disable-dart-dev` across `flutter/engine`. (flutter/engine#54845 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from
vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... (flutter/engine#54852 )
2024-08-28 jonahwilliams@google.com [Impeller] fix clip culling with exp
canvas. (flutter/engine#54701 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) (flutter/engine#54851 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from d55406ca32e9 to
0d8d9d2974fa (4 revisions) (flutter/engine#54850 )
2024-08-28 jacksongardner@google.com [skwasm] Always do backdrop filter
operation even if empty. (flutter/engine#54844 )
2024-08-28 matanlurey@users.noreply.github.com
Migrate`header_guard_check` to `package:test`. (flutter/engine#54811 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54848 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from cd3d3daafe55 to
d55406ca32e9 (10 revisions) (flutter/engine#54847 )
2024-08-28 jonahwilliams@google.com [Impeller] ensure that srcOver to
src conversion takes stroke coverage into account.
(flutter/engine#54817 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from
ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... (flutter/engine#54840 )
2024-08-28 matanlurey@users.noreply.github.com Remove scorecards and
other bading we are no longer tracking/links are borked
(flutter/engine#54839 )
2024-08-28 omersa@google.com Compile dart2wasm modules using the JS
runtime exported compileStreaming (flutter/engine#51488 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
183b9e21b706 to bc3dad16b2d3 (1 revision) (flutter/engine#54838 )
2024-08-28 matanlurey@users.noreply.github.com Ignore generated fixture
`.dill.deps` files. (flutter/engine#54836 )
2024-08-28 68449066+zijiehe-google-com@users.noreply.github.com
[fuchsia] use the api-level from gn-sdk (flutter/engine#54740 )
2024-08-28 jonahwilliams@google.com [Impeller] port clip stack fixes to
new canvas. (flutter/engine#54727 )
2024-08-28 jonahwilliams@google.com [Impeller] fall back to path
rendering on thick paths. (flutter/engine#54822 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... (flutter/engine#54834 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from ca108745b1de to
cd3d3daafe55 (1 revision) (flutter/engine#54832 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
42ddf2278114 to 183b9e21b706 (1 revision) (flutter/engine#54830 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
b519f85c3076 to 42ddf2278114 (1 revision) (flutter/engine#54829 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from
OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54827 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 41cb13f65fe6 to
ca108745b1de (1 revision) (flutter/engine#54828 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 259010335a55 to
41cb13f65fe6 (2 revisions) (flutter/engine#54826 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 505fb55cd044 to
259010335a55 (1 revision) (flutter/engine#54823 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
8334290a421b to b519f85c3076 (1 revision) (flutter/engine#54821 )
2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 84e4a69da303 to
505fb55cd044 (1 revision) (flutter/engine#54819 )
2024-08-27 jonahwilliams@google.com [Impeller] Increase host buffer
arena count to 4. (flutter/engine#54808 )
2024-08-27 flar@google.com Synchronize accounting for render op depths
(flutter/engine#54794 )
2024-08-27 34871572+gmackall@users.noreply.github.com Fix broken links
in `docs/` (flutter/engine#54815 )
2024-08-27 chinmaygarde@google.com [Impeller] Don't override user
specification on Vulkan validation in unopt. (flutter/engine#54816 )
2024-08-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b81b344a194f to 8334290a421b (12 revisions) (flutter/engine#54813 )
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 77017d30a455 to
84e4a69da303 (3 revisions) (flutter/engine#54812 )
2024-08-27 chinmaygarde@google.com [Impeller] Clarify where to put the
metadata in the manifest. (flutter/engine#54814 )
2024-08-27 chinmaygarde@google.com [Impeller] Use infinite swapchain
present timeouts to avoid logspam. (flutter/engine#54810 )
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 2e1eea538014 to
77017d30a455 (2 revisions) (flutter/engine#54809 )
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from a2e2eb292492 to
2e1eea538014 (4 revisions) (flutter/engine#54806 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BCqzoTS_Sz6- to ZL8AvfXX5LFI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
...
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-08-28 22:08:34 -07:00
Nate Wilson
e1f0083c78
Fix Drawer prematurely snapping ( #153955 )
...
This regression is due to the fact that `animationController.isAnimating` and `animationController.status.isAnimating` sometimes return opposite values.
This PR implements & tests the bugfix, and also adds documentation to explain this behavior.
<br>
fixes https://github.com/flutter/flutter/issues/153851
cc @azeunkn0wn @huycozy
2024-08-29 02:23:19 +00:00
LongCatIsLooong
24194e5631
Defer overlay child layout if the target overlay is currently laying out its size-determining child ( #154222 )
...
Fixes #153903
2024-08-29 01:59:34 +00:00
Matan Lurey
32e29fc39b
Temporarily mark Linux customer_testing as bringup: true. ( #154297 )
...
See https://github.com/flutter/flutter/issues/154293 .
2024-08-28 16:09:05 -07:00
