firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,276 Commits 1 Branch 0 Tags
Commit Graph

5326 Commits

Author SHA1 Message Date
Todd Volkert
10decc7c19 Fix race condition in protocol_discovery.dart (#10092) 
For some reaosn, when we discovered our URI, we were re-instantiating
the `Completer` instance variable whose future we listen to in `nextUri()`.
This led to a race between a caller calling `nextUri()` and us discovering
the URI. If we happened to discover our URI before a caller called
`nextUri()`, then they would be left waiting on a future from the newly
allocated `Completer` (which would never complete).

Fixes #10064
 2017-05-16 08:25:51 -07:00
xster
b232a84b0d Auto provision iOS deploy 1/3 - find and use the first valid code signing certs (#9946) 
* blind wrote everything except the user prompt

* works

* Add some logical refinements

* Make certificates unique and add more instructinos

* print more info

* Add test

* use string is empty

* review notes

* some formatting around commands

* add a newline
 2017-05-15 12:54:32 -07:00
Ian Hickson
292abf7223 "flutter packages pub ..." to passthrough to dart pub (#10044) 2017-05-12 15:40:35 -07:00
Ian Hickson
7c9c5a296c Rearrange tests to more closely match code structure (#10043) 2017-05-12 10:44:52 -07:00
Ian Hickson
18eac03d76 VerboseLogger should just wrap the parent Logger (#10020) 
This way, you can test things even with a VerboseLogger.
 2017-05-12 10:00:11 -07:00
Jason Simmons
f44ba8b9c9 Add a flutter doctor --android-licenses command that locates and runs the Android SDK license manager (#9892) 
See https://github.com/flutter/flutter/issues/8438
 2017-05-09 10:18:45 -07:00
Yegor
aba6095444 make zero-device test hermetic (#9891) 2017-05-08 17:57:20 -07:00
Michael Goderbauer
ca4d7211b0 Enforce valid package names on flutter create (#9854) 
* Enforce valid package names on flutter create

Fixes #9564

* refactor

* fix other tests
 2017-05-08 14:08:59 -07:00
Todd Volkert
a29585298e Add level field to the "showMessage" daemon event. (#9889) 
Spawned from a discussion in https://github.com/flutter/flutter-intellij/pull/1003
 2017-05-08 11:49:47 -07:00
xster
31b958378a Report flutter doctor success/failure (#9664) 
* record doctor failures

* fully mock out analytics dependencies
 2017-05-08 11:10:36 -07:00
xster
c74225e00d Report timing on failed executions too (#9661) 
* handle errors

* review notes
 2017-05-08 11:10:21 -07:00
Todd Volkert
6a4b08bec6 Make DeviceDomain echo a msg if doctor says it can't list anything (#9749) 
This message will be picked up by IntelliJ and shown to the user in a toast.
 2017-05-03 16:12:08 -07:00
Todd Volkert
31000ef77e Remove unused code in adb.dart (#9732) 2017-05-02 21:12:28 -07:00
xster
85b2b86939 CocoaPods flow step 3 - don't automatically pod setup (#9703) 
* Don’t automatically pod setup if the user never did it

* fix/add test

* rename getters
 2017-05-02 16:11:37 -07:00
xster
66ed8de745 Record flutter run success/fail, build mode, platform, start time in analytics (#9597) 
FlutterCommand.runCommand subclasses can optionally return a FlutterCommandResult which is used to append additional analytics. 

Fix flutter run timing report and add a bunch of dimensional data
 2017-04-27 15:28:15 -07:00
Devon Carew
9ac2e44ee7 add a regression test for daemon device notification (#9618) 
* add a regression test for daemon device notification

* revert event send simplification
 2017-04-27 09:30:47 -07:00
Zachary Anderson
0770c3c14f [flutter_tools] Adds some support for '-d all' (#9585) 2017-04-26 21:49:38 -07:00
Todd Volkert
e2cd78358f Fix missing await (#9617) 
Fixes #9612
 2017-04-26 13:14:31 -07:00
Michael Goderbauer
460561bad8 Make Flutter plugins usable from a Windows host (#9599) 
Note: In a cross-platform context `Uri.path` is not a valid file path. Allways use `fs.path.fromUri` to convert.
 2017-04-26 10:02:22 -07:00
Todd Volkert
60c5ffc1a9 Switch many Device methods to be async (#9587) 
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
 2017-04-25 17:23:00 -07:00
Michael Goderbauer
ad1c497c03 Do not lower-case paths during canonicalization. (#9571) 
* Do not lower-case paths during canonicalization.

This breaks hot reload on some platfroms with case insensitive file systems.

* Add unit tests
 2017-04-25 10:34:43 -07:00
Todd Volkert
a3f0f6911b Remove replay test (#9542) 
It's going to be replaced by #8963

Fixes #8947
 2017-04-24 08:47:38 -07:00
Alexandre Ardhuin
35803c2297 comprehensive list of lints (#9330) 
* comprehensive list of lints
* add comments to commented out lint
* fix unnecessary_this lints
* exclude prefer_final_fields
 2017-04-20 09:38:57 +02:00
Mikkel Nygaard Ravn
cb220c85be Add test of flutter create --plugin (#9459) 2017-04-19 00:00:39 +02:00
Devon Carew
4631717f1b De-duplicate the dartanalyzer command output (#9441) 2017-04-18 14:02:06 -07:00
John McCutchan
2c1bb355dd Do less file system crawling when we have the Dart dependency set (#9424) 
- [x] Skip scanning the file system if we already have the Dart dependency set.

Fixes #9376

```
Performing hot reload...
Reloaded 1 of 418 libraries in 888ms.

Performing hot reload...
Reloaded 1 of 418 libraries in 871ms.

** UNTAR dragontail under project root **
Performing hot reload...
Reloaded 0 of 418 libraries in 443ms.

** UNTAR dragontail under lib/ **
Performing hot reload...
Reloaded 0 of 418 libraries in 385ms.
```
 2017-04-17 11:20:04 -07:00
Ian Hickson
00dfa224d1 Be more consistent about how stack traces are output from flutter_test (#9361) 2017-04-13 12:31:04 -07:00
Yegor
5efbe05f04 do not warn about out-of-date Flutter installation too often (#9271) 
* do not warn about out-of-date Flutter installation too often

* style fix
 2017-04-10 13:21:02 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297) 
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
 2017-04-08 08:43:19 +02:00
Yegor
361afef305 fix checkLockAcquired: support re-entrant locking (#9272) 
* fix checkLockAcquired: support re-entrant locking

* add test; address comments

* add comment
 2017-04-07 21:08:53 -07:00
Michael Goderbauer
18d69b1b3e Delete Color supported test :( (#9235) 2017-04-05 16:25:20 -07:00
Michael Goderbauer
a559b8df5c [Regression] Re-enable ANSI color support on Windows (#9232) 
Also adds a test to make sure we don't break it again.
 2017-04-05 15:44:22 -07:00
Michael Goderbauer
d2abdf8e6b Roll Dart to 1.23.0-dev.11.5 (#9151) 
* Roll Dart to 1.23.0-dev.11.3.

This is expected to fix the Windows crashes reported in https://github.com/flutter/flutter/issues/8912.

* fix tests

* Roll to 1.23.0-dev.11.5

* Fix tests
 2017-04-05 09:47:02 -07:00
Alexandre Ardhuin
189028a958 Separate the 'if' expression from its statement (#9177) 2017-04-04 21:45:50 +02:00
Yegor
93126a85e1 warn about outdated Flutter installations (#9163) 2017-04-04 10:45:43 -07:00
Ian Hickson
57b3422795 Bold each line individually (#9069) 
This should make the message in Travis logs look better.
 2017-04-01 17:47:09 -07:00
Jason Simmons
e7f1361681 Update artifact names and remove obsolete artifacts (#9091) 2017-03-29 16:30:41 -07:00
Jason Simmons
72effdd27c Roll the engine and update for new binary names (#9089) 2017-03-29 15:31:36 -07:00
Yegor
3ef9909237 enable crash reporting in flutter_tools (#9039) 
* enable crash reporting in flutter_tools

* fix analytics text; use relative paths

* fix test
 2017-03-28 15:16:38 -07:00
Dan Rubel
52245e5082 update flutter analyze to call dartanalyzer 2017-03-28 08:44:15 -04:00
Todd Volkert
ff61962144 Update devfs_test to use MemoryFileSystem (#8811) 2017-03-27 12:55:19 -07:00
Jakob Andersen
e93f4a57a1 iOS: Make flutter doctor unhappy if CocoaPods is missing. (#8979) 2017-03-27 12:11:14 +02:00
John McCutchan
51ea62c143 Attempt to fix devfs test (#9007) 2017-03-24 12:32:45 -07:00
Ian Hickson
dfb6198feb Make the flutter test tests resilient to startup lock (#8941) 2017-03-22 11:07:58 -07:00
Jakob Andersen
f79b333882 Remove unnecessary Android SDK checks. (#8926) 
* Remove unnecessary Android SDK checks.

* Remove unused accessors, skip replay test.
 2017-03-22 13:51:28 +01:00
Michael Goderbauer
14933de986 Defer to operating system for whichAll (#8921) 
The old `whichAll` implementation was not considering different extensions for executables on Windows. By defering to OS-built-in tools we avoid implementing it.

Fixes #8882.
 2017-03-21 10:23:44 -07:00
Michael Goderbauer
d35a9db6fe Avoid downloading artifacts twice (#8872) 
* Avoid downloading artifacts twice

* Don't update cache before `flutter upgrade` is executed (`flutter upgrade` might bump the engine version)
* Don't update cache twice during `flutter precache`

Fixes #8249.

* add test
 2017-03-20 17:09:59 -07:00
Adam Barth
97816e1571 Rename Dismissable to Dismissible (#8919) 
The latter is the proper spelling.

Fixes #8883
 2017-03-20 16:17:08 -07:00
Alexandre Ardhuin
2166ea5b7f apply partially the upcoming unnecessary_lambdas (#8810) 2017-03-15 23:09:58 +01:00
Michael Goderbauer
15330ffbc4 Make ProcessSignals portable (#8779) 
* Make ProcessSignals portable

This removes the need to wrap unsupported signals with in `if (!platform.isWindows) ..`.

It also allows us to implement a work around for breaking the Windows console when flutter is exited with Ctrl+C.

* review comments

* adding tests

* add license header
 2017-03-15 11:28:14 -07:00