firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
34,201 Commits 1 Branch 0 Tags
Commit Graph

2579 Commits

Author SHA1 Message Date
Elias Yishak
a32f0bb7a0
Add analytics package + setTelemetry method attached (#124015) 
The first of many PRs for transitioning to `package:unified_analytics`.
This PR is only focused on disabling and enabling telemetry via the
`flutter config --[no-]analytics` flag

Fixes: https://github.com/flutter/flutter/issues/121617

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
 2023-04-05 14:08:56 -04:00
Michael Goderbauer
daaa32bc06
Add CustomDimensions.commandRunIsTest (#124135) 2023-04-05 09:30:36 -07:00
Danny Tuppeny
1a6a20cdc6
[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients (#121239) 
[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients
 2023-04-05 05:39:09 +00:00
Victoria Ashworth
842873c2fc
Allow --ipv6 flag for flutter attach on iOS devices (#123822) 
Allow --ipv6 flag for flutter attach on iOS devices
 2023-04-04 22:33:28 +00:00
Victoria Ashworth
dbc18bbdb8
Add flag to filter by device connection interface (#124034) 
Add flag to filter by device connection interface
 2023-04-04 22:33:26 +00:00
Chinmay Garde
f6c2b10e1a
[Impeller] Plumb through the impeller-force-gl flag. (#123828) 
[Impeller] Plumb through the impeller-force-gl flag.
 2023-03-31 15:13:10 +00:00
Chinmay Garde
7d31fe32f8
[Impeller] Plumb through the enable-vulkan-validation flag. (#123808) 
[Impeller] Plumb through the enable-vulkan-validation flag.
 2023-03-30 21:34:19 +00:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load (#122932) 
Update device selection to wait for wireless devices to load
 2023-03-29 17:58:07 +00:00
Janice Collins
81e9060968
Suppress analytics flag pass through to analysis server (#123235) 
Suppress analytics flag pass through to analysis server
 2023-03-24 19:59:15 +00:00
Harry Terkelsen
897e3db40c
Inject the gstatic CanvasKit CDN URL by default in flutter build web (#122772) 2023-03-23 09:17:25 -07:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag (#123031)" (#123280) 
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
 2023-03-22 22:53:49 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks (#123259) 
Remove 1745 decorative breaks
 2023-03-22 21:12:22 +00:00
Jason Simmons
d81e915780
Provide an ApplicationPackage to the flutter_tools logs command (#123149) 
Provide an ApplicationPackage to the flutter_tools logs command
 2023-03-22 14:51:39 +00:00
Michael Goderbauer
25e38a2a87
Bump lower Dart SDK constraints to 3.0 & add class modifiers (#122546) 
Bump lower Dart SDK constraints to 3.0 & add class modifiers
 2023-03-21 20:21:58 +00:00
Victoria Ashworth
9136a47458
Set plugin template minimum iOS version to 11.0 (#122625) 
Set plugin template minimum iOS version to 11.0
 2023-03-21 16:40:50 +00:00
Zachary Anderson
7e88acfb0e
[flutter_tool] Adds a flag to disable Impeller (#122960) 2023-03-20 22:23:23 -07:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909)" (#123031) 
[flutter_tools] Remove sound null safety flag #2
 2023-03-20 22:32:07 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909) 
This reverts commit 7c3088cf22c8a863ca38e3890851fd8dc776768d.
 2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag (#120936) 
[flutter_tools] Remove sound null safety flag
 2023-03-17 17:48:35 +00:00
Christopher Fujino
7e151b4641
[flutter_tools] throw tool exit on invocation of flutter format (#121646) 
[flutter_tools] throw tool exit on invocation of flutter format
 2023-03-16 21:40:26 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices (#122615) 
Separate attached and wireless devices
 2023-03-15 16:35:05 +00:00
Bartek Pacia
37fc9ed260
[flutter_tools] Clean up boolArgDeprecated and stringArgDeprecated (#122184) 
[flutter_tools] Clean up `boolArgDeprecated` and `stringArgDeprecated`
 2023-03-13 21:20:19 +00:00
Victoria Ashworth
ee42a302ec
Move target devices logic to its own classes and file (#121903) 
Move target devices logic to its own classes and file
 2023-03-13 16:14:21 +00:00
Jim Graham
3f2cca8eeb
Adjust the minimum sdk version in the synthetic pkg for new Dart requirements (#122380) 
Manually landing to fix the Engine rolls. The change will not affect Google Testing.
 2023-03-10 09:23:33 -08:00
Tim Maffett
2e8c3468e7
fix devtool instructional messages after flutter build ... --analyze-size . Fixes #122229 (#122230) 
fix devtool instructional messages after `flutter build ... --analyze-size `.  Fixes #122229
 2023-03-09 22:29:50 +00:00
Reid Baker
fe9e819143
Create configOnly flag for android (#121904) 
Create configOnly flag for android
 2023-03-08 19:46:52 +00:00
Christopher Fujino
b1641749fc
pin flutter_plugin_android_lifecycle and roll other pub deps (#122043) 
pin flutter_plugin_android_lifecycle and roll other pub deps
 2023-03-06 21:51:07 +00:00
Seiya Kokushi
acc840e574
[tool] Proposal to multiple defines for --dart-define-from-file (#120878) 
[tool] Proposal to multiple defines for --dart-define-from-file
 2023-03-06 18:16:14 +00:00
Christopher Fujino
26b7456f88
[flutter_tools] remove late from update-packages command (#121891) 
[flutter_tools] remove late from update-packages command
 2023-03-03 22:38:19 +00:00
Chris Yang
b81b1e28a3
[flutter_tool] add enable-embedder-api flag (#121895) 
[flutter_tool] add enable-embedder-api flag
 2023-03-03 21:13:54 +00:00
Victoria Ashworth
cc26a1aa0c
Update device filtering and introduce isConnected and connectionInterface (#121359) 
Update device filtering and introduce isConnected and connectionInterface
 2023-03-03 18:06:16 +00:00
Kevin Moore
a7f9ebcc49
Reorganize CLI flags for build web (#121837) 
Reorganize CLI flags for `build web`
 2023-03-03 00:59:16 +00:00
Kevin Moore
a8cc95e36d
flutter_tool: only enable wasm compile in master channel (#121755) 
flutter_tool: only enable wasm compile in master channel
 2023-03-02 22:21:50 +00:00
Kevin Moore
0cd6f1fbdb
[flutter_tool] advertise the default value for --dart2js-optimization (#121621) 
[flutter_tool] advertise the default value for --dart2js-optimization
 2023-03-01 01:17:56 +00:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory (#118577)" (#121606) 
This reverts commit 275ab9c69bc15113003b77637ea90031df8ed348.
 2023-02-28 11:57:04 -05:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory (#118577)" (#121215)" (#121555) 
Revert "Reland "Remove references to Observatory (#118577)""
 2023-02-27 23:46:53 +00:00
Danny Tuppeny
06952ba254
[flutter_tools] Add support for URI formats like ?line=x for "flutter test" (#119740) 
* [flutter_tools] Add support for URI formats like ?line=x for "flutter test"

* Remove unnecessary function

* Handle parsing absolute paths on Windows

* Use Windows-style paths when running on Windows

* Fix paths in isFile

* Remove unnecessary clear
 2023-02-27 19:13:00 +00:00
Greg Price
516b60bda1
Give error on too many arguments to flutter config (#121494) 
Give error on too many arguments to `flutter config`
 2023-02-27 17:22:20 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory (#118577)" (#121215) 
This reverts commit 298d8c76ba78007deb5b96f320a11ccefe97a794.
 2023-02-27 09:26:43 -05:00
Lioness100
26b6c1bedd
Fix typos (#121171) 
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
 2023-02-23 19:43:21 +00:00
Enguerrand ARMINJON
6259b690f6
feature/clean-a-specific-scheme: Add this-scheme new flag for clean command (#116733) 
Co-authored-by: Enguerrand_ARMINJON_MAC_2 <earminjon@sqli.com>
 2023-02-21 17:35:13 +00:00
Mateus Felipe C. C. Pinto
ebbc94bc2b
allow passing --file-reporter option to test running refs #69425 (#120716) 
* allow passing --file-reporter option to test running refs #69425

* Add trailing comma to help to meet style requirements

* Add space between tests for clarity

---------

Co-authored-by: daniel-v <dvarga@skawa.hu>
 2023-02-21 17:24:11 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) (#120842) 
* lerp documentation

* Remove Note, Note That from repo

* Improve BorderSide documentation.

* apply review comments
 2023-02-17 22:27:33 +00:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory (#118577)" (#120929) 
This reverts commit 2df140f40d8c771ecef4f21cbdf635ec1235b4ac.
 2023-02-16 21:28:30 -08:00
Christopher Fujino
c6b636fa51
[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) (#120637) 
* wip run_local_linter.dart

* get run_local_linter.dart working

* slow working implementation

* speed up run_local_linter.dart

* fix run_local_linter.dart

* remove catchError

* another fix

* fix another

* fix

* more fixes

* fix moar

* fix moar

* fix

* finish

* fix tests

* clean up further

* code review

* delete run_local_linter.dart
 2023-02-15 19:03:00 +00:00
Ian Hickson
d29668ddb2
Improve network resources doctor check (#120417) 
...and various other minor cleanup:

* Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.

* Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.

* Made the logger delete the slow warning when it's finished.

* Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.

* Added a debug toString to ValidationResult for debugging purposes (not used).

* In http_host_validator:

  - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
  - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
  - Renamed the check "Network resources".
  - Updated the `slowWarning` of the check to say which hosts are pending.
  - Removed all timeout logic. Timeouts violate our style guide.
  - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
  - Replaced the `_HostValidationResult` class with `String?` for simplicity.
  - Improved the error messages to be more detailed.
  - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
  - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
  - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
  - Replaced a lot of list-filtering logic with just a single for loop to check the results.
  - Replaced code that added a constant to a known-empty list with just returning a constant list.
  - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
 2023-02-15 00:02:09 +00:00
Ben Konyi
2df140f40d
Remove references to Observatory (#118577) 
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
 2023-02-13 14:29:30 -05:00
Michael Thomsen
c8c8621416
Clean up null safety messages (#120350) 2023-02-09 19:40:32 +01:00
Christopher Fujino
1089588863
un-pin package:intl (#119900) 2023-02-07 12:10:18 -08:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119737) 
This reverts commit 254a796bc3f8a32d3e09c1416bce7b7b9f1ba33b.
 2023-02-06 09:23:35 -05:00