16895 Commits

Author SHA1 Message Date
Jonah Williams
a491697893
[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct 2019-12-09 17:32:03 -08:00
liyuqian
69728097bd Remove unused observer and raise the waiting time (#46626) 2019-12-09 15:18:02 -08:00
Christopher Fujino
0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Tong Mu
a4f7a0dfb9
Revert changes to TestPointer; MouseTracker no longer relies on Add events (#46285)
* Revert test pointer

* Synthesize new state
2019-12-09 15:12:11 -08:00
engine-flutter-autoroll
5406f2b597
Roll engine d9f856510d16..a614c0a2d45f (4 commits) (#46627)
d9f856510d...a614c0a2d4

git log d9f856510d16..a614c0a2d45f --first-parent --oneline
2019-12-09 hterkelsen@users.noreply.github.com Convert radians to degrees in canvaskit backend for drawArc (flutter/engine#14163)
2019-12-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia f0148c4881df..c937bc50250d (11 commits) (flutter/engine#14262)
2019-12-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 2Nav3... to Zkpa_... (flutter/engine#14261)
2019-12-09 bkonyi@google.com Roll src/third_party/dart a9c77229c2..7fcaafbb3e (88 commits) (flutter/engine#14260)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-09 18:08:33 -05:00
Jonah Williams
63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210)" (#46630)
This reverts commit b698c9d72e42a5ab15338849a3a81fc435882ecb.
2019-12-09 13:13:59 -08:00
Jonah Williams
b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210) 2019-12-09 13:01:37 -08:00
Ian Hickson
05862ff968 Fix platform-specif test logic. (#46623) 2019-12-09 12:58:03 -08:00
Todd Volkert
55f0bdc033
Fix docker tag during upload as well (#46252)
In https://github.com/flutter/flutter/pull/46035, we fixed the docker
tag to be a legal tag during build.  This PR makes the corresponding
change to the tag during upload.  Without this, we build the right tag,
but then we try to upload the wrong tag.
2019-12-09 12:56:47 -08:00
engine-flutter-autoroll
9cb97346b3
d9f856510 Roll src/third_party/skia 9910d829ad18..f0148c4881df (1 commits) (flutter/engine#14258) (#46612)
4beaa696fc...d9f856510d

git log 4beaa696fc59..d9f856510d16 --first-parent --oneline
2019-12-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9910d829ad18..f0148c4881df (1 commits) (flutter/engine#14258)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-09 15:55:33 -05:00
engine-flutter-autoroll
5e06984854
4beaa696f Roll src/third_party/skia b60ec7f98b08..9910d829ad18 (3 commits) (flutter/engine#14257) (#46585)
ff6fa47659...4beaa696fc

git log ff6fa47659c0..4beaa696fc59 --first-parent --oneline
2019-12-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia b60ec7f98b08..9910d829ad18 (3 commits) (flutter/engine#14257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-09 04:54:33 -05:00
engine-flutter-autoroll
4edb509e50
ff6fa4765 Roll src/third_party/skia 274a766baf2f..b60ec7f98b08 (9 commits) (flutter/engine#14256) (#46572)
5b870a218f...ff6fa47659

git log 5b870a218f15..ff6fa47659c0 --first-parent --oneline
2019-12-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 274a766baf2f..b60ec7f98b08 (9 commits) (flutter/engine#14256)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-08 23:49:33 -05:00
Emmanuel Garcia
f264d6c277
Allow plugins that don't support the Android platform (#46282) 2019-12-08 20:04:19 -08:00
engine-flutter-autoroll
37384f2517
Roll engine e7b69ced2e24..5b870a218f15 (3 commits) (#46569)
e7b69ced2e...5b870a218f

git log e7b69ced2e24..5b870a218f15 --first-parent --oneline
2019-12-08 wvvwwvw@gmail.com Add support for setting window size limits for glfw (flutter/engine#13415)
2019-12-06 iska.kaushik@gmail.com [fuchsia] SnapToNextPhase refactor + add tests and documentation (flutter/engine#14158)
2019-12-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VKso5... to 9C6UA... (flutter/engine#14161)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-08 22:42:32 -05:00
Jenn Magder
e58dc16d7b
Revert "Add a FlutterDriver screenshot test to device lab. (#45411)" (#46281)
This reverts commit adec6977be800690d81cfc81cd07eb5037f4317f.
2019-12-06 18:21:52 -08:00
engine-flutter-autoroll
3d1e796be4
e7b69ced2 Roll src/third_party/skia 24ee4e0341fd..274a766baf2f (8 commits) (flutter/engine#14159) (#46249)
5f6fa92a8f...e7b69ced2e

git log 5f6fa92a8fd3..e7b69ced2e24 --first-parent --oneline
2019-12-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 24ee4e0341fd..274a766baf2f (8 commits) (flutter/engine#14159)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-06 18:31:33 -05:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Tom Robinson
9233b53255 Update SliverPersistentHeader docs (#46081) 2019-12-06 14:17:29 -08:00
Chris Yang
adec6977be
Add a FlutterDriver screenshot test to device lab. (#45411) 2019-12-06 14:17:02 -08:00
engine-flutter-autoroll
a830f687cc
Roll engine ed2d00ba02a4..5f6fa92a8fd3 (2 commits) (#46241)
git@github.com:flutter/engine.git/compare/ed2d00ba02a4...5f6fa92a8fd3

git log ed2d00ba02a4..5f6fa92a8fd3 --first-parent --oneline
2019-12-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 46e2d8d4a1ae..24ee4e0341fd (2 commits) (#14157)
2019-12-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia aa4f7f55829d..46e2d8d4a1ae (1 commits) (#14156)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-06 15:53:33 -05:00
Shi-Hao Hong
37e66b2179
gen_l10n.dart tool testing (#44856)
* Add tests to gen_l10n.dart tool

* Separate out LocalizationsGenerator class to improve testability of code

* Add testing dependencies to dev/tools

* Integrate dev/tools testing to flutter CI

* Restructure dev/tools folder for testing

* Fix license headers
2019-12-06 11:35:08 -08:00
engine-flutter-autoroll
066b5a1667
ed2d00ba0 Roll fuchsia/sdk/core/mac-amd64 from qQlb5... to VKso5... (flutter/engine#14154) (#46220)
git@github.com:flutter/engine.git/compare/fd240d0d532a...ed2d00ba02a4

git log fd240d0d532a..ed2d00ba02a4 --first-parent --oneline
2019-12-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from qQlb5... to VKso5... (#14154)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-06 13:42:28 -05:00
Amr Yousef
237c478683 Update iOS build signing error message (#45835) 2019-12-06 10:41:06 -08:00
engine-flutter-autoroll
240305238e
Roll engine 29998f07faf9..fd240d0d532a (2 commits) (#46218)
git@github.com:flutter/engine.git/compare/29998f07faf9...fd240d0d532a

git log 29998f07faf9..fd240d0d532a --first-parent --oneline
2019-12-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3e01360677b2..aa4f7f55829d (3 commits) (#14153)
2019-12-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia cc92b27c78a0..3e01360677b2 (2 commits) (#14152)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-06 04:39:28 -05:00
engine-flutter-autoroll
854f92d7be
Roll engine 0506c65f5915..29998f07faf9 (6 commits) (#46211)
git@github.com:flutter/engine.git/compare/0506c65f5915...29998f07faf9

git log 0506c65f5915..29998f07faf9 --first-parent --oneline
2019-12-06 fmil@google.com Configures ICU to load the timezone data (#13952)
2019-12-06 jason-simmons@users.noreply.github.com Do not paint a layer's children if the children were not prerolled (#14149)
2019-12-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0af13b3caf03..cc92b27c78a0 (26 commits) (#14151)
2019-12-05 50856934+nturgut@users.noreply.github.com [web] [tests] Changing configurations for firefox (#14148)
2019-12-05 dnfield@google.com Raise API level for reportFullyDrawn (#14146)
2019-12-05 30870216+gaaclarke@users.noreply.github.com Started setting the FlutterOverlayView's bounds when it gets added to its superview. (#14018)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-06 03:37:28 -05:00
Jonah Williams
7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
Tong Mu
ad20d368ff Fix null event crash in TapGestureRecognizer (#45943) 2019-12-05 19:33:01 -08:00
liyuqian
a2005eaf9a Memory test on scrolling large images quickly (#46184) 2019-12-05 19:28:00 -08:00
engine-flutter-autoroll
42cb9190b2
Roll engine ee4c2a53c7c6..0506c65f5915 (5 commits) (#46194)
git@github.com:flutter/engine.git/compare/ee4c2a53c7c6...0506c65f5915

git log ee4c2a53c7c6..0506c65f5915 --first-parent --oneline
2019-12-05 mouad.debbar@gmail.com [web] DOM text measurement return a LineMetrics list if single-line (#14138)
2019-12-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from XCAOU... to qQlb5... (#14144)
2019-12-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia f5542b6aa307..0af13b3caf03 (1 commits) (#14143)
2019-12-05 dnfield@google.com Disable a11y on detach (#14142)
2019-12-05 ferhat@gmail.com Fix firefox detection to fix app startup for other browsers (#14145)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-05 22:18:28 -05:00
Greg Spencer
bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Jonah Williams
e6fa5717d1
fix release web builds where the target file is not under lib (#46179) 2019-12-05 15:57:12 -08:00
Greg Spencer
e3005e6962
Fixes Focus and FocusScope's assignment of canRequestFocus. (#46168)
This fixes an issue where lines like this:

    focusNode.canRequestFocus = widget.canRequestFocus ?? focusNode.canRequestFocus;

Were causing the canRequestFocus bit to copy the status of the enclosing scope, since canRequestFocus also looks to the enclosing scope to decide if it can focus.
2019-12-05 15:33:05 -08:00
engine-flutter-autoroll
cb0dcbe1a9
Roll engine fdaa7cf12175..ee4c2a53c7c6 (8 commits) (#46178)
git@github.com:flutter/engine.git/compare/fdaa7cf12175...ee4c2a53c7c6

git log fdaa7cf12175..ee4c2a53c7c6 --first-parent --oneline
2019-12-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6344c2937997..0af32fdf5fea (12 commits) (#14139)
2019-12-05 dworsham@google.com Wire up Opacity on Fuchsia, round 2 (#14024)
2019-12-05 gw280@google.com Disable fml_tests until they're fixed on Fuchsia (#14137)
2019-12-05 30870216+gaaclarke@users.noreply.github.com Started specifying the OS version for running the tests. (#14094)
2019-12-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia ccca30aad770..6344c2937997 (13 commits) (#14133)
2019-12-04 30870216+gaaclarke@users.noreply.github.com Expanded our scenario_app docs. (#14136)
2019-12-04 yjbanov@google.com [web][felt] fix source map path (#14134)
2019-12-04 chinmaygarde@google.com Fix platform view offsets incorrectly taking into account device pixel ratios. (#14135)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-05 17:30:28 -05:00
Kaushik Iska
6705d08fb4
Manual roll engine fdaa7cf12175..ee4c2a53c7c6 (8 commits) (#46174)
git@github.com:flutter/engine.git/compare/fdaa7cf12175...ee4c2a53c7c6

git log fdaa7cf12175..ee4c2a53c7c6 --first-parent --oneline
2019-12-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6344c2937997..0af32fdf5fea (12 commits) (#14139)
2019-12-05 dworsham@google.com Wire up Opacity on Fuchsia, round 2 (#14024)
2019-12-05 gw280@google.com Disable fml_tests until they're fixed on Fuchsia (#14137)
2019-12-05 30870216+gaaclarke@users.noreply.github.com Started specifying the OS version for running the tests. (#14094)
2019-12-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia ccca30aad770..6344c2937997 (13 commits) (#14133)
2019-12-04 30870216+gaaclarke@users.noreply.github.com Expanded our scenario_app docs. (#14136)
2019-12-04 yjbanov@google.com [web][felt] fix source map path (#14134)
2019-12-04 chinmaygarde@google.com Fix platform view offsets incorrectly taking into account device pixel ratios. (#14135)
2019-12-05 13:59:54 -08:00
Alexandre Ardhuin
ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Chris Bracken
fa0c49d775
Dispatch hover events to PlatformViewController (#46124)
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
2019-12-05 13:31:50 -08:00
gaaclarke
86dd664fef
Made the behavior for caching large images modular. (#46010)
Introduced LargeImageHandler to ImageCache class.
2019-12-05 12:46:59 -08:00
Alexandre Ardhuin
ec0842e0d3
implicit-casts:false in examples (#45805) 2019-12-05 21:33:07 +01:00
Greg Spencer
c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Tong Mu
f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Jenn Magder
fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson
e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Todd Volkert
6d848ebf37 Name the docker_builer shard (#46103) 2019-12-05 12:13:01 -08:00
Zachary Anderson
99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Alexandre Ardhuin
649e188562
implicit-casts:false in flutter/lib/src/painting (#45621) 2019-12-05 09:41:49 +01:00
Jenn Magder
d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c03847c872dae91be63ce84511455379.
2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
godofredoc
1657075914
Move technical_debt_cost to use a cloud vm. (#45996) 2019-12-04 16:26:41 -08:00
Greg Spencer
f7d1616173
Overridable default platform key bindings (#45102)
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
2019-12-04 16:07:01 -08:00
Kate Lovett
9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00