13220 Commits

Author SHA1 Message Date
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Todd Volkert
3b47b44348
Re-apply "Ensure all curves return 0 and 1 in .transform(t) when t=0/1" (#28006)
Re-applies #27409 by reverting #27919

The analyzer issue (dart-lang/sdk#35940) has been temporarily
worked around by virtue of #27929
2019-02-15 12:29:09 -05:00
Greg Spencer
dff25a3055
Fix Dashing rules to use new dartdoc CSS entity markers. (#27818)
This fixes the offline Dash/Zeal docs generation to use the newly added dartdoc markers for different entity types to make it more exact when finding entity names.

Bumped Dartdoc to the next release.
2019-02-15 08:40:19 -08:00
Todd Volkert
cb1c7a3664
Ensure that Dart SDK dirs have appropriate permissions (#26315)
This is a partial re-application of #24669

https://github.com/flutter/flutter/issues/24413
2019-02-15 11:03:57 -05:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
Martin Kustermann
7862bef13a
Use double literals where a double type is expected (#27929)
This makes the code more consistent but also fixes our flutter-analyze bot.

Issue https://github.com/dart-lang/sdk/issues/35940
2019-02-15 14:10:55 +01:00
Jonah Williams
67cf21577f
Add basic codegen app to be used for integration testing and benchmarks (#27257) 2019-02-14 23:17:16 -08:00
Jonah Williams
3205736fcf
add ui.Window fallback to TestViewConfiguration (#27987) 2019-02-14 22:49:49 -08:00
Jonah Williams
9bc5656637
Wire dart2js through flutter tool, add compilation test (#27668) 2019-02-14 22:42:30 -08:00
xster
8661d8aecd
Test text paint orders by color (#27983) 2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00
Anthony
d1371cd269 Do not draw Slider tick marks if they are too dense (#27969) 2019-02-14 16:42:30 -08:00
Michael Goderbauer
d1707ab0ad
Revert "Fix overflow clipping/fading for text (#27892)" (#27966)
This reverts commit 46cabdab22ce59ba06949d666216ae4d10b76761.
2019-02-14 15:15:01 -08:00
KyleWong
e99c881f8d
Don't cache result for homeDirPath. (#27873) 2019-02-14 16:08:26 +08:00
engine-flutter-autoroll
da5c97c3ef
Roll engine d48de7a3ec97..3757390fa4b0 (17 commits) (#27907)
d48de7a3ec...3757390fa4

git log d48de7a3ec97ebf7ffe543aa74993efa51064789..3757390fa4b00d2d261bfdf5182d2e87c9113ff9 --no-merges --oneline
3757390fa Roll src/third_party/dart ecd7a88606..0a7dcf17eb (4 commits)
61d3080d5 Add FFI to libraries.yaml. (flutter/engine#7811)
f5259b8e2 Roll src/third_party/skia b6f53783337e..186669c4128b (8 commits) (flutter/engine#7816)
816921b9e Use newer Skia API for PathMeasure (flutter/engine#7809)
da56ff9c6 Roll src/third_party/skia 94a5328e0e4b..b6f53783337e (8 commits) (flutter/engine#7812)
04fbc2545 Roll src/third_party/skia 66f09a72995a..94a5328e0e4b (1 commits) (flutter/engine#7810)
347d690b2 Add support for new Scenic clip planes. (flutter/engine#7804)
309b90ca5 Roll src/third_party/skia 14d64dd4c47c..66f09a72995a (8 commits) (flutter/engine#7805)
1dead52a8 Roll src/third_party/skia 0b6ae6386d34..14d64dd4c47c (10 commits) (flutter/engine#7802)
74d94e52c Revert "Use all font managers to discover fonts for strut. (#7734)" (flutter/engine#7801)
769016c88 Roll src/third_party/skia 63d477cd99b0..0b6ae6386d34 (9 commits) (flutter/engine#7798)
f7eb3cb20 Roll src/third_party/skia 217acf58d0d8..63d477cd99b0 (1 commits) (flutter/engine#7797)
c4a55552b Use all font managers to discover fonts for strut. (flutter/engine#7734)
17b7d1e0a Roll src/third_party/dart 754e5f404c..ecd7a88606 (8 commits)
b4ed8cff3 Roll src/third_party/skia 233fc0b03c02..217acf58d0d8 (1 commits) (flutter/engine#7795)
27ab9f7af Roll src/third_party/skia 454e5fb7457d..233fc0b03c02 (4 commits) (flutter/engine#7794)
c58f5fefe Roll src/third_party/dart fdfe40ea95..754e5f404c (13 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-14 02:47:29 -05:00
Todd Volkert
4309fe863a
Revert "Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409)" (#27919)
This reverts commit d8cd2ff484c7799db0a7ed01f1a448dba14e6cec.
2019-02-14 02:20:35 -05:00
Jonah Williams
537b592ed5 fix multiroot scheme (#27914) 2019-02-13 23:17:28 -05:00
Todd Volkert
f1a8eed083
Revert "Clean up matters related to "offstageness". (#27425)" (#27915)
This reverts commit 1d93e924b7a1b4611de74537eba4f2bf25a4d0cf.
2019-02-13 20:58:41 -05:00
Tim Traversy
2cbd050f92 Adding horizontal and vertical scale parameter to ScaleUpdateDetails. (#27752) 2019-02-13 15:51:22 -08:00
Dan Field
ed4e3da360
update packages and supress lint (#27902) 2019-02-13 15:45:20 -08:00
Ian Hickson
1d93e924b7
Clean up matters related to "offstageness". (#27425)
In particular, make debugVisitOnstageChildren only work in debug mode, and add documentation.
2019-02-13 15:36:47 -08:00
Alexander Aprelev
8de5a07c3f
Revert "Disable usage of bare instructions in AOT (#27410)" (#27789)
This reverts commit 965dc52e2e86158a983e502ecfbac07ee29035f4 as performance gains seems to outweigh compressed apk size increase.
2019-02-13 15:29:50 -08:00
Marco Scannadinari
d8cd2ff484 Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409) 2019-02-13 15:17:42 -08:00
Michael Goderbauer
46cabdab22
Fix overflow clipping/fading for text (#27892) 2019-02-13 13:49:00 -08:00
Tim Traversy
f372eb37e6 DatePicker noon/midnight overflow fix (#27773) 2019-02-13 13:03:12 -08:00
Kartik Sharma
b4adafac08 Fixed Cupertino Switch Demo (#27528) 2019-02-13 12:43:08 -08:00
jslavitz
1196dbe94a
Fixes a cursor offset mistake for Material on iOS (#27851)
* Fixes offset and unblocks roll
2019-02-13 12:25:25 -08:00
Jonah Williams
a5af29e83c
Revert "Lazily download artifacts (Part II) (#27735)" (#27895)
This reverts commit 76061c4fa95b94a8e6462eb360aa1e7456cc0de3.
2019-02-13 11:59:51 -08:00
Jonah Williams
76061c4fa9
Lazily download artifacts (Part II) (#27735) 2019-02-13 11:04:28 -08:00
Hans Muller
16fd0eb512
Add Armenian translations (#27865) 2019-02-13 08:35:26 -08:00
KyleWong
4b4a9400b7 Refactor build-number/build-name logic. (#27743)
This PR aims at several things:

1. Use pub_semver to check a version in pubspec.yaml meets the requirements specified in https://semver.org/.
2. Don't limit build-number/build-name as a fixed format. Instead, validate it according to the target(ios/android).
3. Make sure that build-number/build-name are always validated no matter it's specified by the `flutter command` or version in pubspec.yaml.

Fixes #27589
2019-02-13 07:48:03 -08:00
KyleWong
f2004b8f43
Add android studio process logic for JetBrainsToolbox (#27687)
* Make plugin path search logic use version check as a fallback.

* In JetBrainsToolbox, Info.plist would be just some kind of wrapper, we need a double check before get the real one.

* Use Regex to get content instead of `default command` to avoid error output as there could be no JetBrainsToolboxApp key/value for a normal Info.plist(Android Studio.)
2019-02-13 15:05:20 +08:00
KyleWong
199ebaa677 Refactor ios bundleid/android application process logic. (#27471)
When creating a flutter project,
Make sure: applicationid for android conforms to: https://developer.android.com/studio/build/application-id

Make sure: bundleid for ios conforms to:
https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html
(Not only the name,but also the organization, as it's a check for whole bundleid.)
2019-02-12 19:40:53 -08:00
Greg Spencer
ef9c059ef2
Hook up character events and unmodified code points to Android raw key event handling. (#27853)
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
2019-02-12 19:40:19 -08:00
xster
8d0346a0ec
Handle back swipe completed->completed or completed->dismissed transitions (#27866) 2019-02-12 18:50:06 -08:00
Jonah Williams
7cc694e5d5
Track InheritedElement dependencies in diagnostic properties (#27387) 2019-02-12 18:37:51 -08:00
Michael Goderbauer
aa8f86135d
Fix crash when disposing nested Scrollables while holding in overscroll position (#27864) 2019-02-12 18:00:35 -08:00
Raouf Rahiche
964fab0205 fix small typo (#27659)
just a small typo 
the word "the constraints" is duplicated
2019-02-12 15:54:50 -08:00
xster
892c8919c7
Add long-press-drag cursor move support on iOS (#26001) 2019-02-12 15:10:48 -08:00
Gary Qian
e44fc1356f
Temporarily disable inconsistent golden tests due to test fonts (#27861) 2019-02-12 15:02:45 -08:00
Jake Gough
dfce0a7f0b Added 'physics' prop to Stepper. (#26297)
* Update stepper.dart

Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.

* Update stepper.dart

Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.

* Update stepper.dart

Ran through format to remove unwanted whitespace which Analysis isn't happy about.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Formatting again why do you hate me github editor.

* Update stepper.dart

* Update stepper.dart

if this format doesn't work i'll cry

* Update stepper_test.dart

Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`

* Update stepper_test.dart

Added const constructors

* Update stepper_test.dart

trying to get rid of whitespace again

* Update stepper_test.dart

* Update stepper_test.dart

why whitespace why

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

Swapped to `findsNothing` because I'm an idiot.

* Update stepper_test.dart

* Update stepper.dart
2019-02-12 14:02:36 -08:00
rami-a
c348be9739
[Material] Update the card demo in the Gallery to demonstrate different uses of the Card widget (#27699)
Additionally, this adds a tappable Card example to the Card documentation.
2019-02-12 16:56:47 -05:00
vanya elizarov
f021ee27be CupertinoSliverRefreshControl inactive overscroll behavior (#27588) 2019-02-12 13:41:17 -08:00
Ian Hickson
58939b70ef Prevent tests from importing other tests. (#27800)
This pattern is problematic when Flutter is ported to build systems
that require each executable end-point to be self-contained (e.g.
Bazel).
2019-02-12 12:29:36 -08:00
Dan Field
ead5e8e4d7
Fix Xcode_backend.sh for flavors (#27691) 2019-02-12 12:28:56 -08:00
Dan Field
fdcb861b05
Deflake AnsiSpinner tests (#27825) 2019-02-12 12:28:45 -08:00
Dan Field
e711fd9744
Revert "Revert "d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27822)" (#27849)" (#27855)
This reverts commit 4bb21a5c5339a152dbf2f5b4d242f730fb8f91e6.
2019-02-12 12:28:20 -08:00
engine-flutter-autoroll
d64d30828b
d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27850)
713fe130eb...d48de7a3ec

git log 713fe130eb0200412b04cc0c3356fce5f6f98153..d48de7a3ec97ebf7ffe543aa74993efa51064789 --no-merges --oneline
d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-12 14:51:28 -05:00
Dan Field
4bb21a5c53
Revert "d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27822)" (#27849)
This reverts commit 738559188c8f92be47bba679e5ce9c34ce306f4d.
2019-02-12 10:44:36 -08:00
TruongSinh Tran-Nguyen
d15a361244 flutter create --template=plugin now include flutter unit test (#26456) 2019-02-12 10:37:00 -08:00