10318 Commits

Author SHA1 Message Date
Mikkel Nygaard Ravn
a61592793c Silence broken test (#15446)
* Silence broken test

* Mark test as flaky instead
2018-03-12 12:02:58 -07:00
Jason Simmons
466d15433f
Use Dart 2 camel case constants (#15360) 2018-03-12 11:06:32 -07:00
Hans Muller
33f9afd99c
Updated the BottomNavigationBar class doc (#15347) 2018-03-12 10:27:20 -07:00
Hans Muller
11d81b11d7
Add OutlineButton, Tristate Checkbox to Flutter Gallery (#15312) 2018-03-12 10:21:14 -07:00
Danny Tuppeny
465929f71e Remove flaky flag from all tests that are green for the whole dashboard
Plus run_machine_concurrent_hot_reload which isn't all green, but is
green since the fix was pushed.
2018-03-12 17:03:21 +00:00
Mikkel Nygaard Ravn
658f9e6c83
Make plugins work in Swift projects (#15437) 2018-03-12 17:33:10 +01:00
P.Y. Laligand
c0118ea4b9
Leave source list empty for Fuchsia targets. (#15337) 2018-03-12 15:38:32 +01:00
xster
c8fd99fb33
Add a simple convenience test task runner for VSCode (#15417) 2018-03-12 01:05:23 -07:00
Siva
e5ba3041cd
Update dart-petitparser and dart-xml packages (#15376)
* Update the following packages
- dart-petitparser to 1.7.5
- dart-xml to 3.0.3
- image to 1.1.30
These updates fix some of the strong mode errors we were encountering
while running flutter tests.
2018-03-11 18:57:14 -07:00
Ian Hickson
7865d319ba
Factor out BorderSide creation for dividers (#15403)
This allows other code to get the same style without having to know exactly it is computed.
2018-03-11 13:01:00 -07:00
Ian Hickson
ded3905102
Various documentation improvements. (#15071)
For example, mention the icon used for the drawer menu in the docs (this helps people writing unit tests); add DefaultAssetBundle sample code.
2018-03-11 03:19:18 -07:00
Ian Hickson
48bb5b7926
Include opacity in FadeTransition logging (#15073) 2018-03-09 22:49:19 -08:00
Greg Spencer
984a24c51b
Fix error handling for the packaging script (#15351)
This fixes the error handling for the packaging script so that it will properly report a failure exit code when it can't find the executable that it's looking for.

Added a test too.
2018-03-09 18:58:41 -08:00
Jason Simmons
4b56ba17d5 More fixes for the prefer_const_literals_to_create_immutables analyzer check (#15363)
See 3961306bad
2018-03-09 16:47:56 -08:00
Alexandre Ardhuin
3961306bad enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables (#14848) 2018-03-09 14:37:06 -08:00
Greg Spencer
7fab7f6d02
Adding edge avoidance, painting tests, general cleanup (#15078)
Fixed the real repaint problem the Slider had (missing addListener), and added tests for it.

Added GlobalKey reparenting test.

Added the ability for the value indicator to slide left and right to avoid falling off the edge of the screen.
It only shifts as much as it can without deforming, but even at large text scales, that is enough to keep the text on the screen.

Updated the formatting on theme_data.dart and others to use longer line length.

Also, removed a color tween that faded the value indicator in as it scaled, since that wasn't to spec.
2018-03-09 14:04:58 -08:00
Michael Goderbauer
3a40d0ee4e
Support SemanticsFlag for Header (#15255) 2018-03-09 13:32:01 -08:00
Jason Simmons
96ce9d64ac
Add more package names to the flutter create conflict list (#15350)
Fixes https://github.com/flutter/flutter/issues/12445
2018-03-09 13:11:33 -08:00
Todd Volkert
2e970008ad
Pass --verbose to pub instead of --trace when in verbose mode (#15314) 2018-03-09 12:55:06 -08:00
Yegor
2e429bfbdd
[tools] add Stdio to AppContext created by daemon AppInstance (#15268) 2018-03-09 12:25:30 -08:00
Alexander Aprelev
ded538a1bb
Update dependencies with forced upgrade. (#15344)
* Update dependencies with forced upgrade.

Now that https://github.com/flutter/flutter/issues/15261 is fixed, do the update with upgrade.

* Update test package use following upgrade

* Replace addOption(allowMultiple) with addMultiOption
2018-03-09 10:38:54 -08:00
Michael Goderbauer
5d03a59379
Allow wrapping CheckBox in Semantics (#15259) 2018-03-09 10:37:59 -08:00
Jonah Williams
7d1ceb4080
Add Text.rich constructor to Text widget (#15317)
* add fromSpan constructor to Text widget and simple smoke test:

* change fromSpan to rich, clean up comments

* 'directly from' to 'with'

* make sure text styles are applied to either data or textspan. add diagnostic properties for span

* add expectation for text style to test case

* some work on diagnostics and docs
2018-03-09 09:57:17 -08:00
Jonah Williams
4ace88bfc0
fix spacing issue and add test for supportsHardwareRendering (#15305)
* fix spacing issue and add test for supportsHardwareRendering

* remove extra async tag

* move spacing to prev line
2018-03-09 09:30:13 -08:00
Jacob Richman
046c6d5f7f
Track which Widget objects were created by the local project. (#15041)
Make flutter test support the --track-widget-creation flag.
Add widget creation location tests. Tests are skipped when
--track-widget-creation flag is not passed.
2018-03-09 08:09:49 -08:00
Michael Goderbauer
a9e2781132
Do not do semantics for detached objects (#15320) 2018-03-08 22:33:46 -08:00
Michael Goderbauer
35c43ecc98
Roll engine to 1d0da7799583b089ede66b81068f40cc4597a429 (#15322) 2018-03-08 22:30:55 -08:00
Michael Goderbauer
f002839d44
Better print-out of semantics tree (#15302) 2018-03-08 19:14:43 -08:00
Alexander Aprelev
2890e18bcb
Return copied kernel filename for flutter test execution. (#15298)
* Return copied kernel filename.

This fixes 'flutter test --preview-dart-2' crash.
2018-03-08 16:02:21 -08:00
Hans Muller
0038a2b21c
Updated the material_en.arb description for signedIn (#15306) 2018-03-08 15:42:29 -08:00
Jason Simmons
6f5bcb97a4
Do not add spacing to the first child's width in RenderWrap line wrapping (#15272)
The first child fits on the line if the line can accomodate its width.
After the first child the line needs room for the child's width plus spacing.
2018-03-08 15:01:37 -08:00
Todd Volkert
d996ab921c
Rename "slow mode" to be "debug mode" (#15205)
This moves toward more consistency in our messaging. Apps are
launched using --debug, so the banner will reflect the build
mode.
2018-03-08 12:54:06 -08:00
Alexander Aprelev
1087279a4d
Create frontend compiler in flutter test lazily. (#15251)
* Create frontend compiler in `flutter test` lazily.

This is needed to avoid unwarranted runtime dependencies on Artifacts,
for example when in non-preview-dart-2 mode.
Refactor the compilation-related code into _Compiler class.
2018-03-08 11:21:40 -08:00
Alexander Aprelev
1a3c9b83c0
Step process, boolean_selector, collection deps up. (#15262)
This is needed to fix 'flutter test --preview-dart-2 test/all.dart' in dev/devicelab
2018-03-08 11:07:03 -08:00
Hans Muller
f14397ae11
Correct DefaultMaterialLocalizations.delegate supported locales list (#15260) 2018-03-08 11:06:31 -08:00
Hans Muller
ea155df91e
Roll localizations (#15269) 2018-03-08 11:06:09 -08:00
Stefano Rodriguez
b944cd7187 Plug TextDirection into box_decoration background gradient (#14810)
* Plug TextDirection into box_decoration background gradient

* Add test
2018-03-08 11:00:21 -08:00
Jonah Williams
afabdfecf9
Display a message if hardware rendering is supported (#15266)
* add device.supportsHardwareRendering and display a message if true

* Address some comments
2018-03-08 10:41:29 -08:00
Alexander Aprelev
69c33a321a
Fix path to uri conversion. (#15264) 2018-03-08 10:25:27 -08:00
Jason Simmons
6e46c184d6
Roll engine back to 24cf8ebd8621713a6936df783dad5019f52bc85e (#15270)
This reverts commit 9d46ed2bb96869071464c37b5314e23edceea1d7.
2018-03-08 10:09:18 -08:00
Jason Simmons
7358d59036
Dart2 typesafe invocation of IsolateConfiguration callback (#15267) 2018-03-08 10:08:59 -08:00
Jason Simmons
9d46ed2bb9
Roll engine to 1b7325ca6825a1305d5521a5c0abe6fb32688dea (#15257)
(libtxt is enabled by default in this engine)
2018-03-07 13:37:26 -08:00
Jonah Williams
27df288568
RenderWrap.performLayout should take spacing into consideration (#15256)
* RenderWrap.performLayout takes should take spacing into consideration when deciding to move to next row/axis

* fix spacing in text

* remove dart:developer import

* remove extra line
2018-03-07 13:00:14 -08:00
xster
c2261a3a2c
Remove a mixin from RenderListWheelViewport that was never used (#14900) 2018-03-07 11:56:36 -08:00
Todd Volkert
fffb7630c1
Give file system recording serialization a timeout. (#15217)
Some file I/O is piped from OS processes and never completes,
so without havign a timeout on the recording serialzation, we
end up waiting forever on that I/O to complete.
2018-03-07 11:39:59 -08:00
shrike69
f3c806c9f2
Remove _checkPort() when getting flutter views (#15184) 2018-03-07 10:35:24 -08:00
Alexander Markov
7d0536b87a
Enable global type flow analysis in Dart 2 AOT (#15221) 2018-03-07 09:35:22 -08:00
Alexander Aprelev
0d6d312546
Test gradle dependencies-file generation (#15176)
* Test gradle dependency file generation

* Fix lints, clean up comments, formatting.
2018-03-07 08:29:05 -08:00
Alexander Aprelev
c01cad3491
Fix flutter test --preview-dart-2 following last dart roll. (#15233)
* Fix `flutter test --preview-dart-2`  following last dart roll.

Incremental compiler maintains single incremental dill file, so for every test compilation that dill file has to be copied away for execution.

* Fix lints
2018-03-07 06:27:58 -08:00
Siva
9c38d6bb35
Fix some of the generic types specified to avoid runtime errors in --preview-dart-2 (#15166)
* Fix some of the generic types specified to avoid runtime errors in
--preview-dart-2

  type 'YamlMap' is not a subtype of type 'Map<String, dynamic>' where
    YamlMap is from package:yaml/src/yaml_node.dart
    Map is from dart:core
    String is from dart:core

  package:flutter_devicelab/framework/manifest.dart 17:36       loadTaskManifest
  test/manifest_test.dart 14:33                                 main.<fn>.<fn>
  package:test/src/backend/declarer.dart 161:27                 Declarer.test.<fn>.<fn>.<fn>

* Add dynamic generic types to keep the analyer happy.

* Address code review comment.
2018-03-07 00:33:21 -08:00