9738 Commits

Author SHA1 Message Date
Alexander Aprelev
a6c963032e Fix gen_snapshot name, path for Windows.
Executables have '.exe' extension on Windows. We do have to specify extension for gen_snapshot since when running with local engine, we are looking for that exact file before launching it.
2017-12-22 17:00:24 -08:00
amirh
31e78f1e7f
roll engine to 7c126001d8195abfb2c5778d32cb779f3c8b66c6 (#13755) 2017-12-22 11:06:22 -08:00
Todd Volkert
7132083b24
Partially revert #13711 (#13745)
This reverts the change to `user_accounts_drawer_header.dart`
(and the associated test), as it was causing regressions in layout
of the drawer header.

https://github.com/flutter/flutter/issues/13743
2017-12-22 01:26:15 -05:00
xster
36bd9ee0d4
update html on flutter_tools (#13744) 2017-12-21 19:13:18 -08:00
xster
4fcdb50d9b
Add Cupertino scrollbar (#13290)
* Create CupertinoScrollbar

* handle main axis margin

* Adaptive material scrollbar and tests

* Small tweaks

* reapply changes on head

* Docs

* start

* Refactored ScrollbarPainter to be more immutable

* fix tests

* fix bug: one animationcontroller pointed to multiple painters

* some docs tweak

* remove unused import

* review

* review

* add dispose
2017-12-21 16:44:42 -08:00
Michael Goderbauer
4e13cd07bb
Fixes crash caused by invisible semantics children (#13740)
**tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation.

When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`).

To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree.
If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm.

Fixes https://github.com/flutter/flutter/issues/13326.
/cc @gavindoughtie FYI
2017-12-21 16:09:43 -08:00
amirh
56061759fc
Add an AnimatedIcon class and vitool (vector icon tool) to generate data for it (#13530) 2017-12-21 15:46:05 -08:00
Zachary Anderson
a5b277030a
Roll engine to 39029aad6cd21aa2c1359ebdd05cb4e57ad3794d (#13739) 2017-12-21 15:34:05 -08:00
Ian Hickson
370c73d9bc
Audit all the "final Widget child" properties. (#13718)
This attempts to apply some of what we learnt from UX studies, namely
that people wonder how to add multiple children to widget that take
one child.
2017-12-21 15:02:35 -08:00
Ian Hickson
4e2f77745f
Miscellaneous documentation improvements (#13719)
This is a collection of fixes I've run into recently.
2017-12-21 15:02:21 -08:00
Ian Hickson
4e16b9db29
Attempt a less invasive way to disable fading. (#13733)
Hopefully this will fix the performance regression in https://github.com/flutter/flutter/pull/13680 but with an easier way to flip the switch.
2017-12-21 15:02:03 -08:00
Leaf Petersen
b3cfa785c4
Uncontroversial and backwards compatible 2.0 SDK fixes (#13723)
Small code changes as part of moving the framework SDK forward to a 2.0 dev version.
2017-12-21 13:39:03 -08:00
Ian Hickson
ecb708ee3a
Clean up lerp() methods and their documentation. (#13684)
This cleans up lerp, lerpFrom, lerpTo, and scale methods, and their
documentation.

Fixes https://github.com/flutter/flutter/issues/12377.
2017-12-21 11:09:49 -08:00
Sarah Zakarias
075ba6477f
Roll engine (#13727) 2017-12-21 12:05:15 +01:00
Mikkel Nygaard Ravn
e2988adef3
Mention Kotlin in README (#13725) 2017-12-21 11:33:22 +01:00
Alexander Aprelev
af4ac729ef Revert "Roll engine to pick up fix for windows preview-dart-2 tests"
This reverts commit dbd3eb678af12bf0e91a289dba4a400d05e523e0.

Commit above fixed initial problem with frontend_server on Windows, but caused another more explicit problem with gen_snapshot down the line.
2017-12-20 19:35:31 -08:00
Alexander Aprelev
dbd3eb678a Roll engine to pick up fix for windows preview-dart-2 tests 2017-12-20 18:30:23 -08:00
Yegor
291602db92
localize a11y tab labels in the TabBar (#13714)
* localize a11y tab labels in the TabBar

* break import cycle

* test boilerplate

* fix German translation

* more test boilerplate fixes
2017-12-20 17:10:32 -08:00
Yegor
6873608184
Make UserAccountsDrawerHeader accessible (#13711)
* other accounts a11y; show accounts button a11y

* layout with bigger tap areas; all semantics

* internationalize UserAccountsDrawerHeader a11y labels

* better Russian translation

* break import cycle

* address comments
2017-12-20 17:10:06 -08:00
Greg Spencer
dd796853cc
Revert "Adding minzip to packaging steps for Windows (#13679)" (#13716)
This reverts commit 765191e7b4ec55758293090cdd37c97cbd9ec757.
because the updated packages cause a gradle build problem.
2017-12-20 16:21:57 -08:00
Greg Spencer
765191e7b4
Adding minzip to packaging steps for Windows (#13679)
This adds our self-compiled copy of the MinGit executable (built from the flutter/git repo) to the archive when building an archive for Windows.

I also tweaked the internal API for prepare_package.dart so that there's a single entry point to build an archive.
2017-12-20 15:35:53 -08:00
Hans Muller
83134cd39f
Added find.ancestor to CommonFinders (#13691) 2017-12-20 15:03:58 -08:00
Michael Goderbauer
95aeb05ced
Roll engine to 937bde8f98e64aa574f77049bc52e9c8e862c82c (#13709) 2017-12-20 14:32:22 -08:00
Ian Hickson
b1c870b312
Reenable fade transition for Material page transition (#13048) (#13680)
Fixes #12877 by reverting #9472
2017-12-20 13:52:01 -08:00
Victor Choueiri
ba58111b7b Add .vscode/ to .gitignore template (#13697)
Adds .vscode/ to the .gitignore rules generated on flutter create.
2017-12-20 12:43:22 -08:00
Yegor
81d4834278
support increase and decrease SemanticsActions in time picker (#13689)
* support increase and decrease SemanticsActions in time picker

* test roll over
2017-12-20 10:25:33 -08:00
Erik Corry
7766b2a196 Roll Dart to 718bda0c9 (#13698) 2017-12-20 15:13:34 +01:00
Erik Corry
a96487929b Roll Flutter engine incl. new Skia. (#13696) 2017-12-20 13:28:40 +01:00
Mikkel Nygaard Ravn
36bcdc4c7e
Fix Android templates (#13681) 2017-12-20 10:50:40 +01:00
Michael Goderbauer
39c2521f29
Update project.pbxproj of flutter_gallery (#13678) 2017-12-19 16:59:35 -08:00
Michael Goderbauer
52ebff721a
selected ListTile is selected (#13676)
* selected ListTile is selected

* review comment

* analyzer fix
2017-12-19 16:39:56 -08:00
Hans Muller
31418570a2
Gen localization classes intead of a big map (#13653)
* Gen localization classes intead of a big map

* tighten up the newlines so that std output matches file output

* restore locale sorting
2017-12-19 14:02:22 -08:00
Alan Russian
30720bd148 Change async stubbing to use thenAnswer. (#13521)
* Change async stubbing to use thenAnswer.

Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79

* Update all Mockito deps to 3.0.0.

* Revert "Update all Mockito deps to 3.0.0."

This reverts commit e8ab9d37c33d3d7fe384abde64ea5b4d72623c75.

I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.

* Change thenAnswer((_) => to thenAnswer((invocation) =>

* Add Invocation type to thenAnswer lambdas
2017-12-19 13:13:57 -08:00
Ian Hickson
78ff7707e1
Fix niggling PaginatedDataTable bugs (#13556)
Prevent header from thinking it can wrap and then overflowing.

Fix default footer string which lost its colon (localized values are fine).

Make the "rows per page" drop-down include at least one value even when the table lacks many items. (Previously it would assert if your table was too short.)

Make the footer scrollable.

Fix some todos and improve some debug output.

Tests for much of the above.
2017-12-19 12:39:48 -08:00
Yegor
b5eac0422a
use different delimiter for generated code; print generated code into mismatch description (#13667) 2017-12-19 11:45:29 -08:00
Michael Goderbauer
e6f20eb95c
IconButton is a button, semantically (#13674)
* IconButton is a button, semantically

* fix datepicker test
2017-12-19 11:33:23 -08:00
Hans Muller
12f405578f
Added five new locales to flutter_localizations (#13621) 2017-12-19 11:09:50 -08:00
xster
ce75911f1a
Add flutter_assets and *.class to gitignore (#13664) 2017-12-19 10:21:59 -08:00
Chris Bracken
e478a5472d
Apply media padding in Gallery Pesto demo (#13668)
Applies horizontal safe area insets to the Pesto demo in the Gallery.
This is to support the iPhone X sensor housing notch and other similarly
creative display features when in landscape orientation.
2017-12-19 09:15:26 -08:00
Greg Spencer
37f216bfab
Add support for 7Zip to the packaging script. (#13659)
A modern version of 7Zip (7za.exe) is now installed on the bots, this makes use of that.
2017-12-18 14:40:29 -08:00
Mikkel Nygaard Ravn
d2d86e35c5
Bump test timeout threshold (#13661) 2017-12-18 23:04:07 +01:00
Mikkel Nygaard Ravn
e9ba0dd4ba
Switch from app.flx to flutter_assets (#13656) 2017-12-18 22:09:49 +01:00
Chris Bracken
b771294c16
Use idevice_id for devicelab iOS device lookups (#13652)
This replaces the use of ideviceinfo (whose output was then filtered for
device IDs) with an invocation idevice_id -l, which returns the list
directly, one per line.
2017-12-18 11:10:18 -08:00
Sarah Zakarias
68bf4b3c62 Remove app.flx and add flutter_assets to project.pbxproj of all example apps (#13649) 2017-12-18 20:08:30 +01:00
Sarah Zakarias
73552ecae2 Remove app.flx on iOS (#13648) 2017-12-18 18:58:44 +01:00
Chris Bracken
c7ea97f2bb
Use idevice_id for devicelab iOS device listing (#13624)
This patch migrates iOS device listing from using Xcode instruments to
using the libimobiledevice tools idevice_id and ideviceinfo.

ideviceinfo was previously incompatible with iOS 11 physical devices;
this has now been fixed.

In 58fe8237d2ec012ea51a673bc228f6545af8bb3c flutter_tools migrated from
libimobiledevice-based device listing on iOS to using Xcode instruments
to work around the lack of support for iOS 11. Using instruments entails
several downsides, including a significantly higher performance hit, and
leaking hung DTServiceHub processes in certain cases when a simulator is
running, necessitating workarounds in which we watched for, and cleaned
up leaked DTServiceHub processes. This patch returns reverts the move to
instruments now that it's no longer necessary.

This reverts commit 58fe8237d2ec012ea51a673bc228f6545af8bb3c.
2017-12-18 09:46:33 -08:00
Sarah Zakarias
2ef379ad12
Remove app.flx from apk (#13647) 2017-12-18 14:33:35 +01:00
Chris Bracken
e85d099229
Apply media padding to Contacts demo (#13628)
Applies horizontal safe area insets to the Contacts demo in the Gallery.
This is to support the iPhone X sensor housing notch and other similarly
creative display features when in landscape orientation.
2017-12-15 19:10:18 -08:00
xster
2e1b0a7fd2
update xcode project (#13587) 2017-12-15 19:02:53 -08:00
Chris Bracken
7fb78523e9
Require Xcode 9.0 or later for iOS builds (#13608) (#13622)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.

This re-lands flutter/flutter#13608 now that the devicelab Macs have
been updated to Xcode 9.
2017-12-15 18:13:10 -08:00