16548 Commits

Author SHA1 Message Date
Jonah Williams
a901b650b6
Update meta to 1.1.8 (#44584) 2019-11-12 13:48:42 -08:00
Shi-Hao Hong
2b498567a4
Sort Localization generation output (#44743)
* Sort Localization generation output

- When creating locales that were assumed from existing locales, the
file that is used is non-deterministic. This adds a sort to the iterator
to ensure that the same existing locale is used to generate the assumed
locale
- When generating material, cupertino and date localizations, the generated getters were not sorted. This
introduces an alphabetic sort

* remove main.dart.snapshot
2019-11-12 12:50:51 -08:00
Greg Spencer
d39e2bb776
Check in new diffs to material localizations (#44736)
Updates localizations to match what is now generated. It's unclear what caused the change: it didn't happen because of a flutter PR change, so we're still looking for where the source of the non-determinism is.  In the meantime, this will fix the build.
2019-11-12 10:27:58 -08:00
Greg Spencer
99055c754a
Bump memory requirements for tool_tests-general-linux (#44620)
This bumps the Cirrus memory limits for tool_tests-general-linux from 8GB to 10GB, as we're seeing a lot of OOMKill failures.
2019-11-12 08:04:48 -08:00
xster
9e0df259df
Show a warning when a module uses a v1 only plugin (#44499) 2019-11-11 15:56:43 -08:00
Shi-Hao Hong
159a47da64
l10n tool improvements, stocks app i18n refresh (#44473)
* Add check for placeholders being an empty map

* Remove unnecessary properties from en_ES.arb in the stocks example

* Use getter instead of methods in the stocks example

* Fixed "annotating types for function expression parameters" lint issue from generated localizations delegate code
2019-11-11 14:42:29 -08:00
Mouad Debbar
9307a83f7c
Changing RenderEditable.textAlign doesn't break hot reload anymore (#44605) 2019-11-11 14:35:15 -08:00
Greg Spencer
23d1ae0ff7
Convert to TextPosition for getWordBoundary (#44611)
Convert the call to getWordBoundary to use a TextPosition, in preparation for landing flutter/engine#13727, which switches the desired API to the final desired API.
2019-11-11 14:27:06 -08:00
Sam Rawlins
86c91b12d8 Remove new unused elements (#44551) 2019-11-11 13:29:46 -08:00
Janice Collins
cf08a995f6
Update dartdoc to 0.29.1 (#44466) 2019-11-11 13:23:05 -08:00
Greg Spencer
f3334885e4
Revert engine rolls. (#44613)
Reverting 9a486d2 and 20169f0 to green-up the build.
2019-11-11 13:07:54 -08:00
engine-flutter-autoroll
9a486d204b
3fb5d855f Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773) (#44603)
git@github.com:flutter/engine.git/compare/eec36a8d4f6d...3fb5d855f228

git log eec36a8d4f6d..3fb5d855f228 --no-merges --oneline
2019-11-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-11 14:45:17 -05:00
Fedor Korotkov
82a92afe89 [ci] Use the latest Cirrus Image for macOS (#44576)
* [ci] use Xcode 11.2.1
* Always use the latest image
* sudo bundle install
2019-11-11 10:28:17 -08:00
engine-flutter-autoroll
20169f0d2f
Roll engine 31cd2dfca22a..eec36a8d4f6d (6 commits) (#44533)
git@github.com:flutter/engine.git/compare/31cd2dfca22a...eec36a8d4f6d

git log 31cd2dfca22a..eec36a8d4f6d --no-merges --oneline
2019-11-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771)
2019-11-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
2019-11-09 ychris@google.com Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759)
2019-11-09 matthew-carroll@users.noreply.github.com Point old plugin registry accessors to new embedding plugin accessors.  (#44225) (flutter/engine#13739)
2019-11-09 fmil@google.com Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
2019-11-09 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13762)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-11 12:08:17 -05:00
Yegor
e7073f9a1f
add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00
engine-flutter-autoroll
9206bd0252
31cd2dfca Remove usage of fuchsia.modular.Clipboard. (flutter/engine#13763) (#44503)
git@github.com:flutter/engine.git/compare/e0b9a2bb23e4...31cd2dfca22a

git log e0b9a2bb23e4..31cd2dfca22a --no-merges --oneline
2019-11-09 gabeschine@users.noreply.github.com Remove usage of fuchsia.modular.Clipboard. (flutter/engine#13763)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-09 19:26:16 -05:00
engine-flutter-autoroll
c1920c4c03
Roll engine b4a50d7ab192..e0b9a2bb23e4 (2 commits) (#44501)
git@github.com:flutter/engine.git/compare/b4a50d7ab192...e0b9a2bb23e4

git log b4a50d7ab192..e0b9a2bb23e4 --no-merges --oneline
2019-11-09 gspencergoog@users.noreply.github.com Change wordBoundary to take dynamic temporarily (flutter/engine#13765)
2019-11-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KRali... to eq_Rz... (flutter/engine#13766)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 23:36:17 -05:00
engine-flutter-autoroll
ef81bdb066
Roll engine 2f69e38160a3..b4a50d7ab192 (2 commits) (#44497)
git@github.com:flutter/engine.git/compare/2f69e38160a3...b4a50d7ab192

git log 2f69e38160a3..b4a50d7ab192 --no-merges --oneline
2019-11-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c88d1774ed50..4135cf0b57c2 (13 commits) (flutter/engine#13764)
2019-11-08 a-siva@users.noreply.github.com Manual Dart roll fa4379946109467c8a48f20f19d83d7c72968a3e...d45c3d15cb3cea0104a87697c085259666eec528 (flutter/engine#13761)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 22:40:17 -05:00
Shi-Hao Hong
e7d78b69a1
Use raw string for l10n description (#44451)
* Use raw string for l10n description

* Stock app refresh
2019-11-08 19:34:37 -08:00
Alex Fourman
924ab725d9 Fix AboutListTile having an empty icon placeholder when no icon set. (#43422) 2019-11-08 19:33:44 -08:00
Taufiq Rahman
8ad7456cd4 Adjust and refactor all OutlineButton tests into its respective file (#44328) 2019-11-08 19:32:16 -08:00
Greg Spencer
dd90ff429d
Remove TextRange, export it from dart:ui (#44422)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, and updates the APIs that use Paragraph.getWordBoundary (there was only one) to expect a TextRange or  a pair of ints temporarily until the engine side returns TextRanges, so that I can convert over without breaking the builds.
2019-11-08 18:57:44 -08:00
engine-flutter-autoroll
9323a623bd
Roll engine af04338413c3..2f69e38160a3 (2 commits) (#44493)
git@github.com:flutter/engine.git/compare/af04338413c3...2f69e38160a3

git log af04338413c3..2f69e38160a3 --no-merges --oneline
2019-11-08 hterkelsen@users.noreply.github.com Implement Path.computeMetrics in the CanvasKit backend (flutter/engine#13760)
2019-11-08 jason-simmons@users.noreply.github.com libtxt: pass an RTL bool flag instead of a bidiFlags enum to measureText (flutter/engine#13736)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 21:35:17 -05:00
Jenn Magder
856a90e67c
Add swift_versions to plugin template podspec, include default CocoaPod version (#44324) 2019-11-08 18:00:01 -08:00
engine-flutter-autoroll
076bea38f2
Roll engine 5f5713e33971..af04338413c3 (8 commits) (#44486)
git@github.com:flutter/engine.git/compare/5f5713e33971...af04338413c3

git log 5f5713e33971..af04338413c3 --no-merges --oneline
2019-11-08 a-siva@users.noreply.github.com Manual roll of Dart e68ca9b652acdb642668a6acb5f630d5be6c03da...fa4379946109467c8a48f20f19d83d7c72968a3e (flutter/engine#13756)
2019-11-08 ychris@google.com Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter/engine#13757)
2019-11-08 ferhat@gmail.com [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas.  (flutter/engine#13748)
2019-11-08 ychris@google.com Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755)
2019-11-08 gspencergoog@users.noreply.github.com Move TextRange from the framework to dart:ui. (flutter/engine#13747)
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter/engine#13754)
2019-11-08 ychris@google.com Revert "Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753)
2019-11-08 ychris@google.com Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 20:00:17 -05:00
Ian Hickson
1ce4a4f36f
Make sure all our .dart files have license headers (#44467) 2019-11-08 16:53:21 -08:00
Ian Hickson
f4da9f72eb
Deprecation cleanup in flutter_tools (#44469)
One deprecated member was no longer used; removed it.

The other probably shouldn't be deprecated, because it's not the
parser that's deprecated so much as the format it's parsing. The code
itself will live on until we decide to stop supporting the format,
it's not like people calling the member should use something else.
2019-11-08 16:31:34 -08:00
Greg Spencer
c921c5ae67
Add macOS fn key support. (#44410)
This adds support for the fn key on macOS. It adds it to the key mappings as a supplemental mapping that overwrites the one from the Chrome headers, since the chrome headers have a TODO, but no implementation of the key.

Also, ignore the fn key entirely on macOS. This is because On macOS laptop keyboards, the fn key is used to generate home/end and f1-f12, but it ALSO generates a separate down/up event for the fn key itself. Other platforms hide the fn key, and just produce the key that it is combined with, so to keep it possible to write cross platform code that looks at which keys are pressed, the fn key is ignored.
2019-11-08 16:30:38 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root (#44468) 2019-11-08 14:38:44 -08:00
Collin Jackson
03ac37af08
Re-enable docs uploading (#44454)
* Revert "Turn off docs upload temporarily (#44365) (#44413)"

This reverts commit 8f2ea9d0e959b084e64e5adc23e3737d90f8118f.

* Re enables docs upload
2019-11-08 12:47:26 -08:00
Jonah Williams
eeb88f4385
Revert "Demonstrate that artifact invalidation works (#44312)" (#44463)
This reverts commit c1d029b84f852a95d02d535da36dd49581b9b27e.
2019-11-08 12:44:24 -08:00
Jonah Williams
69a783b806
switch web test to macOS (#44421) 2019-11-08 12:43:08 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly (#43876)
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams
c1d029b84f
Demonstrate that artifact invalidation works (#44312) 2019-11-08 12:32:55 -08:00
LongCatIsLooong
09c80aa45a
Segmented control quick double tap fix (#44391) 2019-11-08 10:05:53 -08:00
Luiz França
d961ae85b5 Adding subtitle to ExpansionTile (#43946)
* Adding subtitle to expansion_tile
2019-11-08 10:04:49 -08:00
engine-flutter-autoroll
dd59739513
Roll engine 6a1f093398c6..5f5713e33971 (5 commits) (#44448)
git@github.com:flutter/engine.git/compare/6a1f093398c6...5f5713e33971

git log 6a1f093398c6..5f5713e33971 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
2019-11-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali... (flutter/engine#13750)
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746)
2019-11-08 chinmaygarde@google.com Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 13:01:17 -05:00
Greg Spencer
19778f9e33
Make selected item get focus when dropdown is opened (#43722)
As it stands, dropdowns currently do not focus the item that is selected, so if you select something on a dropdown, and then close it, and re-open it, then the new item is not auto-focused. This PR changes that so that selected value is focused by default when the dropdown is re-opened.
2019-11-08 08:58:37 -08:00
engine-flutter-autoroll
4cc8ce0628
Roll engine 7ed9c9fc5885..6a1f093398c6 (5 commits) (#44419)
git@github.com:flutter/engine.git/compare/7ed9c9fc5885...6a1f093398c6

git log 7ed9c9fc5885..6a1f093398c6 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 345a2735e2c8..76eaab6b8cef (18 commits) (flutter/engine#13745)
2019-11-08 gw280@google.com Only specify --no-link-platform when not specifying --aot, roll dart-lang sdk (flutter/engine#13742)
2019-11-08 ferhat@gmail.com Don't run engine tests under vm (causing warnings) (flutter/engine#13737)
2019-11-07 christopherfujino@gmail.com Switch to Cirrus Dockerfile as CI (flutter/engine#13440)
2019-11-07 matthew-carroll@users.noreply.github.com Removed scary experimental warnings for new embedding. (#44314) (flutter/engine#13738)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 11:55:17 -05:00
engine-flutter-autoroll
ff95b14ad8
Roll engine 629930e8887c..7ed9c9fc5885 (2 commits) (#44401)
git@github.com:flutter/engine.git/compare/629930e8887c...7ed9c9fc5885

git log 629930e8887c..7ed9c9fc5885 --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia f66ec5d69d04..345a2735e2c8 (1 commits) (flutter/engine#13732)
2019-11-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL... (flutter/engine#13734)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 23:14:17 -05:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
Jenn Magder
8f2ea9d0e9
Turn off docs upload temporarily (#44365) (#44413) 2019-11-07 19:16:04 -08:00
chunhtai
6a9b72c16b
fixing todo comments in flutter tests to include url link. (#42691) 2019-11-07 17:34:36 -08:00
engine-flutter-autoroll
d3c403219c
629930e88 Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728) (#44388)
git@github.com:flutter/engine.git/compare/ddceed5f7af1...629930e8887c

git log ddceed5f7af1..629930e8887c --no-merges --oneline
2019-11-07 liyuqian@google.com Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 19:39:17 -05:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396)
This reverts commit e5d6d92498669b9a1aa0112685be1bbd96c85729.
2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
engine-flutter-autoroll
99f2b940f6
Roll engine c448d39d5307..ddceed5f7af1 (2 commits) (#44380)
git@github.com:flutter/engine.git/compare/c448d39d5307...ddceed5f7af1

git log c448d39d5307..ddceed5f7af1 --no-merges --oneline
2019-11-07 alexmarkov@google.com Cleanup obsolete --strong option of front-end server (flutter/engine#13735)
2019-11-07 bkonyi@google.com Roll src/third_party/dart bdd9e74afc..4b9638aaa1 (7 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 18:42:17 -05:00
Collin Jackson
62b7ce306d
Revert "Turn off docs upload temporarily (#44365)" (#44371)
* Revert "Turn off docs upload temporarily (#44365)"

This reverts commit 3dd67410787e918774f052121963086f0ef777a9.

* show contents of firebase-debug.log
2019-11-07 15:21:45 -08:00
Emmanuel Garcia
2c80bc973d
Flip enable-android-embedding-v2 flag (#44369) 2019-11-07 15:18:56 -08:00
liyuqian
cc9e9ce2ce
Remove TODO that's done (#44318)
See https://github.com/flutter/engine/pull/13728
2019-11-07 14:06:07 -08:00