12555 Commits

Author SHA1 Message Date
Jonah Williams
213027dd82
[Perf/codesize] Reland: Reduce constraint member reads during layout
This reverts commit 2132a0c7a3d2a107190238ca0c5570baa0467bb7.
2020-02-28 10:02:57 -08:00
Justin McCandless
7011d30876
AppBar Height Fix (#48761) 2020-02-28 09:51:02 -08:00
Jason Simmons
ae027c194f
Use strut box heights to calculate selection rectangles in order to ensure that they remain within visible bounds (#50354) 2020-02-28 09:36:03 -08:00
Zachary Anderson
b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567)" (#51616)
This reverts commit 9de7787f258870e60a7c4127883e8f7f1af5822c.
2020-02-27 22:57:13 -08:00
stuartmorgan
33bb1faf5b
Reland: Always use new plugin schema for plugin template (#49832)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-02-27 22:48:25 -08:00
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567) 2020-02-27 22:46:23 -08:00
Jonah Williams
4e5cb2b299
[flake] attempt to de-flake hot reload test (#51608) 2020-02-27 18:30:42 -08:00
Jason Simmons
d499d61efe
Update Android activities because plugin registration is now done by FlutterActivity.configureFlutterEngine (#50841) 2020-02-27 18:16:04 -08:00
Jonah Williams
e00d424de5
[flutter_tools] clean-ups to linux doctor test (#51593) 2020-02-27 15:15:35 -08:00
Darren Austin
fef2d6ccd6
Pass RouteSettings into all callers of showGeneralDialog. (#51525) 2020-02-27 15:11:01 -08:00
Jenn Magder
4fb9ce8414
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh (#51532) 2020-02-27 12:18:06 -08:00
Jonah Williams
080dfb5eb3
[flutter_tools] swap mustache dependency for mustache_template (#51578) 2020-02-27 11:23:41 -08:00
chunhtai
52a5311924
remove isinitialroute from RouteSettings (#51435) 2020-02-27 10:41:08 -08:00
stuartmorgan
dd2756c36a
Generate a makefile for Linux plugins (#51520)
When generating the plugin registrant for Linux, also generate a
makefile that can be included in the app-level Makefile to manage all of
the plugin targets and flags, exporting them in a few known variables
for use in the outer makefile.

Part of #32720
2020-02-27 09:45:22 -08:00
Jonah Williams
3b5668c996
[flutter_tools] hide usage of package:mustache behind interface (#51500) 2020-02-27 09:17:42 -08:00
Jonah Williams
08d079f6c2
[flutter_tools] wire up complete support for Dart obfuscation (#50509) 2020-02-27 08:58:33 -08:00
Jonah Williams
fe1e8f3bb7
[flutter_tools] add logging to integration test (#51527) 2020-02-27 08:54:24 -08:00
Jonah Williams
611e5cb427
[flutter_tools] update chrome tests to remove globals, mock processmanager, mock process (#51533) 2020-02-27 08:47:11 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception (#51440)" (#51539)
This reverts commit f1cd47ef5cd9a365e968a83b84f4e893595accc2.
2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception (#51440) 2020-02-26 21:45:02 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests (#51444) 2020-02-26 18:31:42 -08:00
Greg Spencer
d4226566d4
Change Focus.unfocus to take a disposition for where the focus… (#50831)
When Focus.unfocus is called, the caller usually just thinks about wanting to remove focus from the node, but really, unfocus is a request to automatically pass the focus to another (hopefully useful) node.

This PR removes the focusPrevious flag from unfocus, and replaces it with a disposition enum that indicates where the focus should go from here.

The other value of the UnfocusDisposition enum is UnfocusDisposition.scope.

UnfocusDisposition.previouslyFocusedChild is closest to what focusPrevious used to do: focus the nearest enclosing scope and use its focusedChild field to walk down the tree, finding the leaf focusedChild. This PR modifies it slightly so that it walks up to the nearest focusable enclosing scope before trying to focus the children. This change addresses #48903

A new mode: UnfocusDisposition.scope will focus the nearest focusable enclosing scope of this node without trying to use the FocusScopeNode.focusedChild value to descend to the leaf focused child. This is useful as a default for both text field finalization and for what happens when canRequestFocus is set to false. It allows the scope to stay focused so that nextFocus/previousFocus still work as expected, but removes the focus from primary focus.

In addition to those changes, unfocus called on a FocuScope that wasn't the primary focus used to unfocus the primary focus instead. I removed that behavior, since it was buggy: if the primary focus was inside of a child scope, and you called unfocus on the parent scope, then the child scope could have focused another of its children instead, leaving the scope that you called unfocus on with hasFocus returning true still. If you want to remove the focus from the primary focus instead of the scope, that's easy enough to do: just call primaryFocus.unfocus().

Fixes #48903
2020-02-26 18:04:32 -08:00
Dan Field
444b13b895
Colored box and container optimization (#50979) 2020-02-26 16:04:35 -08:00
Dan Field
c75db98337
Live image cache (#51485)
* Reland "Live image cache" (#51441)

This reverts commit 419a2853a8e4ac846524afeb49b866d4cdaa7d9d.

* Make evict safer
2020-02-26 16:01:56 -08:00
Ferhat
1a79592b4a
Reduce closure allocation in RenderObject.cleanRelayoutBoundary (#51439) 2020-02-26 15:53:19 -08:00
Ferhat
2132a0c7a3
Revert "[Perf/codesize] Reduce constraint member reads during layout (#51418)" (#51489)
This reverts commit 69080e07e6bb178332bf546cf83054a85b91b2fe.
2020-02-26 15:51:30 -08:00
Jenn Magder
e31521eab5
Validate empty pubspec plugin section (#51503) 2020-02-26 15:44:35 -08:00
Christopher Fujino
f794091e1d
don't do a version check when testing (#51507) 2020-02-26 15:36:02 -08:00
Jenn Magder
0407a318c6
Replace clean command test functions with test groups (#51508) 2020-02-26 15:13:43 -08:00
Jonah Williams
cd97f23a93
ensure dart defines work on web and not web (#51505) 2020-02-26 14:59:49 -08:00
Alexander Aprelev
0a9b358e3d
Fix expression evaluation test leaking flutter_tester processes. (#51496)
* Fix expression evaluation test leaking flutter_tester processes.

Let flutter_tester process complete, wait for it completion, kill the test only if didn't complete on time.

* Type annotation
2020-02-26 13:42:40 -08:00
Lynn
2243c42ebc
Fix flutter doctor (pluginsPath) check for Mac (#50324) 2020-02-26 13:41:03 -08:00
Greg Spencer
9e744c5710
Implement VisualDensity for text fields. (#51438)
This implements VisualDensity changes for text fields*. By default, the layout of the text field does not change.

If the ThemeData.visualDensity is set to a value other than zero, then the density of the UI will increase or decrease. See the VisualDensity docs for more information.

(*In reality, the changes are on the InputDecorator class, not on the text field.)

I also fixed a problem that I think I found with _Decoration where it doesn't compare isDense or isCollapsed as part of its operator==.
2020-02-26 13:38:28 -08:00
Miguel Beltran
7ff3a50fe7
Set highContrast value from AccessibilityFeatures into MediaQueryData (#48811) 2020-02-26 13:36:02 -08:00
Jonah Williams
65a7941228
[flutter_tools] reduce globals in web validator and chrome launcher (#51443) 2020-02-26 10:37:52 -08:00
Jonah Williams
55072246d0
[flutter_tools] remove build script from tool package (#50690) 2020-02-26 08:25:04 -08:00
Jonah Williams
53457c2241
[flutter_tools] Reland initialize frontend_sever with build (#51477) 2020-02-26 08:06:03 -08:00
Jonah Williams
421056ee54
Revert "[flutter_tools] initialize frontend server with build (#49405)" (#51476)
This reverts commit 59cc3cdf0167740b51236f5eb5571c6bf3345d6f.
2020-02-26 07:24:18 -08:00
Alexandre Ardhuin
a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00
Dan Field
419a2853a8
Revert "Live image cache" (#51441)
* Revert "Live image cache (#51249)"

This reverts commit e2dcdb60e327f80d414d3d1e72e2863bf4c9252c.

* fix tests for other commit
2020-02-25 16:52:47 -08:00
Dan Field
7cbe55cf1a
Avoid caching image load failures that are retriable (#51398) 2020-02-25 14:56:04 -08:00
Zachary Anderson
bc4bd7bd55
[flutter_tools] Don't try to run pub before the version command (#51436) 2020-02-25 17:19:47 -05:00
stuartmorgan
22c807773a
Automatically add plugin projects to Windows .sln (#51246)
Adds utility code for managing list of plugin projects within a solution file, updating them as the plugins change.

This is a prototype of an approach to solution-level portion of Windows plugin tooling; it may not be what the final plugin handling on Windows uses, but it makes things much better in the short term, and gives us a baseline to evaluate other possible solution management systems against.

Part of #32719
2020-02-25 14:16:27 -08:00
Greg Spencer
c71978f600
Remove deprecated DefaultFocusTraversal widget (#51240)
Remove deprecated DefaultFocusTraversal widget
2020-02-25 14:15:35 -08:00
Ferhat
69080e07e6
[Perf/codesize] Reduce constraint member reads during layout (#51418) 2020-02-25 13:50:21 -08:00
Nate Bosch
9228b87eb3
Don't use a default test randomize ordering seed (#51018)
Fixes #51010

The test package differentiates between passing and not passing this
argument. A previous version had a bug that treated passing `0`
identically to not passing the argument, and the flutter test runner
relied on this bug by always passing a value and using a default of `0`.

- Remove the argument defaults throughout to make it clear that `null`
  is a valid value and the default.
- Remove the argument defaulting on the argument parser.
- Update the wording of the usage for this argument, this will also be
  updated on the `package:test` side.
2020-02-25 13:01:40 -08:00
Zachary Anderson
d73dd6b356
[flutter_tools] Rework iOS vmservice handshake failure usage event (#51419) 2020-02-25 15:22:17 -05:00
Christopher Fujino
704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:09:40 -08:00
Hans Muller
9b3754d56f
Extend the gen_l10n integration test (#51375) 2020-02-24 16:42:30 -08:00
LongCatIsLooong
eb00c56205
fix symobol refs in the dynamic color doc (#46003) 2020-02-24 16:21:17 -08:00