firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,703 Commits 1 Branch 0 Tags
Commit Graph

40703 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Elliott Brooks
b487b8c19a
[flutter web] Listen for service extension registration events to determine hot-restart method name (#147897) 
### Some background:

* Flutter registers the hot-restart service extension for all devices **except** web devices. For web devices, DWDS registers the service extensions.
* When a user is debugging their code via VS Code, the VS Code Dart extension [sends a hot-restart](94cb81c552/src/debug/run_daemon_base.ts (L100)) request via stdin/out to flutter_tools
* flutter_tools then [calls the "hotRestart" service extension](f3978c7a46/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart (L447)) (which, again, has been registered by DWDS)

### Why is this change necessary?

In DWDS, we are changing how we register the "hotRestart" service extension (here is the PR for that: https://github.com/dart-lang/webdev/pull/2388). Previously, we registered the "hotRestart" service extension on a client that was directly connected to the VmService. With https://github.com/dart-lang/webdev/pull/2388, we will be registering the "hotRestart" service extension on a client that is connected to DDS. 

When a service extension is registered against DDS, DDS adds a prefix to the service extension method name (e.g. "hotRestart" becomes "s0.hotRestart"). It informs clients of the service extension name via `kServiceRegistered` events sent to the `Service` stream. 

Therefore, this change simply listens to those service extension registered events, and uses them to determine the "hotRestart" service extension's method name.
 2024-05-07 23:06:59 +00:00
engine-flutter-autoroll
89e538da28
Roll Flutter Engine from 42898e014fd1 to 1fe835b85f5c (3 revisions) (#147943) 
42898e014f...1fe835b85f

2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" (flutter/engine#52630)
2024-05-07 matanlurey@users.noreply.github.com Move `verbose` to `environment.verbose`, pass to `ninja --verbose` if provided. (flutter/engine#52619)
2024-05-07 chinmaygarde@google.com Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 22:44:58 +00:00
David Iglesias
d7656f2fcf
[web] Use platform detection from Flutter web engine. (#147346) 
> [!IMPORTANT]
> Requires the following engine PR:
> * https://github.com/flutter/engine/pull/52380
> ----

This PR refactors Flutter `foundation`'s library `platform` for the web with the same code we use to detect platforms in the engine.

## Issues

* Fixes: https://github.com/flutter/flutter/issues/128943

## Testing

Demo app deployed here:

* https://dit-browser-detect.web.app
 2024-05-07 22:44:56 +00:00
LongCatIsLooong
f20c853d20
Implement RenderEditable.computeDryBaseline (#147911) 
Missed `RenderEditable` so https://github.com/flutter/flutter/pull/146224 is failing in google3
 2024-05-07 21:26:48 +00:00
Taha Tesser
74356f30dd
Introduce TabBar.textScaler for tab label upper text scale limit (#147232) 
fixes [Tab is hardcoding the height of the icons and the text ](https://github.com/flutter/flutter/issues/13322)

### Description

This PR introduces `TabBar.textScaler` to provide upper text scale limit for tab label.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: MediaQuery(
        data: const MediaQueryData(textScaler: TextScaler.linear(3.0)),
        child: DefaultTabController(
          length: 3,
          child: Scaffold(
            appBar: AppBar(
              title: const Text('Sample'),
              bottom: const TabBar(
                textScaler: TextScaler.linear(2.0),
                tabs: <Widget>[
                  Tab(text: 'Tab 1'),
                  Tab(text: 'Tab 2'),
                  Tab(text: 'Tab 3'),
                ],
              ),
            ),
            floatingActionButton: Builder(builder: (BuildContext context) {
              return FloatingActionButton(
                onPressed: () {
                  print(MediaQuery.textScalerOf(context));
                },
                child: const Icon(Icons.add),
              );
            }),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Without `TabBar.textScaler`
![Screenshot 2024-04-30 at 13 46 10](https://github.com/flutter/flutter/assets/48603081/99db889a-b717-4ddf-b99e-89fdf7edb3ac)

### With `TabBar.textScaler`

```dart
              bottom: const TabBar(
                textScaler: TextScaler.linear(2.0),
                tabs: <Widget>[
                  Tab(text: 'Tab 1'),
                  Tab(text: 'Tab 2'),
                  Tab(text: 'Tab 3'),
                ],
              ),
```

![Screenshot 2024-04-30 at 14 04 22](https://github.com/flutter/flutter/assets/48603081/92216cbb-eb89-4c0a-b2f2-feb6a33a3337)
 2024-05-07 20:54:09 +00:00
Michael Goderbauer
8796562d0a
Properly guard context access in then clauses (#147935) 
Prepares for a fix to the `use_build_context_synchronously` lint (https://dart-review.googlesource.com/c/sdk/+/365541) that will complain about these unsafe usages.
 2024-05-07 20:50:46 +00:00
engine-flutter-autoroll
458c384fe2
Roll Flutter Engine from d88b7dbfef2e to 42898e014fd1 (2 revisions) (#147939) 
d88b7dbfef...42898e014f

2024-05-07 chinmaygarde@google.com [Impeller] Wait for the previous AHB texture to be fully recyclable. (flutter/engine#52588)
2024-05-07 jason-simmons@users.noreply.github.com Manual Skia roll to 2319f1ae8fe42525f8b6a1969a1cee67bdbee290 (flutter/engine#52615)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 20:41:15 +00:00
derdilla
a7bdf369e5
improve focus example (#147464) 
Part of #130459. Adds a test to the [second focus example](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.2) and makes the function of the example more clear.
 2024-05-07 20:07:49 +00:00
August
be3e916443
feat: Rework getting plugin implementation candidates and plugin resolution (#145258) 
Part of #137040 and #80374

- Extracted getting plugin implementation candidates and the default implementation to its own method
- Extracted resolving the plugin implementation to its own method
- Simplify candidate selection algorithm
- Support overriding inline dart implementation for an app-facing plugin
- Throw error, if a federated plugin implements an app-facing plugin, but also references a default implementation
- Throw error, if a plugin provides an inline implementation, but also references a default implementation
 2024-05-07 20:03:27 +00:00
engine-flutter-autoroll
b8dc9da9b6
Roll Flutter Engine from 5d94a52687a6 to d88b7dbfef2e (1 revision) (#147938) 
5d94a52687...d88b7dbfef

2024-05-07 jonahwilliams@google.com [Impeller] allow cloning a rectangle packer with an increased size. (flutter/engine#52563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 19:57:50 +00:00
Mitchell Goodwin
e67e951388
Change dialog font family (#141295) 
Fixes #139434.

Changes the font from "Text" to "Display". We should only be using the "Display" font for fonts of size 20 and above. Previously "Display" was not showing correctly so this font being wrong was flying under the radar.

Before:
<img width="315" alt="Screenshot 2024-01-10 at 10 49 26 AM" src="https://github.com/flutter/flutter/assets/58190796/c8beba30-04d2-4c22-86ae-85c0576136ee">

After:
<img width="289" alt="Screenshot 2024-01-10 at 10 52 11 AM" src="https://github.com/flutter/flutter/assets/58190796/c6b33aaf-791c-460e-a640-37d8ddf3f713">
 2024-05-07 19:32:47 +00:00
Daco Harkes
6967ae551e
Fix dep tracking (#147709) 
Fix dependency tracking in the build.

* https://github.com/flutter/flutter/issues/147643

## Testing

It's not clear to me where to test the caching behavior of specific targets.

* test/general.shard/build_system/targets/common_test.dart
   * This doesn't test the caching behavior of any targets
* test/general.shard/build_system/build_system_test.dart
* test/general.shard/cache_test.dart
   * Both of these don't test specific `Target`s, these have `TestTarget`s.
* test/integration.shard/isolated/native_assets_test.dart
   * This could work, but it's an integration test that already takes long to run.
 2024-05-07 17:44:12 +00:00
Gray Mackall
d04edd1d7f
Add kotlinOptions jvmTarget to templates (#147326) 
Adds jvmTarget to gradle templates. 

Fixes https://github.com/flutter/flutter/issues/147185.

Interestingly, we already had this in many of our examples/tests, see search results here https://github.com/search?q=repo%3Aflutter%2Fflutter%20jvmTarget&type=code.
 2024-05-07 17:32:10 +00:00
Greg Spencer
95be3fb1fe
Revert "Move docs_test and docs_publish to bringup (#147645)" (#147928) 
## Description

This reverts commit cb2197e9b3b179929b9f775b4263938dd823d491 to move `docs_test` and `docs_publish` back to normal mode after being fixed.

## Related Issues
 - https://github.com/flutter/flutter/issues/147609
 - https://github.com/flutter/flutter/pull/147645
 2024-05-07 17:26:07 +00:00
chunhtai
007faa980d
Reapply new PopScope API (#147607) 
same as previous but with soft transition on modalroute

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
 2024-05-07 09:04:49 -07:00
engine-flutter-autoroll
8dde4490db
Roll Flutter Engine from 150f694a7816 to 5d94a52687a6 (2 revisions) (#147926) 
150f694a78...5d94a52687

2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Various documentation improvements (#52600)" (flutter/engine#52607)
2024-05-07 ian@hixie.ch Various documentation improvements (flutter/engine#52600)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 15:58:11 +00:00
engine-flutter-autoroll
2f43ecfcea
Roll Packages from 2dfe645a96f9 to 5ccddfc995e4 (6 revisions) (#147924) 
2dfe645a96...5ccddfc995

2024-05-06 15619084+vashworth@users.noreply.github.com [shared_preferences_foundation] Adds Swift Package Manager compatibility (flutter/packages#6640)
2024-05-06 stuartmorgan@google.com [file_selector] Add support for SPM (flutter/packages#6672)
2024-05-06 43054281+camsim99@users.noreply.github.com [camerax] Add empty implementation for `prepareForVideoRecording` not used on Android (flutter/packages#6676)
2024-05-06 stuartmorgan@google.com [ci] Reduce the number of tasks in recipe CQ (flutter/packages#6673)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter from f1037a01b796 to 04424e10fe28 (25 revisions) (flutter/packages#6674)
2024-05-06 43054281+camsim99@users.noreply.github.com [camerax] Prevent using unsupported concurrent camera use cases (flutter/packages#6608)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 15:50:08 +00:00
Kostia Sokolovskyi
7920a52dd5
Add tests for callback_shortcuts.0.dart API example. (#147536) 
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Corrects the name for `examples/api/test/widgets/shortcuts/callback_shortcuts.0_test.dart` test file
- Update tests for `examples/api/lib/widgets/shortcuts/callback_shortcuts.0.dart`
 2024-05-07 15:21:46 +00:00
Bartek Pacia
7cf1969ad4
Improve Android SDK and NDK mistmatch warning message (#147809) 
This PR resolves #147806

- List plugin that want to be compiled against a higher Android SDK version
- List plugins that depend on a different NDK version (we don't have a way to compare them)
- Small formatting and wording improvements
- Update syntax to work for both Groovy and Kotlin
- If project uses `build.gradle.kts`, then it is mentioned in the warning message (previously always `build.gradle` was mentioned)

<img width="1209" alt="demo" src="https://github.com/flutter/flutter/assets/40357511/be3522b5-d1b4-4983-9fed-8aaa0f0bc7f7">
 2024-05-07 15:11:00 +00:00
Kostia Sokolovskyi
28e65b7811
Add tests for shortcuts.dart API examples. (#147433) 
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Adds tests for `examples/api/lib/widgets/shortcuts/shortcuts.0.dart`
- Adds tests for `examples/api/lib/widgets/shortcuts/shortcuts.1.dart`
 2024-05-07 11:25:12 +00:00
osama
774ef8acf4
Added missing tests for ButtonStyle example (#147457) 
Added missing tests for ButtonStyle example. Issue #130459
 2024-05-07 09:00:27 +00:00
engine-flutter-autoroll
c785a49d0e
Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (#147912) 
ece1d686e3...150f694a78

2024-05-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/engine#52599)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 08:20:22 +00:00
Bruno Leroux
986c5a9d7f
DropdownMenu cleanup (#147860) 
## Description

This PR cleans up some typos and formatting issues in `DropdownMenu` implementation.

## Tests

No semantic change.
 2024-05-07 07:57:21 +00:00
engine-flutter-autoroll
a7272028c6
Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (#147910) 
80470584e1...ece1d686e3

2024-05-07 jonahwilliams@google.com [Impeller] AHB swapchain mark frame start for tracer. (flutter/engine#52596)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 07:23:27 +00:00
engine-flutter-autoroll
05f1f342ea
Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (#147906) 
b7bfd94af7...80470584e1

2024-05-07 jonahwilliams@google.com [Impeller] eagerly bootstrap content context. (flutter/engine#52590)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 04:56:24 +00:00
engine-flutter-autoroll
3a837bd584
Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (#147905) 
b64e2300bc...b7bfd94af7

2024-05-07 jonahwilliams@google.com [Impeller] add clip coverage stack to exp canvas. (flutter/engine#52215)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 03:03:25 +00:00
zhengzeqin
23ae246a2e
fix MenuItemButton if child is null (#147485) 
Fix https://github.com/flutter/flutter/issues/147479

Pre-launch Checklist
 2024-05-07 02:39:09 +00:00
Greg Spencer
8a7c18c12a
Fix document generation, eliminate template support from snippets tool. (#147893) 
## Description

This fixes the API doc generation that I broke when I moved the snippets tool into the framework.

It removes the last of the template support (properly this time), and makes sure all of the tests pass.

## Related Issues
 - https://github.com/flutter/flutter/issues/144408
 - https://github.com/flutter/flutter/issues/147609
 - https://github.com/flutter/flutter/pull/147645

## Tests
 - Fixed tests, including smoke test of doc generation.
 2024-05-07 02:13:54 +00:00
engine-flutter-autoroll
91f2350a07
Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (#147904) 
4cb9e02c06...b64e2300bc

2024-05-06 chinmaygarde@google.com [Impeller] Document how to use Impeller as a standalone library with OpenGL ES and EGL. (flutter/engine#52473)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 01:40:38 +00:00
derdilla
5ecd4ea83d
test focus example 0 (#147564) 
Part of #130459. Adds tests for [Focus example 0](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.1).
 2024-05-07 01:03:09 +00:00
engine-flutter-autoroll
ea7b93986d
Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (#147899) 
422f92b992...4cb9e02c06

2024-05-06 jonahwilliams@google.com [Impeller] remove compute tessellator. (flutter/engine#52584)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-07 00:04:26 +00:00
flutter-pub-roller-bot
c0ed9f6ff4
Roll pub packages (#147896) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-05-06 23:36:21 +00:00
engine-flutter-autoroll
c7b90aeae7
Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (#147895) 
463ff7d2d4...422f92b992

2024-05-06 jason-simmons@users.noreply.github.com Migrate third_party/android_tools to flutter/third_party (flutter/engine#52582)
2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from a5c042cb4b12 to 869cacf2a3f1 (1 revision) (flutter/engine#52583)
2024-05-06 jonahwilliams@google.com [Impeller] remove unused includes. (flutter/engine#52579)
2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from da772ace76ff to a5c042cb4b12 (6 revisions) (flutter/engine#52581)
2024-05-06 jonahwilliams@google.com [Impeller] fix missing GPU probe. (flutter/engine#52580)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 23:26:24 +00:00
davidhicks980
d5f70135fe
MultiSelectableSelectionContainerDelegate documentation fixes. (#147843) 
Minor grammatical fixes to MultiSelectableSelectionContainerDelegate:

* Removed plural words describing a singular subject.
* Removed redundant language. 
* Elaborated on the behavior of `ensureChildUpdated`.

No issue was filed this was a minor rewording.
 2024-05-06 23:14:52 +00:00
flutter-pub-roller-bot
d4b2e5d705
Roll pub packages (#147891) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-05-06 22:39:58 +00:00
dependabot[bot]
4031041a4b
Bump actions/checkout from 4.1.4 to 4.1.5 (#147888) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.4...v4.1.5">https://github.com/actions/checkout/compare/v4.1.4...v4.1.5</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="44c2b7a8a4"><code>44c2b7a</code></a> README: Suggest <code>user.email</code> to be `41898282+github-actions[bot]<a href="https://github.com/users"><code>@​users</code></a>.norepl...</li>
<li><a href="8459bc0c7e"><code>8459bc0</code></a> Bump actions/upload-artifact from 2 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1695">#1695</a>)</li>
<li><a href="3f603f6d5e"><code>3f603f6</code></a> Bump actions/setup-node from 1 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1696">#1696</a>)</li>
<li><a href="fd084cde18"><code>fd084cd</code></a> Bump github/codeql-action from 2 to 3 (<a href="https://redirect.github.com/actions/checkout/issues/1694">#1694</a>)</li>
<li><a href="9c1e94e0ad"><code>9c1e94e</code></a> Update NPM dependencies (<a href="https://redirect.github.com/actions/checkout/issues/1703">#1703</a>)</li>
<li>See full diff in <a href="0ad4b8fada...44c2b7a8a4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.4&new-version=4.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-05-06 21:45:36 +00:00
Valentin Vignal
f3978c7a46
Fix janks and memory leaks in CupertinoPageTransition and CupertinoFullscreenDialogTransition (#146999) 2024-05-06 14:26:00 -07:00
engine-flutter-autoroll
9dac4eda90
Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (#147886) 
960a0c8fec...463ff7d2d4

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 29e77cd14063 to da772ace76ff (2 revisions) (flutter/engine#52578)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 20:54:09 +00:00
engine-flutter-autoroll
215d087f2e
Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (#147884) 
70cc300f9a...960a0c8fec

2024-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ieb4BPN0ZIRRgYl4y... to 27ZAbzJkEopmu0Emp... (flutter/engine#52576)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Ieb4BPN0ZIRR to 27ZAbzJkEopm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 19:38:23 +00:00
Jonah Williams
5230ec5ba4
[new gallery] Reisze gallery images (#147882) 
Some cause of jank on both Skia and Impeller are these massive images. We should just resize them so that the noise is reduced and we can see other performance issues.

Fixes https://github.com/flutter/flutter/issues/147797

Tested: this is a test!
 2024-05-06 19:20:32 +00:00
engine-flutter-autoroll
af84f6b847
Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (#147880) 
d0f99b35ea...70cc300f9a

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 4754c3fd6b73 to 29e77cd14063 (3 revisions) (flutter/engine#52577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 18:44:51 +00:00
Polina Cherkasova
5bac0de9e3
Fix leak in a test. (#147846) 2024-05-06 17:47:37 +00:00
engine-flutter-autoroll
d498e68eef
Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (#147878) 
a30ae7729c...d0f99b35ea

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 3bc48d128d4b to 4754c3fd6b73 (1 revision) (flutter/engine#52575)
2024-05-06 jason-simmons@users.noreply.github.com Skip files in the clang-tidy driver if clang-tidy crashes when processing the file (flutter/engine#52379)
2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 2da0f29636d3 to 3bc48d128d4b (1 revision) (flutter/engine#52574)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 17:31:22 +00:00
engine-flutter-autoroll
8978d809b7
Roll Packages from f4719ca2feff to 2dfe645a96f9 (3 revisions) (#147866) 
f4719ca2fe...2dfe645a96

2024-05-06 PROGrand@users.noreply.github.com [camera] MediaSettings parameter for createCameraWithSettings (flutter/packages#3586)
2024-05-06 tarrinneal@gmail.com Fix unnecessary toList/fromList calls during encode/decode process (flutter/packages#6426)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter from bf7191fd3884 to f1037a01b796 (21 revisions) (flutter/packages#6641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 15:42:07 +00:00
engine-flutter-autoroll
04424e10fe
Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (#147865) 
f2bfea5fde...a30ae7729c

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 7f582d054385 to 2da0f29636d3 (1 revision) (flutter/engine#52573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 15:30:07 +00:00
Karel Klíč
f94b1e1fc8
Fix Tooltip.decoration comment (#147858) 
Tooltip decoration's comment had the backgrounds for Brightness.dark and Brightness.light swapped.
 2024-05-06 13:13:19 +00:00
engine-flutter-autoroll
9a005f8c06
Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (#147854) 
e2b828f368...f2bfea5fde

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 1454154ed14e to 7f582d054385 (1 revision) (flutter/engine#52572)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 08:39:24 +00:00
engine-flutter-autoroll
7913164947
Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (#147853) 
c73fd390d1...e2b828f368

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 2365dff19ed4 to 1454154ed14e (1 revision) (flutter/engine#52571)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 07:47:34 +00:00
engine-flutter-autoroll
f6c8cc3fa0
Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (#147852) 
624dcb987f...c73fd390d1

2024-05-06 skia-flutter-autoroll@skia.org Roll Skia from 3d798c416f5c to 2365dff19ed4 (1 revision) (flutter/engine#52570)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 05:57:33 +00:00
engine-flutter-autoroll
b8abc10689
Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (#147845) 
900322f233...624dcb987f

2024-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PqcaFvWlaz5ZrFcpC... to Ieb4BPN0ZIRRgYl4y... (flutter/engine#52569)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PqcaFvWlaz5Z to Ieb4BPN0ZIRR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-05 17:01:23 +00:00