Polina Cherkasova
b48dfca382
Upgrade leak_tracker. ( #143236 )
2024-02-09 14:41:22 -08:00
Kris Pypen
2f117c545b
Fix: performance improvement on golden test comparison ( #142913 )
...
During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image.
When you run this test snippet I go from 51 seconds to 14 seconds:
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
for (int i = 0; i < 100; i++) {
testWidgets('Small test', (WidgetTester tester) async {
await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo')));
await expectLater(find.byType(Text), matchesGoldenFile('main.png'));
});
}
}
```
2024-02-09 22:05:00 +00:00
Nate
1887bc410f
Implementing switch expressions in lib/src/material/ ( #142793 )
...
This PR is the 6áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.
(previous pull requests: #139048 , #139882 , #141591 , #142279 , #142634 )
The current focus is on `packages/flutter/lib/src/material/`. The previous 2 PRs covered files in this directory starting with letters `a-m`; this one takes care of everything else.
2024-02-09 22:03:23 +00:00
Henry Riehl
fa71e8029b
Add position data to OnDragEnd callback ( #140378 )
...
This PR adds localPosition/globalPosition data to the `DragEndDetails`
argument of the `onDragEnd` callback.
2024-02-09 12:37:20 -08:00
engine-flutter-autoroll
ed02cf2f4a
Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) ( #143237 )
...
1232d598f7...8c521eb241skia-flutter-autoroll@skia.org Roll Skia from fbe1d2265637 to 4081496b7693 (1 revision) (flutter/engine#50499 )
2024-02-09 zanderso@users.noreply.github.com Supports building with RBE on a Windows host. (flutter/engine#49877 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 19:49:25 +00:00
engine-flutter-autoroll
2edf7d7bef
Roll Flutter Engine from 7a5390c6b3bd to 1232d598f7c4 (1 revision) ( #143235 )
...
7a5390c6b3...1232d598f7skia-flutter-autoroll@skia.org Manual roll Dart SDK from 452dd17120b7 to 03130d49f214 (4 revisions) (flutter/engine#50494 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 19:11:51 +00:00
Jenn Magder
2fc19619e8
Set plugin template minimum iOS version to 12.0 ( #143167 )
...
Fixes https://github.com/flutter/flutter/issues/140474
See https://github.com/flutter/flutter/pull/122625 where this was done 11->12.
2024-02-09 18:32:10 +00:00
engine-flutter-autoroll
2207a3077b
Roll Flutter Engine from 7a241130fcf8 to 7a5390c6b3bd (1 revision) ( #143231 )
...
7a241130fc...7a5390c6b3skia-flutter-autoroll@skia.org Roll Skia from 14ee546dcfe8 to fbe1d2265637 (2 revisions) (flutter/engine#50495 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 18:12:02 +00:00
Bartek Pacia
60f30a65b4
Migrate integration_test plugin to Gradle Kotlin DSL ( #142008 )
...
We already have a simple app in this repo that fully uses Gradle Kotlin DSL (see #141541 ). The next small step is to have at least one plugin that also uses Gradle Kotlin DSL. Let's use `integration_test` for that, since it's versioned with Flutter SDK.
2024-02-09 18:07:56 +00:00
engine-flutter-autoroll
445b08685a
Roll Flutter Engine from dcac9863a1fc to 7a241130fcf8 (1 revision) ( #143222 )
...
dcac9863a1...7a241130fcskia-flutter-autoroll@skia.org Roll Skia from 68cb550de88d to 14ee546dcfe8 (1 revision) (flutter/engine#50493 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 17:30:07 +00:00
engine-flutter-autoroll
2174915cc3
Roll Flutter Engine from 1508b11bf791 to dcac9863a1fc (1 revision) ( #143220 )
...
1508b11bf7...dcac9863a1jason-simmons@users.noreply.github.com [Impeller] Remove the Vulkan queue submit thread and always present Vulkan images on the raster thread (flutter/engine#50484 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 16:44:07 +00:00
engine-flutter-autoroll
03891a4578
Roll Packages from 29d8cc006b0e to 11152d2bc8f3 (4 revisions) ( #143217 )
...
29d8cc006b...11152d2bc8jsharp83@gmail.com [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704 )
2024-02-09 32931186+erdzan12@users.noreply.github.com [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918 )
2024-02-09 43054281+camsim99@users.noreply.github.com [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068 )
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter from 8431cae8843c to eb5d0a434ef1 (33 revisions) (flutter/packages#6079 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 15:38:16 +00:00
engine-flutter-autoroll
5f89a50349
Roll Flutter Engine from 350dc662e5af to 1508b11bf791 (1 revision) ( #143214 )
...
350dc662e5...1508b11bf7skia-flutter-autoroll@skia.org Roll Skia from 64a25300fe1c to 68cb550de88d (2 revisions) (flutter/engine#50491 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 12:55:20 +00:00
David Martos
f0bb9d57e6
barrierColor property in DialogTheme ( #142490 )
2024-02-09 01:50:14 -08:00
engine-flutter-autoroll
8b228b9eda
Roll Flutter Engine from f6dddb257a4f to 350dc662e5af (1 revision) ( #143208 )
...
f6dddb257a...350dc662e5skia-flutter-autoroll@skia.org Roll Skia from 9bcc54924128 to 64a25300fe1c (3 revisions) (flutter/engine#50489 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 06:31:07 +00:00
engine-flutter-autoroll
950e0025c4
Roll Flutter Engine from 377f1b068541 to f6dddb257a4f (1 revision) ( #143207 )
...
377f1b0685...f6dddb257askia-flutter-autoroll@skia.org Roll Skia from c36362d95df0 to 9bcc54924128 (1 revision) (flutter/engine#50488 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 05:38:30 +00:00
engine-flutter-autoroll
88dead0168
Roll Flutter Engine from 1f3b15738adb to 377f1b068541 (1 revision) ( #143204 )
...
1f3b15738a...377f1b0685skia-flutter-autoroll@skia.org Roll Skia from 672bb50b6d8f to c36362d95df0 (3 revisions) (flutter/engine#50485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 04:17:10 +00:00
engine-flutter-autoroll
189fe6b77e
Roll Flutter Engine from f9a169e0e0c1 to 1f3b15738adb (1 revision) ( #143201 )
...
f9a169e0e0...1f3b15738adnfield@google.com [Impeller] Move impeller/image to impeller/playground/image (flutter/engine#50480 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 02:11:07 +00:00
engine-flutter-autoroll
345857712f
Roll Flutter Engine from 7b579dc30979 to f9a169e0e0c1 (2 revisions) ( #143199 )
...
7b579dc309...f9a169e0e0chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter in the Android embedder. (flutter/engine#50472 )
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 59943f4e92b9 to 672bb50b6d8f (3 revisions) (flutter/engine#50476 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 01:25:32 +00:00
Michael Goderbauer
0aa9b5e17d
Layout animated GIFs only once ( #143188 )
...
Fixes https://github.com/flutter/flutter/issues/138610 .
When `RenderImage` receives a new `Image` it only needs to fire up the layout machinery when the dimensions of the image have changed compared to the previous image. If the dimensions are the same, a repaint is sufficient.
2024-02-09 01:12:06 +00:00
engine-flutter-autoroll
5f1a3c16bd
Roll Flutter Engine from 95feed196aab to 7b579dc30979 (1 revision) ( #143195 )
...
95feed196a...7b579dc309ditman@gmail.com Reland "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50457 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 00:48:24 +00:00
engine-flutter-autoroll
808588c750
Roll Flutter Engine from eabac2fa7a26 to 95feed196aab (2 revisions) ( #143192 )
...
eabac2fa7a...95feed196achinmaygarde@google.com [Impeller] Delete the archivist framework. (flutter/engine#50474 )
2024-02-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CPiPDUwCrjHYf_lAR... to RK2irywND2DKT4l6C... (flutter/engine#50473 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from CPiPDUwCrjHY to RK2irywND2DK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 00:06:15 +00:00
engine-flutter-autoroll
ebeba8f01f
Roll Flutter Engine from 9b37c68b4069 to eabac2fa7a26 (2 revisions) ( #143190 )
...
9b37c68b40...eabac2fa7aflutter/engine#50388 )
2024-02-08 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter tester. (flutter/engine#50454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 23:29:59 +00:00
engine-flutter-autoroll
87dd27cf77
Roll Flutter Engine from 6f5b6a37107b to 9b37c68b4069 (2 revisions) ( #143189 )
...
6f5b6a3710...9b37c68b4030870216+gaaclarke@users.noreply.github.com Updated CONTRIBUTING.md to have a testing section (flutter/engine#50469 )
2024-02-08 26625149+0xZOne@users.noreply.github.com Fix Core Foundation object leaks. (flutter/engine#50460 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 22:51:05 +00:00
Gustl22
2299ec781f
Set default flutter source directory for gradle builds ( #142934 )
...
See [#142498 ](https://github.com/flutter/flutter/pull/142498#discussion_r1478602032 )
See this discussion: https://discord.com/channels/608014603317936148/1186378330178601000
2024-02-08 22:28:39 +00:00
Gray Mackall
4b0abc7771
[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions ( #143132 )
...
Re land of https://github.com/flutter/flutter/pull/142000 .
Differences:
1. Fixed the test that was failing in postsubmit. The reason was that the Flutter Gradle Plugin was being applied after KGP in that test, so we couldn't find the KGP version. This caused a log, and the test expects no logs. I moved FGP to after KGP
2. Added to the logs for when we can't find AGP. Change is from
> "Warning: unable to detect project AGP version. Skipping version checking."
to
> ~"Warning: unable to detect project AGP version. Skipping version checking. \nThis may be because you have applied the Flutter Gradle Plugin after AGP."~
update: the above is wrong, changed to
> "Warning: unable to detect project KGP version. Skipping version checking. \nThis may be because you have applied AGP after the Flutter Gradle Plugin."
3. Added a note to the app-level build.gradle templates that FGP must go last
> // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugin.
2024-02-08 22:10:58 +00:00
engine-flutter-autoroll
d1d690276d
Roll Flutter Engine from fb99a84de07e to 6f5b6a37107b (2 revisions) ( #143183 )
...
fb99a84de0...6f5b6a3710110993981+htoor3@users.noreply.github.com [web] - Fix `inputmode` on Android Firefox (flutter/engine#46901 )
2024-02-08 bdero@google.com [Impeller] Vulkan: Don't fail initialization if stencil-only textures aren't supported. (flutter/engine#50455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 21:56:22 +00:00
Jackson Gardner
2efeeb47bc
Revert Dual Web Compile changes ( #143175 )
...
Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs:
https://github.com/flutter/flutter/pull/143128
https://github.com/flutter/flutter/pull/141396
While doing this revert, I had a few merge conflicts with https://github.com/flutter/flutter/pull/142760 , and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.
2024-02-08 21:45:09 +00:00
Michael Goderbauer
8d3c7b6f6a
Cross-link SliverFixedExtentList/SliverPrototypeExtentList/SliverVariedExtentList ( #143184 )
...
Fixes https://github.com/flutter/flutter/issues/141678 .
2024-02-08 21:45:06 +00:00
Zachary Anderson
fbc9f2d5bf
[flutter_tool] Retry a gradle build on connection timeout ( #143084 )
...
This PR will likely not help with the issue on our CI discussed in
https://github.com/flutter/flutter/issues/142637 , but will do one retry
for our users if they hit the same issue.
2024-02-08 12:39:00 -08:00
Qun Cheng
cc4abe92fb
Correct menu position when menu is constrained ( #143121 )
...
Fixes #142896
The original code below is to always place the selected item above(overlap) the popup button so that the selected item can always be visible: f8a77225f3/packages/flutter/lib/src/material/popup_menu.dart (L723-L732)https://github.com/flutter/flutter/assets/36861262/ad761f95-0ff5-4311-a81d-dac56df879c5
Even though the original calculation is to make the selected item visible when open the menu, the menu doesn't auto scroll and only expands itself as much as possible to show the selected one. In this case, if the screen it too small to show the selected item, we still cannot see it. This can be fixed by using `Scrollable.ensureVisible()`(#143118 ).
So we remove the calculation in this PR and the menu will always show up based on the top left of the anchor(button).
https://github.com/flutter/flutter/assets/36861262/03272f26-9440-4ac4-a701-9a0b41776ff9
2024-02-08 20:36:24 +00:00
keyonghan
e64a372d6b
Enable the whole logcat log ( #143119 )
...
Help with https://github.com/flutter/flutter/issues/142572 .
2024-02-08 19:10:07 +00:00
engine-flutter-autoroll
aed2ae54e1
Roll Flutter Engine from 3fb60b8f37c3 to fb99a84de07e (1 revision) ( #143169 )
...
3fb60b8f37...fb99a84de0jonahwilliams@google.com [Impeller] remove extra buffer usage in compute. (flutter/engine#50415 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 19:08:25 +00:00
engine-flutter-autoroll
efd1d1f536
Roll Flutter Engine from f53fbd8393ce to 3fb60b8f37c3 (1 revision) ( #143165 )
...
f53fbd8393...3fb60b8f3730870216+gaaclarke@users.noreply.github.com [Impeller] blur: drop eighth downsample barrier (flutter/engine#50405 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 18:13:26 +00:00
Daco Harkes
4e70bfae2b
Reland "Move native assets to isolated/ directory" ( #143055 )
...
Reland of https://github.com/flutter/flutter/pull/142709 .
The revert of the revert is in the first commit, the fix in the commit on top.
The move of the fakes for packages/flutter_tools/test/general.shard/resident_runner_test.dart was erroneous before, as it was trying to use setters instead of a private field. This PR changes the private `_devFS` field in the fake to be a public `fakeDevFS` in line with other fakes.
## Original PR description
Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.
This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.
In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:
* bin/fuchsia_tester.dart
* lib/executable.dart
The build_system/targets dir is already excluded in other build systems.
So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.
Context:
* https://github.com/flutter/flutter/issues/142041
2024-02-08 17:49:48 +00:00
Zachary Anderson
38c6a5acba
Highlight the links to the release branches more prominently in the CP issue template ( #143000 )
...
Unfortunately, there's no option to preview these changes in the GitHub UI, so I may need to iterate on this...
2024-02-08 16:40:23 +00:00
Bartek Pacia
deaa600204
Reland "Update gradle lockfiles template ( #140115 )" ( #143081 )
...
Trying to reland #140115 which I had to revert in #142889 because [it broke the tree](https://github.com/flutter/flutter/pull/140115#issuecomment-1925774719 ).
In this PR I fixed the post-submit following tests:
2024-02-08 16:22:15 +00:00
engine-flutter-autoroll
eb5d0a434e
Roll Packages from e4ea6bf72e1b to 29d8cc006b0e (5 revisions) ( #143161 )
...
e4ea6bf72e...29d8cc006btd@technodisaster.com [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125 )
2024-02-07 jason-simmons@users.noreply.github.com [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076 )
2024-02-07 58767497+GiftShower@users.noreply.github.com Add transitionDuration parameter (flutter/packages#5854 )
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter from e6ba809b8a23 to 8431cae8843c (23 revisions) (flutter/packages#6075 )
2024-02-07 ltv.luongthevinh@gmail.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 15:37:20 +00:00
engine-flutter-autoroll
004d96a1be
Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) ( #143160 )
...
6d524588c0...f53fbd8393skia-flutter-autoroll@skia.org Roll Skia from fe4aa8a3ea53 to 59943f4e92b9 (1 revision) (flutter/engine#50463 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 15:35:34 +00:00
engine-flutter-autoroll
92c7ba8191
Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) ( #143147 )
...
22e1241e98...6d524588c0skia-flutter-autoroll@skia.org Roll Skia from 97f12df11af2 to fe4aa8a3ea53 (2 revisions) (flutter/engine#50462 )
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 8e08ece134da to 97f12df11af2 (1 revision) (flutter/engine#50461 )
2024-02-08 xilaizhang@google.com [github actions] update license year (flutter/engine#50458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 08:21:52 +00:00
engine-flutter-autoroll
720f73a4da
Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) ( #143140 )
...
084bd0b8f5...22e1241e98skia-flutter-autoroll@skia.org Roll Skia from 91a9154d0dfa to 8e08ece134da (1 revision) (flutter/engine#50459 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 05:19:37 +00:00
engine-flutter-autoroll
be659e0b04
Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) ( #143139 )
...
104804aa37...084bd0b8f5robert.ancell@canonical.com Clear objects before setting them. (flutter/engine#50344 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 04:40:15 +00:00
engine-flutter-autoroll
28904c0cd3
Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) ( #143138 )
...
45137ea6ba...104804aa3726625149+0xZOne@users.noreply.github.com [ios] Fix memory leak in ChildClippingView (flutter/engine#50389 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 03:51:25 +00:00
Jackson Gardner
71c6cd0cb9
Pass along web renderer into debugging options in the test command. ( #143128 )
...
We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.
2024-02-08 01:21:07 +00:00
engine-flutter-autoroll
b586bd9188
Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) ( #143135 )
...
4ea7bd0732...45137ea6bagoderbauer@google.com Report display sizes in physical pixels on MacOS (flutter/engine#50221 )
2024-02-07 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with multiple packages (flutter/engine#50219 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 01:07:20 +00:00
engine-flutter-autoroll
6af69544ab
Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) ( #143131 )
...
322a461dc7...4ea7bd0732skia-flutter-autoroll@skia.org Roll Skia from 8332438cbeb9 to 91a9154d0dfa (2 revisions) (flutter/engine#50452 )
2024-02-07 jonahwilliams@google.com [Impeller] move path out of PathBuilder in TakePath. (flutter/engine#50444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 00:01:08 +00:00
Qun Cheng
d85497d91b
Add a unit test for NavigationRail ( #143108 )
...
Adding `SingleChildScrollView` to `NavigationRail` may cause exception if the nav rail has some expanded widgets inside, like the issue: https://github.com/flutter/flutter/issues/143061 . This PR is just to add a unit test to avoid causing this breaking again.
2024-02-07 23:14:56 +00:00
engine-flutter-autoroll
52f897be5f
Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) ( #143123 )
...
b1ba9f329f...322a461dc7skia-flutter-autoroll@skia.org Roll Skia from eacaa2d3600c to 8332438cbeb9 (6 revisions) (flutter/engine#50451 )
2024-02-07 dnfield@google.com [Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR (flutter/engine#50448 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 23:08:21 +00:00
auto-submit[bot]
cc4e07954d
Reverts "Improve build output for all platforms" ( #143125 )
...
Reverts flutter/flutter#128236
Initiated by: vashworth
Reason for reverting: Causing `Mac_pixel_7pro run_release_test` and `Mac_arm64_android run_release_test` to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_pixel_7pro%20run_release_test/547/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/10516/overview
Original PR Author: guidezpl
Reviewed By: {christopherfujino, loic-sharma}
This change reverts the following previous change:
Original Description:
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-02-07 22:44:19 +00:00
engine-flutter-autoroll
aeb87eb52e
Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) ( #143120 )
...
e4a5acc14b...b1ba9f329fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kvEXgoydRYnW3UvX2... to CPiPDUwCrjHYf_lAR... (flutter/engine#50447 )
2024-02-07 matanlurey@users.noreply.github.com Fix Android `scenario_app` to actually run and block on CI (flutter/engine#50414 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kvEXgoydRYnW to CPiPDUwCrjHY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 22:26:23 +00:00
