Correctly handle the case where the TextEditingController associated
with a TextField is set to null. Due to a typo (= vs ==), previously
this was a no-op and the existing TextEditingController was retained,
rather than copied.
* Add IconThemeData adjustment to ListTile trailing element (makes consistent with leading element)
* Add test for ListTile theme changes
* Pull out and share IconThemeData variable between leading and trailing
* remove extra comma
* fix style nit
* Record original pointer event timestamp
* review
* review
* review
* Matched motions with iOS. Didn’t add overscroll spring clamps and fix tests yet.
* clamp max overscroll transfer
* Add test
* review notes, moved things around
* remove function passing indirection
* review
* Replace stopwatch with timestamp from #11988
* move static
* Review
Fixes some tests that weren't aggressively catching exceptions.
Fixes some actual failures that were found because of this.
Tries to fix an intermittent failure with crash1_test.dart which could be a race condition.
This will enable both to be RTL'ed.
Also, factor out common border painting code into paintBorder.
Also, make Border paint uniform non-rounded borders using drawRect.
Also, add some documentation about an issue that wasted an hour of my life.
Also, factor out all the border painting code into TableBorder.paint.
* Allow FloatingActionButton to not have a heroTag.
* Allow FloatingActionButton to not have a child.
* Allow Tooltip to not have a child.
* Improve the debug output of the default FloatingActionButton hero tag.
* Improve the error message in the Hero clashing-tag case.
* Improve the debug output of the Hero widget.
* Improve the debug output of gesture-related widgets.
* Minor improvements to documentation.
* Fix some typos in comments.
* Fix some style nits.
* Allow apps to change the title margin in app bar.
* Fix documentation links and the shouldLayout function in the _ToolbarLayout
* Rename margin to spacing
* review comments
* Test fixes. Now we also test the width to make sure enough space is left for trailing widget
* Expose the middle spacing default and use it in app bar.
* Fix analyzer break
* Doc fixes due to review
* Roll engine dependency forward
* Tests seem to fail with segfault. Trying different engine version to troubleshoot
* Tests seem to fail with segfault. Trying original engine version to troubleshoot
* Tests seem to pass with original engine version. Continue bisecting.
* Tests seem to fail now. Continue bisecting.
* Reverted culprit cl, rolling to that
1. Migrate simulator device log tailing to os_log toolchain
2. When the log tag (component) is available (iOS 11/Xcode 9), filter to
the set of log lines with tag 'Flutter'.
As of iOS 11 / Xcode 9, Flutter engine logs are no longer recorded in the
simulator's syslog file, which we previously read using tail -f. Instead
they're now accessible through Apple's new macOS/iOS os_log facility,
via /usr/bin/log, which supports a relatively flexible query language.
When run in non-interactive mode, /usr/bin/log buffers its output in 4k
chunks, which is significantly smaller than what's emitted up to the
point where the observatory/diagnostics port information is logged. As a
workaround we force it to run in interactive mode via the script tool.
This ports the five-second retry interval from flutter.bat to the Bash
version. Failures during "pub get" of the flutter tool are common on
Travis and so this should help Travis reliability if nothing else.
