9197 Commits

Author SHA1 Message Date
Chris Bracken
de736f0d43 Update minimum ios-deploy version to 1.9.2 (#11936)
ios-deploy 1.9.2 includes fixes for a common source of Xcode breakage
(flutter/flutter#4326) with Xcode 8.3.3 + iOS 10.3.3, and is required to
to support Xcode 9 (flutter/flutter#11875).
2017-09-05 16:26:36 -07:00
Chris Bracken
93438245f0 Update DevToolsSecurity doctor message (#11935)
Opening Xcode is no longer sufficient to enable develop mode in Xcode 9.
Update the message to run the command-line tool. Alternatively users can
launch an app in the Xcode debugger to do this.
2017-09-05 13:28:13 -07:00
Michael Goderbauer
30fd06f787 getOffsetToReveal deals with pinned slivers (#11878)
* getOffsetToReveal deals with pinned slivers

If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver.

This is important for accessibility scrolling with app bars.

Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent.

* name fixes

* review feedback

* typos

* renaming

* fix analyzer

* fix test

* analyzer fixes
2017-09-05 12:42:28 -07:00
Adam Barth
8eb6ad2776 Add RTL support to GridView (#11921)
Fixes #11855
2017-09-05 11:29:20 -07:00
Chris Bracken
c896fe2f6e Invalidate snapshot when entrypoint changes (#11913)
Adds the app entrypoint as a key in the checksum file.

This change eliminates the assumption that checksummed files change when
the main entrypoint changes. In the case where there are two
entrypoints, a.dart and b.dart and a.dart imports b.dart and b.dart
imports a.dart, building the app with entrypoint a.dart followed by a
build of the app with entrypoint b.dart would result in the same
files list and checksums, but should invalidate the build.
2017-09-05 11:19:09 -07:00
Alexander Aprelev
59bc0a0fce Move host build check until it's actually used. (#11926)
* Move host build check until it's actually used

* Elaborate diagnostic message
2017-09-05 11:12:15 -07:00
Michael Goderbauer
7ee0b6a574 Clear tags on SemanticsNode.reset() (#11903) 2017-09-05 10:37:53 -07:00
Adam Barth
5f29abe2d2 Add RTL support to Switch and CupertinoSwitch (#11928)
Fixes #11868
2017-09-05 09:46:02 -07:00
Adam Barth
9fc9f40263 Add RTL support for AnimatedCrossFade and AnimatedSize (#11920)
Fixes #11848
2017-09-05 09:45:26 -07:00
Mikkel Nygaard Ravn
9be9a40948 Avoid running pub get and analyze on every project during create_test (#11932) 2017-09-05 13:17:14 +02:00
Sarah Zakarias
02c10b78d2 Bundle assets used in packages (#11751) 2017-09-05 09:42:24 +02:00
Adam Barth
baf3b45e0d Add RTL support to AnimatedContainer (#11910)
Also, fix the interpolation between visual and directional fractional
offsets. The interpolation now works visually in whatever direction the
result eventually gets resolved into.

Fixes #11847
Fixes #11357
2017-09-02 22:27:17 -07:00
German Saprykin
74b0bf6480 Fix tracking scroll controller (#11914)
* Fixed TrackingScrollController cleaning stored offset on position's detach

* Fixed format.

* Fixed format.

* Fixed test with Directionality support.
2017-09-02 21:15:59 -07:00
Adam Barth
ea8da05f25 Add RTL support to Stepper (#11873)
Fixes #11379
2017-09-01 22:01:17 -07:00
Chris Bracken
4670c9266c Bugfix in build test: ensure prev snapshot exists (#11912)
Fix a test for build invalidation due to a change in main entry point.
Previously this test's build was always invalidated to the the lack of a
previous snapshot (as well as the change in checksums). This change
ensures that the build is invalidated only due to the change in
checksums.
2017-09-01 18:06:35 -07:00
Chris Bracken
b29680cccf Improve readability of build_test JSON (#11911) 2017-09-01 18:06:13 -07:00
Adam Barth
10130fc551 Spam EdgeInsetsGeometry to improve RTL support (#11849)
Most of the framework widgets should work in terms of EdgeInsetsGeometry
rather than EdgeInsets so that their clients can supply directional
insets.
2017-09-01 16:05:38 -07:00
Alexandre Ardhuin
0783ec906b Enable lints (#11891)
* enable lint prefer_final_fields

* enable lint recursive_getters

* enable lint unnecessary_overrides
2017-09-01 22:18:51 +02:00
Adam Barth
9b5599a4a7 Add RTL support to Drawer (#11872)
Fixes #5215
2017-09-01 12:55:46 -07:00
Adam Barth
9cdfb95b1f Add RTL support to AppBar (#11834)
Fixes #11381
2017-09-01 12:55:31 -07:00
Hans Muller
7ae4de70be Added material string translations for the 6 additional RTL locales we recognize (#11876) 2017-09-01 12:15:05 -07:00
Hans Muller
f3fe875714 Added missing Localizations API doc (#11896) 2017-09-01 11:26:42 -07:00
Ian Hickson
7b33efb620 Revert "Fixed TrackingScrollController cleaning offset on position's detach (#11798)" (#11897)
This reverts commit ec25f6bd5142d9c3b70d81a7ccf7c77f27dc63f7.
2017-09-01 10:48:05 -07:00
German Saprykin
ec25f6bd51 Fixed TrackingScrollController cleaning offset on position's detach (#11798)
* Fixed TrackingScrollController cleaning stored offset on position's detach

* Fixed format.

* Fixed format.
2017-09-01 10:37:33 -07:00
Mehmet Fidanboylu
eae9e053e3 Fix localizations so that extract_messages is happy. (#11894)
extract_messages script currently fails to parse this file because of its use of static asserts, super and a ctr body. Since we already have an assert in the body, I think it is also more readable to put all of them together. _LocalizationScope follows the same pattern above.
2017-09-01 10:15:29 -07:00
Chris Bracken
eba6ceb85d Use idevice_id, ideviceinfo for iOS device listing (#11883)
This patch migrates iOS device listing from using Xcode instruments to
using the libimobiledevice tools idevice_id and ideviceinfo.

ideviceinfo was previously incompatible with iOS 11 physical devices;
this has now been fixed.

In 37bb5f1300e67fe590c44bb9ecda653b2967e347 flutter_tools migrated from
libimobiledevice-based device listing on iOS to using Xcode instruments
to work around the lack of support for iOS 11. Using instruments entails
several downsides, including a significantly higher performance hit, and
leaking hung DTServiceHub processes in certain cases when a simulator is
running, necessitating workarounds in which we watched for, and cleaned
up leaked DTServiceHub processes. This patch returns reverts the move to
instruments now that it's no longer necessary.
2017-09-01 10:10:49 -07:00
Yegor
0793add818 rename Element.visitChildrenForSemantics to visitOnstageChildren; fix DropdownButton (#11744)
* rename Element.visitChildrenForSemantics to debugVisitOnstageChildren

* address comments
2017-09-01 09:48:12 -07:00
Andrew Wilson
aaa9d18024 Handle negative and zero sizes. (#11827) 2017-09-01 09:27:15 -07:00
Hans Muller
4faa036736 Added localizations for Directionality (#11870) 2017-09-01 08:04:31 -07:00
Carlo Bernaschina
e216004b86 Roll Engine to 29e0c1c2814ebbb325f1ddbc5d365a2960ec4575 (#11879) 2017-08-31 23:12:35 -07:00
Ian Hickson
2cbc4a0202 Make "pub get" retry once a second when it fails. (#11882) 2017-08-31 19:35:05 -07:00
Alexander Aprelev
42bd30dd3f Add preview_dart_2 builds to the dashboard (#11889) 2017-08-31 18:06:17 -07:00
Carlo Bernaschina
1328fd043a Mark commands_test as not flaky (#11880) 2017-08-31 18:04:49 -07:00
Collin Jackson
936c6e3616 Remove dead code for hero overlay inserting (#11841) 2017-08-31 17:13:30 -07:00
Ian Hickson
400f118d92 Improve the Flex overflow marker style (#11723)
* Improve the Flex overflow marker style

* Update basic.dart
2017-08-31 17:12:13 -07:00
Collin Jackson
1c372c6803 Roll alpha (#11874) 2017-08-31 15:54:45 -07:00
Phil Quitslund
8fa545fee2 Update Hot Reload label text in template app instructions. (#11857)
* Update Hot Reload label text in template app instructions.

* label fix
2017-08-31 15:37:01 -07:00
Jason Simmons
d77955fb1a Pass the width constraint to the text layout engine if ellipsizing is enabled (#11877) 2017-08-31 14:51:11 -07:00
Alexander Aprelev
c5750cd7ea Introduce --preview-dart-2 option to run new frontend compiler in flutter tools. (#11741)
This adds --preview-dart-2 flag that enables use of Dart 2.0 Frontend in Flutter tools.
2017-08-31 13:35:55 -07:00
Devon Carew
8c36ccf534 More frame events (#11747)
* Revert "Revert "fire service protocol events for frames (#11565)" (#11727)"

This reverts commit f25e2f5213b064edc1fa71bb2326a3e1e15fcbd6.

* move the postEvent() call into a separate method
2017-08-31 11:38:21 -07:00
Adam Barth
ff3acad1ad Fix build 2017-08-31 10:39:09 -07:00
Adam Barth
145f3894e5 Add RTL support to ListTile (#11838)
Fixes #11373
2017-08-31 09:55:52 -07:00
Adam Barth
15bf91fb3d Add RTL support to scrolling (#11842)
This patch includes:

 * SliverPadding
 * ScrollView
 * PageView

Fixes #11764
Fixes #11836
2017-08-31 09:55:42 -07:00
Yegor
76f245156c fix typo in State.didUpdateWidget dartdoc (#11863)
* fix typo in State.didUpdateWidget

* rephrase
2017-08-31 08:54:46 -07:00
Hans Muller
b682b78105 Mark android_sample_catalog_generator flaky (#11867) 2017-08-31 08:41:02 -07:00
Hans Muller
541afae45b Localizations for Material (#11832) 2017-08-31 07:45:30 -07:00
xster
0323f2ddd2 Address comments (#11620) 2017-08-31 02:20:28 -07:00
Alexandre Ardhuin
bb4f4070f9 Prefer const constructors (#11853)
* upgrade to linter-0.1.35

* re-enable lint prefer_const_constructors

* address review comments
2017-08-31 08:55:21 +02:00
Devon Carew
f0bf7b5c8c add intellij metadata for the plugin and packages templates (#11852) 2017-08-30 15:37:35 -07:00
Adam Barth
4a18cbdf2c Add RTL support to progress indicators (#11840)
Fixes #11374
2017-08-30 10:05:53 -07:00