Justin McCandless
924e48eeb9
Increase TextField's minimum height from 40 to 48 ( #42449 )
...
This is being done to match the Material spec. It will likely break many visual diff tests.
2019-11-01 12:36:15 -04:00
LongCatIsLooong
3cd8c3142c
Update CupertinoSlidingSegmentedControl control/feedback mechanism ( #43932 )
2019-10-31 19:35:52 -07:00
Jonah Williams
a192e29603
check for instanceof instead of runtimeType and wait for testbed ( #43870 )
2019-10-31 19:31:42 -07:00
engine-flutter-autoroll
43a8d705ed
Roll engine 44c9fab7b4d8..8ea19b1c76f6 (4 commits) ( #43942 )
...
git@github.com:flutter/engine.git/compare/44c9fab7b4d8...8ea19b1c76f6
git log 44c9fab7b4d8..8ea19b1c76f6 --no-merges --oneline
2019-10-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 549325c87e9d..809ec77893be (1 commits) (flutter/engine#13458 )
2019-10-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from p7XYM... to JngMB... (flutter/engine#13456 )
2019-10-31 iska.kaushik@gmail.com [fuchsia] [packaging] Prettify parent folder name (flutter/engine#13463 )
2019-10-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from nhX22... to 866GG... (flutter/engine#13450 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-31 21:27:25 -04:00
Greg Spencer
3a30722fda
Add convenience accessor for primaryFocus ( #43859 )
...
This adds accessors for WidgetsBinding.instance.focusManager and WidgetsBinding.instance.focusManager.primaryFocus so that they can be more easily found in IDEs and accessed.
This adds a top level getter for WidgetsBinding.instance.focusManager.primaryFocus called primaryFocus, and a static accessor FocusManager.instance that returns WidgetsBinding.instance.focusManager.
2019-10-31 18:02:31 -07:00
engine-flutter-autoroll
5f7b48188a
44c9fab7b Roll src/third_party/dart d50c158d42..bbe2ac28c9 (19 commits) ( #43937 )
...
git@github.com:flutter/engine.git/compare/73541c97b8b6...44c9fab7b4d8
git log 73541c97b8b6..44c9fab7b4d8 --no-merges --oneline
2019-10-31 bkonyi@google.com Roll src/third_party/dart d50c158d42..bbe2ac28c9 (19 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-31 20:38:25 -04:00
Emmanuel Garcia
99cd440384
Revert "Revert "Reland: Migrate examples new embedding ( #43868 )" ( #43885 )" ( #43939 )
2019-10-31 16:17:31 -07:00
engine-flutter-autoroll
6d42c4103f
73541c97b [recipe] Upload sky_engine to CIPD (flutter/engine#13464) ( #43933 )
...
git@github.com:flutter/engine.git/compare/7c80d62e89f6...73541c97b8b6
git log 7c80d62e89f6..73541c97b8b6 --no-merges --oneline
2019-10-31 iska.kaushik@gmail.com [recipe] Upload sky_engine to CIPD (flutter/engine#13464 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-31 18:46:25 -04:00
Jonah Williams
a60a47ae2c
Serve correct mime type on release dev server ( #43907 )
2019-10-31 14:57:34 -07:00
engine-flutter-autoroll
353721a166
Roll engine 4b76fadbf438..7c80d62e89f6 (5 commits) ( #43920 )
...
git@github.com:flutter/engine.git/compare/4b76fadbf438...7c80d62e89f6
git log 4b76fadbf438..7c80d62e89f6 --no-merges --oneline
2019-10-31 iska.kaushik@gmail.com CIPD needs the directory to be relative (flutter/engine#13461 )
2019-10-31 1541038+josh-ksr@users.noreply.github.com Force orientation change when current orientation not allowed on iOS (flutter/engine#13170 )
2019-10-31 jason-simmons@users.noreply.github.com Duplicate the directory fd in fml::VisitFiles (flutter/engine#13448 )
2019-10-31 amirh@users.noreply.github.com Fix iOS crash when multiple platform views are in the scene (flutter/engine#13449 )
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7df14d055703..549325c87e9d (11 commits) (flutter/engine#13447 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-31 17:56:25 -04:00
Emmanuel Garcia
7fe4ea2475
Fix stdout test ( #43927 )
2019-10-31 14:29:21 -07:00
engine-flutter-autoroll
c48f76c798
4b76fadbf Fizzle onConfigurationChanged if no FlutterView (flutter/engine#13445) ( #43867 )
2019-10-31 13:40:23 -07:00
Gary Qian
f9b8d688cf
Reorder show and setEditingState calls to the IMM ( #43865 )
2019-10-31 13:28:48 -07:00
Emmanuel Garcia
175b37247d
Refactor gradle.dart ( #43479 )
2019-10-31 13:19:15 -07:00
Greg Spencer
0028887a69
Don't allow Disabled InkWells to be focusable ( #43848 )
...
Makes sure that disabled InkWell/InkResponse and widgets that use them don't allow themselves to be focused.
ListTile, PopupMenu, and Stepper were not setting canRequestFocus properly on the InkWell, and InkWell was allowing focus even if it was disabled (it was basically just relying on the containing widget to set canRequestFocus properly). Now InkWell must both be enabled (have an onTap or similar) and have canRequestFocus set to true.
2019-10-31 12:58:14 -07:00
Kaushik Iska
f798cb6d29
Revert "[flutter_runner] Use sky_engine from the topaz tree ( #43684 )" ( #43913 )
...
This reverts commit e091d724f697d78375b9b850b67b6a810daa8f82.
2019-10-31 11:59:45 -07:00
Kate Lovett
26d09f1ab4
Gold Performance improvements ( #43748 )
2019-10-31 11:44:07 -07:00
Michael Goderbauer
07a09c4b70
Mark routes as opaque when added without animation ( #43756 )
2019-10-31 11:32:19 -07:00
Dan Field
8e0799a657
Revert "Reland: Migrate examples new embedding ( #43868 )" ( #43885 )
...
This reverts commit 46edc80237f9f95b661c09dd1c194f47f28f1efc.
2019-10-30 23:33:38 -07:00
Jonah Williams
79323f7c13
Ensure target platform is passed is always passed to assemble ( #43862 )
2019-10-30 19:40:19 -07:00
liyuqian
40670c09dc
Allow multiple TimingsCallbacks ( #43676 )
...
This fixes https://github.com/flutter/flutter/issues/39277
The following tests cover this change:
- packages/flutter/test/foundation/service_extensions_test.dart
- packages/flutter/test/scheduler/scheduler_test.dart
2019-10-30 19:02:13 -07:00
Emmanuel Garcia
46edc80237
Reland: Migrate examples new embedding ( #43868 )
2019-10-30 19:00:24 -07:00
engine-flutter-autoroll
ababfd3316
b16eab6af Remove usage of yaml module from CIPD script (flutter/engine#13444) ( #43864 )
...
git@github.com:flutter/engine.git/compare/97807b534122...b16eab6affb7
git log 97807b534122..b16eab6affb7 --no-merges --oneline
2019-10-30 iska.kaushik@gmail.com Remove usage of yaml module from CIPD script (flutter/engine#13444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-30 21:04:50 -04:00
Michael Goderbauer
99fd65e79a
Remove print and fix code formatting ( #43843 )
2019-10-30 17:15:52 -07:00
engine-flutter-autoroll
b8857c8795
Roll engine e609577d1201..97807b534122 (3 commits) ( #43860 )
...
git@github.com:flutter/engine.git/compare/e609577d1201...97807b534122
git log e609577d1201..97807b534122 --no-merges --oneline
2019-10-30 matthew-carroll@users.noreply.github.com Automatically destroy FlutterEngine when created by FlutterActivity or FlutterFragment. (flutter/engine#13423 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart f30b494035..d50c158d42 (5 commits) (flutter/engine#13443 )
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7da048b5e8f1..7df14d055703 (7 commits) (flutter/engine#13441 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-30 20:00:50 -04:00
Jonah Williams
79bc6cafc5
implement build aot with assemble for Android target platforms ( #43282 )
2019-10-30 15:23:25 -07:00
engine-flutter-autoroll
bdd93924d6
Roll engine 5051bef17bdc..e609577d1201 (3 commits) ( #43854 )
...
git@github.com:flutter/engine.git/compare/5051bef17bdc...e609577d1201
git log 5051bef17bdc..e609577d1201 --no-merges --oneline
2019-10-30 mklim@google.com Revert "Turn on RasterCache based on view hierarchy (#13360 )" (flutter/engine#13442 )
2019-10-30 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13360 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart d3a5b82355..f30b494035 (9 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-30 18:16:50 -04:00
Erick (CptBlackPixel)
8b09a53252
Fixing focus traversal when the node options are empty ( #43238 )
...
Fixes directional focus traversal when there are no available nodes to traverse to.
2019-10-30 14:54:29 -07:00
Zachary Anderson
d0d8e6edcb
[flutter_tool] Teach the tool about local engine Fuchsia artifacts ( #43759 )
2019-10-30 14:11:18 -07:00
Jonah Williams
417449e2f3
Deflake flutter tool logger test ( #43800 )
2019-10-30 13:09:26 -07:00
engine-flutter-autoroll
e0094eee52
Roll engine 36303c61b63f..5051bef17bdc (21 commits) ( #43828 )
...
git@github.com:flutter/engine.git/compare/36303c61b63f...5051bef17bdc
git log 36303c61b63f..5051bef17bdc --no-merges --oneline
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia ebdae1144978..7da048b5e8f1 (1 commits) (flutter/engine#13438 )
2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from DfLN8... to p7XYM... (flutter/engine#13437 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart eb4ab61349..d3a5b82355 (4 commits)
2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from goLxs... to nhX22... (flutter/engine#13435 )
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia c3a51a5e47ba..ebdae1144978 (1 commits) (flutter/engine#13434 )
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1ae54bc22fc2..c3a51a5e47ba (1 commits) (flutter/engine#13433 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart ae5a86d790..eb4ab61349 (7 commits)
2019-10-30 dnfield@google.com Set the install name at link time for darwin dylibs (flutter/engine#13428 )
2019-10-30 mehmetf@users.noreply.github.com Add isRunningInRobolectricTest back (flutter/engine#13424 )
2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76d22d1ee8cb..1ae54bc22fc2 (26 commits) (flutter/engine#13430 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart ebd059030b..ae5a86d790 (3 commits)
2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/clang/linux-amd64 from Vghc_... to WxGHg... (flutter/engine#13420 )
2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from mc3jR... to DfLN8... (flutter/engine#13413 )
2019-10-30 bkonyi@google.com Roll src/third_party/dart 780af0fcfc..ebd059030b (17 commits)
2019-10-30 chinmaygarde@google.com Make sure root surface transformations survive resetting the matrix directly in Flow. (flutter/engine#13405 )
2019-10-30 iska.kaushik@gmail.com [fuchsia] [packaging] Create a script to upload debug symbols to CIPD (flutter/engine#13422 )
2019-10-29 47866232+chunhtai@users.noreply.github.com Revert "fix fml_unittes is not run during presubmit (#13395 )" (flutter/engine#13425 )
2019-10-29 30870216+gaaclarke@users.noreply.github.com Made it so we clean up gl resources when view controllers get deleted. (flutter/engine#13396 )
2019-10-29 30870216+gaaclarke@users.noreply.github.com Added back in empty lifecycle events so we don't break people that used to call `super`. (flutter/engine#13421 )
2019-10-29 47866232+chunhtai@users.noreply.github.com fix fml_unittes is not run during presubmit (flutter/engine#13395 )
2019-10-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia f22dda960136..76d22d1ee8cb (2 commits) (flutter/engine#13411 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-30 16:08:50 -04:00
Jonah Williams
349d694fb7
Revert "Added a null check for ranges in the sourceReport map. ( #43667 )" ( #43827 )
...
This reverts commit 0dc5ea4a950ed2215befd1d924f16bcd5589927d.
2019-10-30 10:57:35 -07:00
engine-flutter-autoroll
8f704840ee
Roll engine 46c757be07fd..36303c61b63f (3 commits) ( #43784 )
...
git@github.com:flutter/engine.git/compare/46c757be07fd...36303c61b63f
git log 46c757be07fd..36303c61b63f --no-merges --oneline
2019-10-29 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from sLCwg... to goLxs... (flutter/engine#13412 )
2019-10-29 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from EpbPE... to 6tttO... (flutter/engine#13418 )
2019-10-29 bkonyi@google.com Roll src/third_party/dart 0b96f9f9ae..780af0fcfc (8 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-30 13:55:50 -04:00
LongCatIsLooong
9ea0ecc33b
CupertinoSlidingSegmentedControl ( #42775 )
2019-10-30 10:42:48 -07:00
Efthymis Sarmpanis
c5b3b3ac26
Flutter doctor should require java 1.8+ ( #41989 )
2019-10-30 10:40:27 -07:00
Nate Bosch
7cf362fc31
Handle onError callback with optional argument ( #43436 )
...
Check for a binary callback first since a function with an optional
second argument will match both typedefs.
Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.
Add a test for a unary error handler and an error handler with an
optional stack trace argument.
2019-10-30 10:39:50 -07:00
Larry McKenzie
0dc5ea4a95
Added a null check for ranges in the sourceReport map. ( #43667 )
2019-10-30 10:35:45 -07:00
Shi-Hao Hong
207135cd04
Separate DropdownButton and DropdownButtonFormField tests ( #43738 )
...
* Separate DropdownButtonFormField and DropdownButton test files
2019-10-30 10:27:43 -07:00
Phil Quitslund
57160b938c
enable avoid_web_libraries_in_flutter ( #43739 )
2019-10-30 10:04:04 -07:00
stuartmorgan
f6f6e86eb8
Split desktop config fallback variable by platform ( #43758 )
...
The environment variable for all desktop platforms is currently
ENABLE_FLUTTER_DESKTOP to allow backward compatibility with existing
workflows. However, this is actually causing issues since 'flutter
config' provides a better experience (most importantly, IDEs will work
correctly, which is generally not the case with the environemnt
variable). Currently people following old (third-patry) instructions
don't realize that they are missing available functionality, so aren't
looking for the current instructions.
In adddition, this will be confusing as different platform graduate to
channels other than master at different times.
To resolve both issues, the environment variable fallback is now
separate for each desktop platform, and follows a naming scheme
consistent with the web environment variable.
2019-10-29 21:43:25 -07:00
Jonah Williams
9cb2047139
Make Spinner test case use mockStopwatch ( #43761 )
2019-10-29 21:36:19 -07:00
Jonah Williams
50da3bd062
check if libimobiledevice executables exist ( #43767 )
2019-10-29 21:35:51 -07:00
Bernardo Ferrari
28a214ba8a
Add onLongPress to Buttons ( #40641 )
...
* Add onLongPress to Buttons.
* Button enabled status will now respond to onLongPress
2019-10-29 18:41:44 -07:00
engine-flutter-autoroll
dc44c5668d
Roll engine 419f5d594afc..46c757be07fd (6 commits) ( #43769 )
...
git@github.com:flutter/engine.git/compare/419f5d594afc...46c757be07fd
git log 419f5d594afc..46c757be07fd --no-merges --oneline
2019-10-29 iska.kaushik@gmail.com [dart_runner] Common libs need to exist for aot runner (flutter/engine#13419 )
2019-10-29 jason-simmons@users.noreply.github.com Fix the dry run mode of the GN format checker script (flutter/engine#13406 )
2019-10-29 jason-simmons@users.noreply.github.com Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401 )
2019-10-29 jason-simmons@users.noreply.github.com Use DartExecutor.getBinaryMessenger in FlutterNativeView instead of deprecated send methods (flutter/engine#13403 )
2019-10-29 bkonyi@google.com Roll src/third_party/dart e1fce75301..0b96f9f9ae (28 commits)
2019-10-29 matthew-carroll@users.noreply.github.com Converted ActivityAware and ServiceAware Lifecycles to opaque objects (#43670 ) (flutter/engine#13402 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-29 20:41:06 -04:00
Greg Spencer
a1c5e3354b
Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. ( #43657 )
...
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213 ), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.
2019-10-29 17:09:26 -07:00
Jonah Williams
b1aff28593
pass --no-gen-bytecode to aot kernel compiler invocations ( #43753 )
2019-10-29 16:05:54 -07:00
Emmanuel Garcia
7e60a65ff0
Don't read AndroidManifest.xml if it doesn't exit ( #43669 )
2019-10-29 16:05:13 -07:00
gaaclarke
53dcf92f7d
Fixed bug where we could accidently call a callback twice. ( #43467 )
2019-10-29 16:04:38 -07:00
Tim Sneath
05c3f7b6a1
Update README to include non-mobile targets ( #42873 )
...
* Update README to include non-mobile targets
* Tweak headings
2019-10-29 15:57:14 -07:00
LongCatIsLooong
3352b91f2c
CupertinoPicker doc update ( #43736 )
2019-10-29 14:31:27 -07:00
