firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,560 Commits 1 Branch 0 Tags
Commit Graph

16560 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Christopher Fujino
20af1f25db
Re-land fix docker build and deploy_gallery-macos (#43654) 2019-10-29 14:29:27 -07:00
Christopher Fujino
261594e785
add libzip cache artifact (#43677) 2019-10-29 14:29:00 -07:00
Taufiq Rahman
13c4ba2a25 Adjust and refactor all MaterialButton tests into its respective file (#43528) 
* Adjust and refactor all MaterialButton tests into its respective file
 2019-10-29 14:27:07 -07:00
Kaushik Iska
e091d724f6
[flutter_runner] Use sky_engine from the topaz tree (#43684) 
This is to account for the flutter_runner migration.
fxb/fl-250 has more context. This change specifically uses
the build rules that were added as a part of: fxr/333681
 2019-10-29 14:24:10 -07:00
liyuqian
c523149819
Reland "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43455) 
This reverts commit b9eb3f717a017ebe444e3074278788d8e0353147.

We fixed the issue by updating the constructors.
 2019-10-29 14:20:22 -07:00
gaaclarke
6931d5e33e
Fixed usage of optional types in swift. (#43461) 2019-10-29 14:20:05 -07:00
Jonah Williams
e778686e72
Re-enable chrome dev mode tests (#43691) 2019-10-29 13:23:27 -07:00
Jonah Williams
2637a6cbca
Update packages --force-upgrade (#43745) 2019-10-29 13:21:45 -07:00
Jonah Williams
331d19ff4b
Add reloadMethod RPC (#43725) 2019-10-29 13:21:06 -07:00
Jonah Williams
1d7afd9c1d
Don't indefinitely persist file hashes, handle more error conditions (#43602) 2019-10-29 13:20:51 -07:00
Yegor
5f6ca6838e
Enable heroes_test.dart on the web matrix (#43662) 2019-10-29 12:23:16 -07:00
Pieter van Loon
0120c414fb Improved ios 13 scrollbar fidelity (#41799) 
Drag from the right is no more
Longpress is now only 100ms instead of 500
Added optional duration field to longpressgesturerecognizer
Added controller field to material scrollbar api
Haptic feedback only triggers when scrollbar is fully expanded
Added haptic feedback when releasing the scrollbar after dragging it
 2019-10-29 08:46:21 -07:00
engine-flutter-autoroll
2cedd559bb
419f5d594 Roll src/third_party/skia 1beb8ae9a2f5..f22dda960136 (11 commits) (flutter/engine#13409) (#43698) 
git@github.com:flutter/engine.git/compare/25563a12cab1...419f5d594afc

git log 25563a12cab1..419f5d594afc --no-merges --oneline
2019-10-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1beb8ae9a2f5..f22dda960136 (11 commits) (flutter/engine#13409)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-29 00:43:06 -04:00
engine-flutter-autoroll
4a0401ffcd
Roll engine 49971e21402e..25563a12cab1 (7 commits) (#43695) 
git@github.com:flutter/engine.git/compare/49971e21402e...25563a12cab1

git log 49971e21402e..25563a12cab1 --no-merges --oneline
2019-10-29 iska.kaushik@gmail.com Update recipe_changelog to account for dart_aot runner and clobbering
2019-10-28 iska.kaushik@gmail.com Revert "[flutter_runner] Don't build far files twice (#13397)" (flutter/engine#13400)
2019-10-28 matthew-carroll@users.noreply.github.com Remove multiplexed Flutter Android Lifecycle. (#43663) (flutter/engine#13394)
2019-10-28 iska.kaushik@gmail.com [flutter_runner] Don't build far files twice (flutter/engine#13397)
2019-10-28 chinmaygarde@google.com Delay metal drawable acquisition till frame submission. (flutter/engine#13367)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 9MM-e... to mc3jR... (flutter/engine#13390)
2019-10-28 bkonyi@google.com Roll src/third_party/dart 5e39817ec7..e1fce75301 (2 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 23:56:06 -04:00
Jenn Magder
01dc19b93f
Pass environment variables through to xcodebuild (#43553) 2019-10-28 19:58:06 -07:00
Jonah Williams
19e551c7a6
Remove Poller class from flutter_tools (#43685) 2019-10-28 19:35:43 -07:00
Emmanuel Garcia
ea4da39fab
Revert: Migrate examples to the new embedding (#43689) 2019-10-28 19:11:09 -07:00
engine-flutter-autoroll
f41becf53e
Roll engine c3b63d610b07..49971e21402e (3 commits) (#43673) 
git@github.com:flutter/engine.git/compare/c3b63d610b07...49971e21402e

git log c3b63d610b07..49971e21402e --no-merges --oneline
2019-10-28 yjbanov@google.com Implement basic Picture.toImage via BitmapCanvas (flutter/engine#13391)
2019-10-28 chinmaygarde@google.com Switch the MacOS Desktop embedder to using a thread configuration where the platform and render task runners are the same. (flutter/engine#13300)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 18f5b1a6dd77..1beb8ae9a2f5 (9 commits) (flutter/engine#13392)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 20:17:06 -04:00
Emmanuel Garcia
910b8ee1c5
Fix device lab tests (#43675) 2019-10-28 17:00:15 -07:00
Emmanuel Garcia
5bec33f428
Add missing import (#43674) 2019-10-28 16:35:24 -07:00
gaaclarke
56e3c0c678
Added note about design doc template. (#43658) 
* Added note about design doc template.

* switched "our" to "flutter"

* updated link
 2019-10-28 15:58:24 -07:00
Jonah Williams
e25cd84a06
Catch failed startup error from build_daemon (#43598) 2019-10-28 15:58:14 -07:00
Ian Hickson
7de800c44a
Support platform-specific test lines (#43458) 2019-10-28 15:51:22 -07:00
LongCatIsLooong
4ac2daf337
CupertinoTheme & CupertinoTextTheme dark mode updates (#41859) 2019-10-28 15:50:08 -07:00
Emmanuel Garcia
20e015ffe6
Reland: Migrate examples new embedding (#43643) 
* Fix device lab tests

* Migrate examples to the Android embedding v2 (#43221)
 2019-10-28 15:43:37 -07:00
knaeckeKami
ccfdf95c4a Use PRODUCT_BUNDLE_IDENTIFIER from buildSettings to find correct bundle id on iOS when using flavors (#42964) 2019-10-28 15:33:27 -07:00
Jenn Magder
f7d78d5baa
Alias upgrade-packages => update-packages (#43546) 
* Alias upgrade-packages => update-packages

* Trailing whitespace
 2019-10-28 15:32:39 -07:00
Justin McCandless
6e888dac24
Add enableSuggestions flag to TextField and TextFormField (#42550) 
This flag controls Android's keyboard suggestions on/off
 2019-10-28 15:31:52 -07:00
engine-flutter-autoroll
98bc378d6f
Roll engine 728e473f1a4b..c3b63d610b07 (2 commits) (#43661) 
git@github.com:flutter/engine.git/compare/728e473f1a4b...c3b63d610b07

git log 728e473f1a4b..c3b63d610b07 --no-merges --oneline
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from urhvj... to sLCwg... (flutter/engine#13389)
2019-10-28 bkonyi@google.com Roll src/third_party/dart 5b7c981086..5e39817ec7 (2 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 17:40:06 -04:00
creativecreatorormaybenot
e903485de2 Change PopupMenuButton.icon type to Widget (#43526) 2019-10-28 13:46:14 -07:00
Shi-Hao Hong
c461ff9d4a
Implement AlertDialog title/content overflow scroll (#43226) 
* Wrap alert dialog title and content in single child scroll view

* Scrollable alert dialog title and content tests

* Remove unnecessary comment

* Fix mainAxisSize and crossAxisAlignment issue
 2019-10-28 13:45:05 -07:00
Shi-Hao Hong
036c102c34
Improve DropdownButton assert message (#43511) 
- Adds an assert message checking for exactly one unique value for `DropdownItem`s
 2019-10-28 13:44:21 -07:00
engine-flutter-autoroll
c08de65b37
Roll engine 869b74eb4eca..728e473f1a4b (2 commits) (#43652) 
git@github.com:flutter/engine.git/compare/869b74eb4eca...728e473f1a4b

git log 869b74eb4eca..728e473f1a4b --no-merges --oneline
2019-10-28 garyq@google.com Pass LinearTextFlat to SkFont -  iOS13 letter spacing (flutter/engine#13321)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 428b5de64a08..18f5b1a6dd77 (1 commits) (flutter/engine#13387)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 16:40:06 -04:00
Yegor
f5f24a6cd1
Enable tests that failed due to CupertinoDynamicColor (#43636) 2019-10-28 13:38:18 -07:00
Greg Spencer
38f2d27685
Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)" (#43647) 
This reverts commit 8017f63b083474d0ba28457e48acbb35d15a727a, since it breaks web tests.
 2019-10-28 11:28:09 -07:00
Albertus Angga Raharja
b31ca1aaca
Add more structure to errors (continuation of #34684) (#42640) 
* Add structured errors in Animations, TabView, ChangeNotifier

* Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan

* Add structured errors in Debug

* Fix test errors

* Add structured errors in Scaffold and Stepper

* Add structured errors in part of Rendering Layer

* Fix failing test due to FloatingPoint precision

* Fix failing tests due to precision error and not using final

* Fix failing test due to floating precision error with RegEx instead

* Add structured error in CustomLayout and increase test coverage

* Add structured error & its test in ListBody

* Add structured error in ProxyBox and increase test coverage

* Add structured error message in Viewport

* Fix styles and add more assertions on ErrorHint and DiagnosticProperty

* Add structured error in scheduler/binding and scheduler/ticker

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in AssetBundle and TextInput

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured errors in several widgets #1

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove unused import

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add assertions on hint messages

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix catch spacing

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in several widgets part 2 and increase code coverage

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in flutter_test/widget_tester

* Fix floating precision accuracy by using RegExp

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove todo to add tests in Scaffold showBottomSheet

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix reviews by indenting lines and fixing the assertion orders

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix failing tests due to renaming class

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Try skipping the NetworkBundleTest

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove leading space in material/debug error hint

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
 2019-10-28 11:00:49 -07:00
Shi-Hao Hong
734ddd3103
Make DropdownButton's disabledHint and hint behavior consistent (#42479) 
* Fix DropdownButton disabledHint behavior

* Fix hint behavior when selectedItemBuilder is null

* Improve variable names, some formatting updates

* Create _DropdownMenuItemContainer widget

* Improve API docs to be consistent with hint/disabledHint actual behavior
 2019-10-28 11:00:33 -07:00
Justin McCandless
109f25588d
No multiline password fields (#42470) 
Use assertions to prevent multiline password fields from being created
 2019-10-28 10:59:26 -07:00
Greg Spencer
8017f63b08
Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384) 
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
 2019-10-28 10:55:11 -07:00
Jonah Williams
b142c9bbdb
catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599) 2019-10-28 10:54:03 -07:00
Jonah Williams
450a72488d
set trace to true for desktop builds (#43577) 2019-10-28 10:27:11 -07:00
Jonah Williams
36d50a48f4
Catch MissingPortFile exception (#43573) 2019-10-28 10:26:43 -07:00
Jonah Williams
d983c1d1ae
Ensure Chrome is closed on tab close (#43586) 2019-10-28 10:26:18 -07:00
engine-flutter-autoroll
c31cd0717c
Roll engine 6c257df8e7b9..869b74eb4eca (15 commits) (#43637) 
git@github.com:flutter/engine.git/compare/6c257df8e7b9...869b74eb4eca

git log 6c257df8e7b9..869b74eb4eca --no-merges --oneline
2019-10-28 bkonyi@google.com Roll src/third_party/dart 207082714c..5b7c981086 (2 commits)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from eUAUP... to urhvj... (flutter/engine#13385)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x1rDE... to 9MM-e... (flutter/engine#13383)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 01b1f63d641b..428b5de64a08 (1 commits) (flutter/engine#13382)
2019-10-28 bkonyi@google.com Roll src/third_party/dart d166b0be1c..207082714c (7 commits)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 62160f2f358a..01b1f63d641b (1 commits) (flutter/engine#13380)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 1SdS3... to eUAUP... (flutter/engine#13379)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from SbuUq... to x1rDE... (flutter/engine#13378)
2019-10-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia ff82e15d014a..62160f2f358a (1 commits) (flutter/engine#13377)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from zvXL3... to 1SdS3... (flutter/engine#13376)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from qmqw-... to SbuUq... (flutter/engine#13375)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from eUB9h... to zvXL3... (flutter/engine#13373)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from oeFc8... to qmqw-... (flutter/engine#13372)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fHxWy... to eUB9h... (flutter/engine#13371)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Tbg2V... to oeFc8... (flutter/engine#13370)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 13:08:06 -04:00
Zachary Anderson
0dfabb2ae1
[flutter_tool] Use engine flutter_runner prebuilts (#43381) 
* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
 2019-10-28 09:38:08 -07:00
Jonah Williams
ab260bacd2
Refactor BuildMode into class, add jit_release configuration (#42476) 2019-10-28 09:37:29 -07:00
engine-flutter-autoroll
84299aeb16
6c257df8e Roll src/third_party/dart 6354b0b97d..d166b0be1c (4 commits) (#43563) 
git@github.com:flutter/engine.git/compare/3ebf00690418...6c257df8e7b9

git log 3ebf00690418..6c257df8e7b9 --no-merges --oneline
2019-10-26 bkonyi@google.com Roll src/third_party/dart 6354b0b97d..d166b0be1c (4 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-28 12:24:20 -04:00
Emmanuel Garcia
5bc7fb6835
Revert "Migrate examples to the Android embedding v2 (#43221)" (#43611) 
This reverts commit b49ffa81c1b2088c3d22e61dc2a764f7078cca50.
 2019-10-27 21:25:13 -07:00
engine-flutter-autoroll
80b526ea62
3ebf00690 Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202) (flutter/engine#13349) (#43562) 
git@github.com:flutter/engine.git/compare/1c104d435994...3ebf00690418

git log 1c104d435994..3ebf00690418 --no-merges --oneline
2019-10-26 matthew-carroll@users.noreply.github.com Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202) (flutter/engine#13349)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-26 01:18:06 -04:00
Emmanuel Garcia
b49ffa81c1
Migrate examples to the Android embedding v2 (#43221) 2019-10-25 22:03:49 -07:00