16560 Commits

Author SHA1 Message Date
engine-flutter-autoroll
50112f3cdc
88734cc9e Roll src/third_party/dart 17ed3cb5b3..cccb9ffb2a (2 commits) (#43330)
git@github.com:flutter/engine.git/compare/f0a2850b356d...88734cc9ef53

git log f0a2850b356d..88734cc9ef53 --no-merges --oneline
2019-10-23 bkonyi@google.com Roll src/third_party/dart 17ed3cb5b3..cccb9ffb2a (2 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-23 14:20:06 -04:00
engine-flutter-autoroll
a817b4e6a4
f0a2850b3 Roll src/third_party/skia 1ab27a2b5c5f..4d727acb2455 (3 commits) (flutter/engine#13304) (#43322)
git@github.com:flutter/engine.git/compare/d3e38d28a3e5...f0a2850b356d

git log d3e38d28a3e5..f0a2850b356d --no-merges --oneline
2019-10-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1ab27a2b5c5f..4d727acb2455 (3 commits) (flutter/engine#13304)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-23 03:14:06 -04:00
engine-flutter-autoroll
37521710aa
Roll engine b5a33d4d6a10..d3e38d28a3e5 (5 commits) (#43317)
git@github.com:flutter/engine.git/compare/b5a33d4d6a10...d3e38d28a3e5

git log b5a33d4d6a10..d3e38d28a3e5 --no-merges --oneline
2019-10-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _PqfD... to 4TVGx... (flutter/engine#13303)
2019-10-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from xGLLm... to bQlPz... (flutter/engine#13302)
2019-10-23 bkonyi@google.com Roll src/third_party/dart 4ab09db0f4..17ed3cb5b3 (10 commits)
2019-10-23 franciscojma@google.com Send flag modified events to the framework (flutter/engine#13269)
2019-10-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2638f3d44b02..1ab27a2b5c5f (8 commits) (flutter/engine#13299)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-23 02:10:06 -04:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert (#43315) 2019-10-22 22:05:00 -07:00
James D. Lin
83704b1d91
Make ProjectFileInvalidator.findInvalidated able to use the async FileStat.stat (#42028)
Empirical measurements indicate on the network file system we use
internally, using `FileStat.stat` on thousands of files is much
faster than using `FileStat.statSync`. (It can be slower for files
on a local SSD, however.)

Add a flag to `ProjectFileInvalidator.findInvalidated` to let it
use `FileStat.stat` instead of `FileStat.statSync` when scanning for
modified files.  This can be enabled by overriding `HotRunnerConfig`.

I considered creating a separate, asynchronous version of
`findInvalidated`, but that led to more code duplication than I
liked, and it would be harder to avoid drift between the versions.
2019-10-22 20:48:23 -07:00
Taufiq Rahman
35adf72c7f Add smallestScreenSize to android:configChanges in the Android manifest template (#43245) 2019-10-22 20:46:18 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode (#43225) 2019-10-22 20:35:43 -07:00
Jonah Williams
79a985f9fd
Add compiler configuration to support dartdevc target (#43281) 2019-10-22 20:35:05 -07:00
engine-flutter-autoroll
58c46a83ce
Roll engine a064063e3f63..b5a33d4d6a10 (17 commits) (#43308)
git@github.com:flutter/engine.git/compare/a064063e3f63...b5a33d4d6a10

git log a064063e3f63..b5a33d4d6a10 --no-merges --oneline
2019-10-23 chinmaygarde@google.com Allow embedders to update preferrred locales. (flutter/engine#13238)
2019-10-23 jason-simmons@users.noreply.github.com Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter/engine#13298)
2019-10-22 ferhat@gmail.com [web] Cupertino dynamic color fix. (flutter/engine#13296)
2019-10-22 bkonyi@google.com Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits)
2019-10-22 garyq@google.com Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter/engine#13242)
2019-10-22 ferhat@gmail.com Fix decode feature detection in HtmlCodec (flutter/engine#13274)
2019-10-22 chinmaygarde@google.com Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295)
2019-10-22 gw280@google.com Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291)
2019-10-22 hterkelsen@users.noreply.github.com Flesh out the CanvasKit backend some more (flutter/engine#13275)
2019-10-22 rmacnak@google.com Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294)
2019-10-22 chinmaygarde@google.com Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292)
2019-10-22 jason-simmons@users.noreply.github.com Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290)
2019-10-22 bkonyi@google.com Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (flutter/engine#13287)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-22 23:16:06 -04:00
Jonah Williams
c896ab74a6
skip failing web test to make build green(#43296) 2019-10-22 16:55:48 -07:00
Albertus Angga Raharja
6c04a2a1bd
Properly throw error when CupertinoPageRoute builder returns null (#42602) 2019-10-22 14:24:29 -07:00
engine-flutter-autoroll
a35c874f7e
Roll engine 39e6901e6395..a064063e3f63 (9 commits) (#43279)
git@github.com:flutter/engine.git/compare/39e6901e6395...a064063e3f63

git log 39e6901e6395..a064063e3f63 --no-merges --oneline
2019-10-22 a-siva@users.noreply.github.com Manual Roll of Dart from a61c775db8...e1c409792c (flutter/engine#13282)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4a152d340f06..f3f8ac37e468 (1 commits) (flutter/engine#13283)
2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from hALu4... to xGLLm... (flutter/engine#13284)
2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _e7Up... to _PqfD... (flutter/engine#13285)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 81e8d3b29662..4a152d340f06 (2 commits) (flutter/engine#13281)
2019-10-22 vsm@google.com Enable/tweak web sdk source maps, take 2 (flutter/engine#13161)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 56f569d9bec2..81e8d3b29662 (7 commits) (flutter/engine#13277)
2019-10-22 matthew-carroll@users.noreply.github.com Forwards Activity result to FlutterFragment in FlutterFragmentActivity. (flutter/engine#13214)
2019-10-21 gw280@google.com Ensure we call into Engine from the UI taskrunner in Shell::EngineHasLivePorts (flutter/engine#13265)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-22 15:57:06 -04:00
Jonah Williams
8cac409d90
Clarify hot restart behavior on the web (#42931) 2019-10-22 12:36:56 -07:00
Emmanuel Garcia
f6d3dbd620
[cleanup] Remove unused files (#43188) 2019-10-22 12:25:12 -07:00
Shi-Hao Hong
56f9c950d8
ButtonBar aligns in column when it overflows horizontally (#43193)
* Custom layout for ButtonBar column when it overflows horizontally
2019-10-22 12:12:10 -07:00
Shi-Hao Hong
547b86a91f
[Android 10] Activity zoom transition (#41935)
* Android 10 zoom transition
2019-10-22 12:09:03 -07:00
engine-flutter-autoroll
4dd509710c
Roll engine 8882bf3c73f5..39e6901e6395 (21 commits) (#43228)
git@github.com:flutter/engine.git/compare/8882bf3c73f5...39e6901e6395

git log 8882bf3c73f5..39e6901e6395 --no-merges --oneline
2019-10-21 iska.kaushik@gmail.com Add recipe changelog (flutter/engine#13270)
2019-10-21 jonahwilliams@google.com fix NPE in accessibility bridge (flutter/engine#13255)
2019-10-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9889d509ed9f..56f569d9bec2 (21 commits) (flutter/engine#13266)
2019-10-21 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from hc4p_... to hALu4... (flutter/engine#13252)
2019-10-21 mouad.debbar@gmail.com [web] Support input action (flutter/engine#13268)
2019-10-21 mouad.debbar@gmail.com [web] Support -j to use goma in felt build (flutter/engine#13259)
2019-10-21 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 30Ua7... to _e7Up... (flutter/engine#13254)
2019-10-21 jason-simmons@users.noreply.github.com Hold a reference to the Skia unref queue in UIDartState (flutter/engine#13239)
2019-10-21 jason-simmons@users.noreply.github.com Do not attempt to drain the SkiaUnrefQueue in the destructor (flutter/engine#13237)
2019-10-21 bkonyi@google.com Updated license script to ignore testdata directories, which often contain object files and other compilation results (flutter/engine#13261)
2019-10-21 iska.kaushik@gmail.com Add templates to generate fuchsia host bundles (flutter/engine#13158)
2019-10-21 garyq@google.com Update ui.instantiateImageCodec docs to reflect what it does. (flutter/engine#13233)
2019-10-21 hterkelsen@users.noreply.github.com Update CanvasKit to 0.7.0 and flesh out painting (flutter/engine#13240)
2019-10-19 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from CYDvx... to 30Ua7... (flutter/engine#13251)
2019-10-19 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 0JpMS... to hc4p_... (flutter/engine#13250)
2019-10-19 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from bdTv5... to CYDvx... (flutter/engine#13249)
2019-10-19 skia-flutter-autoroll@skia.org Roll src/third_party/skia c65eb34d2f37..9889d509ed9f (1 commits) (flutter/engine#13248)
2019-10-19 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from SevlL... to 0JpMS... (flutter/engine#13244)
2019-10-19 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7605c89c00f7..c65eb34d2f37 (3 commits) (flutter/engine#13243)
2019-10-19 bkonyi@google.com Ignore *.obj files when gathering licenses (flutter/engine#13241)
2019-10-18 garyq@google.com Roll buildroot to 994c6 (flutter/engine#13236)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-22 14:55:23 -04:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert (#42491)" (#43235)
This reverts commit 3597bae6a0b15c446afd291679b0221340a1a7e2.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0 Extra defensive programming for pub modification time assert (#42491) 2019-10-21 20:15:20 -07:00
Kate Lovett
3a3939a7fa
Revert "Skia Gold Support for Local & PreSubmit Testing in package:flutter (#40710)" (#43227)
This reverts commit 8df0d6556dd5ce5931fe79c8b177d7930d188c1f.
2019-10-21 17:31:54 -07:00
Jonah Williams
22f0bf87e4
Silence presubmit codecov checks (#43183) 2019-10-21 16:54:02 -07:00
Emmanuel Garcia
e82ddc4c7a
Ensure android.enableR8 is appended to a new line (#43187) 2019-10-21 16:52:30 -07:00
Jonah Williams
27105cba2f
switch dart2js build to depfile, remove Source.function (#42977) 2019-10-21 16:46:44 -07:00
Jonah Williams
6c91a13731
Adding missing break in plugin validation check (#43180) 2019-10-21 16:46:07 -07:00
Kate Lovett
8df0d6556d
Skia Gold Support for Local & PreSubmit Testing in package:flutter (#40710) 2019-10-21 16:45:56 -07:00
Jonah Williams
31a4ff80c7
add samsungexynos7570 to list of known physical devices (#43042) 2019-10-21 16:45:48 -07:00
Kate Lovett
83878683c0
Re-landing SliverAnimatedList (#42485) 2019-10-21 16:44:55 -07:00
Jonah Williams
6db4c44da8
remove period from URL so that it opens correctly in vscode (#43200) 2019-10-21 16:43:11 -07:00
engine-flutter-autoroll
ce2d8ace2f
8882bf3c7 Avoid dereferencing IO manager weak pointers on the UI thread (flutter/engine#13232) (#43045)
git@github.com:flutter/engine.git/compare/8aefcd857508...8882bf3c73f5

git log 8aefcd857508..8882bf3c73f5 --no-merges --oneline
2019-10-18 jason-simmons@users.noreply.github.com Avoid dereferencing IO manager weak pointers on the UI thread (flutter/engine#13232)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-21 19:43:06 -04:00
Emmanuel Garcia
30493a35b6
Test Gradle on Windows (#42709) 2019-10-21 16:42:46 -07:00
Christopher Fujino
898e6fe3c6
comment out fastlane test archiving (#43207) 2019-10-21 15:25:55 -07:00
Ian Hickson
584ee10c68 Disable CI tests that LUCI is failing (#43149) 2019-10-21 07:49:28 -07:00
Ian Hickson
d09ed19ee9 Disable CI tests that LUCI is failing (2) (#43150) 2019-10-21 07:49:21 -07:00
Tong Mu
1c535de7e0
Soften layer breakage (#42953)
* Replace hard break of Layer.find/All with findAllAnnotations
* Deprecate findAll
2019-10-18 16:40:42 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
engine-flutter-autoroll
40b1335a87
8aefcd857 Roll src/third_party/skia f4b3d6b9f3d1..7605c89c00f7 (10 commits) (flutter/engine#13234) (#43039)
git@github.com:flutter/engine.git/compare/ee91881ccc8f...8aefcd857508

git log ee91881ccc8f..8aefcd857508 --no-merges --oneline
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia f4b3d6b9f3d1..7605c89c00f7 (10 commits) (flutter/engine#13234)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 18:48:06 -04:00
Edman P. Anjos
faa514fc24 Quick fix on material dialog docs (#42968) 2019-10-18 15:43:04 -07:00
Aditya Sharma
b6c865ff9c Fix typo (#42922) 2019-10-18 15:42:28 -07:00
Jonah Williams
39e4d9d152
Expand scope of rethrown gradle errors (#42966) 2019-10-18 14:56:39 -07:00
engine-flutter-autoroll
f7018c2a47
ee91881cc Adds Dark Mode support to new Android embedding (this was accidentally missed previously). (flutter/engine#13215) (#43032)
git@github.com:flutter/engine.git/compare/98e6d15663b0...ee91881ccc8f

git log 98e6d15663b0..ee91881ccc8f --no-merges --oneline
2019-10-18 matthew-carroll@users.noreply.github.com Adds Dark Mode support to new Android embedding (this was accidentally missed previously). (flutter/engine#13215)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 17:37:06 -04:00
engine-flutter-autoroll
ac012c5f1b
Roll engine dea7150f33fd..98e6d15663b0 (3 commits) (#43027)
git@github.com:flutter/engine.git/compare/dea7150f33fd...98e6d15663b0

git log dea7150f33fd..98e6d15663b0 --no-merges --oneline
2019-10-18 mouad.debbar@gmail.com Preserve stdout colors of subprocesses run by felt (flutter/engine#13209)
2019-10-18 ferhat@gmail.com [web] Fix canvas reuse metrics. Refactor drawVertices code. (flutter/engine#13190)
2019-10-18 jfedor@jfedor.org Add repeatCount to FlutterKeyEvent (flutter/engine#13176)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 16:51:06 -04:00
Emmanuel Garcia
29afbe0d8c
Remove GeneratedPluginRegistrant.java (#42981) 2019-10-18 13:11:33 -07:00
Jonah Williams
6fc99e98ad
rename headless server to web server (#42970) 2019-10-18 12:41:47 -07:00
Jonah Williams
21be8372c9
implement debugTogglePlatform for the web (#42951) 2019-10-18 12:41:15 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode (#43016) 2019-10-18 12:40:50 -07:00
engine-flutter-autoroll
5db53aee5e
Roll engine 7a621a7f7e4f..dea7150f33fd (4 commits) (#43023)
git@github.com:flutter/engine.git/compare/7a621a7f7e4f...dea7150f33fd

git log 7a621a7f7e4f..dea7150f33fd --no-merges --oneline
2019-10-18 50856934+nturgut@users.noreply.github.com Adding firefox_installer.dart (flutter/engine#13185)
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _G94w... to bdTv5... (flutter/engine#13228)
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia b80d31f8cbe2..f4b3d6b9f3d1 (1 commits) (flutter/engine#13229)
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KNygX... to SevlL... (flutter/engine#13227)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 15:34:06 -04:00
Erick (CptBlackPixel)
12b7b08da5 Reading deviceId for RawKeyEventDataAndroid event (#42235)
This PR adds a new property on RawKeyEventDataAndroid to hold the deviceId from which that event was generated. The deviceId is been sent from the engine on the changes from this PR: flutter/engine#12958

With this, we will be able to identify from where the event came from, adding the ability to support local multiplayer games, with multiple gamepads.
2019-10-18 12:32:21 -07:00
Greg Spencer
560873af92
Wire up canRequestFocus and skipTraversal in FocusScopeNode (#43013)
This adds a canRequestFocus and skipTraversal argument to FocusScope and FocusScopeNode, so that a scope can prevent being traversed.

This allows a fix for a problem in the gallery where the focus while traversing the list of items would sometimes appear to disappear, since it would be focusing things that were in the backdrop that were part of the tree, but were not visible.

Related Issues
Fixes #42955
2019-10-18 12:31:15 -07:00
Greg Spencer
df76354488
Add a Focus node to the DropdownButton, and adds an activation action for it. (#42811)
This adds a Focus node to the DropdownButton widget, allowing it to receive keyboard focus, and to show a focus highlight. In addition, I added the ability to activate the dropdown using the "enter" key binding (which is bound to ActivateAction in the WidgetsApp).

Related Issues
Fixes #42646
Fixes #43008
Fixes #42511
2019-10-18 12:30:40 -07:00
Christopher Fujino
18ff9a24db
temporarily disable system_debug_ios devicelab test (#43026) 2019-10-18 12:28:46 -07:00