firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,999 Commits 1 Branch 0 Tags
Commit Graph

16999 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
godofredoc
1657075914
Move technical_debt_cost to use a cloud vm. (#45996) 2019-12-04 16:26:41 -08:00
Greg Spencer
f7d1616173
Overridable default platform key bindings (#45102) 
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
 2019-12-04 16:07:01 -08:00
Kate Lovett
9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Emmanuel Garcia
9e94eb93bc
Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Christopher Fujino
d88345e726 only run codecov on master (#46100) 2019-12-04 15:18:01 -08:00
engine-flutter-autoroll
f213f92587
Roll engine 07aab98212cb..fdaa7cf12175 (2 commits) (#46095) 
git@github.com:flutter/engine.git/compare/07aab98212cb...fdaa7cf12175

git log 07aab98212cb..fdaa7cf12175 --first-parent --oneline
2019-12-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from OSk8h... to XCAOU... (#14128)
2019-12-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 75368c3a0290..ccca30aad770 (12 commits) (#14129)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-04 14:04:28 -05:00
Greg Spencer
09927b94c3
Add a VisualDensity manual test (#46083) 
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
 2019-12-04 10:48:06 -08:00
Janice Collins
50c8e6b2d6
Update dartdoc to 0.29.2. (#46014) 2019-12-04 09:59:16 -08:00
Christopher Fujino
dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
engine-flutter-autoroll
19f8f497f4
07aab9821 Fix one more use of deprecated path fill type API (flutter/engine#14127) (#46092) 
git@github.com:flutter/engine.git/compare/1cdfc99314df...07aab98212cb

git log 1cdfc99314df..07aab98212cb --first-parent --oneline
2019-12-04 brianosman@google.com Fix one more use of deprecated path fill type API (#14127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-04 12:55:27 -05:00
Brian Egan
3ea8c87ce9
Api Samples and Diagrams for 10 more classes / functions (#45603) 
* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"
 2019-12-04 13:27:23 +01:00
Alexandre Ardhuin
4956bcc2f9
implicit-casts:false in flutter_driver (#45175) 
* implicit-casts:false in flutter_driver

* address review comments
 2019-12-04 11:10:50 +01:00
Alexandre Ardhuin
a5f9b3b036
implicit-casts:false in flutter/lib/src/rendering (#45720) 
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
 2019-12-04 10:27:04 +01:00
Alexandre Ardhuin
166d422b05
implicit-casts:false in flutter/lib/src/widgets (#45728) 
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
 2019-12-04 09:43:54 +01:00
engine-flutter-autoroll
54e7b2ba62
1cdfc9931 Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (flutter/engine#14107) (#46059) 
git@github.com:flutter/engine.git/compare/3e6d6bc612fd...1cdfc99314df

git log 3e6d6bc612fd..1cdfc99314df --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (#14107)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-04 03:31:08 -05:00
Alexandre Ardhuin
4049460d31
implicit-casts:false in flutter/lib/src/semantics (#45722) 2019-12-04 08:59:19 +01:00
Alexandre Ardhuin
1c7a1c3873
implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
engine-flutter-autoroll
f908e18287
3e6d6bc61 add pointer data santizing in flutter web engine (flutter/engine#14082) (#46049) 
git@github.com:flutter/engine.git/compare/90e28c027c0b...3e6d6bc612fd

git log 90e28c027c0b..3e6d6bc612fd --first-parent --oneline
2019-12-04 47866232+chunhtai@users.noreply.github.com add pointer data santizing in flutter web engine (#14082)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 23:44:08 -05:00
Sebastian Döll
417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Jacek Marchwicki
50532f387a [Driver] correct type for getWidgetDiagnostics (#45985) 2019-12-03 20:33:02 -08:00
Zachary Anderson
4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Todd Volkert
066a992a5c
Ensure that docker tag is legal (#46035) 2019-12-03 19:53:39 -08:00
Todd Volkert
4c95bbd1c6
Re-enable hostonly tests on non-master branches (#46037) 
This is a follow-on to #45455 - the test failures indicated a
real problem, so re-enabling the tests on non-master.

https://github.com/flutter/flutter/issues/45453
 2019-12-03 19:53:28 -08:00
Greg Spencer
185da9b0af
Add Density API to ThemeData, implement for buttons. (#43547) 
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
 2019-12-03 19:49:56 -08:00
Michael Goderbauer
1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
engine-flutter-autoroll
1b05cb2b1c
Roll engine 617938024315..90e28c027c0b (3 commits) (#46043) 
git@github.com:flutter/engine.git/compare/617938024315...90e28c027c0b

git log 617938024315..90e28c027c0b --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 89e31069e8..19fc1016da (6 commits) (#14093)
2019-12-03 dworsham@google.com Relanding: Add Flow unittests and fixtures (#14091)
2019-12-03 bkonyi@google.com Roll src/third_party/dart a4d799c402..89e31069e8 (14 commits) (#14089)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 22:46:08 -05:00
Emmanuel Garcia
09126abb22
Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
engine-flutter-autoroll
50d81a0b8a
Roll engine 1a96087747ac..617938024315 (5 commits) (#46023) 
git@github.com:flutter/engine.git/compare/1a96087747ac...617938024315

git log 1a96087747ac..617938024315 --first-parent --oneline
2019-12-03 caseyhillers@gmail.com Update fallback to Roboto url to be HTTPS (#14086)
2019-12-03 iska.kaushik@gmail.com Revert "Fix fml_unittests (#14062)" (#14087)
2019-12-03 liyuqian@google.com Revert PRs to unblock David and Jim's work (#14088)
2019-12-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085)
2019-12-03 bkonyi@google.com Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 20:41:08 -05:00
Ian Hickson
97495d8938
Simplify logging code in flutter_driver (#45945) 
* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206ef457fcd59b203544244a9bedf0a9ac31 (PR #45924).
 2019-12-03 17:14:43 -08:00
Ian Hickson
2991dc28a5
Update PULL_REQUEST_TEMPLATE.md (#45944) 
Update for recent changes to policies.
 2019-12-03 14:19:29 -08:00
Dan Field
b61dec79c7
Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Jonah Williams
b96d818c19
Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
engine-flutter-autoroll
a484db665a
1a9608774 Update to newer path fill-type API in Skia (flutter/engine#14070) (#46002) 
git@github.com:flutter/engine.git/compare/faa11214c09b...1a96087747ac

git log faa11214c09b..1a96087747ac --first-parent --oneline
2019-12-03 brianosman@google.com Update to newer path fill-type API in Skia (#14070)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 15:17:09 -05:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Jonah Williams
c95dafc4c6
Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams
0dace48932
Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams
0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
engine-flutter-autoroll
8e92ba07ce
Roll engine 8672e79af873..faa11214c09b (7 commits) (#45986) 
git@github.com:flutter/engine.git/compare/8672e79af873...faa11214c09b

git log 8672e79af873..faa11214c09b --first-parent --oneline
2019-12-03 liyuqian@google.com Run benchmarks in Cirrus (#13950)
2019-12-03 stuartmorgan@google.com Report backing store changes in the macOS view (#13933)
2019-12-03 franciscojma@google.com Listen to keyUp event on meta modified keys (#13984)
2019-12-02 dnfield@google.com Fix live region logic (#14081)
2019-12-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia e8c96d8e6116..2792515dab7c (1 commits) (#14069)
2019-12-02 bkonyi@google.com Roll src/third_party/dart 3f32196958..e4344a568f (1 commits) (#14073)
2019-12-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from aVdHP... to 6QxEZ... (#14080)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 10:01:09 -05:00
engine-flutter-autoroll
7ea0d4d8e3
Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45918) 
git@github.com:flutter/engine.git/compare/6c605f8a9624...8672e79af873

git log 6c605f8a9624..8672e79af873 --first-parent --oneline
2019-11-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (#14065)
2019-11-28 hterkelsen@users.noreply.github.com Fallback to Roboto if no suitable font is found (#14061)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-03 09:14:04 -05:00
Alexandre Ardhuin
1ae5d676e5
implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Jonah Williams
8a9897c84c
Revert "update macOS configuration settings (#45920)" (#45965) 
This reverts commit 3b2042a02875f70d0c768cb16f72969568cd545f.
 2019-12-02 21:34:41 -08:00
Jonah Williams
9708e7d16a
use package-scheme imports for generated web entrypoint (#45934) 2019-12-02 21:10:08 -08:00
Jonah Williams
3b2042a028
update macOS configuration settings (#45920) 2019-12-02 21:06:38 -08:00
godofredoc
4c4cdbfc2b
Move dartdocs to devicelab vm. (#45952) 
We added support linux VMs to devicelab and we will be moving some of
the machine independent benchmarks there.
 2019-12-02 19:45:04 -08:00
Dan Field
c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Jonah Williams
df0b3fed7b
fix lint applied after PR was opened (#45953) 2019-12-02 17:31:11 -08:00
Greg Spencer
37f86c3195
Clean up some things I noticed while doing another change (#45658) 
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
 2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00