16999 Commits

Author SHA1 Message Date
Jonah Williams
b63683b6cd
Update configuration for flutter features (#45914) 2019-12-02 17:06:41 -08:00
Jonah Williams
8cf20f3be7
Dont crash on malformed packages.json (#45786) 2019-12-02 17:04:37 -08:00
Kate Lovett
0ce9206ef4
Revert "Make all of the driver interface public. (#45733)" (#45924)
This reverts commit f2445002b256e3def20564fe39ea86484c7ef508.
2019-12-02 17:02:59 -08:00
Kate Lovett
cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cdb70c77368c04aaed39ca4791cad539.
2019-12-02 15:08:35 -08:00
Emmanuel Garcia
8c25328014
Handle case where lastLogcatTimestamp is null (#45937) 2019-12-02 15:02:11 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Dan Field
088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Tong Mu
afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Michael Goderbauer
8954ee85dd
Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00
Kaushik Iska
3994872073
Sample driver test working on Fuchsia (#45652)
* [flutter_driver] [fuchsia] Validate existance of cmx for driver tests

Also added an example driver test that can run on Fuchsia devices.

Fixes: https://github.com/flutter/flutter/issues/45624

* update packages for stock example

* fix licenses
2019-12-02 12:56:16 -08:00
Zachary Anderson
02bca1342d
Revert "Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45817)" (#45916)
This reverts commit b9a56b9f48462d897101284f5f57b8568ef683c6.
2019-12-02 11:13:19 -08:00
engine-flutter-autoroll
b9a56b9f48 Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45817)
* 8d6fa7e85 Fallback to Roboto if no suitable font is found (flutter/engine#14061)

* 8672e79af Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (flutter/engine#14065)
2019-11-29 20:40:44 -05:00
engine-flutter-autoroll
1e50db60ad Roll engine 4bdd15cd5438..6c605f8a9624 (3 commits) (#45746)
* a86ef9465 Dynamically determine whether to use offscreen surface based on need (flutter/engine#13976)

* 0fc7867ae Roll src/third_party/dart 96e7a4ff30..73fdf19b56 (3 commits) (flutter/engine#14063)

* 6c605f8a9 Fix fml_unittests (flutter/engine#14062)
2019-11-29 09:17:52 -05:00
Gary Qian
d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d794360bb7d3ff7bf2f6dfbcbd58516c3f20.
2019-11-28 19:42:06 +09:00
engine-flutter-autoroll
714650d7e4 Roll engine 35937eb31240..4bdd15cd5438 (5 commits) (#45741)
* 29b2e91f1 Include uncommitted files when checking for code format issues. (flutter/engine#14035)

* 7a7118d0a Roll src/third_party/skia 861ac61cb1a9..c96f5108df28 (10 commits) (flutter/engine#14059)

* bc07e6a23 [web] Initial support for LineMetrics (flutter/engine#13985)

* bcb826759 Revert "Do not default to downstream affinity on iOS insertText (#13852)" (flutter/engine#14053)

* 4bdd15cd5 more tests for enabling semantics (flutter/engine#14060)
2019-11-27 20:54:32 -05:00
Emmanuel Garcia
475ee89879
Make Android log reader read any recent logs (#45743) 2019-11-27 17:52:36 -08:00
Jenn Magder
e2642fd6c0
Do not delete output directory during flutter build ios-framework (#45740) 2019-11-27 17:48:19 -08:00
Ian Hickson
f2445002b2
Make all of the driver interface public. (#45733)
We keep finding things that we've accidentally not made public. The
pattern we use elsewhere in the platform is to just export everything,
to avoid encouraging people from importing `src/` files directly.
2019-11-27 16:26:05 -08:00
Ian Hickson
a78fb87dfe
Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
engine-flutter-autoroll
3cacad5b5e Roll engine fad1b23c42b9..35937eb31240 (3 commits) (#45725)
* f61bec846 Pass "null" when copy data is null to iOS pasteboard.string (flutter/engine#14046)

* 268107d2f fixing the method call for testing semantics (flutter/engine#14056)

* 35937eb31 Roll src/third_party/dart 134e0e28cd..96e7a4ff30 (38 commits) (flutter/engine#14058)
2019-11-27 19:12:20 -05:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Chris Bracken
dc49fa2140
Eliminate commented-out code (#45726)
This appears to have been inadvertently added in #37497 (333c961).

The code in question already exists in `_PlatformViewGestureMixin`, which
`PlatformViewRenderBox` (where it was added) mixes in.
2019-11-27 14:50:15 -08:00
Ian Hickson
f87c5102af
Add more documentation around layers. (#45648) 2019-11-27 14:22:48 -08:00
Jonah Williams
59ca523b2c
Support web-server/profile/release mode with incremental compiler support for web (#45713) 2019-11-27 13:32:45 -08:00
Jonah Williams
598f2ab0fb
Cleanups to resident runner and flutter device classes (#45673) 2019-11-27 13:11:04 -08:00
Chris Bracken
b39949ff09
Fix parameter name: handlePointerEvent (#45717)
Removes an unnecessary leading underscore from a parameter name. The
parameter type is library private, but parameters cannot be 'private'.
2019-11-27 12:48:43 -08:00
liyuqian
264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
Alexandre Ardhuin
5ccd4f3430
implicit-casts:false in flutter/lib/src/physics (#45622) 2019-11-27 21:28:45 +01:00
LongCatIsLooong
37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Kate Lovett
1374a41313
Provide debug output for Gold uploads on post-submit (#45704) 2019-11-27 11:29:53 -08:00
Zachary Anderson
e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' (#45628) 2019-11-27 10:18:43 -08:00
Takeshi Tsukamoto
876303b3f9 Fix comment (#45325) 2019-11-27 10:01:57 -08:00
engine-flutter-autoroll
84a1de5c74
fad1b23c4 Roll fuchsia/sdk/core/linux-amd64 from xyyOR... to mSEnz... (flutter/engine#14043) (#45689)
git@github.com:flutter/engine.git/compare/18d74fe45b9c...fad1b23c42b9

git log 18d74fe45b9c..fad1b23c42b9 --first-parent --oneline
2019-11-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xyyOR... to mSEnz... (#14043)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-27 07:40:51 -05:00
Danny Tuppeny
4741e9c3fe
Retry Xcode builds if they fail due to concurrent builds running (#45608)
* Retry Xcode builds if they fail due to concurrent builds running

Fixes #40576.

* Add tests for concurrent iOS launches

* Increase number of retries to account for the initial build being slow
2019-11-27 09:44:05 +00:00
engine-flutter-autoroll
3e3b49e132
18d74fe45 Show test output when engine unit test fails. (flutter/engine#14026) (#45675)
git@github.com:flutter/engine.git/compare/e3e5f8dabc2e...18d74fe45b9c

git log e3e5f8dabc2e..18d74fe45b9c --first-parent --oneline
2019-11-27 flar@google.com Show test output when engine unit test fails. (#14026)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-27 02:59:51 -05:00
engine-flutter-autoroll
1b835a722b
e3e5f8dab Adding support for enabling semantics on desktop (flutter/engine#14003) (#45667)
git@github.com:flutter/engine.git/compare/2c0eee43923f...e3e5f8dabc2e

git log 2c0eee43923f..e3e5f8dabc2e --first-parent --oneline
2019-11-27 50856934+nturgut@users.noreply.github.com Adding support for enabling semantics on desktop (#14003)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 23:48:51 -05:00
engine-flutter-autoroll
3d4ceaf460
Roll engine 5250d6315e7a..2c0eee43923f (2 commits) (#45663)
git@github.com:flutter/engine.git/compare/5250d6315e7a...2c0eee43923f

git log 5250d6315e7a..2c0eee43923f --first-parent --oneline
2019-11-26 garyq@google.com Always set mEditable values when different in TextPlugin (#13951)
2019-11-26 dnfield@google.com Avoid retaining self in block (#14022)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 22:40:51 -05:00
Kaushik Iska
d1805aa22a
update-packages after dwds updates (#45633) 2019-11-26 18:34:06 -08:00
engine-flutter-autoroll
20025e2579
Roll engine 27fa60793bcb..5250d6315e7a (4 commits) (#45659)
git@github.com:flutter/engine.git/compare/27fa60793bcb...5250d6315e7a

git log 27fa60793bcb..5250d6315e7a --first-parent --oneline
2019-11-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 54036c9b8e4b..40a7dfc268b6 (1 commits) (#14016)
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Bxgic... to aVdHP... (#14017)
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from kzFUw... to xyyOR... (#14021)
2019-11-26 chinmaygarde@gmail.com Add a separate target for Dart coverter on FML types. (#14011)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 21:33:51 -05:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
engine-flutter-autoroll
e60c0f6852
27fa60793 Added docstring for FlutterOverlayView. (flutter/engine#14019) (#45642)
git@github.com:flutter/engine.git/compare/e136d637a873...27fa60793bcb

git log e136d637a873..27fa60793bcb --first-parent --oneline
2019-11-26 30870216+gaaclarke@users.noreply.github.com Added docstring for FlutterOverlayView. (#14019)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 19:05:51 -05:00
Jonah Williams
831163f0d0
Register memory info command on vmservice for Android devices (#45568) 2019-11-26 14:49:56 -08:00
Dan Field
2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00
Jenn Magder
7d8f82051b
Suggest GitHub template when flutter tool crashes (#45360)
* On flutter tool crash suggest GitHub template

* Shorten GitHub URLs

* Whitespace

* Wording tweak from @InMatrix

* Review edits
2019-11-26 14:06:31 -08:00
Albertus Angga Raharja
e1512b4dd7
Add additional properties callback in Inspector Serialization Delegate (#45531)
* Add additional properties callback in Inspector Serialization Delegate

* Rename _SerializationDelegate to InspectorSerializationDelegate and add test

* Fix indentation

* Remove trailing whitespace

* Handle case when addAdditionalPropertiesCallback returns null

* Improve docs and minor renames

* Improve docs

* Improve documentation
2019-11-26 13:57:41 -08:00
Greg Spencer
0190e40457
Keyboard scrolling of Scrollable (#45019)
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
2019-11-26 09:56:25 -08:00
Danny Tuppeny
459c7fb884
Resume isolate before terminating tests to prevent flutter_tester leaks in integration tests (#45248)
* Resume isolate before terminating tests to prevent flutter_tester leak

* Fix lint

* Catch exceptions from resume() as well as timeout()

* Formatting fixes

* Don't try to resume if there's no vm service

* Fix handling of timeouts to not leak futures
2019-11-26 17:04:51 +00:00
Christopher Fujino
dc68d5700b
Fix flutter run cache (#45267) 2019-11-26 09:02:34 -08:00
Emmanuel Garcia
943f98d3c3
Add integration test for transitive plugin dependencies (#45579) 2019-11-26 08:58:43 -08:00
engine-flutter-autoroll
b2a36ffcd2
Roll engine 96cba6c92a8a..e136d637a873 (2 commits) (#45616)
git@github.com:flutter/engine.git/compare/96cba6c92a8a...e136d637a873

git log 96cba6c92a8a..e136d637a873 --first-parent --oneline
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 1nxSz... to Bxgic... (#14014)
2019-11-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4f90f9d83183..54036c9b8e4b (4 commits) (#14013)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 11:45:51 -05:00