firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
34,954 Commits 1 Branch 0 Tags
Commit Graph

34954 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Parker Lougheed
c313083a88
Remove null-safety argument from DartPad doc samples (#127345) 
Removes the `null_safety=true` query parameter from DartPad samples in the API docs, since all DartPad channels only support null safety now and the parameter does nothing.

## Test

Removing code, but updates the check in the dartdoc tool for the removal.
 2023-05-23 00:10:11 +00:00
Daniel Iglesia
a6d62ca8de
Support keeping a bottom sheet with a DraggableScrollableSheet from closing on drag/fling to min extent (#127339) 2023-05-22 16:14:35 -07:00
Jackson Gardner
758ea6c096
Fix wasm-opt location when using local_web_sdk (#127355) 
We were looking up the wrong path for `wasm-opt` previously when using the `local-web-sdk` flag.
 2023-05-22 23:08:11 +00:00
engine-flutter-autoroll
7a12d825e2
Roll Flutter Engine from 1ed9fc0caf55 to a342a9186e69 (3 revisions) (#127352) 
1ed9fc0caf...a342a9186e

2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213)
2023-05-22 aam@google.com Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210)
2023-05-22 jonahwilliams@google.com [Impeller] Create reusable prefix sum. (flutter/engine#42167)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 22:26:25 +00:00
LouiseHsu
e345a830ba
Show warning when attempting to flutter run on an ios device with developer mode turned off (#125710) 
This PR adds a warning when a user attempt to `flutter run -d <device id>` on a device without developer mode enabled.
<img width="738" alt="Screenshot 2023-05-09 at 3 53 18 AM" src="https://github.com/flutter/flutter/assets/36148254/6f473a6a-5a0d-438b-9e6f-06d09eb1f3a9">

Also handles multiple partial matches.
<img width="788" alt="Screenshot 2023-05-09 at 3 52 24 AM" src="https://github.com/flutter/flutter/assets/36148254/60c82b3c-d501-4a01-95ad-d6309fe39576">

Fixes https://github.com/flutter/flutter/issues/111988
 2023-05-22 22:06:15 +00:00
Ian Hickson
487ed57388
Suggest that people move to "beta" when they upgrade on "master" (#127146) 
Similar to https://github.com/flutter/flutter/pull/126972 but for master
upgrades.

Co-authored-by: Tim Sneath <timsneath@google.com>
 2023-05-22 15:03:14 -07:00
Andrew Kolos
46a742f025
add test for setting JAVA_HOME and PATH when invoking sdkmanager --licenses (#127344) 
#126086 inadvertently fixed https://github.com/flutter/flutter/issues/124776

This follow-up PR gets the fix under test.
 2023-05-22 20:41:23 +00:00
engine-flutter-autoroll
6e1caadc8c
Roll Flutter Engine from e04c14786d5a to 1ed9fc0caf55 (1 revision) (#127343) 
e04c14786d...1ed9fc0caf

2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from ef226c5a7930 to 2612bb159848 (1 revision) (flutter/engine#42209)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 20:34:27 +00:00
Victor Ohashi
7e3f1df36c
fix: Search anchor box location when used on nested navigator (#127198) 
This PR is to fix the position of `SearchAnchor` when used with nested navigator. This solution is based on what `DropdownButton` internally do, looking to the closest `Navigator` to proper calculate the where to render `SearchViewRoute`.

Fixes: https://github.com/flutter/flutter/issues/126435

<details>
<summary>Test case</summary>

```dart
void main() => runApp(const NestedSearchBarApp());

class NestedSearchBarApp extends StatefulWidget {
  const NestedSearchBarApp({super.key});

  @override
  State<NestedSearchBarApp> createState() => _NestedSearchBarAppState();
}

class _NestedSearchBarAppState extends State<NestedSearchBarApp> {
  final SearchController controller = SearchController();

  @override
  Widget build(BuildContext context) {
    final ThemeData themeData = ThemeData(useMaterial3: true);

    return MaterialApp(
      theme: themeData,
      builder: (BuildContext context, Widget? child) {
        return Scaffold(
          body: Row(
            children: <Widget>[
              NavigationRail(
                selectedIndex: 1,
                destinations: const <NavigationRailDestination>[
                  NavigationRailDestination(
                    icon: Icon(Icons.favorite_border),
                    selectedIcon: Icon(Icons.favorite),
                    label: Text('First'),
                  ),
                  NavigationRailDestination(
                    icon: Icon(Icons.bookmark_border),
                    selectedIcon: Icon(Icons.book),
                    label: Text('Second'),
                  ),
                ],
              ),
              const VerticalDivider(thickness: 1, width: 1),
              Expanded(child: child!)
            ],
          ),
        );
      },
      home: Scaffold(
        appBar: AppBar(title: const Text('Search Anchor Sample')),
        body: Column(
          children: <Widget>[
            SearchAnchor(
                searchController: controller,
                builder: (BuildContext context, SearchController controller) {
                  return IconButton(
                    icon: const Icon(Icons.search),
                    onPressed: () {
                      controller.openView();
                    },
                  );
                },
                suggestionsBuilder:
                    (BuildContext context, SearchController controller) {
                  return List<ListTile>.generate(5, (int index) {
                    final String item = 'item $index';
                    return ListTile(
                      title: Text(item),
                      onTap: () {
                        setState(() {
                          controller.closeView(item);
                        });
                      },
                    );
                  });
                }),
            Center(
              child: controller.text.isEmpty
                  ? const Text('No item selected')
                  : Text('Selected item: ${controller.value.text}'),
            ),
          ],
        ),
      ),
    );
  }
}
```
</details>

<details>
<summary>Before fix:</summary>

![Screenshot 2023-05-19 at 11 55 53](https://github.com/flutter/flutter/assets/38299943/c86747e5-6716-4e87-b3fd-ce7f0f943b92)
</details>

<details>
<summary>After fix:</summary>

![Screenshot 2023-05-19 at 11 53 30](https://github.com/flutter/flutter/assets/38299943/d790ee49-e047-485c-87f4-7254acbdddfa)
</details>
 2023-05-22 20:21:26 +00:00
Christopher Fujino
7e1a0d4086
[flutter_tools] delete entitlements files after copying to macos build dir (#126875) 
Fixes https://github.com/flutter/flutter/issues/126705
 2023-05-22 20:00:39 +00:00
engine-flutter-autoroll
343718945b
Roll Flutter Engine from f0f3fe729a91 to e04c14786d5a (10 revisions) (#127325) 
f0f3fe729a...e04c14786d

2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
NE_eTA29vOHN4goJL... to LrfeC0dLk8ToJVik5... (flutter/engine#42208)
2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
HPZKiLZlLCR6moOCE... to QAwORJOkyNl4J3x4Y... (flutter/engine#42207)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 16c60e5bebfc to
ef226c5a7930 (1 revision) (flutter/engine#42206)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 79088c6b7a33 to
16c60e5bebfc (1 revision) (flutter/engine#42205)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 76303a5498e9 to
79088c6b7a33 (2 revisions) (flutter/engine#42204)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 2d4ea9542e83 to
76303a5498e9 (1 revision) (flutter/engine#42203)
2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
88pzkUAkSKsJrNG38... to NE_eTA29vOHN4goJL... (flutter/engine#42202)
2023-05-21 dkwingsmt@users.noreply.github.com [macOS] Clean up unused
methods in FlutterRenderer (flutter/engine#42196)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JU-dKW3CQIUzhbqWE... to HPZKiLZlLCR6moOCE... (flutter/engine#42201)
2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from 5b2005e47bf3 to
2d4ea9542e83 (1 revision) (flutter/engine#42200)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 88pzkUAkSKsJ to LrfeC0dLk8To
  fuchsia/sdk/core/mac-amd64 from JU-dKW3CQIUz to QAwORJOkyNl4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 11:11:18 -07:00
Justin McCandless
f6f5bb9023
Fix bug in Autocomplete example (#127219) 
This example was incorrectly throwing away results from a query when multiple queries were pending at once.   Thanks to @sun-jiao in https://github.com/flutter/flutter/pull/127019#issuecomment-1552347037 for pointing this out.

I also added a quick  `Text` widget explaining what to do to use the examples.  Since there are only three small possible `options`, it's easy to type into the field and not get any results and wonder what's wrong.
 2023-05-22 16:55:21 +00:00
engine-flutter-autoroll
5b0615c6ab
Roll Packages from 1e214d716ed4 to 83959fb7de37 (9 revisions) (#127322) 
1e214d716e...83959fb7de

2023-05-22 JeroenWeener@users.noreply.github.com [in_app_purchases] Fix mismatching method signature strings (flutter/packages#4040)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) (flutter/packages#4051)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter from 5ae64381578c to 077d644bbc5f (23 revisions) (flutter/packages#4043)
2023-05-19 stuartmorgan@google.com [local_auth] Migrate iOS to Pigeon (flutter/packages#3974)
2023-05-19 hamadyalghanim@gmail.com [go_router] fix context extension for replaceNamed (flutter/packages#3927)
2023-05-19 JeroenWeener@users.noreply.github.com [image_picker] Fix crash due to `SecurityException` (flutter/packages#4004)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 16:10:09 +00:00
engine-flutter-autoroll
fdc6c135ac
Roll Flutter Engine from aac09195688d to f0f3fe729a91 (16 revisions) (#127292) 
aac0919568...f0f3fe729a

2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from 7c7dff949a27 to
5b2005e47bf3 (1 revision) (flutter/engine#42199)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
gQ989rlKAuTJHQR-C... to 88pzkUAkSKsJrNG38... (flutter/engine#42198)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
868_67npyO8nD_JCx... to JU-dKW3CQIUzhbqWE... (flutter/engine#42197)
2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from a60bfcb01af9 to
7c7dff949a27 (1 revision) (flutter/engine#42195)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... (flutter/engine#42194)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from f3e9cb7d37fd to
a60bfcb01af9 (1 revision) (flutter/engine#42193)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... (flutter/engine#42191)
2023-05-20 kjlubick@users.noreply.github.com Move SkSurface::MakeNull to
SkSurfaces::Null (flutter/engine#42158)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from b4a4782cf89d to
f3e9cb7d37fd (1 revision) (flutter/engine#42188)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
pwdDQgM88sqLmZczj... to sfLkc5VBFU6UkljF6... (flutter/engine#42187)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from 7202b405f061 to
b4a4782cf89d (19 revisions) (flutter/engine#42185)
2023-05-20 dnfield@google.com [Impeller] avoid creating multiple
concurrent message loops for Andorid Vulkan (flutter/engine#42146)
2023-05-20 jacksongardner@google.com Implement
`ImageFilter`/`ColorFilter`/`MaskFilter` in Skwasm
(flutter/engine#42088)
2023-05-20 30870216+gaaclarke@users.noreply.github.com [Impeller] Made
other vulkan objects cleanup properly. (flutter/engine#42113)
2023-05-19 coldpalelight@gmail.com [Impeller] Fix the issue that
'coverage_coords' is incorrectly calculated in
'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TWjmvLCOnYAU to 88pzkUAkSKsJ
  fuchsia/sdk/core/mac-amd64 from pwdDQgM88sqL to JU-dKW3CQIUz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 08:28:09 -07:00
林洵锋
883b06666f
Add myself to AUTHORS (#127298) 
I made a few contributions.
-
[flutter/flutter](https://github.com/flutter/flutter/issues?q=author%3ALinXunFeng)
-
[flutter/engine](https://github.com/flutter/engine/pulls?q=author%3ALinXunFeng)
 2023-05-22 07:21:07 -07:00
engine-flutter-autoroll
ab573048e7
Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (#127241) 
482c99af9c...aac0919568

2023-05-19 47866232+chunhtai@users.noreply.github.com Overrides accessibilityScrollToVisible (flutter/engine#42047)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-20 15:32:26 +00:00
Andrew Kolos
80a4f9b159
Reland "[tool] Move Java functions to their own file" (#126577) 
Relands #126086, which was reverted by #126569.
 2023-05-20 06:29:21 +00:00
engine-flutter-autoroll
0a6e1375d8
Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (#127240) 
f0c02aee69...482c99af9c

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from f5716102efe8 to b3e1eeda4918 (1 revision) (flutter/engine#42172)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-20 00:26:21 +00:00
Gil Nobrega
7b16cbcb57
Do not animate TabBarView if controller is invalid (#123442) 2023-05-19 16:43:40 -07:00
keyonghan
784ebdf2a3
Run Mac intel only targets on both intel and arm (#127230) 
The slowness issue was resolved with latest xcode: https://github.com/flutter/flutter/issues/119750, and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots.

This PR updates these targets:

- Mac plugin_test_ios: https://github.com/flutter/flutter/issues/119764
- Mac build_tests: https://github.com/flutter/flutter/pull/120620
- Mac plugin_test: https://github.com/flutter/flutter/pull/120714
- Mac plugin_test_macos: https://github.com/flutter/flutter/pull/122212
- Mac framework_tests_misc: https://github.com/flutter/flutter/pull/122618
 2023-05-19 23:22:25 +00:00
Loïc Sharma
ce61eda70c
[Windows] Ensure window is shown (#127046) 
## Background

The Windows runner has a race at startup:

1. **Platform thread**: creates a hidden window
2. **Platform thread**: launches the Flutter engine
3. **UI/Raster threads**: renders the first frame
4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered.

Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown.

As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](1f09a8662d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp (L60-L64)), can flake if the first frame is rendered before the show window callback has been registered.

## Solution

This change makes the runner schedule a frame after it registers the next frame callback. If step 3 hasn't completed yet, this no-ops as a frame is already scheduled. If step 3 has already completed, a new frame will be rendered, which will call the next frame callback and show the window.

Part of https://github.com/flutter/flutter/issues/119415

See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
 2023-05-19 22:25:55 +00:00
engine-flutter-autoroll
41e4c5867d
Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (#127233) 
3267fa2949...f0c02aee69

2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eal6a4HeaQon_Y4ml... to TWjmvLCOnYAUgAzvT... (flutter/engine#42168)
2023-05-19 chris@bracken.jp [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164)
2023-05-19 110993981+htoor3@users.noreply.github.com [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870)
2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from eal6a4HeaQon to TWjmvLCOnYAU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 22:25:52 +00:00
engine-flutter-autoroll
7bb60446e2
Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (#127224) 
2b14f8a1f2...3267fa2949

2023-05-19 bdero@google.com [Impeller] Limit blur kernel to 1000x1000 pixels (flutter/engine#42154)
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IGeTvUK2wkajmQQ2k... to pwdDQgM88sqLmZczj... (flutter/engine#42163)
2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 0a63dbe8cd15 to 7202b405f061 (1 revision) (flutter/engine#42162)
2023-05-19 jonahwilliams@google.com [Impeller] Fix 1d threadgroup dispatch size, Implement drawPoint geometry computation with compute, fallback to specialized CPU. (flutter/engine#42060)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from IGeTvUK2wkaj to pwdDQgM88sqL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 21:29:21 +00:00
Phil Quitslund
d0c0439b8d
fixes to anticipate next Dart linter release (#127211) 
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases. 

See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
 2023-05-19 21:27:24 +00:00
Kate Lovett
e8b7889dfd
Remove deprecated OverscrollIndicatorNotification.disallowGlow (#127050) 
The deprecated OverscrollIndicatorNotification.disallowGlow has expired and is removed in the PR. The replacement is OverscrollIndicatorNotification.disallowIndicator. This deprecation was introduced in https://github.com/flutter/flutter/pull/87839 when the StretchingOverscrollIndicator was added. The name change made it clearer since there is now more than one overscroll indicator.

This change is supported by dart fix. ✅ 

Part of https://github.com/flutter/flutter/issues/127042
 2023-05-19 19:40:51 +00:00
engine-flutter-autoroll
d211dc141a
Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (#127221) 
f471b37a21...2b14f8a1f2

2023-05-19 jonahwilliams@google.com [Impeller] use host image upload path on simulator (flutter/engine#42161)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 19:16:03 +00:00
Christopher Fujino
e310475fc7
[flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (#127150) 
Fixes https://github.com/flutter/flutter/issues/123621
 2023-05-19 19:14:17 +00:00
Zachary Anderson
31a16f342e
Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (#127218) 
goldctl hasn't been updated in about a year, and an update may be needed to reland https://github.com/flutter/flutter/pull/127110.
 2023-05-19 18:52:50 +00:00
engine-flutter-autoroll
c7b898b101
Roll Packages from b31a12861905 to 1e214d716ed4 (3 revisions) (#127217) 
b31a128619...1e214d716e

2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter from d0d1feb6283f to 5ae64381578c (42 revisions) (flutter/packages#4038)
2023-05-18 stuartmorgan@google.com [ci] Lower iOS LUCI timeouts (flutter/packages#4035)
2023-05-18 stuartmorgan@google.com [ci] Increase Android sharding (flutter/packages#4029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 18:41:47 +00:00
engine-flutter-autoroll
4f6f1887c5
Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (#127212) 
a0ea4d2d9e...f471b37a21

2023-05-19 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add some comments on the tricky part (flutter/engine#42136)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 18:13:57 +00:00
joshualitt
3001d6ab17
Revert "Migrate benchmarks to package:web" (#127207) 
Reverts flutter/flutter#126848

Triggered some kind of measuring discrepancy / performance regression.
 2023-05-19 10:20:44 -07:00
Chris Yang
972b447434
[tool] delete xcresult bundle file before each xcode retry. (#127144) 
xcodebuild command generates a xcresult bundle file on each run, however, it doesn't delete the file generated from previous run and will throw an error if the exact file already exists.

In tool, we manually delete the file after each `flutter build` or `flutter run` command. However, there are some internal logic where xcodebuild retries multiple times. 

This PR deletes the xcresult bundle file at the start of each retry if it exists.

Fixes https://github.com/flutter/flutter/issues/127119
 2023-05-19 17:18:15 +00:00
Victoria Ashworth
b9e8b0a827
[iOS] Dispose of log readers and port forwarders if launch fails (#127140) 
When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again.

434b81f1a5/packages/flutter_tools/lib/src/drive/drive_service.dart (L177-L186)

However, it's using the same `device` instance for each iteration. So what was happening was when it would fail to launch, it would tell its listeners that it was cancelled.
434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L486-L489) 

Then when the next iteration started, the `vmServiceDiscovery` would immediately return with null because the `deviceLogReader` would be cached from the previous iteration and would already be cancelled. Therefore, bypassing and cancelling the timer.

434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L585-L591)

434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L627)

In addition, it seems like sometimes the stop would fail and therefore the the drain would never get the signal that it was done and therefore would hang forever. There was no indication that the stop had failed though because the logs were going to the stream that had no listeners since `deviceLogReader` was already cancelled.
434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L563-L576)

Fixes https://github.com/flutter/flutter/issues/127141
 2023-05-19 16:44:58 +00:00
engine-flutter-autoroll
077d644bbc
Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (#127203) 
2e6b1e6c34...a0ea4d2d9e

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 9cc604b2c3ed to 0a63dbe8cd15 (1 revision) (flutter/engine#42159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 16:40:13 +00:00
engine-flutter-autoroll
54ac355dc1
Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (#127196) 
e9178e115f...2e6b1e6c34

2023-05-19 mdebbar@google.com [web] Cleanup Vector3 (flutter/engine#42096)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 15:42:35 +00:00
Felix Angelov
3af7f9bef5
fix(flutter_tools): findBundleFile w/multiple flavor dimensions (#127133) 
Fixes the `findBundleFile` method in `gradle.dart` to correctly locate app bundles generated from multiple flavor dimensions.

- closes https://github.com/flutter/flutter/issues/92316
- closes https://github.com/flutter/flutter/issues/65264
 2023-05-19 15:00:53 +00:00
engine-flutter-autoroll
0d67c7e10c
Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (#127188) 
2e8875870f...e9178e115f

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 4a2e45ecfc50 to f5716102efe8 (2 revisions) (flutter/engine#42156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 13:43:43 +00:00
engine-flutter-autoroll
3d69e1f33a
Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (#127185) 
c7a209cc40...2e8875870f

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from aac83f59bbba to 9cc604b2c3ed (1 revision) (flutter/engine#42152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 12:13:26 +00:00
engine-flutter-autoroll
6456d603c0
Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (#127175) 
5a57ff52f0...c7a209cc40

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 9e38597c3757 to aac83f59bbba (1 revision) (flutter/engine#42150)
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zqkH0qb9GQ3jO24Bh... to eal6a4HeaQon_Y4ml... (flutter/engine#42149)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from zqkH0qb9GQ3j to eal6a4HeaQon

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 09:50:25 +00:00
engine-flutter-autoroll
2f299f2aa7
Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (#127172) 
bfbd2e1daf...5a57ff52f0

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 37e853069c04 to 9e38597c3757 (1 revision) (flutter/engine#42148)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 08:58:38 +00:00
engine-flutter-autoroll
b50ec64bd9
Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (#127167) 
e640845961...bfbd2e1daf

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 09d8a47a1f65 to 37e853069c04 (1 revision) (flutter/engine#42147)
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Tl371NrGBEHFYPxHQ... to IGeTvUK2wkajmQQ2k... (flutter/engine#42145)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Tl371NrGBEHF to IGeTvUK2wkaj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 07:06:05 +00:00
engine-flutter-autoroll
47f3532dc2
Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (#127163) 
6bc60c8a98...e640845961

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 95b96a9f498a to 4a2e45ecfc50 (1 revision) (flutter/engine#42143)
2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 8931359a74f1 to 09d8a47a1f65 (1 revision) (flutter/engine#42141)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 06:20:26 +00:00
engine-flutter-autoroll
fcba066bea
Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (#127162) 
bca11a423f...6bc60c8a98

2023-05-19 leroux_bruno@yahoo.fr [Android] Fix BasicMessageChannel.resizeChannelBuffer (flutter/engine#41982)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 05:26:16 +00:00
engine-flutter-autoroll
e49d35d3a6
Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (#127156) 
9039c2dfb7...bca11a423f

2023-05-19 yjbanov@google.com [web:a11y] support dialogs described by descendants (flutter/engine#42108)
2023-05-18 47866232+chunhtai@users.noreply.github.com Makes android embedding to send full uri (flutter/engine#41836)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 02:26:29 +00:00
engine-flutter-autoroll
8135a4beda
Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (#127154) 
3c23ddae1d...9039c2dfb7

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) (flutter/engine#42139)
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) (flutter/engine#42138)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 01:26:30 +00:00
chunhtai
ea5cfe09fd
Properly cleans up routes (#126453) 
fixes https://github.com/flutter/flutter/issues/126100
 2023-05-19 00:32:26 +00:00
Qun Cheng
af83c76723
Remove deprecated primaryVariant and secondaryVariant from ColorScheme (#127124) 
This PR is to remove deprecated `primaryVariant` and `secondaryVariant` from framework. These two apis are made obsolete in #93427

Part of https://github.com/flutter/flutter/issues/127042
 2023-05-19 00:26:53 +00:00
engine-flutter-autoroll
25d2d4dd28
Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (#127147) 
17227c16ca...3c23ddae1d

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ac47a05bf253 to 2ffed2e4c6f8 (8 revisions) (flutter/engine#42137)
2023-05-18 chris@bracken.jp [macOS] Refactor PlatformView mutators (flutter/engine#42130)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-19 00:05:08 +00:00
Qun Cheng
be40991082
Update useMaterial3 api doc (#127142) 
This is to update the components section for `useMaterial3` api doc.
 2023-05-18 23:34:07 +00:00
engine-flutter-autoroll
45808c28d9
Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (#127143) 
c7c679d6d4...17227c16ca

2023-05-18 leroux_bruno@yahoo.fr [Android] Return keyboard pressed state (flutter/engine#41695)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-18 23:06:15 +00:00