Michael Goderbauer
c4dc2c9890
Add script to check format of changed dart files ( #160007 )
...
The script is modeled after a similar script in the engine (see engine's
[format.dart](https://github.com/flutter/engine/blob/main/ci/bin/format.dart )).
It identifies the files that have been changed and checks if their
formatting is correct. It also offers an option to correct formatting
(`--fix`) and an option to check the formatting of all files in the
repro (not just changed ones, `--all-files`).
When we are enforcing dart format this script will be called as part of
presubmit.
2024-12-11 19:38:24 +00:00
Mairramer
2f9e2d9bc9
Fix false positive validation result on form submission with AutovalidateMode.onUnfocus ( #159394 )
...
Fixes #159378
Resolved an issue where focused TextFormField was bypassed during form
validation
when using AutovalidateMode.onUnfocus on mobile devices. Validation is
now correctly
triggered for all fields, including those that are focused.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-11 19:20:22 +00:00
engine-flutter-autoroll
7c3c60b598
Roll Flutter Engine from e4316b8bc5f2 to 7941d7801b08 (1 revision) ( #160092 )
...
e4316b8bc5...7941d7801bskia-flutter-autoroll@skia.org Roll Skia from 830bc24e0b98 to
79a7b95e32fe (2 revisions) (flutter/engine#57122 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 19:16:45 +00:00
engine-flutter-autoroll
6f917c92f6
Roll Packages from 0f1fd493b893 to 16616ad588d7 (2 revisions) ( #160099 )
...
0f1fd493b8...16616ad588engine-flutter-autoroll@skia.org Manual roll Flutter from
ab5b20c16d56 to 456366232af9 (10 revisions) (flutter/packages#8264 )
2024-12-10 sinyuper@gmail.com [quick_action_ios] add localizedSubtitle
for iOS (flutter/packages#8149 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 19:16:45 +00:00
Christopher Fujino
8aaec3a093
Conductor output updates ( #160054 )
...
Update some outdated, obsolete text output from the conductor.
2024-12-11 19:15:12 +00:00
Taha Tesser
275153c234
Add submenuIcon property to override the default SubmenuButton arrow icon ( #160086 )
...
Fixes
[https://github.com/flutter/flutter/issues/132898 ](https://github.com/flutter/flutter/issues/132898 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: SafeArea(
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
MenuBar(
children: [
SubmenuButton(
menuChildren: <Widget>[
SubmenuButton(
menuChildren: <Widget>[
MenuItemButton(
onPressed: () {},
child: const Text('Menu '),
),
],
child:
const Text('SubmenuButton with default arrow icon'),
),
SubmenuButton(
submenuIcon: const WidgetStateProperty<Widget?>.fromMap(
<WidgetStatesConstraint, Widget?>{
WidgetState.disabled: Icon(Icons.close),
WidgetState.hovered: Icon(Icons.favorite),
WidgetState.focused: Icon(Icons.add),
WidgetState.any: Icon(Icons.arrow_forward_ios),
},
),
menuChildren: <Widget>[
MenuItemButton(
onPressed: () {},
child: const Text('Menu '),
),
],
child:
const Text('SubmenuButton with custom Icon widget'),
),
SubmenuButton(
submenuIcon: WidgetStatePropertyAll(Image.network(
'https://i.imgur.com/SF3mSOY.png ',
width: 28,
height: 28)),
menuChildren: <Widget>[
MenuItemButton(
onPressed: () {},
child: const Text('Menu '),
),
],
child:
const Text('SubmenuButton with network image icon'),
),
],
child: const Text('Menu'),
),
],
)
],
),
),
),
);
}
}
```
</details>
### Preview
<img width="803" alt="Screenshot 2024-12-11 at 14 04 57"
src="https://github.com/user-attachments/assets/4b330020-28c6-4af9-967b-630c0d43b01a ">
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2024-12-11 19:10:07 +00:00
Flutter GitHub Bot
a3eb526ce4
Marks Linux android_release_builds_exclude_dev_dependencies_test to be unflaky ( #160074 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux android_release_builds_exclude_dev_dependencies_test"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20android_release_builds_exclude_dev_dependencies_test%22 ).
This test can be marked as unflaky.
2024-12-11 19:06:08 +00:00
engine-flutter-autoroll
4397f43d37
Roll Flutter Engine from 4f6180a2a577 to e4316b8bc5f2 (4 revisions) ( #160085 )
...
4f6180a2a5...e4316b8bc5skia-flutter-autoroll@skia.org Roll Dart SDK from
d87b2f6d2b03 to 4789a86f4d3f (1 revision) (flutter/engine#57119 )
2024-12-11 skia-flutter-autoroll@skia.org Roll Skia from b2f13d9a5678 to
830bc24e0b98 (1 revision) (flutter/engine#57118 )
2024-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from
f863f0b43625 to d87b2f6d2b03 (2 revisions) (flutter/engine#57110 )
2024-12-11 skia-flutter-autoroll@skia.org Roll Skia from 854eb19c722e to
b2f13d9a5678 (1 revision) (flutter/engine#57114 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 12:12:29 +00:00
engine-flutter-autoroll
f27bac4ee2
Roll Flutter Engine from a8f755647275 to 4f6180a2a577 (1 revision) ( #160063 )
...
a8f7556472...4f6180a2a5skia-flutter-autoroll@skia.org Roll Skia from e4d2c3dbb848 to
854eb19c722e (1 revision) (flutter/engine#57111 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 06:05:26 +00:00
engine-flutter-autoroll
9c86062f94
Roll Flutter Engine from 3a641b680edb to a8f755647275 (3 revisions) ( #160061 )
...
3a641b680e...a8f7556472goderbauer@google.com Add support for dart formatter
(flutter/engine#57075 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Skia from d541f1aa0c9b to
e4d2c3dbb848 (2 revisions) (flutter/engine#57106 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
dd92932823d1 to f863f0b43625 (1 revision) (flutter/engine#57104 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 03:03:41 +00:00
engine-flutter-autoroll
0dfd63751d
Roll Flutter Engine from 23fc43d5e61f to 3a641b680edb (3 revisions) ( #160052 )
...
23fc43d5e6...3a641b680erobert.ancell@canonical.com Clean up key embedder responder
tests (flutter/engine#57054 )
2024-12-10 jonahwilliams@google.com [Impeller] reland: switch Pipeline
to use raw ptr instead of shared ptr for recorded references.
(flutter/engine#57086 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Skia from bd7d952398d5 to
d541f1aa0c9b (3 revisions) (flutter/engine#57098 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-11 02:00:37 +00:00
yim
7b262d926d
Test SliverMainAxisGroup offstage child ( #159406 )
...
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('my test', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: LayoutBuilder(
builder: (context, view) {
return CustomScrollView(
slivers: [
SliverMainAxisGroup(
slivers: [
SliverToBoxAdapter(child: SizedBox(height: view.maxHeight)),
const SliverToBoxAdapter(child: Text('1')),
],
)
],
);
},
),
),
);
expect(find.text('1'), findsNothing);
});
}
```
The above test should have passed, but it failed. This PR fixes the
issue.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-11 00:58:59 +00:00
yim
7814641bd8
fix fade_transition issue ( #157663 )
...
Fixes : #157312
A simpler way to reproduce this issue:
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> with SingleTickerProviderStateMixin {
late AnimationController controller = AnimationController(
duration: const Duration(seconds: 2),
value: 1,
vsync: this,
);
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: FadeTransition(
opacity: controller,
child: Builder(
builder: (context) {
return GestureDetector(
onTap: () {
controller.value = 0.5;
context.findRenderObject()?.markNeedsPaint();
controller.value = 0;
},
child: Text("Click"),
);
},
),
),
),
),
);
}
}
```
The main reason is that updating the opacity with
`markNeedsCompositedLayerUpdate` followed by `markNeedsPaint` causes it
to be added to `owner!._nodesNeedingPaint` twice.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-12-11 00:54:07 +00:00
Christopher Fujino
df330d5949
mark Linux packages_autoroller bringup ( #160056 )
...
Temporarily mark non-blocking until
https://github.com/flutter/flutter/issues/160055 is resolved
2024-12-11 00:48:33 +00:00
Michael Goderbauer
0147b1f0ec
Pin pkg:intl to 0.19.0 ( #159992 )
...
Version 0.20.0 introduces new transitive dependencies that are not
cleared (yet) in our allow list [1]. Work is underway in
https://github.com/flutter/flutter/pull/158555 to change that.
[1]
eabed2381b/dev/bots/allowlist.dart
2024-12-10 23:07:59 +00:00
engine-flutter-autoroll
87cc38a8fc
Roll Flutter Engine from 58e5f9b3df54 to 23fc43d5e61f (2 revisions) ( #160044 )
...
58e5f9b3df...23fc43d5e6chris@bracken.jp iOS: Add null checks on shell dereference
(flutter/engine#57099 )
2024-12-10 Breakthrough@users.noreply.github.com [engine] Migrate
fuchsia.io Open functions to Open3 (flutter/engine#56818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 21:29:51 +00:00
chunhtai
a893157f1e
Revert "Framework sends a11y message when enabling semantics ( #159163 )" ( #160039 )
...
This reverts commit 1a2d6a30bca2476c91dd01cd67405443cfc251d3.
This is a straight revert as we are pivot away from using message
channel, instead we will be adding api to dart:ui.
See https://github.com/flutter/engine/pull/56691
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-10 21:24:09 +00:00
Renzo Olivares
119f1707ca
CupertinoTextField accessibility behavior on Linux should match TextField (#159823 )
...
While going through `TextField` and `CupertinoTextField` I noticed
https://github.com/flutter/flutter/pull/94898 and
https://github.com/flutter/flutter/pull/129652 did not make it over to
`CupertinoTextField`. This PR brings over those changes to
`CupertinoTextField`. On Linux after this change the
`CupertinoTextField` now focuses when gaining a11y focus, and unfocuses
when losing a11y focus.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Co-authored-by: Renzo Olivares <roliv@google.com>
2024-12-10 20:32:45 +00:00
Flop
fe0e219b9e
Adjust the drawing position of OutlineInputBorder ( #159943 )
...
Fixes #159942
Related Discussion: [#158440
(comment)](https://github.com/flutter/flutter/pull/158440#discussion_r1844902638 )
## Temporary code
- Change the background color of the label container.
3f08b61784/packages/flutter/lib/src/material/input_decorator.dart (L2216-L2220)3f08b61784/packages/flutter/lib/src/material/input_decorator.dart (L4838)https://github.com/user-attachments/assets/c4b5ee75-f9f8-4ec0-baa4-7a51430893e6 ) |  |
|  |  |
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-10 20:32:45 +00:00
engine-flutter-autoroll
795fef59e8
Roll Flutter Engine from 4d001245329b to 58e5f9b3df54 (1 revision) ( #160042 )
...
4d00124532...58e5f9b3dfskia-flutter-autoroll@skia.org Roll Dart SDK from
1a28e6c86b09 to dd92932823d1 (1 revision) (flutter/engine#57096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 19:42:00 +00:00
engine-flutter-autoroll
953208752e
Roll Flutter Engine from 0338d1c7d7fe to 4d001245329b (6 revisions) ( #160027 )
...
0338d1c7d7...4d00124532skia-flutter-autoroll@skia.org Roll Dart SDK from
d3a963b2f237 to 1a28e6c86b09 (3 revisions) (flutter/engine#57091 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
tVShMDVFeKJFcDFHJ... to 5taAI9-tnFN84ZJvr... (flutter/engine#57090 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
9694974b6d41 to d3a963b2f237 (1 revision) (flutter/engine#57072 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Skia from 949557697922 to
bd7d952398d5 (3 revisions) (flutter/engine#57087 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Skia from e11d70745224 to
949557697922 (1 revision) (flutter/engine#57084 )
2024-12-10 skia-flutter-autoroll@skia.org Roll Skia from 3a58be4817a8 to
e11d70745224 (2 revisions) (flutter/engine#57082 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tVShMDVFeKJF to 5taAI9-tnFN8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 17:09:16 +00:00
engine-flutter-autoroll
a5feed5515
Roll Packages from 45bcc3210fcc to 0f1fd493b893 (4 revisions) ( #160028 )
...
45bcc3210f...0f1fd493b843054281+camsim99@users.noreply.github.com [dependabot]
Generalizes dependabot commit message prefix (flutter/packages#8255 )
2024-12-09 ditman@gmail.com [google_adsense] Tighten exports and docs.
(flutter/packages#8233 )
2024-12-09 stuartmorgan@google.com [path_provider] Clean up Java code
(flutter/packages#8240 )
2024-12-09 stuartmorgan@google.com [google_sign_in] Clean up Java code
(flutter/packages#8241 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 15:51:16 +00:00
Ben Konyi
4b14308413
Add support for injecting assets into the widget_preview_scaffold ( #159859 )
...
The generated widget_preview_scaffold project needs to explicitly
reference the assets from the parent project's pubspec.yaml. This change
updates flutter widget-preview start to read the parent project's
pubspec.yaml and add references to the assets listed to the
widget_preview_scaffold's pubspec.yaml. If generate: true is set in the
parent project, a reference to the autogenerated flutter_gen package is
manually added to the widget_preview_scaffold's package_config.json.
2024-12-10 15:34:33 +00:00
Mikhail Novoseltsev
2eee054d41
[tool] Fix android tests using outdated regexs to modify templates ( #159396 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
**Description**
While exploring some semi-related stuff, found these 2 tests using
outdated regex which does not work because AGP version in modern
templates is set in `settings.gradle.kts` and in form of
`com.android.application` instead of `com.android.tools.build:gradle`.
Apart from that, in `android_plugin_example_app_build_test.dart` deleted
all lines regarding version change (instead of comply with new way of
declaring plugin) because for a long time it's didn't work anyway:
`replaceAll` haven't find any matches and test ran on latest AGP from
template. More than that, attempt to adapt this test to modern AGP setup
failed because build is not working with AGP < 8 (I lost logs with
actual error for this case, but I believe I can reproduce if anyone
wants)
in `native_assets_agp_version_test`:
- Fixed version to comply with AGP versioning format, which is
`major.minor.patch`.
- Updated regex and version changing logic to work with
`com.android.application` format and `settings.gradle.kts` file. I
believe that version updating is desired behavior here, unlike in
`android_plugin_example_app_build_test.dart`.
- Updated `kts` syntax for declaring flavors in `build.gradle.kts` and
updated regex-based updating of this file (didn't work previously
because there wasn't actual writing to file)
didn't list any issues because there're not any regarding these tests
(or maybe I just failed to find). In any case, I think that this doesn't
require issue because fix is kinda trivial and motivation is clear.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-10 14:19:24 +00:00
engine-flutter-autoroll
0104a81f55
Roll Flutter Engine from 2069db895c62 to 0338d1c7d7fe (1 revision) ( #160011 )
...
2069db895c...0338d1c7d730870216+gaaclarke@users.noreply.github.com Revert
"[Impeller] switch Pipeline to use raw ptr instead of shared ptr for
recorded references." (flutter/engine#57079 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 05:31:10 +00:00
engine-flutter-autoroll
952f5d4b60
Roll Flutter Engine from 4d0e9ac8f5ae to 2069db895c62 (3 revisions) ( #160008 )
...
4d0e9ac8f5...2069db895cjonahwilliams@google.com [Impeller] simplify render target
size rounding up heuristics. (flutter/engine#57043 )
2024-12-09 30870216+gaaclarke@users.noreply.github.com moved device
buffer to an untracked handle (flutter/engine#57021 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Skia from 14f8f6d984ff to
3a58be4817a8 (3 revisions) (flutter/engine#57073 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-10 04:17:36 +00:00
Renzo Olivares
d620ec9274
fix: SelectableRegion should only finalize selection after changing ( #159698 )
...
There are some cases where selection behavior varies on a given platform
by the pointer device, for example dragging to select changes on mobile
platforms depending on whether a mouse or a touch is used. When a mouse
is used a user can drag to select normally, when a touch is used the
selection does not change on mobile platforms when dragging.
Before this change at the end of a touch drag users would still be
notified the selection was finalized even though nothing changed and
they had not previously received a `changing` notification. After this
change the selection is no longer finalized unless the
`SelectableRegionSelectionStatus` was previously in a `changing` state.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Renzo Olivares <roliv@google.com>
2024-12-10 01:25:58 +00:00
Valentin Vignal
129a35a5e1
Add mouseCursor to Tooltip ( #159922 )
...
Part of https://github.com/flutter/flutter/issues/58192
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2024-12-10 00:25:20 +00:00
engine-flutter-autoroll
6a019d2f7d
Roll Flutter Engine from 37a7a144b864 to 4d0e9ac8f5ae (3 revisions) ( #160000 )
...
37a7a144b8...4d0e9ac8f5jonahwilliams@google.com [Impeller] switch Pipeline to use
raw ptr instead of shared ptr for recorded references.
(flutter/engine#57015 )
2024-12-09 jonahwilliams@google.com [Impeller] disable all Adrenos older
than 630 (flutter/engine#57069 )
2024-12-09 bdero@google.com Roll Skia to 14f8f6d984ff
(flutter/engine#57068 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 23:37:22 +00:00
dependabot[bot]
e77558a7f3
Bump codecov/codecov-action from 5.0.2 to 5.1.1 in the all-github-actions group across 1 directory ( #159995 )
...
Bumps the all-github-actions group with 1 update in the / directory:
[codecov/codecov-action](https://github.com/codecov/codecov-action ).
Updates `codecov/codecov-action` from 5.0.2 to 5.1.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's
releases</a>.</em></p>
<blockquote>
<h2>v5.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(release): wrapper-0.0.30 by <a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1715 ">codecov/codecov-action#1715</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.0...v5.1.1 ">https://github.com/codecov/codecov-action/compare/v5.1.0...v5.1.1 </a></p>
<h2>v5.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.27.4 to 3.27.5 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1701 ">codecov/codecov-action#1701</a></li>
<li>fix: hide unnecessary error on shasum by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1692 ">codecov/codecov-action#1692</a></li>
<li>chore(release): wrapper-0.0.29 by <a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1713 ">codecov/codecov-action#1713</a></li>
<li>chore(release): 5.1.0 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1714 ">codecov/codecov-action#1714</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.7...v5.1.0 ">https://github.com/codecov/codecov-action/compare/v5.0.7...v5.1.0 </a></p>
<h2>v5.0.7</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: use HEAD_REPO by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1690 ">codecov/codecov-action#1690</a></li>
<li>chore(release): 5.0.7 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1691 ">codecov/codecov-action#1691</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.6...v5.0.7 ">https://github.com/codecov/codecov-action/compare/v5.0.6...v5.0.7 </a></p>
<h2>v5.0.6</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: update CODECOV_TOKEN and fix tokenless by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1688 ">codecov/codecov-action#1688</a></li>
<li>chore(release): 5.0.6 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1689 ">codecov/codecov-action#1689</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.5...v5.0.6 ">https://github.com/codecov/codecov-action/compare/v5.0.5...v5.0.6 </a></p>
<h2>v5.0.5</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(release): wrapper-0.0.27 by <a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1685 ">codecov/codecov-action#1685</a></li>
<li>chore(release): 5.0.5 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1686 ">codecov/codecov-action#1686</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1685 ">codecov/codecov-action#1685</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.4...v5.0.5 ">https://github.com/codecov/codecov-action/compare/v5.0.4...v5.0.5 </a></p>
<h2>v5.0.4</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: add action version by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1678 ">codecov/codecov-action#1678</a></li>
<li>fix: strip out a trailing /n from input tokens by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1679 ">codecov/codecov-action#1679</a></li>
<li>chore(deps): bump wrapper to 0.0.26 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1681 ">codecov/codecov-action#1681</a></li>
<li>chore(release): 5.0.4 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1682 ">codecov/codecov-action#1682</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's
changelog</a>.</em></p>
<blockquote>
<h2>v5.1.1</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.0..v5.1.1 ">https://github.com/codecov/codecov-action/compare/v5.1.0..v5.1.1 </a></p>
<h2>v5.1.0</h2>
<h3>What's Changed</h3>
<ul>
<li>fix: hide unnecessary error on shasum by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1692 ">codecov/codecov-action#1692</a></li>
<li>build(deps): bump github/codeql-action from 3.27.4 to 3.27.5 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1701 ">codecov/codecov-action#1701</a></li>
<li>chore(release): wrapper-0.0.29 by
<code>@app/codecov-releaser-app</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1713 ">codecov/codecov-action#1713</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.7..v5.1.0 ">https://github.com/codecov/codecov-action/compare/v5.0.7..v5.1.0 </a></p>
<h2>v5.0.7</h2>
<h3>What's Changed</h3>
<ul>
<li>fix: use HEAD_REPO by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1690 ">codecov/codecov-action#1690</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.6..v5.0.7 ">https://github.com/codecov/codecov-action/compare/v5.0.6..v5.0.7 </a></p>
<h2>v5.0.6</h2>
<h3>What's Changed</h3>
<ul>
<li>fix: update CODECOV_TOKEN and fix tokenless by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1688 ">codecov/codecov-action#1688</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.5..v5.0.6 ">https://github.com/codecov/codecov-action/compare/v5.0.5..v5.0.6 </a></p>
<h2>v5.0.5</h2>
<h3>What's Changed</h3>
<ul>
<li>chore(release): wrapper-0.0.27 by
<code>@app/codecov-releaser-app</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1685 ">codecov/codecov-action#1685</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.4..v5.0.5 ">https://github.com/codecov/codecov-action/compare/v5.0.4..v5.0.5 </a></p>
<h2>v5.0.4</h2>
<h3>What's Changed</h3>
<ul>
<li>chore(deps): bump wrapper to 0.0.26 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1681 ">codecov/codecov-action#1681</a></li>
<li>fix: strip out a trailing /n from input tokens by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1679 ">codecov/codecov-action#1679</a></li>
<li>fix: add action version by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1678 ">codecov/codecov-action#1678</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.3..v5.0.4 ">https://github.com/codecov/codecov-action/compare/v5.0.3..v5.0.4 </a></p>
<h2>v5.0.3</h2>
<h3>What's Changed</h3>
<ul>
<li>fix: update OIDC audience by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1675 ">codecov/codecov-action#1675</a></li>
<li>fix: use double-quotes for OIDC by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1669 ">codecov/codecov-action#1669</a></li>
<li>fix: prevent always setting tokenless to be true by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1673 ">codecov/codecov-action#1673</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="7f8b4b4bdehttps://redirect.github.com/codecov/codecov-action/issues/1715 ">#1715</a>)</li>
<li><a
href="c2fcb216dehttps://redirect.github.com/codecov/codecov-action/issues/1714 ">#1714</a>)</li>
<li><a
href="0192401724https://redirect.github.com/codecov/codecov-action/issues/1713 ">#1713</a>)</li>
<li><a
href="cda5e552bahttps://redirect.github.com/codecov/codecov-action/issues/1692 ">#1692</a>)</li>
<li><a
href="2ed5abcb9fhttps://redirect.github.com/codecov/codecov-action/issues/1701 ">#1701</a>)</li>
<li><a
href="015f24e681https://redirect.github.com/codecov/codecov-action/issues/1691 ">#1691</a>)</li>
<li><a
href="a76271d959https://redirect.github.com/codecov/codecov-action/issues/1690 ">#1690</a>)</li>
<li><a
href="d168679d44https://redirect.github.com/codecov/codecov-action/issues/1689 ">#1689</a>)</li>
<li><a
href="373fd71a64https://redirect.github.com/codecov/codecov-action/issues/1688 ">#1688</a>)</li>
<li><a
href="288befbd10https://redirect.github.com/codecov/codecov-action/issues/1686 ">#1686</a>)</li>
<li>Additional commits viewable in <a
href="5c47607acb...7f8b4b4bdehttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=5.0.2&new-version=5.1.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-09 22:03:21 +00:00
LongCatIsLooong
9ff7238937
Add handler for SemanticsAction.scrollToOffset ( #159811 )
...
Also closes https://github.com/flutter/flutter/issues/159515
~Looking at the google testing failures~ cl/703169955
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-09 21:47:34 +00:00
engine-flutter-autoroll
06b95c3880
Roll Flutter Engine from a8c08bc9b909 to 37a7a144b864 (1 revision) ( #159993 )
...
a8c08bc9b9...37a7a144b8robert.ancell@canonical.com Make
fl_key_channel_responder_handle_event async (flutter/engine#56959 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 21:42:23 +00:00
Renzo Olivares
0737dbfcb6
iOS Selection Handle Improvements ( #157815 )
...
Fixes #110306
https://github.com/user-attachments/assets/d0a20ae9-912c-4ddc-bd6a-a21409468078
This change:
* Allows selection handles on iOS to swap with each other when inverting
on `TextField`.
* Allows selection handles to visually collapse when inverting on
`SelectableRegion`/`SelectionArea`, previously they showed both left and
right handles when collapsed, instead of the collapsed handles.
* Adds a border to the CupertinoTextMagnifier, the same color as the
selection handles to match native iOS behavior.
`SelectionOverlay`:
* Previously would build an empty end handle when the selection was
collapsed. Now it builds an empty end handle when the selection is being
collapsed and the start handle is being dragged, and when the selection
is collapsed and no handle is being dragged.
* Hides start handle when the selection is being collapsed and the end
handle is being dragged.
* Keeps the handles from overlapping.
`TextSelectionOverlay`:
* Removes guards against swapping handles for iOS and macOS.
* Tracks `_oppositeEdge` used to maintain selection as handles invert.
`RenderParagraph`:
* Send collapsed selection handle state in `SelectionGeometry`,
previously we wouldn't so the collapsed state would show both start and
end handles.
`CupertinoTextMagnifier`:
* Inherit border color from parent
`CupertinoTheme.of(context).primaryColor`. Selection handles also uses
`primaryColor`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Renzo Olivares <roliv@google.com>
2024-12-09 20:54:04 +00:00
engine-flutter-autoroll
0ca9f51227
Roll Flutter Engine from 7dd1cffaad06 to a8c08bc9b909 (5 revisions) ( #159990 )
...
7dd1cffaad...a8c08bc9b9jonahwilliams@google.com [Impeller] use ES3 extension for
external images. (flutter/engine#57018 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
264c0c6f5894 to 9694974b6d41 (1 revision) (flutter/engine#57066 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Skia from afa77852dcde to
e78dd0265002 (1 revision) (flutter/engine#57063 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Skia from 0971c208bb9f to
afa77852dcde (1 revision) (flutter/engine#57061 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
c7e47c6c5df6 to 264c0c6f5894 (1 revision) (flutter/engine#57060 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 20:16:32 +00:00
Matan Lurey
48c2301f7a
Add a simple golden-file test to package:integration_test. ( #159233 )
...
Closes https://github.com/flutter/flutter/issues/72045 .
Let's see if I wired this correctly and if `Flutter Gold` knows to check
based on the files changed.
2024-12-09 20:00:26 +00:00
Nate Wilson
dc5809309a
Fix SafeArea DartPad sample ( #159344 )
...
This pull request fixes a bug I introduced in
https://github.com/flutter/flutter/pull/158019 .
<br>
<h3 align="center">Before</h3>
<p align="center">
<img
src="https://github.com/user-attachments/assets/fcb68fac-9c63-445d-8d2b-afc28c685053 "
alt="RenderFlex overflowed"
width="523px"
/>
</p>
<h3 align="center">After</h3>
<p align="center">
<img
src="https://github.com/user-attachments/assets/82091c6a-b3c5-4994-978e-5e76cbb7edfd "
alt="RenderFlex overflowed"
width="523px"
/>
</p>
<br><br>
- fixes https://github.com/flutter/flutter/issues/159340
2024-12-09 19:54:08 +00:00
Taha Tesser
f7871352fb
Fix RangeSlider thumb doesn't align with divisions, thumb padding, and rounded corners ( #159792 )
...
Fixes [`RangeSlider` thumb's center doesn't align with division's
center, thumb padding, and rounded corners don't work as
expected](https://github.com/flutter/flutter/issues/159586 )
This makes a similar fix as the one for `Slider` in
https://github.com/flutter/flutter/pull/149594 . This fix is essential to
bring updated Material Design for `RangeSlider`.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
double _discreetSliderValue = 0.6;
RangeValues _discreteRangeSliderValues = const RangeValues(0.2, 1.0);
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
sliderTheme: const SliderThemeData(
trackHeight: 32,
thumbColor: Colors.green,
activeTrackColor: Colors.deepPurple,
inactiveTrackColor: Colors.amber,
),
),
home: Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Text(
'Discrete Slider',
style: Theme.of(context).textTheme.titleMedium,
),
Slider(
value: _discreetSliderValue,
divisions: 5,
onChanged: (double newValue) {
setState(() {
_discreetSliderValue = newValue;
});
}),
Text(
'Discrete Range Slider',
style: Theme.of(context).textTheme.titleMedium,
),
RangeSlider(
values: _discreteRangeSliderValues,
divisions: 5,
onChanged: (RangeValues newValues) {
setState(() {
_discreteRangeSliderValues = newValues;
});
},
),
],
),
),
),
);
}
}
```
</details>
### Before
<img width="701" alt="Screenshot 2024-12-02 at 18 57 03"
src="https://github.com/user-attachments/assets/62d85476-87fd-48e9-aaa9-42d7629d4808 ">
### After
<img width="701" alt="Screenshot 2024-12-02 at 18 57 21"
src="https://github.com/user-attachments/assets/36f136d1-a759-4b11-b0a9-8cb6b54b8573 ">
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-09 19:24:20 +00:00
Nate Wilson
5f861d5bf7
Show issues in triage even if they've been assigned ( #155615 )
...
Recently I learned that (at least in `team-framework` and `team-design`
triage meetings) we'd like to see all incoming issues, even ones that
already have an assignee.
This PR removes a filter so that this will happen in the future.
resolves #155700
2024-12-09 18:49:20 +00:00
engine-flutter-autoroll
5b51068401
Roll Packages from bc0c22d57910 to 45bcc3210fcc (20 revisions) ( #159978 )
...
bc0c22d579...45bcc3210f737941+loic-sharma@users.noreply.github.com [various] Add
Swift Package Manager integration to Google sign in example apps
(flutter/packages#8230 )
2024-12-05 engine-flutter-autoroll@skia.org Roll Flutter from
e1e4ee9a016e to ab5b20c16d56 (7 revisions) (flutter/packages#8236 )
2024-12-05 stuartmorgan@google.com [various] Update iOS/macOS Pigeon
versions (flutter/packages#8226 )
2024-12-05 ditman@gmail.com [ci] Adds google_adsense to labeler.yml
(flutter/packages#8231 )
2024-12-05 tarrinneal@gmail.com [pigeon] adds event channel support for
kotlin and swift (flutter/packages#7892 )
2024-12-04 50541317+sokoloff06@users.noreply.github.com [google_adsense]
(Experimental) AdSense plugin for Flutter Web (flutter/packages#6871 )
2024-12-04 737941+loic-sharma@users.noreply.github.com [various] Add
Swift Package Manager integration to image picker examp…
(flutter/packages#8227 )
2024-12-04 737941+loic-sharma@users.noreply.github.com [pigeon] Add
Swift Package Manager integration to example app (flutter/packages#8225 )
2024-12-04 pawel.jakubowski@leancode.pl [video_player_avfoundation]
Split iOS native code into multiple files (flutter/packages#8171 )
2024-12-04 engine-flutter-autoroll@skia.org Roll Flutter from
e64ee5de7cdd to e1e4ee9a016e (18 revisions) (flutter/packages#8224 )
2024-12-04 737941+loic-sharma@users.noreply.github.com [various] Add
Swift Package Manager integration to example apps
(flutter/packages#8219 )
2024-12-04 stuartmorgan@google.com [google_maps_flutter] Annotate
deprecated member usage (flutter/packages#8214 )
2024-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon]
Fixes channel names of the named constructors of ProxyApis.
(flutter/packages#8201 )
2024-12-03 stuartmorgan@google.com [local_auth] Add compatibility with
intl 0.20 (flutter/packages#8217 )
2024-12-03 stuartmorgan@google.com [various] Replaces deprecated
`whereNotNull()` (flutter/packages#8215 )
2024-12-03 engine-flutter-autoroll@skia.org Roll Flutter from
08e26a3ffcd7 to e64ee5de7cdd (20 revisions) (flutter/packages#8213 )
2024-12-02 stuartmorgan@google.com [shared_preferences] Limit Android
decoding (flutter/packages#8187 )
2024-12-02 49699333+dependabot[bot]@users.noreply.github.com
[camera_android]: Bump androidx.annotation:annotation from 1.9.0 to
1.9.1 in /packages/camera/camera_android/android (flutter/packages#8164 )
2024-12-02 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.21 to 2.1.0 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8205 )
2024-11-28 engine-flutter-autoroll@skia.org Roll Flutter from
fae695ed6198 to 08e26a3ffcd7 (19 revisions) (flutter/packages#8197 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 15:46:08 +00:00
engine-flutter-autoroll
711103b806
Roll Flutter Engine from 6b2794ee581e to 7dd1cffaad06 (1 revision) ( #159976 )
...
6b2794ee58...7dd1cffaadskia-flutter-autoroll@skia.org Roll Skia from 477c83cf10f8 to
0971c208bb9f (1 revision) (flutter/engine#57059 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 15:16:24 +00:00
engine-flutter-autoroll
6e777a4ac9
Roll Flutter Engine from 28d9aec2e024 to 6b2794ee581e (1 revision) ( #159970 )
...
28d9aec2e0...6b2794ee58skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
BFJjwUVtBDA2mqqpH... to tVShMDVFeKJFcDFHJ... (flutter/engine#57058 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BFJjwUVtBDA2 to tVShMDVFeKJF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 13:18:11 +00:00
engine-flutter-autoroll
4d8b26ec18
Roll Flutter Engine from 13231e3e48d5 to 28d9aec2e024 (2 revisions) ( #159968 )
...
13231e3e48...28d9aec2e0skia-flutter-autoroll@skia.org Roll Skia from ac432c094232 to
477c83cf10f8 (1 revision) (flutter/engine#57057 )
2024-12-09 skia-flutter-autoroll@skia.org Roll Skia from c80d6609b95b to
ac432c094232 (1 revision) (flutter/engine#57056 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 11:19:04 +00:00
engine-flutter-autoroll
69ae667301
Roll Flutter Engine from 292146ab2fda to 13231e3e48d5 (1 revision) ( #159964 )
...
292146ab2f...13231e3e48skia-flutter-autoroll@skia.org Roll Skia from 96b018c1088a to
c80d6609b95b (1 revision) (flutter/engine#57055 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-09 07:49:32 +00:00
engine-flutter-autoroll
1c1f35711b
Roll Flutter Engine from 82d7c1b2c268 to 292146ab2fda (2 revisions) ( #159959 )
...
82d7c1b2c2...292146ab2frobert.ancell@canonical.com Cleanup refactoring in
FlKeyboardManager (flutter/engine#56956 )
2024-12-08 skia-flutter-autoroll@skia.org Roll Skia from 76c51c6e13df to
96b018c1088a (2 revisions) (flutter/engine#57052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-08 22:29:34 +00:00
engine-flutter-autoroll
1d60fc7843
Roll Flutter Engine from 2ed05f0068e2 to 82d7c1b2c268 (2 revisions) ( #159950 )
...
2ed05f0068...82d7c1b2c2skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
__h1RRphItwU5H0tL... to BFJjwUVtBDA2mqqpH... (flutter/engine#57050 )
2024-12-07 skia-flutter-autoroll@skia.org Roll Skia from d1e261ca7f6f to
76c51c6e13df (3 revisions) (flutter/engine#57042 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from __h1RRphItwU to BFJjwUVtBDA2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-08 15:31:31 +00:00
engine-flutter-autoroll
3f08b61784
Roll Flutter Engine from fd41747c23a9 to 2ed05f0068e2 (2 revisions) ( #159929 )
...
fd41747c23...2ed05f0068skia-flutter-autoroll@skia.org Roll Skia from b37f1430f87a to
d1e261ca7f6f (1 revision) (flutter/engine#57039 )
2024-12-07 skia-flutter-autoroll@skia.org Roll Dart SDK from
838ed940b056 to c7e47c6c5df6 (1 revision) (flutter/engine#57038 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-07 17:48:40 +00:00
Bernardo Ferrari
c1a6c5500c
Improve UI-thread animation performance ( #159288 )
...
The following PR (https://github.com/flutter/flutter/pull/138481 ) got
split in 2, this is part 2.
We now have the microbenchmarks to compare this change against (and
hopefully see improvements).
Close: https://github.com/flutter/flutter/issues/146211
Part 1: https://github.com/flutter/flutter/pull/153368
---------
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
2024-12-07 16:59:10 +00:00
engine-flutter-autoroll
61d7d0ed23
Roll Flutter Engine from 1e63abec8faf to fd41747c23a9 (3 revisions) ( #159920 )
...
1e63abec8f...fd41747c23skia-flutter-autoroll@skia.org Roll Dart SDK from
67ce49b905f7 to 838ed940b056 (2 revisions) (flutter/engine#57037 )
2024-12-07 skia-flutter-autoroll@skia.org Roll Skia from c9e9ce277b80 to
b37f1430f87a (1 revision) (flutter/engine#57033 )
2024-12-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
DDdLABVLcqOv_axv-... to __h1RRphItwU5H0tL... (flutter/engine#57028 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from DDdLABVLcqOv to __h1RRphItwU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-07 04:33:43 +00:00
engine-flutter-autoroll
c92e379ea3
Roll Flutter Engine from de53ed532619 to 1e63abec8faf (2 revisions) ( #159918 )
...
de53ed5326...1e63abec8fbdero@google.com Cover offset+bounds wrapping in the APNG
frame region check. (flutter/engine#57025 )
2024-12-06 skia-flutter-autoroll@skia.org Roll Skia from 0d94e966268b to
c9e9ce277b80 (3 revisions) (flutter/engine#57024 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-07 01:42:26 +00:00
Qun Cheng
92107b15fd
Create new page transition for M3 ( #158881 )
...
This PR is to add a new page transition for Material 3.
The new builder matches the latest Android page transition behavior;
while the new page slides in from right to left, it fades in at the same
time and the old page slides out from right to left, fading out at the
same time. When both pages are fading in/out, the black background might
show up, so I added a `ColoredBox` for the slides-out page whose color
defaults to `ColorScheme.surface`. The `backgroundColor` property can be
used to customize the default transition color.
This demo shows the forward and backward behaviors.
https://github.com/user-attachments/assets/a806f25d-8564-4cad-8dfc-eb4585294181
Fixes: https://github.com/flutter/flutter/issues/142352
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2024-12-07 00:56:57 +00:00
