Loïc Sharma
c6aeab930a
[Windows] Add Arm64 benchmarks ( #135514 )
...
Part of: https://github.com/flutter/flutter/issues/129806
Test runs kicked off using `led`:
* â
[hot_mode_dev_cycle_win_target__benchmark](2079b030ac/+/build.proto
)
* â
[windows_home_scroll_perf__timeline_summary](56a3b258e4/+/build.proto
)
* â
[flutter_tool_startup](fa6a1056fc/+/build.proto
)
/cc @pbo-linaro
2023-10-11 16:36:20 +00:00
Kostia Sokolovskyi
cc41e25f21
_RenderSnapshotWidget should dispose created OffsetLayer. ( #136267 )
2023-10-11 08:45:39 -07:00
engine-flutter-autoroll
54d584740b
Roll Flutter Engine from bddb34b09ce9 to ec1d0d69fcf1 (1 revision) ( #136368 )
...
bddb34b09c...ec1d0d69fc
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from e00577618d81 to c05effecb081 (1 revision) (flutter/engine#46770 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 15:45:21 +00:00
engine-flutter-autoroll
ec94ccff83
Roll Flutter Engine from d93fe2367d21 to bddb34b09ce9 (2 revisions) ( #136352 )
...
d93fe2367d...bddb34b09c
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (flutter/engine#46763 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FX5YzwP_ZEnP to hMA99PoacaRZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 11:41:40 +00:00
engine-flutter-autoroll
1ca0991021
Roll Flutter Engine from cb0dabd3b33c to d93fe2367d21 (2 revisions) ( #136346 )
...
cb0dabd3b3...d93fe2367d
2023-10-11 leroux_bruno@yahoo.fr [Android] Add support for text processing actions (flutter/engine#44579 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 10:49:25 +00:00
Taha Tesser
692d7ade9e
Fix FlexibleSpaceBar
does compositing with near zero opacity. ( #136255 )
...
fixes [`flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true.` is thrown when scrolling down in the list and then up](https://github.com/flutter/flutter/issues/135698 )
2023-10-11 07:19:30 +00:00
engine-flutter-autoroll
94f748388e
Roll Flutter Engine from 0d86d529bb7e to cb0dabd3b33c (1 revision) ( #136320 )
...
0d86d529bb...cb0dabd3b3
2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oTiMPVe_PvyCYnlqR... to mLc-VlVTg-p18HjiP... (flutter/engine#46754 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from oTiMPVe_PvyC to mLc-VlVTg-p1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 05:48:21 +00:00
engine-flutter-autoroll
0d1e73b137
Roll Flutter Engine from 80868149792f to 0d86d529bb7e (1 revision) ( #136315 )
...
8086814979...0d86d529bb
2023-10-11 bdero@google.com [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 03:34:12 +00:00
engine-flutter-autoroll
2a221682ec
Roll Flutter Engine from ea275c3d27d3 to 80868149792f (4 revisions) ( #136307 )
...
ea275c3d27...8086814979
2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745 )
2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748 )
2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 02:42:14 +00:00
Polina Cherkasova
ad05949971
Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment. ( #136136 )
2023-10-10 18:11:23 -07:00
Valentin Vignal
b989428fa2
Add SizeTransition.fixedCrossAxisSizeFactor
( #134659 )
...
Fixes https://github.com/flutter/flutter/issues/134654
2023-10-11 00:53:34 +00:00
Matan Lurey
f38244f0b5
Relaxed a test on Paint.toString()
to ignore dither: ...
. ( #136302 )
...
Work towards https://github.com/flutter/flutter/issues/112498 .
Behaviorally the same, except doesn't care if `dither: ...` shows up, or
not (it won't when https://github.com/flutter/flutter/issues/112498 is
fixed).
2023-10-10 17:50:35 -07:00
engine-flutter-autoroll
a7edafe7e8
Roll Flutter Engine from 4a4d9de43848 to ea275c3d27d3 (1 revision) ( #136301 )
...
4a4d9de438...ea275c3d27
2023-10-10 jonahwilliams@google.com [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 00:40:06 +00:00
engine-flutter-autoroll
85e172658b
Roll Flutter Engine from bdeb53455f7c to 4a4d9de43848 (2 revisions) ( #136294 )
...
bdeb53455f...4a4d9de438
2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dCjN58uZQBmAFWSxN... to FX5YzwP_ZEnPP0b3v... (flutter/engine#46734 )
2023-10-10 bdero@google.com [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dCjN58uZQBmA to FX5YzwP_ZEnP
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 23:56:17 +00:00
Greg Spencer
7e1d366a4d
Add key event handlers that happen before or after the focus traversal ( #136280 )
...
## Description
This adds a mechanism for listening to key events before or after focus traversal occurs.
It adds four methods to the public `FocusManager` API:
- `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling.
- `removeEarlyKeyEventHandler` - Removes an early event handler.
- `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree.
- `removeLateKeyEventHandler` - Removes a late event handler.
This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it.
For the menu system, this allows it to eat an escape key press and close all the open menus.
## Related Issues
- https://github.com/flutter/flutter/issues/135334
## Tests
- Added tests for new functionality.
2023-10-10 23:16:25 +00:00
Christopher Fujino
b416473bbb
[flutter_tools] catch StdinException when setting terminal to SingleCharMode ( #136283 )
...
Fixes https://github.com/flutter/flutter/issues/129198
2023-10-10 23:10:29 +00:00
Camille Simon
54cf286e1a
[Android] Update Java/AGP/Gradle warning compatible Java range ( #135710 )
...
Specifies that compatible Java range stated in warning when Java version is incompatible with our template AGP & Gradle versions notes an exclusive upper bound Java version. This was a bug from https://github.com/flutter/flutter/pull/131444 , and I will file a CP request to stable once this lands.
The warning uses [`getJavaVersionFor`](b5c8fd11e4/packages/flutter_tools/lib/src/android/gradle_utils.dart (L606)
), which returns an exclusive upper bound, which is why this fix is necessary.
2023-10-10 22:30:50 +00:00
engine-flutter-autoroll
640050ba80
Roll Flutter Engine from 702f366b1c5d to bdeb53455f7c (6 revisions) ( #136292 )
...
702f366b1c...bdeb53455f
2023-10-10 john@johnmccutchan.com Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724 )
2023-10-10 matanlurey@users.noreply.github.com Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729 )
2023-10-10 godofredoc@google.com Use x86 machines for ios builds. (flutter/engine#46726 )
2023-10-10 chinmaygarde@google.com Remove workaround for older versions of MSVC. (flutter/engine#46689 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728 )
2023-10-10 jonahwilliams@google.com [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 22:29:13 +00:00
Jonah Williams
a106b81cc5
[framework] restore old zoom page transition for benchmarking. ( #133346 )
...
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.
https://github.com/flutter/flutter/issues/129742
https://github.com/flutter/flutter/issues/121325
2023-10-10 22:27:07 +00:00
Mitchell Goodwin
daa52b2501
Seperate localization tests for Material2 and Material3 ( #135779 )
...
Seperates tests for the localizations package into Material2 and Material3 versions and removes dependency on theme.
More info in #127064
2023-10-10 21:46:20 +00:00
Christopher Fujino
0fa01b2156
[flutter_tools] allow tool integration tests to quit on SIGINT ( #136271 )
...
fixes https://github.com/flutter/flutter/issues/136270
2023-10-10 20:47:59 +00:00
engine-flutter-autoroll
09ed4f1f59
Roll Flutter Engine from e0653982dad2 to 702f366b1c5d (1 revision) ( #136281 )
...
e0653982da...702f366b1c
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from f0653c4a2df5 to 475286f0f6f1 (2 revisions) (flutter/engine#46721 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 20:43:59 +00:00
engine-flutter-autoroll
7deb535cb6
Roll Flutter Engine from 39bfce213a4f to e0653982dad2 (1 revision) ( #136278 )
...
39bfce213a...e0653982da
2023-10-10 flar@google.com use TextFrame calls for Impeller in rendertests (flutter/engine#46696 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 19:13:54 +00:00
engine-flutter-autoroll
38a7d9d1ef
Roll Flutter Engine from 60e861dfe6b1 to 39bfce213a4f (3 revisions) ( #136272 )
...
60e861dfe6...39bfce213a
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c634411c51e6 to f0653c4a2df5 (1 revision) (flutter/engine#46716 )
2023-10-10 30870216+gaaclarke@users.noreply.github.com [Impeller] made window size parametric in playground/golden tests (flutter/engine#46682 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c497dae2fedb to c634411c51e6 (1 revision) (flutter/engine#46714 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 18:17:07 +00:00
Kostia Sokolovskyi
0a6947049b
TimePickerDialog should dispose created ChangeNotifiers. ( #136261 )
2023-10-10 11:05:26 -07:00
Victoria Ashworth
e8bd5a3271
Delete simulator after plugin_test_ios ( #136265 )
...
Remove simulator once it's no longer needed for test `plugin_test_ios` .
Fixes https://github.com/flutter/flutter/issues/136224
2023-10-10 17:22:07 +00:00
Kostia Sokolovskyi
5064f782c1
Cover more test/material tests with leak tracking. ( #136093 )
2023-10-10 10:05:51 -07:00
engine-flutter-autoroll
83134ac7e4
Roll Flutter Engine from 2b3f9886fbf0 to 60e861dfe6b1 (1 revision) ( #136264 )
...
2b3f9886fb...60e861dfe6
2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EYr1hCR6hxkSGhtis... to oTiMPVe_PvyCYnlqR... (flutter/engine#46713 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from EYr1hCR6hxkS to oTiMPVe_PvyC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 16:51:23 +00:00
engine-flutter-autoroll
4bae7ce40c
Roll Flutter Engine from e354a13cfeab to 2b3f9886fbf0 (4 revisions) ( #136259 )
...
e354a13cfe...2b3f9886fb
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 6cfbb3a0809e to c497dae2fedb (2 revisions) (flutter/engine#46711 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from ea839690b97d to 6cfbb3a0809e (2 revisions) (flutter/engine#46710 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 0023fc324ff0 to 0732be6b823a (1 revision) (flutter/engine#46709 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c969e4aff32c to ea839690b97d (1 revision) (flutter/engine#46708 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 15:54:09 +00:00
engine-flutter-autoroll
665c876b9f
Roll Packages from 7de08ecd1cba to 4b483f242936 (8 revisions) ( #136258 )
...
7de08ecd1c...4b483f2429
2023-10-10 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or macOS 13 (flutter/packages#5089 )
2023-10-10 ychris@google.com [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085 )
2023-10-09 stuartmorgan@google.com [process] Import the `process` package (flutter/packages#5095 )
2023-10-09 hrkadam.92@gmail.com [go_router] Fixes missing state.extra in onException() (flutter/packages#5077 )
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094 )
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter from 5207a309e8d8 to f52fe4f7e55d (18 revisions) (flutter/packages#5093 )
2023-10-09 chrislangham@rightnow.org [platform] Example app for platform (flutter/packages#4834 )
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 15:52:50 +00:00
Kostia Sokolovskyi
5d9983a125
RenderAnnotatedRegion should dispose created layers. ( #136086 )
2023-10-10 08:32:01 -07:00
Polina Cherkasova
eec3f06090
TestClipPaintingContext should dispose ContainerLayer ( #135949 )
2023-10-10 08:19:50 -07:00
engine-flutter-autoroll
7d01663885
Roll Flutter Engine from 9aa7cb057d22 to e354a13cfeab (1 revision) ( #136248 )
...
9aa7cb057d...e354a13cfe
2023-10-10 skia-flutter-autoroll@skia.org Roll Dart SDK from a471147f6237 to 0023fc324ff0 (1 revision) (flutter/engine#46704 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 11:21:27 +00:00
huycozy
ed7b29a405
Migrate the "Non-speed related performance issues" issue template to Github forms ( #135130 )
...
Closes https://github.com/flutter/flutter/issues/119920
### The difference with the speed issue template
- Issue's main description
- DevTools stats observation section
### Demo
- Demo issue template: [My app has some non-speed performance issues](https://github.com/huycozy/flutter/issues/new?assignees=&labels=from%3A+performance+template&projects=&template=4_performance_others.yml )
- Demo a filed issue: https://github.com/huycozy/flutter/issues/7
2023-10-10 09:51:37 +00:00
engine-flutter-autoroll
4756f8b4ff
Roll Flutter Engine from 171b4b26e68b to 9aa7cb057d22 (4 revisions) ( #136240 )
...
171b4b26e6...9aa7cb057d
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 4378ce41f461 to c969e4aff32c (1 revision) (flutter/engine#46702 )
2023-10-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.3.0 (flutter/engine#46701 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3JmrIr49bTV2DIWsW... to dCjN58uZQBmAFWSxN... (flutter/engine#46700 )
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from f4f3c909993d to 4378ce41f461 (1 revision) (flutter/engine#46699 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3JmrIr49bTV2 to dCjN58uZQBmA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 08:20:10 +00:00
engine-flutter-autoroll
5dfd78c2e3
Roll Flutter Engine from d094401acb99 to 171b4b26e68b (1 revision) ( #136235 )
...
d094401acb...171b4b26e6
2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from YDaOfbTjc-WMEZXZx... to EYr1hCR6hxkSGhtis... (flutter/engine#46698 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from YDaOfbTjc-WM to EYr1hCR6hxkS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 04:07:35 +00:00
engine-flutter-autoroll
dd09ca8b13
Roll Flutter Engine from 92880e9847b3 to d094401acb99 (1 revision) ( #136233 )
...
92880e9847...d094401acb
2023-10-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 078162ecf493 to a471147f6237 (1 revision) (flutter/engine#46695 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 02:47:11 +00:00
engine-flutter-autoroll
0194d93665
Roll Flutter Engine from 51193f8f53eb to 92880e9847b3 (1 revision) ( #136232 )
...
51193f8f53...92880e9847
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from f45ac4569300 to f4f3c909993d (1 revision) (flutter/engine#46694 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 01:58:28 +00:00
engine-flutter-autoroll
872de52ce5
Roll Flutter Engine from 8f2fa3ceb8a0 to 51193f8f53eb (4 revisions) ( #136228 )
...
8f2fa3ceb8...51193f8f53
2023-10-09 skia-flutter-autoroll@skia.org Roll Dart SDK from a6e43b0b9e0c to 078162ecf493 (1 revision) (flutter/engine#46691 )
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from e56387226035 to f45ac4569300 (1 revision) (flutter/engine#46690 )
2023-10-09 chinmaygarde@google.com Remove obsolete tests that were time sensitive. (flutter/engine#46686 )
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from bd77f099b4f9 to e56387226035 (1 revision) (flutter/engine#46687 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 23:41:27 +00:00
engine-flutter-autoroll
5c874c15b4
Roll Flutter Engine from 73da593bac54 to 8f2fa3ceb8a0 (2 revisions) ( #136220 )
...
73da593bac...8f2fa3ceb8
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 26d70e6999f6 to bd77f099b4f9 (3 revisions) (flutter/engine#46685 )
2023-10-09 flar@google.com [Impeller] Run DisplayList render tests. (flutter/engine#46422 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 22:05:42 +00:00
Casey Hillers
d9634155ab
[conductor] Remove PublishChannel and use MPA command ( #135884 )
...
Move more of the playbook into conductor. The MPA command inputs are prone to human error.
2023-10-09 21:13:55 +00:00
engine-flutter-autoroll
e141d0a4de
Roll Flutter Engine from 0966f62d7101 to 73da593bac54 (1 revision) ( #136216 )
...
0966f62d71...73da593bac
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from ef4c093143d2 to 26d70e6999f6 (1 revision) (flutter/engine#46684 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 20:41:10 +00:00
droidbg
67170b1254
[leak-tracking] Add leak tracking in test/painting #1 ( #136167 )
2023-10-09 13:10:07 -07:00
droidbg
3df6078bc4
[leak-tracking] Cover testwidgets with leak tracking in test/gestures ( #136166 )
2023-10-09 13:09:24 -07:00
engine-flutter-autoroll
a1e10ee49e
Roll Flutter Engine from 81e5bf29dee4 to 0966f62d7101 (1 revision) ( #136215 )
...
81e5bf29de...0966f62d71
2023-10-09 zhangzhijian.123@bytedance.com [Impeller] Optionally support SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#46650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:47:10 +00:00
engine-flutter-autoroll
dda74f5ab6
Roll Flutter Engine from 22ce5c6a45e2 to 81e5bf29dee4 (3 revisions) ( #136211 )
...
22ce5c6a45...81e5bf29de
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 4135182b6a56 to ef4c093143d2 (2 revisions) (flutter/engine#46680 )
2023-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0ObCmDD14Cel45cU-... to 3JmrIr49bTV2DIWsW... (flutter/engine#46679 )
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from c5541e2bd213 to 4135182b6a56 (1 revision) (flutter/engine#46677 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0ObCmDD14Cel to 3JmrIr49bTV2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:03:17 +00:00
Hassan
e127f7191b
[web] Fix page up
page down
home
end
shortcut behavior on web ( #135454 )
...
We delegate page up / page down actions to the browser. However, we don't let the browser scroll the underlying `<textarea>` - the framework handles scrolling, so page up/down don't end up doing anything. Since the framework handles scrolling for text inputs and textareas, we should let it also handle the actions for `page up`, `page down`, `home`, `end`, and their modifiers.
fixes https://github.com/flutter/flutter/issues/121867
2023-10-09 17:50:54 +00:00
Greg Spencer
a5e3e78591
Update MediaQuery
documentation to highlight asynchronous nature of size ( #135719 )
...
## Description
This updates the documentation for `MediaQuery` and `Overlay` to include the following:
- That `MediaQueryData.size` is set asynchronously, and doesn't necessarily reflect the size of the current frame.
- That the specific `MediaQuery.sizeOf` and related methods are preferred over the more generic `MediaQuery.of`.
- That the size of the `Overlay` isn't necessarily the size returned by `MediaQueryData.size`
As well as adding some symbol links, and fixing some error in documentation.
## Tests
- Documentation only
2023-10-09 16:55:09 +00:00
chunhtai
ff73448f33
Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… ( #134554 )
...
…… (#134550 )"
fixes https://github.com/flutter/flutter/issues/112567
This reverts commit 5900c4baa751aff8f05e820287a02b60cdd62dfa.
The internal test needs migration. cl/564746935
This is the same of original pr, no new change
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-09 09:10:23 -07:00
engine-flutter-autoroll
51f1a464f5
Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) ( #136205 )
...
429a242b0d...22ce5c6a45
2023-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from nN0l08yRbt0zE3R7a... to YDaOfbTjc-WMEZXZx... (flutter/engine#46675 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from nN0l08yRbt0z to YDaOfbTjc-WM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 15:59:25 +00:00