Polina Cherkasova
c00e9798ff
Fix _paintAvatar in chip.dart to dispose layer. ( #135228 )
2023-09-22 15:26:52 -07:00
Kostia Sokolovskyi
a4e3f93367
Fix memory leak in _MatchesReferenceImage ( #135150 )
2023-09-22 15:26:25 -07:00
Zachary Anderson
579e196073
Stop reporting new_gen_gc_count to SkiaPerf ( #135324 )
...
Movement in this metric is mostly noise, creates many false alerts, and is neither the cause nor effect of changes in other metrics.
2023-09-22 21:55:28 +00:00
engine-flutter-autoroll
feb6d6ed3d
Roll Flutter Engine from 92be04f73d5d to 954ea95be336 (2 revisions) ( #135325 )
...
92be04f73d...954ea95be3skia-flutter-autoroll@skia.org Roll Skia from fe73688dc40f to 8a1e6e5844d7 (1 revision) (flutter/engine#46205 )
2023-09-22 jonahwilliams@google.com [Impeller] Reland: construct text frames on UI thread. (flutter/engine#46115 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 21:17:50 +00:00
Polina Cherkasova
99ac6b8164
_RenderChip should not create OpacityLayer without disposing. ( #134708 )
2023-09-22 13:44:04 -07:00
flutter-pub-roller-bot
9fe6ed15f7
Roll pub packages ( #135315 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-09-22 19:28:54 +00:00
engine-flutter-autoroll
a09b1e43b1
Roll Flutter Engine from ef9ceed1af08 to 92be04f73d5d (3 revisions) ( #135319 )
...
ef9ceed1af...92be04f73dskia-flutter-autoroll@skia.org Roll Skia from 8beae2053939 to fe73688dc40f (1 revision) (flutter/engine#46202 )
2023-09-22 matanlurey@users.noreply.github.com Enable checking headers with Clang Tidy. (flutter/engine#46009 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from f346a813ffd4 to 8beae2053939 (5 revisions) (flutter/engine#46200 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 19:25:24 +00:00
Ricardo Amador
76a938bfa6
Reenable 'Linux packages_autoroller' in prod with kms key update ( #135316 )
...
The Github token was recreated and uploaded to GCS. I have verified a passing run with the new key here:
bc5d1e6662/+/build.protohttps://github.com/flutter/flutter/pull/135315
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131968
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-22 18:23:14 +00:00
Bartek Pacia
dbe0ccd885
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block ( #127897 )
...
This PR fixes #125009 .
2023-09-22 16:31:48 +00:00
engine-flutter-autoroll
74c6693170
Roll Packages from d0411e450a8d to 98ebcd3d9c05 (3 revisions) ( #135310 )
...
d0411e450a...98ebcd3d9cengine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 367f9ea16bfa to 12fccda59847 (2 revisions) (flutter/packages#4976 )
2023-09-21 47866232+chunhtai@users.noreply.github.com [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr⦠(flutter/packages#4723 )
2023-09-21 maurits@vnbskm.nl [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter/packages#4703 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 16:02:02 +00:00
engine-flutter-autoroll
06780cb1d0
Roll Flutter Engine from e97155428ad4 to ef9ceed1af08 (1 revision) ( #135308 )
...
e97155428a...ef9ceed1afskia-flutter-autoroll@skia.org Roll Skia from a911bc1352f2 to f346a813ffd4 (1 revision) (flutter/engine#46195 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 15:25:37 +00:00
engine-flutter-autoroll
f58163447f
Roll Flutter Engine from 9d06c176cf98 to e97155428ad4 (1 revision) ( #135306 )
...
9d06c176cf...e97155428askia-flutter-autoroll@skia.org Roll Skia from d0f04adbec5c to a911bc1352f2 (1 revision) (flutter/engine#46194 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 14:39:31 +00:00
engine-flutter-autoroll
6502883a96
Roll Flutter Engine from b642e4f4dffa to 9d06c176cf98 (2 revisions) ( #135304 )
...
b642e4f4df...9d06c176cfskia-flutter-autoroll@skia.org Roll Dart SDK from 6bde93a6e56f to 4ddff752a6b0 (1 revision) (flutter/engine#46193 )
2023-09-22 whesse@google.com Re-add package tar to DEPS (flutter/engine#46190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 13:48:37 +00:00
engine-flutter-autoroll
99192f83a7
Roll Flutter Engine from 2fa8dec336d0 to b642e4f4dffa (1 revision) ( #135295 )
...
2fa8dec336...b642e4f4dfskia-flutter-autoroll@skia.org Roll Skia from 8752f3ac6e99 to d0f04adbec5c (1 revision) (flutter/engine#46191 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 12:06:02 +00:00
engine-flutter-autoroll
723ba03a44
Roll Flutter Engine from 3d54e44d0654 to 2fa8dec336d0 (1 revision) ( #135289 )
...
3d54e44d06...2fa8dec336skia-flutter-autoroll@skia.org Roll Skia from 8d9e2cd32ec7 to 8752f3ac6e99 (1 revision) (flutter/engine#46186 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 10:25:26 +00:00
engine-flutter-autoroll
8de97ca1bb
Roll Flutter Engine from 3a2346ade2f2 to 3d54e44d0654 (2 revisions) ( #135288 )
...
3a2346ade2...3d54e44d06skia-flutter-autoroll@skia.org Roll Skia from a3480a62e438 to 8d9e2cd32ec7 (1 revision) (flutter/engine#46184 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (flutter/engine#46183 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 09:14:11 +00:00
Matheus Kirchesch
801a1c9304
Added option to disable [NavigationDrawerDestination]s ( #132349 )
...
This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations
* https://github.com/flutter/flutter/issues/132348
2023-09-22 08:03:02 +00:00
engine-flutter-autoroll
12d761a828
Roll Flutter Engine from f8e909b88f3f to 3a2346ade2f2 (4 revisions) ( #135283 )
...
f8e909b88f...3a2346ade2skia-flutter-autoroll@skia.org Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (flutter/engine#46182 )
2023-09-22 leroux_bruno@yahoo.fr [iOS] Disable spelling corrections when auto correction is disabled (flutter/engine#46144 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 86454ab4f3de to 97ec4dbabd05 (1 revision) (flutter/engine#46181 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 5d33f4c85b82 to 6bde93a6e56f (1 revision) (flutter/engine#46180 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 07:36:08 +00:00
Qun Cheng
09f7d7c560
Remove extra padding if a dropdown menu entry also has a leading icon ( #135004 )
...
Fixes #131350
This PR is to remove the extra padding in `DropdownMenuEntry` if both the text field and the dropdown menu entry have leading icons.
**After** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 35 24 PM" src="https://github.com/flutter/flutter/assets/36861262/ed7d92a5-3f96-4106-a03e-09258ea3709f ">
**Before** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 37 58 PM" src="https://github.com/flutter/flutter/assets/36861262/fdbfef54-6c93-48fb-bd64-41fa31dde531 ">
2023-09-22 07:34:06 +00:00
engine-flutter-autoroll
f388559bdc
Roll Flutter Engine from e0fb071ead2f to f8e909b88f3f (1 revision) ( #135281 )
...
e0fb071ead...f8e909b88fskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PXDDhlPyd9sgrWWun... to ZyajVWocCHVIuJkzM... (flutter/engine#46179 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from PXDDhlPyd9sg to ZyajVWocCHVI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 06:40:50 +00:00
Daco Harkes
2def951924
Reland "Native assets support for Linux" ( #135097 )
...
Reland of #134031 . (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.
Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for Linux.
Mainly follows the design of https://github.com/flutter/flutter/pull/130494 .
Some differences are:
* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.
The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
### Tests
This PR adds new tests to cover the various use cases.
* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
* Unit tests the Linux-specific part of building native assets.
It also extends various existing tests:
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-22 06:07:06 +00:00
Tomasz Gucio
0377e80de8
Size CupertinoTextSelectionToolbar to children ( #133386 )
2023-09-22 07:49:06 +02:00
engine-flutter-autoroll
85e52d4363
Roll Flutter Engine from e726798410af to e0fb071ead2f (2 revisions) ( #135276 )
...
e726798410...e0fb071eadskia-flutter-autoroll@skia.org Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 5b2dae1a9b54 to 86454ab4f3de (1 revision) (flutter/engine#46175 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 03:34:27 +00:00
engine-flutter-autoroll
68d5c1760b
Roll Flutter Engine from 2a33fdc4be48 to e726798410af (1 revision) ( #135271 )
...
2a33fdc4be...e726798410dnfield@google.com [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 02:14:19 +00:00
engine-flutter-autoroll
5163d81489
Roll Flutter Engine from 7a9409e12fab to 2a33fdc4be48 (3 revisions) ( #135270 )
...
7a9409e12f...2a33fdc4beskia-flutter-autoroll@skia.org Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168 )
2023-09-21 matanlurey@users.noreply.github.com Revert #46131 , don't store `vkImage`, reset `vkComandPool` synchronously (flutter/engine#46166 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 01:20:25 +00:00
Kostia Sokolovskyi
9d42ad84ee
Fix memory leak in NestedScrollViewState. ( #135248 )
2023-09-21 18:20:23 -07:00
engine-flutter-autoroll
5def6f2bab
Roll Flutter Engine from 78c1ad249b57 to 7a9409e12fab (8 revisions) ( #135266 )
...
78c1ad249b...7a9409e12fskia-flutter-autoroll@skia.org Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164 )
2023-09-21 john@johnmccutchan.com Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071 )
2023-09-21 jonahwilliams@google.com [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023 )
2023-09-21 matanlurey@users.noreply.github.com More Clang Tidy --fix[es] to header files (flutter/engine#46151 )
2023-09-21 dkwingsmt@users.noreply.github.com Reland: Enforce the rule of calling FlutterView.Render (#45300 ) (flutter/engine#45555 )
2023-09-21 yjbanov@google.com Revert "[web] fix clicks on merged semantic nodes (#43620 )" (flutter/engine#46067 )
2023-09-21 matanlurey@users.noreply.github.com Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (flutter/engine#46017 )
2023-09-21 godofredoc@google.com Remove linux fuchsia from recipes cq. (flutter/engine#46153 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 00:00:09 +00:00
Kostia Sokolovskyi
ffecedbca4
Cover more test/widgets tests with leak tracking #11 ( #135231 )
2023-09-21 16:30:32 -07:00
Jacob MacDonald
daea6e00bf
remove field override, assign to super field instead ( #135165 )
...
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.
Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).
2023-09-21 22:02:12 +00:00
hangyu
528a281a5c
Update alwaysNeedsCompositing in RenderParagraph ( #135076 )
...
fix #111370
According to
5b47fef613/packages/flutter/lib/src/rendering/box.dart (L1259)https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-21 14:53:22 -07:00
LongCatIsLooong
45e4a0e525
Fix a TextSpan test ( #135187 )
...
`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.
2023-09-21 19:41:58 +00:00
Yegor
d0664bcd79
a few web tweaks for a11y assessment app ( #134479 )
...
Mostly tweaks for better focus management, namely:
* Use `autofocus` throughout so the a11y focus is transferred to a logical place when overlaid content pops up (screen transitions, dialogs).
* Consolidate "enabled" and "disabled" widgets into the same screen. Otherwise, when only a disabled widget is shown, there's nothing to focus on and the screen reader is lost.
2023-09-21 19:38:20 +00:00
Zachary Anderson
30a9f99bc8
Send analytics on 'build ios' and 'build ipa' for plist impeller value ( #135193 )
...
This analytics event only records the value of the plist entry on
`build` commands. This will give an idea of the proportion of users who
are disabling Impeller when shipping apps.
2023-09-21 11:49:29 -07:00
Derek Xu
c627dbfbc6
Add --frontend-server-starter-path option to flutter run and flutter test ( #135038 )
2023-09-21 14:32:35 -04:00
engine-flutter-autoroll
da1f801fd5
Roll Flutter Engine from fa032d52a118 to 78c1ad249b57 (1 revision) ( #135238 )
...
fa032d52a1...78c1ad249bskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3DKf4d8UFviYKRI28... to PXDDhlPyd9sgrWWun... (flutter/engine#46148 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3DKf4d8UFviY to PXDDhlPyd9sg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 18:16:40 +00:00
Tong Mu
203ec67c65
Fix violation of the render rule in Windows Startup Test ( #134245 )
...
This PR fixes yet another case in the windows startup test that violates the render rule, which caused https://github.com/flutter/engine/pull/45300 to be reverted.
Although the `FlutterView.render` call is within `onBeginFrame`, there is an `await` before the call, causing the call to fall out of the synchronous scope.
I've added this problem to the documentation of `FlutterView.render` in https://github.com/flutter/engine/pull/45555 .
2023-09-21 17:43:07 +00:00
Bruno Leroux
de44daf1f8
Add a parameter to configure InputDecorator hint fade animations duration ( #135211 )
...
## Description
This PR adds a parameter to configure the input decorator hint fade transition duration.
This animation is not part of the Material specification.
Removing it was considered but it breaks internal tests (see https://github.com/flutter/flutter/pull/107406 ).
I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible.
To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/20283 .
## Tests
Adds 3 tests, updates 3 tests.
2023-09-21 17:37:07 +00:00
Kostia Sokolovskyi
4204f07d76
Add RestorationManager disposals in test/services/restoration_test.dart. ( #135218 )
2023-09-21 10:24:52 -07:00
Polina Cherkasova
77718845dd
Handle breaking changes in leak_tracker. ( #135185 )
2023-09-21 10:06:21 -07:00
engine-flutter-autoroll
5708b76ef0
Roll Flutter Engine from 6c1e58c86e8c to fa032d52a118 (1 revision) ( #135227 )
...
6c1e58c86e...fa032d52a1skia-flutter-autoroll@skia.org Roll Skia from 322abacca561 to 0cf83a86c56d (1 revision) (flutter/engine#46143 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 16:30:00 +00:00
engine-flutter-autoroll
8f04f0c2f8
Roll Packages from 51e74b97508a to d0411e450a8d (1 revision) ( #135224 )
...
51e74b9750...d0411e450astuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 15:45:19 +00:00
engine-flutter-autoroll
22748e3a3a
Roll Flutter Engine from 584861202198 to 6c1e58c86e8c (1 revision) ( #135216 )
...
5848612021...6c1e58c86esigurdm@google.com Add package:tar to DEPS (flutter/engine#46140 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 13:33:29 +00:00
derdilla
beeb3ce923
Cover some cupertino tests with leak tracing ( #135149 )
2023-09-21 06:30:21 -07:00
engine-flutter-autoroll
687f9c867f
Roll Flutter Engine from a4b1ef79596a to 584861202198 (2 revisions) ( #135214 )
...
a4b1ef7959...5848612021skia-flutter-autoroll@skia.org Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from c20aeee90da9 to 322abacca561 (1 revision) (flutter/engine#46137 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 10:53:27 +00:00
engine-flutter-autoroll
089e93a15c
Roll Flutter Engine from 3e66ffa6aae6 to a4b1ef79596a (1 revision) ( #135206 )
...
3e66ffa6aa...a4b1ef7959skia-flutter-autoroll@skia.org Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 07:38:23 +00:00
Bruno Leroux
07cc3f7a61
Form fields onChange callback should be called on reset ( #134295 )
...
## Description
This PR fixes form fields in order to call the `onChange` callback when the form is reset.
This change is based on the work done in https://github.com/flutter/flutter/pull/123108 .
I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123009 .
## Tests
Adds 3 tests.
2023-09-21 05:54:19 +00:00
engine-flutter-autoroll
518b775191
Roll Flutter Engine from 88aad1056781 to 3e66ffa6aae6 (2 revisions) ( #135200 )
...
88aad10567...3e66ffa6aaskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (flutter/engine#46133 )
2023-09-21 jonahwilliams@google.com [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zuOP7YCHHocX to 3DKf4d8UFviY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 05:48:26 +00:00
engine-flutter-autoroll
b90a13f3a1
Roll Flutter Engine from 76e5e35ab395 to 88aad1056781 (1 revision) ( #135198 )
...
76e5e35ab3...88aad10567skia-flutter-autoroll@skia.org Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (flutter/engine#46129 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 04:44:25 +00:00
engine-flutter-autoroll
c416aa4735
Roll Flutter Engine from 89d864552acd to 76e5e35ab395 (21 revisions) ( #135192 )
...
89d864552a...76e5e35ab3matanlurey@users.noreply.github.com Tidy up `DlPaint` and friends. (flutter/engine#46120 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (flutter/engine#46128 )
2023-09-21 30870216+gaaclarke@users.noreply.github.com [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127 )
2023-09-20 jonahwilliams@google.com [Impeller] Remove removal of save layer from clip. (flutter/engine#46113 )
2023-09-20 jason-simmons@users.noreply.github.com [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106 )
2023-09-20 matanlurey@users.noreply.github.com Clang tidy-ify `DlColor` and friends. (flutter/engine#46122 )
2023-09-20 godofredoc@google.com Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (flutter/engine#46121 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119 )
2023-09-20 matanlurey@users.noreply.github.com Make `dl_color_(filter|source)` tidy. (flutter/engine#46111 )
2023-09-20 matanlurey@users.noreply.github.com Make `dl_(image|mask|path)_(filter|effect).h` tidy! (flutter/engine#46110 )
2023-09-20 matanlurey@users.noreply.github.com Migrate from `LOG_X` to `kLogX`. (flutter/engine#46107 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118 )
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116 )
2023-09-20 ychris@google.com [ios] fix asset url not found when loading app extension (flutter/engine#46073 )
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (flutter/engine#46112 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108 )
2023-09-20 mdebbar@google.com [web] Move context menu handling to its own class (flutter/engine#46042 )
2023-09-20 matanlurey@users.noreply.github.com Delete `ci/lint.sh`, which is no longer used. (flutter/engine#46049 )
2023-09-20 mdebbar@google.com [web] Make `PlatformViewManager` a clear singleton (flutter/engine#46044 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 03:09:24 +00:00
Jia Hao
f92884c7b8
Rename debugProfilePlatformChannels to a constant that works in release mode ( #134922 )
...
When it comes to startup profiling, it is very helpful to look at platform channels. `debugProfilePlatformChannels` today only works in debug and profile mode. Unfortunately, using profile mode is less accurate for startup profiling, because of the service isolate introducing additional overhead.
This PR allows this toggle to work in release mode. Note that there are two parts to `debugProfilePlatformChannels`:
- Adding timeline events
- Logging statistics about platform channels
I also considered adding a separate toggle to limit the scope of this change to the former, but that seems like complexity that we might not need at this time.
Towards #102189
2023-09-21 00:20:09 +00:00
