auto-submit[bot]
c881808ed2
Reverts "Use Layer.toImage for golden tests on CanvasKit" ( #136860 )
...
Reverts flutter/flutter#135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
2023-10-19 02:20:19 +00:00
Michael Goderbauer
571039f6ee
Bump flutter_lints to 3.0 ( #136841 )
...
Follow-up to https://github.com/flutter/packages/pull/5177
2023-10-18 23:53:08 +00:00
Greg Spencer
2492242593
Add code for updating focusedChild when removing grandchildren from scope ( #136771 )
...
## Description
This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/136758
## Tests
- Added regression test.
2023-10-18 23:44:40 +00:00
Harry Terkelsen
747128ff7a
Use Layer.toImage for golden tests on CanvasKit ( #135249 )
...
Changes golden tests on CanvasKit to use Layer.toImage instead of
browser APIs for screenshots. This brings it more in line with other
platforms and should also fix some async timing bugs with tests.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-18 16:39:27 -07:00
engine-flutter-autoroll
9391a88b18
Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) ( #136846 )
...
b67edb05d3...8d51b64e94skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073 )
2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 23:09:37 +00:00
engine-flutter-autoroll
d9fdbd3df4
Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) ( #136844 )
...
6caee3236d...b67edb05d331859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603 )
2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 22:25:47 +00:00
Sam Rawlins
25d2cdaab7
Null-assert the value given to a Completer expecting a non-null value ( #136776 )
...
The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value.
The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253 .
Fixes https://github.com/flutter/flutter/issues/136775
2023-10-18 22:19:18 +00:00
engine-flutter-autoroll
189196d104
Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) ( #136834 )
...
ab86c53c19...6caee3236dskia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063 )
2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 21:27:10 +00:00
auto-submit[bot]
c32ffa65c9
Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" ( #136839 )
...
Reverts flutter/flutter#136751
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
2023-10-18 20:33:17 +00:00
Greg Spencer
13a0d475f5
Convert menus to use OverlayPortal ( #130534 )
...
## Description
This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/124830
## Tests
- No tests yet (hence it is a draft)
2023-10-18 20:13:08 +00:00
Victoria Ashworth
1599cbebc3
[Reland] Skip injecting Bonjour settings when port publication is disabled ( #136751 )
...
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
2023-10-18 20:08:19 +00:00
engine-flutter-autoroll
697242c9f1
Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) ( #136832 )
...
0eff5d1918...ab86c53c19skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 19:39:07 +00:00
chunhtai
24530b8021
Fixes ability to call nextFocus() on a node to focus its descendant ( #136773 )
...
fixes https://github.com/flutter/flutter/issues/134854
2023-10-18 19:00:53 +00:00
engine-flutter-autoroll
f847346d9c
Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) ( #136829 )
...
b778a07f8a...0eff5d1918skia-flutter-autoroll@skia.org Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057 )
2023-10-18 jiahaog@users.noreply.github.com Add missing source file (flutter/engine#47046 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Kp2wNpzRlAtbME0R4... to PxJM5ivbnbYoVkqBg... (flutter/engine#47056 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5172e904def7 to a52d2a9e2b01 (2 revisions) (flutter/engine#47055 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from OudOcFarQhQQ to 2HSBpWikGWvP
fuchsia/sdk/core/mac-amd64 from Kp2wNpzRlAtb to PxJM5ivbnbYo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 18:45:18 +00:00
Robert Ancell
fe9d9a9db3
Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. ( #136780 )
...
This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown.
Solution for https://github.com/flutter/flutter/issues/136582
2023-10-18 18:08:53 +00:00
engine-flutter-autoroll
07d081b284
Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) ( #136818 )
...
7f37c9b181...b778a07f8askia-flutter-autoroll@skia.org Roll Skia from 8132e3356d63 to 5172e904def7 (4 revisions) (flutter/engine#47052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 18:08:50 +00:00
Taha Tesser
4f959b97a7
Fix Slider onChanged callback order & never calls onChangeStart on SliderInteraction.slideOnly allowed interaction ( #136720 )
...
fixes [Slider will call onChanged before onChangeStart when sliding.](https://github.com/flutter/flutter/issues/136707 )
This fixes a regression from https://github.com/flutter/flutter/pull/121483
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
double _sliderValue = 0.5;
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Slider(
// allowedInteraction: SliderInteraction.tapAndSlide,
// allowedInteraction: SliderInteraction.tapOnly,
// allowedInteraction: SliderInteraction.slideOnly
// allowedInteraction: SliderInteraction.slideThumb,
value: _sliderValue,
onChangeStart: (newValue) {
print("onChangeStart ......");
},
onChanged: (newValue) {
print("onChanged ......");
setState(() {
_sliderValue = newValue;
});
},
onChangeEnd: (newValue) {
print("onChangeEnd ......");
},
),
),
);
}
}
```
</details>
2023-10-18 16:25:47 +00:00
engine-flutter-autoroll
d195d90dc6
Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) ( #136817 )
...
78026b4003...7f37c9b181zanderso@users.noreply.github.com Revert "Roll buildroot to pull in removal of //tools." (flutter/engine#47053 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 16:20:02 +00:00
Arash
a9567313c1
[Feat] Stroke color for Slider value indicator ( #135986 )
...
Consider a scenario where the background color and indicator's background color are the same.
Adding a stroke color to the value indicator would be a valuable for the following reasons:
- **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice.
- **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps.
- **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes #135984
2023-10-18 16:03:08 +00:00
Aakash Pamnani
941897f60b
Fixed : Empty Rows shown at last page in Paginated data table ( #132646 )
...
Fixed empty rows at the last page in paginated data table
BEFORE:
AFTER:
Issues resolves : #80421
2023-10-18 15:44:31 +00:00
engine-flutter-autoroll
8e4292b144
Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) ( #136814 )
...
46923fd390...78026b4003skia-flutter-autoroll@skia.org Roll Skia from fed09695a0b9 to 8132e3356d63 (2 revisions) (flutter/engine#47050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 15:41:10 +00:00
engine-flutter-autoroll
553088f673
Roll Packages from d4390624a624 to 14aa69e2e54c (1 revision) ( #136813 )
...
d4390624a6...14aa69e2e5engine-flutter-autoroll@skia.org Roll Flutter from afc391602b06 to 6eea6e277e56 (27 revisions) (flutter/packages#5165 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 15:41:08 +00:00
Daco Harkes
402a5455d9
Don't build native assets in flutter build bundle ( #136641 )
...
Closes: https://github.com/flutter/flutter/issues/136547
2023-10-18 11:57:44 +00:00
engine-flutter-autoroll
4b7b4d4176
Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) ( #136795 )
...
c9c9684e03...46923fd390skia-flutter-autoroll@skia.org Roll Skia from 212da8293790 to fed09695a0b9 (1 revision) (flutter/engine#47045 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 09:21:31 +00:00
engine-flutter-autoroll
e1fc37d8dc
Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) ( #136792 )
...
0c1c29271e...c9c9684e03skia-flutter-autoroll@skia.org Roll Skia from 3d938d4b00ee to 212da8293790 (1 revision) (flutter/engine#47043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 07:54:11 +00:00
engine-flutter-autoroll
552360e3de
Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) ( #136789 )
...
1de09d13e7...0c1c29271eskia-flutter-autoroll@skia.org Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042 )
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 13694b8c64aa to 8796ee7d1c66 (1 revision) (flutter/engine#47041 )
2023-10-18 matej.knopp@gmail.com [macOS] Fix tests failing on Sonoma (flutter/engine#46461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 07:03:20 +00:00
engine-flutter-autoroll
8a4c81b54a
Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) ( #136785 )
...
6fc36e61a9...1de09d13e7skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VtEx0R7lepGA to OudOcFarQhQQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 05:56:30 +00:00
engine-flutter-autoroll
de49229395
Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) ( #136781 )
...
3f818efff3...6fc36e61a9skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E0Ui7KmD3u5JSKEk5... to Kp2wNpzRlAtbME0R4... (flutter/engine#47037 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E0Ui7KmD3u5J to Kp2wNpzRlAtb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 04:44:16 +00:00
engine-flutter-autoroll
911c4789fe
Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) ( #136777 )
...
2eef9b43cf...3f818efff3skia-flutter-autoroll@skia.org Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033 )
2023-10-18 chinmaygarde@google.com Roll buildroot to pull in removal of //tools. (flutter/engine#47032 )
2023-10-18 jonahwilliams@google.com Disable threading test that fails on CI (flutter/engine#47034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 02:19:42 +00:00
engine-flutter-autoroll
4cf73ca586
Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) ( #136774 )
...
5df7af34a7...2eef9b43cfchris@bracken.jp Move imgui from buildroot to flutter third_party (flutter/engine#47031 )
2023-10-17 jonahwilliams@google.com [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963 )
2023-10-17 chris@bracken.jp [fml][embedder] Improve thread-check logging (flutter/engine#47020 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 00:58:11 +00:00
Christopher Fujino
8a31a3a284
Flutter preview device ( #135639 )
...
Fixes https://github.com/flutter/flutter/issues/130277
This PR does two things:
1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging.
2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.
2023-10-18 00:27:54 +00:00
Gildásio Filho
492b6f7ddf
Add findChildIndexCallback examples ( #133469 )
...
The documentation for using `findChildIndexCallback` recommends using `indexOf`, but that causes [this line](05259ca938/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart (L259)#107123 , but this doesn't actually fix it.
-----
This PR has been updated to add the snippets that were used in the `findChildIndexCallback` comment as examples with proper tests, as well as updating the comment to reference the new examples.
2023-10-18 00:26:17 +00:00
pdblasi-google
52a1a31823
Adds API for performing semantics actions in tests ( #132598 )
...
* Added `performAction` to `SemanticsController` as well as specific methods for specific actions
* Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)`
* Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>`
Closes #112413
2023-10-18 00:26:14 +00:00
engine-flutter-autoroll
11a2bc0b09
Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) ( #136772 )
...
e57b5bac42...5df7af34a7chinmaygarde@google.com Roll buildroot to pull in //gpu removal. (flutter/engine#47014 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-18 00:19:24 +00:00
engine-flutter-autoroll
23d3b1e4a5
Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) ( #136768 )
...
f9f937e510...e57b5bac42jason-simmons@users.noreply.github.com Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017 )
2023-10-17 jason-simmons@users.noreply.github.com Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 23:08:23 +00:00
Andrew Kolos
cdc40b5226
clean up --dart-define-from-file option tests ( #135980 )
...
Fixes https://github.com/flutter/flutter/issues/134279 .
Changes:
* Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`.
* Deletes a duplicate test of malformed JSON detection behavior.
* Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file.
* Renames several tests to better articulate what is under test and what the expected result is.
* Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.
2023-10-17 22:31:38 +00:00
Kostia Sokolovskyi
22f593e578
GoldenFileComparators should dispose created Image objects. ( #136716 )
2023-10-17 15:25:52 -07:00
LinChen
3d1d4532b5
make integration_test_driver_extended.dart support writeResponseData--(done) ( #128382 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
- https://github.com/flutter/flutter/issues/128381
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-10-17 22:17:09 +00:00
dependabot[bot]
380520d41d
Bump actions/checkout from 3.6.0 to 4.1.1 ( #136762 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.6.0 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Update CODEOWNERS to Launch team by <a href="https://github.com/joshmgross "><code>@âjoshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1510 ">actions/checkout#1510</a></li>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe "><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511 ">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514 ">actions/checkout#1514</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshmgross "><code>@âjoshmgross</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1510 ">actions/checkout#1510</a></li>
<li><a href="https://github.com/peterbe "><code>@âpeterbe</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1511 ">actions/checkout#1511</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4...v4.1.1 ">https://github.com/actions/checkout/compare/v4...v4.1.1 </a></p>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README.md for V4 by <a href="https://github.com/sivapalan "><code>@âsivapalan</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1452 ">actions/checkout#1452</a></li>
<li>Add support for partial checkout filters by <a href="https://github.com/finleygn "><code>@âfinleygn</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1396 ">actions/checkout#1396</a></li>
<li>Prepare 4.1.0 release by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1496 ">actions/checkout#1496</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/sivapalan "><code>@âsivapalan</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1452 ">actions/checkout#1452</a></li>
<li><a href="https://github.com/finleygn "><code>@âfinleygn</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1396 ">actions/checkout#1396</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.0.0...v4.1.0 ">https://github.com/actions/checkout/compare/v4.0.0...v4.1.0 </a></p>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a href="https://github.com/takost "><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a href="https://github.com/simonbaird "><code>@âsimonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a href="https://github.com/takost "><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447 ">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost "><code>@âtakost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li><a href="https://github.com/simonbaird "><code>@âsimonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0 ">https://github.com/actions/checkout/compare/v3...v4.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396 ">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067 ">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436 ">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377 ">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579 ">Add option to fetch tags even if fetch-depth > 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196 ">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287 ">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369 ">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289 ">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246 ">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237 ">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209 ">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210 ">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225 ">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045 ">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050 ">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770 ">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057 ">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942 ">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967 ">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002 ">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964 ">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029 ">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039 ">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939 ">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922 ">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b4ffde65f4https://redirect.github.com/actions/checkout/issues/1514 ">#1514</a>)</li>
<li><a href="8530928916https://redirect.github.com/actions/checkout/issues/1511 ">#1511</a>)</li>
<li><a href="7cdaf2fbc0https://redirect.github.com/actions/checkout/issues/1510 ">#1510</a>)</li>
<li><a href="8ade135a41https://redirect.github.com/actions/checkout/issues/1496 ">#1496</a>)</li>
<li><a href="c533a0a4cfhttps://redirect.github.com/actions/checkout/issues/1396 ">#1396</a>)</li>
<li><a href="72f2cec99fhttps://redirect.github.com/actions/checkout/issues/1452 ">#1452</a>)</li>
<li><a href="3df4ab11ebhttps://redirect.github.com/actions/checkout/issues/1447 ">#1447</a>)</li>
<li><a href="8b5e8b7687https://redirect.github.com/actions/checkout/issues/1067 ">#1067</a>)</li>
<li><a href="97a652b800https://redirect.github.com/actions/checkout/issues/1436 ">#1436</a>)</li>
<li>See full diff in <a href="f43a0e5ff2...b4ffde65f4https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.6.0&new-version=4.1.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-10-17 22:15:11 +00:00
engine-flutter-autoroll
cdb2304ccc
Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) ( #136755 )
...
289f29b1ad...f9f937e510skia-flutter-autoroll@skia.org Roll Skia from 1a332d2b35d9 to a9caf3c19792 (1 revision) (flutter/engine#47013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 21:12:08 +00:00
engine-flutter-autoroll
9fd8217abc
Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) ( #136752 )
...
659e68a097...289f29b1ad31859944+LongCatIsLooong@users.noreply.github.com Don't respond to the `insertionPointColor` selector on iOS 17+ (flutter/engine#46373 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 20:32:54 +00:00
Aran Donohue
48eee14f0e
Support --web-header option for flutter run ( #136297 )
...
Adds support for a new --web-header option to flutter run.
Creates a workaround for https://github.com/flutter/flutter/issues/127902
This PR allows adding additional headers for the flutter run web server. This is useful to add headers like Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy without the use of a proxy server. These headers are required enable advanced web features. This approach provides flexibility to the developer to make use of the feature as they see fit and is backward-compatible. One tradeoff is that it increases the surface area to support for future changes to the flutter web server.
https://github.com/flutter/flutter/issues/127902 is not fully addressed by this change. The solution for that task will be more opinionated. This PR creates a general-purpose workaround for anyone who needs a solution sooner while the bigger solution is developed.
2023-10-17 19:42:01 +00:00
Gray Mackall
b136ddc68b
Add Android 14 physical devices to firebase tests ( #136736 )
...
I've been keeping an eye on the device list, and android 14 devices recently became available. For reviewing purposes (and anyone who comes across this in the future), you can check the available devices here at the third option without needing a firebase login:
https://firebase.google.com/docs/test-lab/android/available-testing-devices
The "shiba" device is high capacity. There are no api 34 virtual devices yet.
2023-10-17 19:42:00 +00:00
engine-flutter-autoroll
8536be52b0
Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) ( #136746 )
...
62a90a91ce...659e68a097zanderso@users.noreply.github.com Shift some engine DEPS from github to mirrors (flutter/engine#46633 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 8b3f2ef48a90 to 1a332d2b35d9 (1 revision) (flutter/engine#47009 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2418bda7a457 to 99ce477503f8 (1 revision) (flutter/engine#47008 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 19:41:58 +00:00
auto-submit[bot]
54c0a350dd
Reverts "Skip injecting Bonjour settings when port publication is disabled" ( #136750 )
...
Reverts flutter/flutter#136562
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836 ) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).
Normally, we inject `NSLocalNetworkUsageDescription` (and other bonjour settings) to the Info.plist during the project build for debug and profile mode since by default they will publish the VM Service port over mDNS.
To help diagnose the issue, though, this PR changes it so that we don't inject `NSLocalNetworkUsageDescription` (and other bonjour settings) when port publication is disabled since it shouldn't be needed. Hopefully, this will give us better error messages or cause the app to crash and end the test early (rather than timeout after 30 minutes).
2023-10-17 19:27:19 +00:00
Kate Lovett
0cc2eff204
Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" ( #136744 )
2023-10-17 14:19:24 -05:00
Victoria Ashworth
0383d8ba9e
Skip injecting Bonjour settings when port publication is disabled ( #136562 )
...
Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836 ) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).
Normally, we inject `NSLocalNetworkUsageDescription` (and other bonjour settings) to the Info.plist during the project build for debug and profile mode since by default they will publish the VM Service port over mDNS.
To help diagnose the issue, though, this PR changes it so that we don't inject `NSLocalNetworkUsageDescription` (and other bonjour settings) when port publication is disabled since it shouldn't be needed. Hopefully, this will give us better error messages or cause the app to crash and end the test early (rather than timeout after 30 minutes).
2023-10-17 19:09:08 +00:00
engine-flutter-autoroll
24a762b736
Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) ( #136739 )
...
3ecbe924a5...62a90a91ce30870216+gaaclarke@users.noreply.github.com [Impeller] added trace statements for colorsources (flutter/engine#47007 )
2023-10-17 chinmaygarde@google.com Move the secondary build tree into the engine. (flutter/engine#46989 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 18:48:59 +00:00
engine-flutter-autoroll
5227d00609
Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) ( #136732 )
...
0a4d8b99a9...3ecbe924a5skia-flutter-autoroll@skia.org Roll Skia from d937d10a0ba9 to 8b3f2ef48a90 (3 revisions) (flutter/engine#47005 )
2023-10-17 jacksongardner@google.com Include symbol maps in CanvasKit and Skwasm builds. (flutter/engine#46973 )
2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y9mDBoH4BSC6pWFXV... to VtEx0R7lepGAvwAMU... (flutter/engine#47004 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y9mDBoH4BSC6 to VtEx0R7lepGA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-17 18:08:23 +00:00
Ricardo Amador
d42b4bb55a
Reenable NexusLowRes API 29 ( #136686 )
...
Reenable the NexusLowRes API version 29 tests.
*List which issues are fixed by this PR. You must list at least one issue.*
fixes https://buganizer.corp.google.com/issues/302753598
fixes flutter/flutter#135784
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-10-17 18:04:11 +00:00
