These are bugs uncovered by the integration test for embedded Android
views:
* Some PointerEvents were constructed with radiusMinor set to
radiusMajor.
* Some PointerEvents were missing radiusMajor/radiusMinor.
* The pressure parameter was not passed to PointerUpEvent.
* radiusMin, radiusMax, radiusMinor, and radiusMajor were not
converted from physical pixels to logical.
Sending the fixes without a test as the bugs are covered by the integration
test that is going to land soon.
Updated documentation of SizeTransition, since I found it less than intuitive.
I added some constructor asserts to make the (existing) contract more clear.
* Skip integration tests that use flutter-tester on Windows
This is known to be broken. I will un-skip all of these once a fix for flutter-tester lands on Windows.
* Save with added import!
* Add tests to ensure flutter run does not quit at startup
These tests require https://github.com/dart-lang/vm_service_client/pull/38 to be merged and currently the third test (pause-on-exceptions) fails because of a bug.
* Remove TODO
Probably makes most sense this way for now.
* Address PR comments
* Add `--dry-run` option to `flutter format` sub command
* Add `--set-exit-if-changed` option to `format` sub command
* Add `--machine` option to `format` sub command
* Make variable names to be not shorthand: cmd -> command
Fix https://github.com/flutter/flutter/pull/18360#discussion_r199656120
95e91e31f Update tonic to pull in Android build fixes. (#5834)
29f475c8d Update tonic to pull in fixes to assertions and build failures on Windows. (#5833)
5474415e1 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (#5832)
380eb84c4 Remove unused function CreateSkiaInterface (#5812)
33a4aef1d Fix build break caused by https://github.com/flutter/engine/pull/5830 (#5831)
244ebd660 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (#5830)
0bad812c7 Migrate to a standalone Tonic repository separated from Topaz (#5817)
f949f7d43 Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (#5829)
768daa4d3 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (#5828)
b8cd25b4f libtxt: fix a bug that used incorrect buffer size depending on conditions (#5804)
b7b13b5e9 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (#5824)
5886949c9 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (#5822)
926f546de Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (#5821)
04633f326 Generate process global trace identifiers for pipeline flow traces. (#5818)
fb0bc05d7 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (#5820)
fadfff7fd Mention that running git clone isn't necessary (#5816)
81ec6000d Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (#5819)
2a77a4130 Make git diff range more robust in format.sh (#5813)
e555ea573 Remove trailing white spaces (#5734)
4c7618ac7 Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (#5814)
Changes:
- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
Added five InputBorder properties to InputDecoration etc so that apps can control the appearance of an InputDecorator's border: errorBorder, focusedBorder, focusedErrorBorder, disabledBorder, enabledBorder.
* fixed segmented control golden test
* fixed segmented control golden test
* made the comments more explanatory
* changed comment, wrapped tests with if statements so they only run on MacOS
* changed formatting
* added width and radius fields to TextField; to do: tests and Material defaults
* weak warnings
* added tests
* added default cursor width; changed default EditableText width
* only run golden file tests on linux
* changed goldens version
* actually changed goldens.version
* style changes
* small fixes
* added default material cursor color
* changed goldens.version
* changed goldens version again
* changed goldens.version again (3)
* added todo
* deleted whitespace
The trailing whitespace detector wasn't handling file deletes very well (at all, really).
This filters the set of files grepped to only include files that exist.
Also, clarified the failure message to make it more obvious what the failure is when the grep finds results.
We don't actually care if we're on linux, we care only if the lcov
tool is available. We check for that explicitly just below.
Additionally there is code below which indicates that lcov is available
for macOS. Before this change that code would never execute.
RenderAndroidView is responsible for sizing and displaying an embedded
Android view.
AndroidView is responsible for creating and disposing the Android view
and is using RenderAndroidView to display it.
* Changed duration
* Fixed column width for ios build error messages
* fixed a couple things
* fixed a couple things
* accidental changes
* added spaces
* added spaces
* Added test for default snackbar duration
* Fixed link:
* Final commit
* Final commit2
* Actual final commit
The verbosity change is to help track down timeouts that currently look like:
```
C:\Windows\Temp\flutter sdk>call bin\flutter.bat config --no-analytics
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine c5a63d28bf3735569c8187753bc490d8351a8363...
Unzipping Dart SDK...
Updating flutter tool...
```
