These are bugs uncovered by the integration test for embedded Android
views:
* Some PointerEvents were constructed with radiusMinor set to
radiusMajor.
* Some PointerEvents were missing radiusMajor/radiusMinor.
* The pressure parameter was not passed to PointerUpEvent.
* radiusMin, radiusMax, radiusMinor, and radiusMajor were not
converted from physical pixels to logical.
Sending the fixes without a test as the bugs are covered by the integration
test that is going to land soon.
Updated documentation of SizeTransition, since I found it less than intuitive.
I added some constructor asserts to make the (existing) contract more clear.
* Skip integration tests that use flutter-tester on Windows
This is known to be broken. I will un-skip all of these once a fix for flutter-tester lands on Windows.
* Save with added import!
* Add tests to ensure flutter run does not quit at startup
These tests require https://github.com/dart-lang/vm_service_client/pull/38 to be merged and currently the third test (pause-on-exceptions) fails because of a bug.
* Remove TODO
Probably makes most sense this way for now.
* Address PR comments
* Add `--dry-run` option to `flutter format` sub command
* Add `--set-exit-if-changed` option to `format` sub command
* Add `--machine` option to `format` sub command
* Make variable names to be not shorthand: cmd -> command
Fix https://github.com/flutter/flutter/pull/18360#discussion_r199656120
Changes:
- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
Added five InputBorder properties to InputDecoration etc so that apps can control the appearance of an InputDecorator's border: errorBorder, focusedBorder, focusedErrorBorder, disabledBorder, enabledBorder.
* fixed segmented control golden test
* fixed segmented control golden test
* made the comments more explanatory
* changed comment, wrapped tests with if statements so they only run on MacOS
* changed formatting
* added width and radius fields to TextField; to do: tests and Material defaults
* weak warnings
* added tests
* added default cursor width; changed default EditableText width
* only run golden file tests on linux
* changed goldens version
* actually changed goldens.version
* style changes
* small fixes
* added default material cursor color
* changed goldens.version
* changed goldens version again
* changed goldens.version again (3)
* added todo
* deleted whitespace
We don't actually care if we're on linux, we care only if the lcov
tool is available. We check for that explicitly just below.
Additionally there is code below which indicates that lcov is available
for macOS. Before this change that code would never execute.
RenderAndroidView is responsible for sizing and displaying an embedded
Android view.
AndroidView is responsible for creating and disposing the Android view
and is using RenderAndroidView to display it.
* Changed duration
* Fixed column width for ios build error messages
* fixed a couple things
* fixed a couple things
* accidental changes
* added spaces
* added spaces
* Added test for default snackbar duration
* Fixed link:
* Final commit
* Final commit2
* Actual final commit
The verbosity change is to help track down timeouts that currently look like:
```
C:\Windows\Temp\flutter sdk>call bin\flutter.bat config --no-analytics
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine c5a63d28bf3735569c8187753bc490d8351a8363...
Unzipping Dart SDK...
Updating flutter tool...
```
Generated.xcconfig is only required at build time for iOS apps. In the
flutter create project template and example apps, Generated.xcconfig was
previously marked as a resource to be bundled into the built app.
* Extract some of startApp into a reusable method
* Get basic attach --machine working
* Attach --machine tweaks
Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.
* Bump daemon version so we know whether it's valid to flutter attach
* Tweak output text
* Swap package imports for relative
* Review tweaks (naming, formatting, typedefs)
* Separate arguments from process spawning
This will make calling attach easier
* Add a basic test for flutter attach --machine
* Fix crash if port unforward modifies the list of forwarded ports
* Add a no-op port forwarder for flutter-tester
* Switch to using BasicProject instead of our own inline code
* Fix expectation in test now we have a portForwarder
* Remove stale TODO (this is done)
* Tweak formatting
* Change some Completers to void to fix Dart 2 issues
* Make cleanup of flutter processes in tests more reliable
* Fix quit signals
I confused SigInt&SigTerm for SigTerm&SigKill when I first did this. SigTerm can be blocked and doesn't guarantee the process will be terminated.
* Don't use deprecated constants
* Fix typo
* Add some additional info to debug buffer
* Fix return types on Futures
* Only printError on our simple messages
Any other type is a real error that should be a normal crash (to get a proper error log).
See #19453.
* Add toList() to convert Iterable<String> -> List<String>
This code previously throw in Dart-2 mode.
Fixes#19453.
* Move getSimulatorPath into Xcode
* Add a test that we tried to launch the simulator
* Remove unused import
