42041 Commits

Author SHA1 Message Date
Bernardo Ferrari
ce63c029c5
Fix anti-aliasing when painting borders with solid colors. (#153365)
Trying to reland https://github.com/flutter/flutter/pull/122317 in 2024. Let's see if we can.

<img width="666" alt="image" src="https://user-images.githubusercontent.com/351125/182002867-03d55bbb-163d-48b9-ba3c-ed32dbef2680.png">

Side effect: shapes with border will be rounder:
![Frame 6](https://github.com/user-attachments/assets/95324ebc-8db5-4365-817f-bc62304b9044)

Close https://github.com/flutter/flutter/issues/13675.
2024-08-15 19:02:23 +00:00
flutter-pub-roller-bot
70460854d1
Roll pub packages (#153479)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-15 16:39:28 +00:00
engine-flutter-autoroll
ea87865364
Roll Packages from e4f2247c3f41 to 86d15a65d091 (7 revisions) (#153499)
e4f2247c3f...86d15a65d0

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452d3a8e to cc13cd1f1191 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 15:49:24 +00:00
engine-flutter-autoroll
99f00a1309
Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (#153487)
76a1c64f4e...971ddd9fe1

2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Refactor create_macos_framework.py (#54557)" (flutter/engine#54566)
2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] migrate blur tests to display list. (#54519)" (flutter/engine#54564)
2024-08-15 jonahwilliams@google.com [Impeller] migrate blur tests to display list. (flutter/engine#54519)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zCEfW... (flutter/engine#54561)
2024-08-14 chris@bracken.jp macOS: Refactor create_macos_framework.py (flutter/engine#54557)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... (flutter/engine#54559)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from MeV5i7xXXFPH to qpfC-GAVZvOw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 07:00:25 +00:00
Qun Cheng
108a355453
Update tokens to 5.0.0 (#153385)
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;![Screenshot 2024-08-13 at 12 53 03 PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(#122388)
2024-08-14 22:53:36 +00:00
dependabot[bot]
b4b8f07124
Bump github/codeql-action from 3.26.1 to 3.26.2 (#153468)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="429e197704"><code>429e197</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2425">#2425</a> from github/update-v3.26.2-a93f8c2fd</li>
<li><a href="9eec338902"><code>9eec338</code></a> Update changelog for v3.26.2</li>
<li><a href="a93f8c2fd1"><code>a93f8c2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2423">#2423</a> from github/mergeback/v3.26.1-to-main-29d86d22</li>
<li><a href="af1f2e89e3"><code>af1f2e8</code></a> Address incorrect CHANGELOG.md</li>
<li><a href="2bc3b8381e"><code>2bc3b83</code></a> Update checked-in dependencies</li>
<li><a href="dd9700c166"><code>dd9700c</code></a> Reapply &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2....</li>
<li><a href="ece28a826b"><code>ece28a8</code></a> Update changelog and version after v3.26.1</li>
<li>See full diff in <a href="29d86d22a3...429e197704">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.1&new-version=3.26.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-14 22:19:04 +00:00
Michael Goderbauer
4b60bb530f
Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (#153464)
invalid_runtime_check_with_js_interop_types has been added to recommended: 894b5006c4
2024-08-14 22:10:21 +00:00
engine-flutter-autoroll
fafe3df405
Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (#153465)
9b8421662e...76a1c64f4e

2024-08-14 chris@bracken.jp macOS: Clean up create_macos_framework.py (#54543) (flutter/engine#54555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:06:16 +00:00
engine-flutter-autoroll
bd083887a4
Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (#153463)
328c4df832...9b8421662e

2024-08-14 jonnywang@google.com [fuchsia] Use Fuchsia API 22 (flutter/engine#54554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 21:12:18 +00:00
Michael Goderbauer
6289944ed6
Lint sync (#153453)
Just syncs our analysis_options.yaml with https://github.com/dart-lang/sdk/blob/main/pkg/linter/example/all.yaml. This is a no-op.
2024-08-14 21:12:15 +00:00
Michael Goderbauer
2a4e004bc0
manual pub roll w/ gradle updates (#153403)
Follow-up to https://github.com/flutter/flutter/pull/153388.
2024-08-14 21:06:11 +00:00
Camille Simon
f697d61025
Update docs to use new Android version in the engine (#151601)
Updates the steps based on what I found by working on https://github.com/flutter/engine/pull/54186 and https://github.com/flutter/engine/pull/53574 + general cleanup.
2024-08-14 19:57:07 +00:00
Christopher Fujino
5eca44a1c4
move some tool TESTOWNERS entries to andrew (#153400) 2024-08-14 19:38:02 +00:00
Denis Bowen
51c640297f
Slider shows visual label of value on focus (#152960)
Fixed issue to where value indicator label is not shown to user when initially focused.

Before:  [Screen recording 2024-08-05 12.16.24 PM.webm](https://github.com/user-attachments/assets/806e94d7-7c6c-40e5-93af-dbf2fb9e0dd4)
After: https://screencast.googleplex.com/cast/NTY5NzIzMTYxNjIxMjk5MnxkY2IyMGNkYi1iZA

Fixes https://github.com/flutter/flutter/issues/113538
2024-08-14 18:27:14 +00:00
Taha Tesser
ed40925bb1
Add Row and Column widgets specific spacing tests (#153353)
Fixes [Missing `Row` and `Column` widgets specific `spacing` tests](https://github.com/flutter/flutter/issues/153352)
2024-08-14 18:19:17 +00:00
PurplePolyhedron
b5847d364a
Delay DropdownMenu filtering until text input (#152368)
fixes https://github.com/flutter/flutter/issues/152055

Disabling filtering in `DropdownMenu` at start and after a selection has been made, and re-enable it (if `widget.enableFilter` is true) after text input.
This way it doesn't hide all other options when there is an existing selection.

Note: currently this may crush due to issue https://github.com/flutter/flutter/issues/151878 . Which is not directly related to this PR
2024-08-14 18:06:14 +00:00
Loïc Sharma
6ef1156f7e
Update cherry pick issue template's PR field (#153381)
Make it even more obvious which PR should be linked for folks that have difficulties reading ðŸ˜
2024-08-14 17:11:33 +00:00
engine-flutter-autoroll
0e6c1d1015
Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (#153436)
5909666fde...328c4df832

2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from Kq699Ii76C_pozQ9Y... to J1EXQ2ozMIQEa6F7H... (flutter/engine#54551)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 14:01:40 +00:00
Martin Kustermann
354902f7ca
[web] Pass --no-source-maps instead of --extra-compiler-option=--no-source-maps to dart compile wasm (#153417) 2024-08-14 12:00:24 +02:00
engine-flutter-autoroll
92c98e80ff
Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (#153413)
Manual roll requested by zra@google.com

019f9e3f07...5909666fde

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549)
2024-08-14 chris@bracken.jp macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 flar@google.com [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 mit@google.com Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 chris@bracken.jp macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 matej.knopp@gmail.com Preserve background frame damage (flutter/engine#54540)
2024-08-13 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 07:20:39 +00:00
PurplePolyhedron
593729165d
Move @_debugOnly documentation in framework.dart to be more visible to IDE. (#153134)
Change the location of the documentation of `@_debugOnly` following the style of `@override` so it is visible to IDE where the annotation is used.
2024-08-14 01:13:34 +00:00
engine-flutter-autoroll
fb35123b38
Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (#153394)
4246f1536c...019f9e3f07

2024-08-13 jonahwilliams@google.com [Impeller] fix drawPoints scaling factors. (flutter/engine#54368)
2024-08-13 zanderso@users.noreply.github.com Move API level 34 scenario app tests back to prod (flutter/engine#54539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 22:46:16 +00:00
Joy Serquiña
85b3d97673
fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (#152198)
Adds Semantic Widget to wrap the contents of each page's AppBar title attribute and adds header: true and headingLevel: 1 as Semantic attributes so the content of the title is compiled as an h1 tag to meet accessibility guidelines that each page must have a h1 tag present. Also updates the test cases for the home page and each use case page to check for its respective h1.

[Before Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/4i9LuiGwvLnEcZ8)
[Before Screenshot - Checkbox List Title -- note: each use case page is missing an h1](https://screenshot.googleplex.com/3qQjfqvAMTehRsm)
[After Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/APSJJXBmwNBP35m)
[After Screenshot - Checkbox List Title-- note: change is similar across each Accessibility use case page](https://screenshot.googleplex.com/6EGgZnTusEgeN5L)

Fixes b/338035526
2024-08-13 22:22:28 +00:00
dependabot[bot]
87abed2b23
Bump github/codeql-action from 3.26.0 to 3.26.1 (#153395)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="29d86d22a3"><code>29d86d2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2422">#2422</a> from github/update-v3.26.1-0d5982aa3</li>
<li><a href="5b15b9edeb"><code>5b15b9e</code></a> Revert &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.1...</li>
<li><a href="18ac79e766"><code>18ac79e</code></a> Update changelog for v3.26.1</li>
<li><a href="0d5982aa33"><code>0d5982a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2416">#2416</a> from github/henrymercer/ghes-3.14-compat-info</li>
<li><a href="da9ecb0f40"><code>da9ecb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2421">#2421</a> from github/henrymercer/log-job-run-uuid</li>
<li><a href="c4c3c4421f"><code>c4c3c44</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.18.2</li>
<li><a href="41833c77c6"><code>41833c7</code></a> Log job run UUID</li>
<li><a href="d620faa0b4"><code>d620faa</code></a> Bump the npm group with 4 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2419">#2419</a>)</li>
<li><a href="25ad3c8e40"><code>25ad3c8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2418">#2418</a> from github/henrymercer/extraction-time-telemetry</li>
<li><a href="44ecae4896"><code>44ecae4</code></a> Fix matrixing of &quot;submit SARIF after failure&quot; check</li>
<li>Additional commits viewable in <a href="eb055d739a...29d86d22a3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.0&new-version=3.26.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-13 21:54:23 +00:00
engine-flutter-autoroll
b32eaf6f75
Roll Packages from d9a6de802e1f to e4f2247c3f41 (4 revisions) (#153383)
d9a6de802e...e4f2247c3f

2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7386)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 814e49be4922 to 2afc452d3a8e (12 revisions) (flutter/packages#7399)
2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7390)
2024-08-12 engine-flutter-autoroll@skia.org Roll Flutter from 9b8470197f42 to 814e49be4922 (3 revisions) (flutter/packages#7396)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 20:04:16 +00:00
flutter-pub-roller-bot
5f99d5782a
Roll pub packages (#153380)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-13 19:12:24 +00:00
engine-flutter-autoroll
aba00947b6
Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (#153377)
73c3135cc3...4246f1536c

2024-08-13 zanderso@users.noreply.github.com Revert "Reland: Partial repaint platform views" (flutter/engine#54537)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 9a6ec6cc9627 to 44635f897535 (2 revisions) (flutter/engine#54536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 18:47:03 +00:00
Zachary Anderson
cc13cd1f11
Retry Linux_android_emu tests in presubmit like they are in postsubmit (#153369)
To help keep rolls unblocked while the flakiness of these tests is
investigated.
2024-08-13 10:23:30 -07:00
Zachary Anderson
6200318586
Shift API level 34 emulator tests to prod (#153366)
These are passing consistently
2024-08-13 09:42:30 -07:00
engine-flutter-autoroll
9feae10665
Roll Flutter Engine from 77cd5447b911 to 73c3135cc3be (1 revision) (#153364)
77cd5447b9...73c3135cc3

2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from d11cdccf3fee to 7c0eeaf12413 (1 revision) (flutter/engine#54535)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 16:19:24 +00:00
engine-flutter-autoroll
f2ba204917
Roll Flutter Engine from 9566b25c7319 to 77cd5447b911 (2 revisions) (#153361)
9566b25c73...77cd5447b9

2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from a12a1fc4160e to d11cdccf3fee (1 revision) (flutter/engine#54533)
2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 8WCo7tLjg_GoImlj5... to Kq699Ii76C_pozQ9Y... (flutter/engine#54532)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 15:20:08 +00:00
engine-flutter-autoroll
bcbe3f81c9
Roll Flutter Engine from ba7225c6c068 to 9566b25c7319 (1 revision) (#153351)
ba7225c6c0...9566b25c73

2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 966df41e7755 to 9a6ec6cc9627 (1 revision) (flutter/engine#54531)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 11:52:16 +00:00
engine-flutter-autoroll
e814afaa08
Roll Flutter Engine from 9054eb43aa26 to ba7225c6c068 (3 revisions) (#153348)
9054eb43aa...ba7225c6c0

2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from 899762bba6fd to a12a1fc4160e (1 revision) (flutter/engine#54530)
2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from 8dc4b2e92727 to 899762bba6fd (2 revisions) (flutter/engine#54528)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.6 (flutter/engine#54527)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 10:49:26 +00:00
engine-flutter-autoroll
2afc452d3a
Roll Flutter Engine from adb1fa9fdbcf to 9054eb43aa26 (2 revisions) (#153338)
adb1fa9fdb...9054eb43aa

2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.2 to 1.8.3 (flutter/engine#54526)
2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from d3cd0afd8f0d to 8dc4b2e92727 (1 revision) (flutter/engine#54525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 07:58:07 +00:00
engine-flutter-autoroll
907df025e0
Roll Flutter Engine from af68e772d298 to adb1fa9fdbcf (2 revisions) (#153336)
af68e772d2...adb1fa9fdb

2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 21cde9d69d4e to 966df41e7755 (1 revision) (flutter/engine#54524)
2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from d6f85d7fa251 to d3cd0afd8f0d (1 revision) (flutter/engine#54523)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 07:00:09 +00:00
engine-flutter-autoroll
289ba8dc25
Roll Flutter Engine from 07ecd90b7755 to af68e772d298 (3 revisions) (#153332)
07ecd90b77...af68e772d2

2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from cbd5898acbd8 to d6f85d7fa251 (1 revision) (flutter/engine#54522)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from a6cd8099ff85 to 21cde9d69d4e (1 revision) (flutter/engine#54521)
2024-08-13 skia-flutter-autoroll@skia.org Roll Skia from 7bed8fb6fae2 to cbd5898acbd8 (2 revisions) (flutter/engine#54520)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 04:28:25 +00:00
Greg Spencer
e06738bba4
Add fake dependency on flutter_gpu for the docs (#153325)
## Description

This adds a fake dependency to the docs generation for the `flutter_gpu` package so that it will be included in the docs even though Flutter itself doesn't depend on it directly.

## Related Issues

 - Fixes https://github.com/flutter/flutter/issues/153320

## Tests

 - Adding a test to the canary files that the docs generation script looks for. (Not yet added: still draft)
2024-08-13 01:55:07 +00:00
engine-flutter-autoroll
b6ef354cde
Roll Flutter Engine from 5d8ee52e985b to 07ecd90b7755 (7 revisions) (#153326)
5d8ee52e98...07ecd90b77

2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from c9fd814b106a to 7bed8fb6fae2 (2 revisions) (flutter/engine#54516)
2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from e232752d04c5 to c9fd814b106a (3 revisions) (flutter/engine#54515)
2024-08-12 43054281+camsim99@users.noreply.github.com [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/engine#54186)
2024-08-12 jonahwilliams@google.com [iOS] keep threads merged when using Skia renderer on iOS (flutter/engine#54514)
2024-08-12 chris@bracken.jp iOS,macOS: Clean up create_ios_framework.py (flutter/engine#54500)
2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from ec7558d41b34 to e232752d04c5 (3 revisions) (flutter/engine#54511)
2024-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from cfe2b63d3aca to a6cd8099ff85 (1 revision) (flutter/engine#54512)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 00:59:26 +00:00
Victor Sanni
cc5d08bc79
Make CupertinoButton interactive by keyboard shortcuts (#153126)
This should have been added with https://github.com/flutter/flutter/pull/150721.
2024-08-12 23:14:05 +00:00
gaaclarke
fa1216761d
Added FlutterEngineGroups to engine architecture doc (#153100)
I also formatted the markdown as per our guidelines.  I kept the commits for formatting separate if you want to ignore those.
2024-08-12 22:00:33 +00:00
engine-flutter-autoroll
97218291a0
Roll Flutter Engine from bcf2dcc09a13 to 5d8ee52e985b (4 revisions) (#153313)
bcf2dcc09a...5d8ee52e98

2024-08-12 matej.knopp@gmail.com macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range (flutter/engine#54469)
2024-08-12 737941+loic-sharma@users.noreply.github.com [Windows] Improve texture format logic (flutter/engine#54329)
2024-08-12 bdero@google.com Revert "[Impeller] remove scene3d support." (flutter/engine#54502)
2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from f77adcef7c1c to ec7558d41b34 (1 revision) (flutter/engine#54507)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 21:11:06 +00:00
Jason Simmons
5a04b4dda9
Disable DevTools when running the hot restart integration test in flutter_tools (#153247)
When DevTools is active HotRunner.attach makes a deferred RPC to a DevTools service.  That RPC appears to cause issues if it executes at the wrong time during the hot restart.

Passing the --no-devtools flag works around this by disabling the RPC.

See https://github.com/flutter/flutter/issues/153049
2024-08-12 19:57:22 +00:00
Jamie Kerber
dae3a87d93
Implemented CupertinoButton new styles/sizes (fixes #92525) (#152845)
This PR fixes #92525 and introduces the following changes according to [latest iOS HIG](https://developer.apple.com/design/human-interface-guidelines/buttons#iOS-iPadOS):

- `CupertinoButton` now has a `size` property (type `enum CupertinoButtonSize`, values sm/md/lg, default `lg`) that allows the devs to apply new iOS 15+ button styles
- Previously `CupertinoButton` had a larger padding when no background color was specified. With the new HIG, that is no longer the case
- `CupertinoButton` now has a `.tinted` constructor that renders a translucent background (transparency % is brightness-dependent) and uses a different foreground color compared to `.filled`
- `CupertinoButton` now uses the `actionTextStyle` TextStyle from the given theme
- `CupertinoButton`'s child IconTheme's size will always be x1.2 the given TextStyle's size
- `CupertinoTextThemeData` now has a `actionSmallTextStyle` property to use with small buttons (including a default `_kDefaultActionSmallTextStyle` TextStyle)

Preview & example:

![image](https://github.com/user-attachments/assets/0985eb19-c091-41f5-bd98-0de196b7e403)

> **NOTE**: there is a discrepancy in dark mode button foreground color between the default CupertinoTheme and the HIG. A separate issue will be opened for this.

~EDIT: issue reported here https://github.com/flutter/flutter/issues/152846~
EDIT2: fixed by #153039 !

![image](https://github.com/user-attachments/assets/d671d7b4-bb2f-4b38-9464-ee1b04927304)

## Example
```dart
import 'package:flutter/cupertino.dart';

const Widget body = Row(
  mainAxisSize: MainAxisSize.min,
  mainAxisAlignment: MainAxisAlignment.center,
  children: <Widget>[
    Icon(
      CupertinoIcons.play_fill,
    ),
    Text("Play"),
  ],
);

void main() =>
  runApp(
    CupertinoApp(
      home: Container(
        child: Wrap(
        direction: Axis.horizontal,
        children: <Widget>[
          // header
          Text(''),
          Text('Plain'),
          Text('Grey'),
          Text('Tinted'),
          Text('Filled'),
          // small
          Text('Small'),
          CupertinoButton(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.small,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.small,
            color: CupertinoColors.systemGrey,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.small,
          ),
          CupertinoButton.filled(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.small,
          ),
          // medium
          Text('Medium'),
          CupertinoButton(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.medium,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.medium,
            color: CupertinoColors.systemGrey,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.medium,
          ),
          CupertinoButton.filled(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.medium,
          ),
          // large
          Text('Large'),
          CupertinoButton(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.large,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            color: CupertinoColors.systemGrey,
            size: CupertinoButtonSize.large,
          ),
          CupertinoButton.tinted(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.large,
          ),
          CupertinoButton.filled(
            child: body,
            onPressed: () {},
            size: CupertinoButtonSize.large,
          ),
        ].map((Widget w) => SizedBox(width: 110, height: 70, child: Center(child: w))).toList(),
      ),
      )
    ),
  );

```

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-12 19:26:39 +00:00
flutter-pub-roller-bot
2f0415f37b
Roll pub packages (#153297)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-12 18:41:58 +00:00
Kishan Rathore
33c05da7a0
Refactor: Deprecate inactiveColor from cupertino checkbox (#152981)
Refactor: Deprecate `inactiveColor` from cupertino checkbox
Fixes #151252
2024-08-12 18:29:07 +00:00
Gray Mackall
814e49be49
Upgrade module template AGP version (#151675)
Follow up to https://github.com/flutter/flutter/pull/151433.
2024-08-12 18:17:41 +00:00
engine-flutter-autoroll
bae42ade17
Roll Flutter Engine from 5fea110c3b20 to bcf2dcc09a13 (2 revisions) (#153295)
5fea110c3b...bcf2dcc09a

2024-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 35bc5c866149 to cfe2b63d3aca (6 revisions) (flutter/engine#54505)
2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from a09a0d635b08 to f77adcef7c1c (4 revisions) (flutter/engine#54504)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 17:32:58 +00:00
engine-flutter-autoroll
2593cb3305
Roll Packages from f7b12561aeb6 to d9a6de802e1f (9 revisions) (#153291)
f7b12561ae...d9a6de802e

2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371)
2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376)
2024-08-12 tarrinneal@gmail.com [pigeon] removes restriction on number of custom types per file (flutter/packages#6840)
2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370)
2024-08-12 fertrig@gmail.com [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335)
2024-08-12 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300)
2024-08-12 engine-flutter-autoroll@skia.org Manual roll Flutter from b12d86157e38 to 9b8470197f42 (8 revisions) (flutter/packages#7366)
2024-08-10 engine-flutter-autoroll@skia.org Manual roll Flutter from 76107bdf509f to b12d86157e38 (14 revisions) (flutter/packages#7358)
2024-08-09 tarrinneal@gmail.com [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 17:04:30 +00:00
engine-flutter-autoroll
9b8470197f
Roll Flutter Engine from 1a5e2e58d3d4 to 5fea110c3b20 (1 revision) (#153262)
1a5e2e58d3...5fea110c3b

2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from e3e3fd85802b to a09a0d635b08 (1 revision) (flutter/engine#54501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 07:33:05 +00:00
engine-flutter-autoroll
8e18b5a331
Roll Flutter Engine from d409dcdc9b41 to 1a5e2e58d3d4 (3 revisions) (#153257)
d409dcdc9b...1a5e2e58d3

2024-08-11 jonahwilliams@google.com [Impeller] delete unused aiks PictureRecorder. (flutter/engine#54495)
2024-08-11 skia-flutter-autoroll@skia.org Roll Skia from 9e3c43cb424c to e3e3fd85802b (1 revision) (flutter/engine#54498)
2024-08-11 skia-flutter-autoroll@skia.org Roll Skia from 8f5705639815 to 9e3c43cb424c (1 revision) (flutter/engine#54497)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 03:34:29 +00:00