LongCatIsLooong
9156f6b5f3
Add missing ignore: deprecated_member_use to unblock the engine roller ( #132280 )
...
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-09 22:00:05 -07:00
Polina Cherkasova
2efda23a45
Pin leak_tracker. ( #132261 )
2023-08-09 20:25:06 -07:00
Sam Rawlins
9a32f24a34
Fix prefer_null_aware_operators violation ( #132242 )
...
Use a null-aware `?.` operator instead of a conditional operator. This complies with the `prefer_null_aware_operators` rule. Fixes https://github.com/flutter/flutter/issues/132241
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-10 03:08:11 +00:00
LongCatIsLooong
3f831b694f
Making TextPainter rounding hack disabled by default ( #132094 )
...
Migrate tests in flutter/flutter. Once the tests here and in `*_customer_testing` are migrated, the default value of the migration flag will be changed from false to true, making the rounding hack disabled by default.
2023-08-10 00:30:52 +00:00
Zachary Anderson
118c2df776
Allows adding a storage 'realm' to the storage base URL ( #131951 )
...
Context: https://github.com/flutter/flutter/issues/131862
This PR injects a "realm" component to the storage base URL when the contents of the file `bin/internal/engine.realm` is non-empty.
As documented in the PR, when the realm is `flutter_archives_v2`, and `bin/internal/engine.version` contains the commit hash for a commit in a `flutter/engine` PR, then the artifacts pulled by the tool will be the artifacts built by the presubmit checks for the PR.
This works for everything but the following two cases:
1. Fuchsia artifacts are not uploaded to CIPD by the Fuchsia presubmit builds.
2. Web artifacts are not uploaded to gstatic by the web engine presubmit builds.
For (1), the flutter/flutter presubmit `fuchsia_precache` is driven by a shell script outside of the repo. It will fail when the `engine.version` and `engine.realm` don't point to a post-submit engine commit.
For (2), the flutter/flutter web presubmit tests that refer to artifacts in gstatic hang when the artifacts aren't found, so this PR skips them.
2023-08-09 23:26:05 +00:00
Ian Hickson
9c8f3950e3
Sample code for ImageProvider ( #131952 )
...
Also:
- minor improvements to documentation
- wrap one of our test error messages in a manner more consistent with other messages
2023-08-09 22:58:26 +00:00
Tae Hyung Kim
702b78c6be
Remove shrinkWrap from flexible_space_bar_test.dart ( #132173 )
...
See title.
2023-08-09 22:29:58 +00:00
Bernardo Ferrari
6da6fbf5a8
Deprecate describeEnum. ( #125016 )
...
Final part of https://github.com/flutter/flutter/issues/123346 .
2023-08-09 21:58:52 +00:00
Justin McCandless
f5ceaf9810
Handle hasStrings on web ( #132093 )
...
By default, Flutter web uses the browser's built-in context menu.
<img width="200" src="https://github.com/flutter/flutter/assets/389558/990f99cb-bc38-40f1-9e88-8839bc342da5 " />
As of [recently](https://github.com/flutter/engine/pull/38682 ), it's possible to use a Flutter-rendered context menu like the other platforms.
```dart
void main() {
runApp(const MyApp());
BrowserContextMenu.disableContextMenu();
}
```
But there is a bug (https://github.com/flutter/flutter/issues/129692 ) that the Paste button is missing and never shows up.
<img width="284" alt="Screenshot 2023-08-07 at 2 39 03 PM" src="https://github.com/flutter/flutter/assets/389558/f632be25-28b1-4e2e-98f7-3bb443f077df ">
The reason why it's missing is that Flutter first checks if there is any pasteable text on the clipboard before deciding to show the Paste button using the `hasStrings` platform channel method, but that was never implemented for web ([original hasStrings PR](https://github.com/flutter/flutter/pull/87678 )).
So let's just implement hasStrings for web? No, because Chrome shows a permissions prompt when the clipboard is accessed, and there is [no browser clipboard API](https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API ) to avoid it. The prompt will show immediately when the EditableText is built, not just when the Paste button is pressed.
<img width="200" src="https://github.com/flutter/flutter/assets/389558/5abdb160-1b13-4f1a-87e1-4653ca19d73e " />
### This PR's solution
Instead, before implementing hasStrings for web, this PR disables the hasStrings check for web. The result is that users will always see a paste button, even in the (unlikely) case that they have nothing pasteable on the clipboard. However, they will not see a permissions dialog until they actually click the Paste button. Subsequent pastes don't show the permission dialog.
<details>
<summary>Video of final behavior with this PR</summary>
https://github.com/flutter/flutter/assets/389558/ed16c925-8111-44a7-99e8-35a09d682748
</details>
I think this will be the desired behavior for the vast majority of app developers. Those that want different behavior can use hasStrings themselves, which will be implemented in https://github.com/flutter/engine/pull/43360 .
### References
Fixes https://github.com/flutter/flutter/issues/129692
Engine PR to be merged after this: https://github.com/flutter/engine/pull/43360
2023-08-09 20:36:45 +00:00
Renzo Olivares
6ac161f909
Add an example for TapAndPanGestureRecognizer ( #131873 )
...
This adds an example for `TapAndPanGestureRecognizer` that demonstrates how to scale a widget using a double tap + vertical drag gesture.
https://github.com/flutter/flutter/assets/948037/4c6c5467-2157-4b6a-bc52-264a3b6303de
2023-08-09 19:59:03 +00:00
Mouad Debbar
632681da99
Reland "[web] Migrate framework to fully use package:web ( #128901 )" ( #132092 )
...
Relanding https://github.com/flutter/flutter/pull/128901
Part of https://github.com/flutter/flutter/issues/113402
Part of https://github.com/flutter/flutter/issues/127030
2023-08-09 19:41:45 +00:00
Victoria Ashworth
d631b26285
New tooling for iOS 17 physical devices ( #131865 )
...
This PR includes the following changes. These changes only apply to iOS 17 physical devices.
| Command | Change Description | Changes to User Experience |
| ------------- | ------------- | ------------- |
| `flutter run --release` | Uses `devicectl` to install and launch application in release mode. | No change. |
| `flutter run` | Uses Xcode via automation scripting to run application in debug and profile mode. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal. |
| `flutter run --use-application-binary=xxxx` | Creates temporary empty Xcode project and use Xcode to run via automation scripting in debug and profile. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal. |
| `flutter install` | Uses `devicectl` to check installed apps, install app, uninstall app. | No change. |
| `flutter screenshot` | Will return error. | Will return error. |
Other changes include:
* Using `devicectl` to get information about the device
* Using `idevicesyslog` and Dart VM logging for device logs
Note:
Xcode automation scripting (used in `flutter run` for debug and profile) does not work in a headless (without a UI) interface. No known workaround.
Fixes https://github.com/flutter/flutter/issues/128827 , https://github.com/flutter/flutter/issues/128531 .
2023-08-09 19:25:12 +00:00
engine-flutter-autoroll
88ed9bd9d2
Roll Flutter Engine from 30e7780efacc to b5b41ff66dae (2 revisions) ( #132238 )
...
30e7780efa...b5b41ff66dftsui@google.com Request GLES version 2 interface. (flutter/engine#44504 )
2023-08-09 jonahwilliams@google.com [Impeller] Don't perform final layout transition on worker thread. (flutter/engine#44510 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 18:05:56 +00:00
gaaclarke
1ff82af540
[Impeller] Adds advanced blend benchmark ( #131893 )
...
issue: https://github.com/flutter/flutter/issues/131784
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-09 10:57:35 -07:00
engine-flutter-autoroll
c4954968e2
Roll Packages from ac4137624a13 to 881c1f552d0f (3 revisions) ( #132234 )
...
ac4137624a...881c1f552dengine-flutter-autoroll@skia.org Roll Flutter from 436df69a4684 to f4c25bbb351c (28 revisions) (flutter/packages#4666 )
2023-08-09 reidbaker@google.com [url_launcher] Android API 34 support (flutter/packages#4660 )
2023-08-08 67326251+Franreno@users.noreply.github.com Migrating styleFrom API to new version. (flutter/packages#4540 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 17:13:07 +00:00
engine-flutter-autoroll
26a9c6e9d9
Roll Flutter Engine from 3d3fb4faed02 to 30e7780efacc (8 revisions) ( #132233 )
...
3d3fb4faed...30e7780efaskia-flutter-autoroll@skia.org Roll Skia from 3e85749702f4 to 17ba2122707b (2 revisions) (flutter/engine#44540 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e892c300a7c4 to 3e85749702f4 (1 revision) (flutter/engine#44539 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from ff6d82573f69 to e892c300a7c4 (1 revision) (flutter/engine#44538 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e2885a01f134 to ff6d82573f69 (3 revisions) (flutter/engine#44536 )
2023-08-09 10456171+caroqliu@users.noreply.github.com Remove GFX and Scenic dependencies from Fuchsia integration tests (flutter/engine#44498 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from ac2b25fec6eb to e2885a01f134 (1 revision) (flutter/engine#44534 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from d097852dc928 to ac2b25fec6eb (3 revisions) (flutter/engine#44533 )
2023-08-09 leroux_bruno@yahoo.fr [Windows] Return keyboard pressed state (flutter/engine#43998 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 17:11:01 +00:00
Tae Hyung Kim
fa88170a4f
Update material and cupertino localizations ( #131212 )
...
See title.
Fixes https://github.com/flutter/flutter/issues/130874 .
---------
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
2023-08-09 10:05:27 -07:00
Zachary Anderson
f4c25bbb35
Revert "Handle breaking changes in leak_tracker." ( #132223 )
...
Reverts flutter/flutter#131998
Reverting for https://github.com/flutter/flutter/issues/132222
2023-08-09 08:14:39 -07:00
engine-flutter-autoroll
d78b3ac0af
Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) ( #132193 )
...
8ec575168d...3d3fb4faedskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c18Y3Ga7cvdrmy8FQ... to e7bMhkfY-RPMrSMhB... (flutter/engine#44531 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9Pl8nd13UI8rrS3JD... to tO6r8iQqnmsYkLcvZ... (flutter/engine#44529 )
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e904a9f2010e to d097852dc928 (1 revision) (flutter/engine#44525 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9Pl8nd13UI8r to tO6r8iQqnmsY
fuchsia/sdk/core/mac-amd64 from c18Y3Ga7cvdr to e7bMhkfY-RPM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 07:08:20 +00:00
LongCatIsLooong
aac018974f
Use pattern matching to avoid strange type annotations ( #131964 )
...
Addresses https://github.com/flutter/flutter/pull/131640#discussion_r1284861384
2023-08-09 04:43:57 +00:00
engine-flutter-autoroll
d7877d1fe0
Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) ( #132182 )
...
6839b88283...8ec575168dmatanlurey@users.noreply.github.com [Impeller] Plumb Paint.enableDithering to backend (flutter/engine#44522 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 02:27:24 +00:00
engine-flutter-autoroll
886d676acf
Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) ( #132181 )
...
29b117aa41...6839b88283skia-flutter-autoroll@skia.org Roll Skia from 1fbe521b2c56 to e904a9f2010e (3 revisions) (flutter/engine#44520 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 01:40:37 +00:00
engine-flutter-autoroll
bf729dcd0f
Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) ( #132179 )
...
82292b8390...29b117aa41matanlurey@users.noreply.github.com [Impeller] Add gradient dithering for Radial/Sweep/Conical gradients (flutter/engine#44331 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 68b80f663be6 to 1fbe521b2c56 (2 revisions) (flutter/engine#44518 )
2023-08-08 chris@bracken.jp [macOS] Improve engine retain cycle testing (flutter/engine#44509 )
2023-08-08 34871572+gmackall@users.noreply.github.com Fix name in description of 'create_cipd_packages.sh' (flutter/engine#44513 )
2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] started std::moving `Command`s instead of copying (flutter/engine#44508 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 00:54:55 +00:00
LongCatIsLooong
5de6684b9c
Add more info to OverlayState.insert error messages ( #129363 )
...
I was debugging an Overlay issue and felt I could have identified the problem faster if the existing assertions provided more information about the current state of the OverlayEntry and Overlay.
2023-08-09 00:53:10 +00:00
Qun Cheng
0bc5a2bca4
Add textCapitalization property for SearchBar and SearchAnchor ( #131459 )
...
This is to add `textCapitalization` property for `SearchBar` and `SearchAnchor`.
Fixes : #131260
2023-08-08 23:24:19 +00:00
engine-flutter-autoroll
40a3e4817e
Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) ( #132166 )
...
934ebb005d...82292b8390skia-flutter-autoroll@skia.org Roll Skia from 9fa8ebdfdbb8 to 68b80f663be6 (1 revision) (flutter/engine#44511 )
2023-08-08 31859944+LongCatIsLooong@users.noreply.github.com Disable HTML renderer paragraph input width flooring (flutter/engine#44478 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 5c8c7faf9131 to 9fa8ebdfdbb8 (2 revisions) (flutter/engine#44507 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 23:24:16 +00:00
dependabot[bot]
9b261a7700
Bump github/codeql-action from 2.21.2 to 2.21.3 ( #132165 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.21.2 to 2.21.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817 ">#1817</a></li>
<li>We are rolling out a feature in August 2023 that adds beta support for <a href="https://projectlombok.org/ ">Project Lombok</a> when analyzing Java. <a href="https://redirect.github.com/github/codeql-action/pull/1809 ">#1809</a></li>
<li>Reduce disk space usage when downloading the CodeQL bundle. <a href="https://redirect.github.com/github/codeql-action/pull/1820 ">#1820</a></li>
</ul>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797 ">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811 ">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795 ">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799 ">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724 ">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2 "><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2 "><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760 ">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762 ">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743 ">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721 ">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5b6282e01chttps://redirect.github.com/github/codeql-action/issues/1829 ">#1829</a> from github/update-v2.21.3-f9a7c6738</li>
<li><a href="f0f7a35b85dda4ed3db4f9a7c6738fhttps://redirect.github.com/github/codeql-action/issues/1827 ">#1827</a> from github/dependabot/npm_and_yarn/npm-5103036bd1</li>
<li><a href="31b9dd18d47e2f56aae3878ae4a749https://redirect.github.com/github/codeql-action/issues/1823 ">#1823</a> from github/henrymercer/setup-swift-more-consistent</li>
<li><a href="63602c0f72https://redirect.github.com/github/codeql-action/issues/1824 ">#1824</a> from github/henrymercer/cli-notifications-fix</li>
<li><a href="66dc883276https://redirect.github.com/github/codeql-action/issues/1826 ">#1826</a> from github/henrymercer/increase-reserved-scaling-fa...</li>
<li><a href="22031780900ba4244466...5b6282e01chttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.2&new-version=2.21.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-08-08 23:24:14 +00:00
Jesús S Guerrero
2728ba0f23
Revert of #120385 ( #132167 )
...
Breaking google testing
revert of: https://github.com/flutter/flutter/pull/120385
b/295065534
2023-08-08 16:16:52 -07:00
Taha Tesser
b77b149df6
Add PopupMenuButton.iconColor, PopupMenuTheme.iconSize and fix button icon using unexpected color propert ( #132054 )
...
fixes [PopupMenuButton uses color property for icon color](https://github.com/flutter/flutter/issues/127802 )
fixes [`popup_menu_test.dart` lacks default icon color tests.](https://github.com/flutter/flutter/issues/132050 )
### Description
- Add `PopupMenuButton..iconColor` and fix the PopupMenu button icon using an unexpected color property.
- Add the missing `PopupMenuTheme.iconSize`.
- Clean up some tests and minor improvements.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [PopupMenuButton].
// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }
void main() => runApp(const PopupMenuApp());
class PopupMenuApp extends StatelessWidget {
const PopupMenuApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
popupMenuTheme: PopupMenuThemeData(
// iconSize: 75,
// iconColor: Colors.amber,
color: Colors.deepPurple[100],
),
),
home: const PopupMenuExample(),
);
}
}
class PopupMenuExample extends StatefulWidget {
const PopupMenuExample({super.key});
@override
State<PopupMenuExample> createState() => _PopupMenuExampleState();
}
class _PopupMenuExampleState extends State<PopupMenuExample> {
SampleItem? selectedMenu;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('PopupMenuButton')),
body: Center(
child: PopupMenuButton<SampleItem>(
iconSize: 75,
// iconColor: Colors.amber,
color: Colors.deepPurple[100],
initialValue: selectedMenu,
// Callback that sets the selected popup menu item.
onSelected: (SampleItem item) {
setState(() {
selectedMenu = item;
});
},
itemBuilder: (BuildContext context) => <PopupMenuEntry<SampleItem>>[
const PopupMenuItem<SampleItem>(
value: SampleItem.itemOne,
child: Text('Item 1'),
),
const PopupMenuItem<SampleItem>(
value: SampleItem.itemTwo,
child: Text('Item 2'),
),
const PopupMenuDivider(),
const CheckedPopupMenuItem<SampleItem>(
value: SampleItem.itemThree,
checked: true,
child: Text('Item 3'),
),
],
),
),
);
}
}
```
</details>
2023-08-08 22:23:30 +00:00
Ian Hickson
e65c37ee45
More PageStorage clarity in the documentation ( #131954 )
...
Fixes https://github.com/flutter/flutter/issues/10867
2023-08-08 22:08:32 +00:00
Ian Hickson
b29069ec0b
Document that missed_frame_build_budget_count is misleading ( #132137 )
...
Fixes https://github.com/flutter/flutter/issues/109745
2023-08-08 22:08:30 +00:00
Lau Ching Jun
d5a0fcd5af
Locate the template directory using a TemplatePathProvider. ( #132156 )
...
So that the paths can be overridden.
2023-08-08 21:43:00 +00:00
engine-flutter-autoroll
547bdefba8
Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) ( #132159 )
...
dd03fae51d...934ebb005dskia-flutter-autoroll@skia.org Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506 )
2023-08-08 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457 )
2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] improved glyph hashing performance (flutter/engine#44502 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 21:20:50 +00:00
engine-flutter-autoroll
e2badf3857
Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) ( #132149 )
...
22bd35a193...dd03fae51d10456171+caroqliu@users.noreply.github.com Remove GFX branches from Flutter engine (flutter/engine#44401 )
2023-08-08 jason-simmons@users.noreply.github.com Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 19:49:11 +00:00
Taha Tesser
ee47267d26
Fix TabBarTheme.indicatorColor not applied in Material 2 ( #132123 )
...
fixes [[Proposal] Improve TabBarTheme styling API for indicator color ](https://github.com/flutter/flutter/issues/130392 )
### Description
This fixes an issue where the `TabBarTheme.indicator` isn't applied in Material 2 and also adds indicator color tests for both M3 and M2.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [TabBar].
void main() => runApp(const TabBarApp());
class TabBarApp extends StatelessWidget {
const TabBarApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
useMaterial3: false,
tabBarTheme: const TabBarTheme(
indicatorColor: Colors.amber,
)
),
home: const TabBarExample(),
);
}
}
class TabBarExample extends StatelessWidget {
const TabBarExample({super.key});
@override
Widget build(BuildContext context) {
return DefaultTabController(
initialIndex: 1,
length: 3,
child: Scaffold(
appBar: AppBar(
title: const Text('TabBar Sample'),
bottom: const TabBar(
tabs: <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
text: 'Cloudy',
),
Tab(
icon: Icon(Icons.beach_access_sharp),
text: 'Sunny',
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
text: 'Rainy',
),
],
),
),
body: const TabBarView(
children: <Widget>[
Center(
child: Text("It's cloudy here"),
),
Center(
child: Text("It's rainy here"),
),
Center(
child: Text("It's sunny here"),
),
],
),
),
);
}
}
```
</details>
### Before
### After
2023-08-08 19:37:16 +00:00
Aakash Pamnani
0b81347897
Paginated Data Table : Fixed Row number at footer in last page ( #130389 )
...
Fixed the row count in the footer.
Before
After
*Issues Resolved*
Fixes #80421
2023-08-08 19:25:53 +00:00
Mouad Debbar
a2f48a360f
[web] Use benchmark callback from dart:ui_web ( #132087 )
...
Depends on https://github.com/flutter/engine/pull/44461
Fixes https://github.com/flutter/flutter/issues/130175
Part of https://github.com/flutter/flutter/issues/126831
2023-08-08 18:54:21 +00:00
engine-flutter-autoroll
f10a6ef758
Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) ( #132141 )
...
99fdac88f3...22bd35a193chris@bracken.jp [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497 )
2023-08-08 mdebbar@google.com [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 17:55:08 +00:00
LouiseHsu
d9cb50e63d
[framework] Add Search Web to selection controls for iOS ( #131898 )
...
This PR adds framework support for the Search Web feature in iOS.
https://github.com/flutter/flutter/assets/36148254/c159f0d9-8f14-45e7-b295-e065b0826fab
The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43324 ).
This PR addresses https://github.com/flutter/flutter/issues/82907
More details are available in this [design doc](https://docs.google.com/document/d/1QizXwBiO-2REIcEovl5pK06BaLPOWYmNwOE5jactJZA/edit?resourcekey=0-1pb9mJiAq29Gesmt25GAug )
2023-08-08 17:34:17 +00:00
Justin McCandless
9655311545
Remove Iterator from _History ( #132101 )
...
Cleaning up private code in Navigator.
2023-08-08 10:25:27 -07:00
Ian Hickson
e60dc3012e
Update dartdoc driver to match current behaviour ( #132078 )
2023-08-08 17:12:52 +00:00
Ian Hickson
9dbd1e9872
More documentation about warm-up frames ( #132085 )
2023-08-08 17:11:15 +00:00
engine-flutter-autoroll
23041cb2bb
Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) ( #132135 )
...
146c4c9487...99fdac88f3zanderso@users.noreply.github.com Excludes entity_pass.cc from clang-tidy due to timeouts (flutter/engine#44495 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Jd9VPJCX145RGnqr... to 9Pl8nd13UI8rrS3JD... (flutter/engine#44494 )
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from r0vBgWqKSvQ6zzFam... to c18Y3Ga7cvdrmy8FQ... (flutter/engine#44492 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0Jd9VPJCX145 to 9Pl8nd13UI8r
fuchsia/sdk/core/mac-amd64 from r0vBgWqKSvQ6 to c18Y3Ga7cvdr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 17:09:18 +00:00
engine-flutter-autoroll
3886b0039c
Roll Packages from d7ee75ad59ad to ac4137624a13 (8 revisions) ( #132133 )
...
d7ee75ad59...ac4137624aengine-flutter-autoroll@skia.org Roll Flutter from ad0aa8de7512 to 436df69a4684 (17 revisions) (flutter/packages#4663 )
2023-08-08 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Repeatedly pump WebViews until one is garbage collected (flutter/packages#4662 )
2023-08-08 erikgerman917@gmail.com [xdg_directories] Add example app (flutter/packages#4554 )
2023-08-08 70025277+Nitin-Poojary@users.noreply.github.com [pigeon] Recursively create output target files (flutter/packages#4458 )
2023-08-07 jpnurmi@gmail.com [path_provider] Add getApplicationCachePath() (flutter/packages#4483 )
2023-08-07 10687576+bparrishMines@users.noreply.github.com [flutter_markdown] Adopt code excerpts in README (flutter/packages#4656 )
2023-08-07 reidbaker@google.com [All] Expand artifact hub to all plugins (flutter/packages#4645 )
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter from 2ba9f7bdfe16 to ad0aa8de7512 (31 revisions) (flutter/packages#4659 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 16:53:24 +00:00
Polina Cherkasova
acd636f7ba
Handle breaking changes in leak_tracker. ( #131998 )
2023-08-08 09:39:19 -07:00
engine-flutter-autoroll
436df69a46
Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) ( #132112 )
...
9c83d90b01...146c4c9487skia-flutter-autoroll@skia.org Roll Skia from b4a893827b2a to f7162d33afb2 (1 revision) (flutter/engine#44479 )
2023-08-07 jason-simmons@users.noreply.github.com Revert "[Impeller] DlCanvas implementation wrapping Aiks canvas" (flutter/engine#44466 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 5dd88a48f7e2 to b4a893827b2a (3 revisions) (flutter/engine#44470 )
2023-08-07 mdebbar@google.com [web] Silence `pub get` when it's successful (flutter/engine#44445 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mlT1Bm0L9bVynvMFF... to r0vBgWqKSvQ6zzFam... (flutter/engine#44463 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from d1ada6624536 to 5dd88a48f7e2 (8 revisions) (flutter/engine#44465 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mlT1Bm0L9bVy to r0vBgWqKSvQ6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 05:58:16 +00:00
engine-flutter-autoroll
08b2c44413
Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) ( #132108 )
...
c27109291e...9c83d90b01skia-flutter-autoroll@skia.org Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (flutter/engine#44462 )
2023-08-07 bdero@google.com [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359 )
2023-08-07 ftsui@google.com Fix use-after-free crash in glfw embedder (flutter/engine#44358 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (flutter/engine#44447 )
2023-08-07 zanderso@users.noreply.github.com Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (flutter/engine#44442 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 02:59:25 +00:00
engine-flutter-autoroll
73e1f9f524
Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) ( #132086 )
...
be085f6699...c27109291eyjbanov@google.com [web] remove leftover comments from
semantics tester (flutter/engine#44350 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 77007f51bf81 to
9fbd7296de9a (4 revisions) (flutter/engine#44443 )
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f19578685d17 to
77007f51bf81 (1 revision) (flutter/engine#44440 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-07 18:14:51 -07:00
Jesús S Guerrero
cef00d0c53
Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" ( #132104 )
...
Reverts flutter/flutter#130164
reverting because it cause internal google testing failures b/294917394
2023-08-07 17:30:07 -07:00
Jonah Williams
915c52453b
[Impeller] add drawVertices and drawAtlas benchmarks. ( #132080 )
...
Adds impeller benchmarks to track the progress of improvements made in https://github.com/flutter/flutter/issues/131345
2023-08-08 00:28:16 +00:00
