Greg Spencer
ced3e76626
Reland: "Reorganize and clarify API doc generator" ( #132353 ) ( #132710 )
...
## Description
This re-lands #132353 with some additional options for keeping around the staging directory, so that the recipe for publishing docs can give those options and have the staging directory left around for deploying to the website.
Reverted in #132613
## Related Issues
- https://flutter-review.googlesource.com/c/recipes/+/49580
2023-08-17 23:53:06 +00:00
Ian Hickson
d19fb632ec
Allow date pickers to not have selected date ( #132343 )
...
This enables our various date picker classes to have a null `initialDate`.
It also fixes the logic of some of the widgets which used to do something when you _changed_ the `initial*` parameters, which is wrong for `initial*` properties (they by definition should only impact the initial state) and wrong for properties in general (behaviour should not change based on whether the widget was built with a new value or not, that violates the reactive design principles).
Fixes https://github.com/flutter/flutter/issues/638 .
2023-08-17 23:45:57 +00:00
LouiseHsu
3f34b480c8
[Framework] Add Share to selection controls ( #132599 )
...
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc.
https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765
This PR is the framework portion of the changes that will allow Share to be implemented.
The corresponding merged engine PR is [here](https://github.com/flutter/engine/pull/44554 )
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls )
2023-08-17 23:36:11 +00:00
engine-flutter-autoroll
ac66bdb7ec
Roll Packages from 9bf208f4beb6 to 3b602e77e69a (3 revisions) ( #132784 )
...
9bf208f4be...3b602e77e6ian@hixie.ch Add advice on code review for this repo (flutter/packages#4698 )
2023-08-16 stuartmorgan@google.com [platform] Import the `platform` package (flutter/packages#4613 )
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter from f0e7c5181641 to 2502b51f86c1 (15 revisions) (flutter/packages#4722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 23:30:14 +00:00
engine-flutter-autoroll
fb7baa9e02
Roll Flutter Engine from 533670269c99 to 5019d6da655c (15 revisions) ( #132797 )
...
533670269c...5019d6da65dkwingsmt@users.noreply.github.com Basic view management for engine classes (flutter/engine#42991 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820 )
2023-08-17 matanlurey@users.noreply.github.com Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816 )
2023-08-17 louiseh0313@gmail.com Add share to selection controls (flutter/engine#44554 )
2023-08-17 zanderso@users.noreply.github.com Adds new builders for partial clang-tidy checks. (flutter/engine#44811 )
2023-08-17 41930132+hellohuanlin@users.noreply.github.com [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779 )
2023-08-17 109111084+yaakovschectman@users.noreply.github.com [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238 )
2023-08-17 dkwingsmt@users.noreply.github.com Move `viewConfiguration` parsing from `PlatformDispatcher` to `_hooks` (flutter/engine#44787 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from c4805a975ab3 to d0d390f9310d (2 revisions) (flutter/engine#44807 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cPncZK6z8HmuOmQr_... to 7xOzci7fempFgHNk9... (flutter/engine#44809 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from efb5a5e0b78b to c4805a975ab3 (2 revisions) (flutter/engine#44795 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792 )
2023-08-17 matanlurey@users.noreply.github.com Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789 )
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cPncZK6z8Hmu to 7xOzci7fempF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 23:30:12 +00:00
godofredoc
a70a852c66
Run gsutil with full python3 and full path. ( #132805 )
...
This is to prevent failures when the gsutil.py is not executable.
2023-08-17 23:09:44 +00:00
Polina Cherkasova
aa1bacb35a
Leaks fix. ( #132778 )
...
Fixes https://github.com/flutter/flutter/issues/132769
2023-08-17 12:11:24 -07:00
Michael Goderbauer
f0bfd7d641
Send examples/api PRs to the framework review queue ( #132768 )
2023-08-17 18:56:57 +00:00
Jason Simmons
f1fa9e34c6
Update the tracing_tests Dart SDK version constraint to fix an analyzer error ( #132753 )
2023-08-17 18:51:31 +00:00
Chinmoy
f1d04a46cb
Update Scrollable on ScrollBehaviour change. ( #131164 )
...
Fixes : #130793
2023-08-17 18:48:57 +00:00
Loïc Sharma
9e67e0e4a1
[Windows] Allow overwriting the cache's Dart SDK archive license file… ( #132777 )
...
Relands https://github.com/flutter/flutter/pull/132669 after it was reverted by https://github.com/flutter/flutter/pull/132773 . The test failures were fixed separately by https://github.com/flutter/flutter/pull/132766
Tracking issue: https://github.com/flutter/flutter/issues/132592
Cherrypick issue: https://github.com/flutter/flutter/issues/132718
2023-08-17 18:45:18 +00:00
Zachary Anderson
6a02483044
Run new_gallery__transition_perf on Pixel 7 and Samsung A02 ( #132772 )
2023-08-17 11:42:57 -07:00
Jason Simmons
609382a8c4
Disable test order randomization on some leak tracker tests that are failing with today's seed ( #132766 )
2023-08-17 17:40:05 +00:00
yaakovschectman
e10d74b4d5
Revert "[Windows] Allow overwriting the cache's Dart SDK archive license file" ( #132773 )
...
Reverts flutter/flutter#132669
Introduced failure on `windows/mac/linux framework_library_tests`.
```
05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E]
Expected: leak free
Actual: <Instance of 'Leaks'>
Which: contains leaks:
# The text is generated by leak_tracker.
# For leak troubleshooting tips open:
# https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
notDisposed:
total: 3
objects:
ValueNotifier<_OverlayEntryWidgetState?>:
test: Constructor parameters override theme parameters
identityHashCode: 407433615
FocusScopeNode:
test: Constructor parameters override theme parameters
identityHashCode: 513181650
FocusScopeNode:
test: Constructor parameters override theme parameters
identityHashCode: 704743556
package:matcher expect
package:flutter_test/src/widget_tester.dart 458:18 expect
package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5 _tearDownTestingWithLeakTracking
===== asynchronous gap ===========================
dart:async _CustomZone.registerBinaryCallback
package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9 configureLeakTrackingTearDown.<fn>
```
2023-08-17 17:26:17 +00:00
Loïc Sharma
7ee864ee37
[Windows] Allow overwriting the cache's Dart SDK archive license file ( #132669 )
...
https://github.com/flutter/engine/pull/43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file.
This is a short-term solution that will be cherry-picked for the next [3.14 beta release](https://github.com/flutter/flutter/issues/132267 ). Addresses https://github.com/flutter/flutter/issues/132592 .
The long-term solution is tracked by https://github.com/flutter/flutter/issues/132702
2023-08-17 16:08:08 +00:00
Bernardo Ferrari
b7046b32db
Improve and optimize non-uniform Borders. ( #124417 )
...
~~Using the same priority order as a Border without borderRadius, it is possible to draw them on top of each other. This is better than the current behavior (crash!) and would work well for a "one color on top, another on bottom" scenario.~~
~~With this, if approved, we move the current number of possible exceptions from 4 to 1 (`BoxShape.circle` + `borderRadius`).~~
~~It is kind of odd how `borderRadius.zero` to `borderRadius != BorderRadius.zero` change, but I think it is better than crashing. Alternatively, we just remove the "original function" and see if any goldens are affected.~~
<img width="448" alt="image" src="https://user-images.githubusercontent.com/351125/236550350-7499d758-5b44-40e6-9105-32671eb21998.png ">
Another one for @gspencergoog. If this works, we could make the paint method public and re-use in the InputBorder PR (if that's also approved). Single line fix.
2023-08-17 04:04:23 +00:00
engine-flutter-autoroll
fe9c7f4fa7
Roll Flutter Engine from dbfe71c898b6 to 533670269c99 (15 revisions) ( #132717 )
...
dbfe71c898...533670269cskia-flutter-autoroll@skia.org Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786 )
2023-08-16 jason-simmons@users.noreply.github.com Revert "Conditionally enable HardwareBuffer backed platform views (#44744 )" (flutter/engine#44785 )
2023-08-16 dnfield@google.com [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782 )
2023-08-16 john@johnmccutchan.com Switch some ERROR logs to WARNING logs (flutter/engine#44784 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778 )
2023-08-16 matanlurey@users.noreply.github.com Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777 )
2023-08-16 louiseh0313@gmail.com Fix search web test (flutter/engine#44704 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769 )
2023-08-16 godofredoc@google.com Remove duplicated v1 builds. (flutter/engine#44767 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768 )
2023-08-16 zanderso@users.noreply.github.com Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763 )
2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu
fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-17 02:05:08 +00:00
Kate Lovett
ca319278bd
Fix lower bound of children from TwoDimensionalChildBuilderDelegate ( #132713 )
...
Found in https://github.com/flutter/packages/pull/4536
The max x and max y index should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.
2023-08-17 02:05:06 +00:00
Ian Hickson
8864395034
Improvements to EditableText documentation ( #132532 )
2023-08-17 01:02:17 +00:00
Matan Lurey
b66878a61e
Treat missing --local-engine-host as fatal on CI-like systems. ( #132707 )
...
Partial work towards https://github.com/flutter/flutter/issues/132245 .
The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110 ):
@matanlurey:
> Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245 ).
>
> Also happy to get talked out of this idea ð
@christopherfujino:
> we have a check, lemme find it
> whether or not it is advisable, idk
> https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30
>
> (...)
>
> is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing?
>
> (yes)
>
> uhh, sure, that's advisable ð
2023-08-17 00:41:03 +00:00
Kate Lovett
af0ca97842
Fix bad pattern in 2D tests ( #132709 )
...
Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536
2023-08-17 00:13:04 +00:00
Polina Cherkasova
1a0077dc81
Upgrade flutter packages. ( #132697 )
2023-08-16 16:26:58 -07:00
Renzo Olivares
0e15ab54d1
Triple tap selection should not move beyond text boundary at the tapped location ( #132357 )
...
This PR makes sure we do not select beyond the text boundary at the tapped position unless, we tap at the end of the text which in that case we should select the previous text boundary.
```dart
// if x is a boundary defined by `textBoundary`, most textBoundaries (except
// LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`.
// Use x - 1 here to make sure we don't get stuck at the fixed point x.
final int start = textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0;
```
This was originally carried over from f468f3366c/packages/flutter/lib/src/widgets/editable_text.dart (L4167-L4179)Fixes #132126
2023-08-16 23:05:16 +00:00
Faisal Ansari
2cb762d154
fixed documentation error input decorator ( #132124 )
...
In the documentation of _Shaker in InputDecoration "Used to "shake" the floating label to the left and right"
to the left was twice I have removed it.
2023-08-16 23:03:21 +00:00
Polina Cherkasova
0ea523cf93
Fix not-disposed _InputBorderGap. ( #132694 )
...
Fixes: https://github.com/flutter/flutter/issues/132620
2023-08-16 22:38:59 +00:00
Matan Lurey
223ae5d3ac
Add support for LOCAL_ENGINE_HOST to Linux/Mac/Win builds. ( #132579 )
...
Partial work towards https://github.com/flutter/flutter/issues/132245 .
I also couldn't help myself to do a very minor refactor and add some comments to `LocalEngineInfo` because I was getting confused myself implementing it.
2023-08-16 22:24:51 +00:00
Michael Goderbauer
14f9ed28d0
Analyze doc code snippets for all packages for which we publish docs ( #132607 )
...
Fixes TODO in the analyzer script :)
2023-08-16 22:24:48 +00:00
yaakovschectman
e52e8da303
Revert "Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision)" ( #132698 )
...
Reverts flutter/flutter#132677
Causes failure for `Linux firebase_abstract_method_smoke_test`
2023-08-16 21:58:18 +00:00
engine-flutter-autoroll
8617a18575
Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision) ( #132677 )
...
dbfe71c898...12cafaeb9ejohn@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 19:36:49 +00:00
engine-flutter-autoroll
06cb9a676a
Roll Flutter Engine from 8f5f8b34c374 to dbfe71c898b6 (1 revision) ( #132673 )
...
8f5f8b34c3...dbfe71c898zanderso@users.noreply.github.com Adds runIf to linux_clang_tidy (flutter/engine#44759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 18:25:48 +00:00
Polina Cherkasova
112f4293dc
Fix some leaks and add test to test cover remaining in a simple way. ( #131373 )
...
Contributes to https://github.com/flutter/flutter/issues/130467
Filed issue: https://github.com/flutter/flutter/issues/132620
2023-08-16 18:19:58 +00:00
engine-flutter-autoroll
371a9fc835
Roll Flutter Engine from 70b5700b79f6 to 8f5f8b34c374 (2 revisions) ( #132665 )
...
70b5700b79...8f5f8b34c3skia-flutter-autoroll@skia.org Roll Skia from f30893561924 to d029f149a806 (1 revision) (flutter/engine#44764 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3ab12f40c2a4 to f30893561924 (1 revision) (flutter/engine#44761 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 17:33:44 +00:00
chunhtai
99790cc8c0
Add more use cases to a11y assessments ( #132325 )
...
see [go/flutter-gar-reporting-q3-2023](http://go/flutter-gar-reporting-q3-2023 )
2023-08-16 16:44:11 +00:00
engine-flutter-autoroll
33ef5e413f
Roll Packages from 84218b9d834c to 9bf208f4beb6 (7 revisions) ( #132659 )
...
84218b9d83...9bf208f4beengine-flutter-autoroll@skia.org Manual roll Flutter from 9b6945b465a1 to f0e7c5181641 (63 revisions) (flutter/packages#4719 )
2023-08-15 31859944+LongCatIsLooong@users.noreply.github.com Update palette_generator_test.dart (flutter/packages#4720 )
2023-08-15 mit@google.com [pigeon] Fix typo in README.md (flutter/packages#4707 )
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716 )
2023-08-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563 )
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620 )
2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 16:07:41 +00:00
engine-flutter-autoroll
2502b51f86
Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) ( #132655 )
...
f186f1e9dc...70b5700b79skia-flutter-autoroll@skia.org Roll Dart SDK from 80b9a90ae563 to cc5eeac65f89 (1 revision) (flutter/engine#44758 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 15:14:07 +00:00
engine-flutter-autoroll
9f46ed7449
Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) ( #132649 )
...
e8670f03a9...f186f1e9dcskia-flutter-autoroll@skia.org Roll Skia from cb3451491f11 to 3ab12f40c2a4 (1 revision) (flutter/engine#44756 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 586a6309e3a1 to cb3451491f11 (2 revisions) (flutter/engine#44755 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 12:14:41 +00:00
William Hesse
3423226958
Fix flutter_tools use of --local-engine-host ( #132648 )
...
PR #132346 added the use of --local-engine-host to flutter_tools internals, and had an error on one line. Fix that error, to use the correct field name.
The error occurs when building plugins with the changed tools.
2023-08-16 12:00:25 +00:00
engine-flutter-autoroll
5fd9fc174d
Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) ( #132623 )
...
7cc6a5832a...e8670f03a9skia-flutter-autoroll@skia.org Roll Dart SDK from e6bf503b36fe to 80b9a90ae563 (2 revisions) (flutter/engine#44753 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from orVLXMF7ak2qfFkGs... to GpKKtPGPMiRcY0kcz... (flutter/engine#44751 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 8f0238837ee4 to 586a6309e3a1 (2 revisions) (flutter/engine#44752 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from orVLXMF7ak2q to GpKKtPGPMiRc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 07:24:24 +00:00
engine-flutter-autoroll
03aa95be67
Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) ( #132621 )
...
decaccfc42...7cc6a5832askia-flutter-autoroll@skia.org Roll Skia from 3d2b84e28e79 to 8f0238837ee4 (1 revision) (flutter/engine#44748 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 05:53:05 +00:00
engine-flutter-autoroll
c70d1843ab
Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) ( #132618 )
...
659cdfc5a5...decaccfc42skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747 )
2023-08-16 godofredoc@google.com Move cache builders to prod. (flutter/engine#44739 )
2023-08-16 26625149+0xZOne@users.noreply.github.com Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746 )
2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745 )
2023-08-16 matanlurey@users.noreply.github.com [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7iuIq3PsSkuC to Zp9or9YwxZHH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 04:05:21 +00:00
engine-flutter-autoroll
e188043565
Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) ( #132612 )
...
7409ce4ba0...659cdfc5a5jonahwilliams@google.com [Impeller] Cache render target texture allocations across frames. (flutter/engine#44527 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 03:18:19 +00:00
Jonah Williams
909400dc4d
Revert "Reorganize and clarify API doc generator" ( #132613 )
...
Reverts flutter/flutter#132353
Educated guess that this is causing the docs failures: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8772644466113801713/+/u/Docs/Deploy_docs/Firebase_deploy/stdout
2023-08-16 02:47:26 +00:00
engine-flutter-autoroll
375538873d
Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) ( #132609 )
...
a9da7212ea...7409ce4ba0amirpanahandeh@yahoo.com Add more tests for CompositionAwareMixin (flutter/engine#44717 )
2023-08-15 john@johnmccutchan.com Fix clang_tidy lints (flutter/engine#44740 )
2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737 )
2023-08-15 godofredoc@google.com Add SLSA L1 badge (flutter/engine#44731 )
2023-08-15 john@johnmccutchan.com Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 01:39:27 +00:00
engine-flutter-autoroll
0dd7393278
Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) ( #132608 )
...
22f03ffdc2...a9da7212easkia-flutter-autoroll@skia.org Roll Skia from c7c9e85a8657 to b07a6964a1cf (2 revisions) (flutter/engine#44733 )
2023-08-15 jonahwilliams@google.com [Impeller] Make porter duff blended atlas calls faster. (flutter/engine#44059 )
2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from 4beb6fd05f4f to c7c9e85a8657 (7 revisions) (flutter/engine#44729 )
2023-08-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 19c87486f0a9 to b36934aae968 (1 revision) (flutter/engine#44728 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-16 00:45:54 +00:00
Taha Tesser
23315f1b57
[Reland] #131609 ( #132555 )
...
This relands https://github.com/flutter/flutter/pull/131609
---
fixes [`PopupMenuItem` adds redundant padding when using `ListItem`](https://github.com/flutter/flutter/issues/128553 )
2023-08-16 00:44:06 +00:00
Tong Mu
6971dcb705
Explain the keyboard manager protocol ( #132533 )
...
Fixes https://github.com/flutter/flutter/issues/132433
2023-08-15 23:06:58 +00:00
Kate Lovett
9d9427923f
Fix extent for null returning builder in GridView ( #132511 )
...
Fixes https://github.com/flutter/flutter/issues/130685
This fixes an issue where a GridView/SliverGrid with a SliverChildBuilderDelegate would still reflect a max scroll extent of infinity after returning null from the builder. This change incorporates the same way we handle this case in SliverList:
6d87a23b37/packages/flutter/lib/src/rendering/sliver_list.dart (L305-L307)
2023-08-15 22:56:09 +00:00
Greg Spencer
899a29f830
Reorganize and clarify API doc generator ( #132353 )
...
## Description
This cleans up a lot of issues with the API doc generation.
Here are the main changes:
- Rename `dartdoc.dart` to `create_api_docs.dart`
- Move the bulk of the operations out of `dev/bots/docs.sh` into `create_api_docs.dart`.
- Delete `dashing_postprocess.dart` and `java_and_objc.dart` and incorporate those operations into `create_api_docs.dart`.
- Refactor the doc generation into more understandable classes
- Bump the snippets tool version to 0.4.0 (the latest one)
- Centralize the information gathering about the Flutter repo into the new `FlutterInformation` class.
- Clean up the directory handling, and convert to using the `file` package for all file and directory paths.
- Add an `--output` option to docs.sh that specifies the location of the output ZIP file containing the docs.
- Defaults to placing the output in `dev/docs/api_docs.zip` (i.e. where the previous code generates the file).
- Moved all document generation into a temporary folder that is removed once the documents are generated, to avoid VSCode and other IDEs trying to index the thousands of HTML and JS files in the docs output.
- Updated pubspec dependencies.
## Tests
- Added tests for doc generation.
2023-08-15 22:12:16 +00:00
Greg Spencer
301577a34f
Fixing a memory leak in About box/dialog overlays ( #130842 )
...
## Description
Fix three memory leaks detected by `about_test.dart`, but were really in the `Route` and `OverlayEntry` classes.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/130354
## Tests
- Updates about_test.dart to not ignore the leaks anymore.
2023-08-15 21:58:21 +00:00
Polina Cherkasova
f0e7c51816
Upgrade flutter packages. ( #132585 )
2023-08-15 13:50:17 -07:00
