12681 Commits

Author SHA1 Message Date
Jonah Williams
d1deb32fe9
try disabling flutter run test (#25416) 2018-12-15 10:54:47 -08:00
Stanislav Baranov
c5251cdc02
Flutter tool support for automatic saving of JIT compilation trace (#25301) 2018-12-14 16:09:17 -08:00
Hans Muller
30fb97be42
Fixed Typography null factory constructor (#24932) 2018-12-14 16:01:17 -08:00
jslavitz
ad2e3eb3b5
Adds support for floating cursor (#25384)
* Adds support for floating cursor.
2018-12-14 15:17:33 -08:00
Jonah Williams
b4f1d5a924
Add fuchsia devices to daemon command (#25344) 2018-12-14 14:37:55 -08:00
S McDowall
4c24bcc862 Remove TextField.noMaxLength, use maxLength = -1 instead (#24999) 2018-12-14 14:18:35 -08:00
David Shuckerow
1a60b166f2
Add ipv6 and observatory port support to the attach command (#25303)
* Add ipv6 and observatory port support to the attach command.

* Remove whitespace

* Explain why a name change is useful here

* Refactor common flags out into the parent

* Add an additional test case for when observatory port is provided but debug port is not

* Remove whitespace

* Fix flag validation
2018-12-14 18:03:49 -04:00
Jonah Williams
a0efb78640
Revert "drop/restore focus when app becomes invisible/visible" (#25390) 2018-12-14 12:45:07 -08:00
Hans Muller
8c439fd39f
IntrinsicWidth stepWidth or stepHeight == 0.0 (#25228) 2018-12-14 12:30:01 -08:00
Jonah Williams
ff97e255b5
drop/restore focus when app becomes invisible/visible (#24744) 2018-12-14 12:15:52 -08:00
Michael Goderbauer
ea7d086e11
Revert "Call mark* methods before attaching child (#25239)" (#25382)
This reverts commit 5c1f1d7618e27a3ed5a97971edc95eff9d0ba967.

Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
2018-12-14 10:30:49 -08:00
Jonah Williams
d01f574a4a
Revert "Use stderr instead of stdout to contain errors in flutter attach test" (#25380) 2018-12-14 10:15:31 -08:00
engine-flutter-autoroll
d675bbbd3a
Roll engine a549981da706..101b27da7a1b (4 commits) (#25341)
a549981da7...101b27da7a

git log a549981da706..101b27da7a1b --no-merges --oneline
101b27da7 Roll src/third_party/skia f9e824b8e749..cb6b4bde0c2e (7 commits) (flutter/engine#7215)
eff5e6735 Fallback font match caching to fix emoji lag. (flutter/engine#7208)
18a4e33c2 Downloading and installation of dynamic updates on Android (flutter/engine#7207)
8e56b549a Roll src/third_party/skia 5eb29448dfbd..f9e824b8e749 (10 commits) (flutter/engine#7212)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-14 10:59:31 -05:00
Jonah Williams
4cd87705b7
Revert "Adds support for floating cursor (#24761)" (#25352)
This reverts commit 46878d848566769e51f21407de2fead528c1d2c4.
2018-12-13 20:36:08 -08:00
jslavitz
46878d8485
Adds support for floating cursor (#24761)
* Adds support for floating cursor!
2018-12-13 20:14:27 -08:00
Greg Spencer
95b0124785
Add imports section to sample code templates, and more docs. (#25184)
Adds documentation for the stateless widget template, and adds an "imports" section to both templates.
2018-12-13 14:11:11 -08:00
David Shuckerow
2b819dd257
Use stderr instead of stdout to contain errors in flutter attach test (#25305) 2018-12-13 17:50:41 -04:00
Jasper van Riet
01694ab62d Allow detection of taps on TabBar (#23919) 2018-12-13 13:01:34 -08:00
engine-flutter-autoroll
a37099f3b1
a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211) (#25333)
921b1ccebb...a549981da7

git log 921b1ccebb8f..a549981da706 --no-merges --oneline
a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-13 15:09:28 -05:00
Justin McCandless
c5457068df
Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)
This reverts commit f8f5953d8002cb17b861486dff93e5456ca54efd.
2018-12-13 11:58:37 -08:00
Justin McCandless
f8f5953d80
obscureText and enableInteractiveSelection defaults (#24527)
* obscureText true defaults to disabling selection

* Tests and comments for selectable text field

* Improve selection docs

* Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled

* Fix selection param macros
2018-12-13 11:09:13 -08:00
engine-flutter-autoroll
affcc381d0
Roll engine 571f47457c0e..921b1ccebb8f (4 commits) (#25314)
571f47457c...921b1ccebb

git log 571f47457c0e..921b1ccebb8f --no-merges --oneline
921b1cceb Roll src/third_party/skia 58fc5d19ad1b..a69b10312977 (3 commits) (flutter/engine#7210)
37bf807a5 Roll src/third_party/skia 17c574a193ad..58fc5d19ad1b (1 commits) (flutter/engine#7209)
0ea994a64 Minor Docs to runtime controller WindowData (flutter/engine#6991)
41dc628d6 Roll src/third_party/skia 340aeda6b3ba..17c574a193ad (8 commits) (flutter/engine#7206)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-13 12:12:28 -05:00
Justin McCandless
952d24bf1e
Text field style merge (#24449)
* Merge TextField style with global style so that style changes don't override unspecified fields

* Test that a style param is merged with the theme

* Test a few more style properties

* Analysis fix
2018-12-13 08:32:55 -08:00
MH Johnson
92efec3998
[Material] Theme-able elevation on dialogs. (#24169)
* Themable elevation on dialogs.

* Added `BackgroundColor` in widget + theme

* Addressing Comments

* Fix test name

* Add debugFillProperties test
2018-12-13 09:11:01 -05:00
engine-flutter-autoroll
e6d216cca8 Roll engine e5195ee479c4..571f47457c0e (4 commits) (#25302)
* 2bd75ae8b Support querying display refresh rate in engine (flutter/engine#7002)

* 793a08bbf Add .woff file to binary format (flutter/engine#7202)

* daf0ededb Roll src/third_party/skia 6417060b1c23..340aeda6b3ba (41 commits) (flutter/engine#7205)

* 571f47457 Update marked text before selection so textInRange is never called with (flutter/engine#6989)
2018-12-12 18:22:16 -08:00
Michael Goderbauer
5c1f1d7618
Call mark* methods before attaching child (#25239) 2018-12-12 16:45:51 -08:00
Michael Goderbauer
75228a59da
Remove uses-material-design from hello_world example (#25300) 2018-12-12 16:36:11 -08:00
David Shuckerow
e6292c8da1
Revert "Add ipv6 and observatory port support to the attach command." (#25288)
* Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)"

This reverts commit f198d66332f0f95f1932d35457801809b6e1d543.

* Revert "Validate style in TextField (#24587)"

This reverts commit 9a8e2f0c4b07d81fb3a0d3274443d26a7f34e9fe.

* Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)"

This reverts commit 4a110b6227a10637e1671f1f7ced7faf4da45d5e.

* Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)"

This reverts commit e29b023a6bbbd6b106aaf8802db3192ff3d3cf9c.

* Revert "Add ipv6 and observatory port support to the attach command. (#24537)"

This reverts commit 9150b3f031a9b1f743e25b9516a72a0bb3064adc.
2018-12-12 16:56:50 -04:00
Jonah Williams
f30029bae1
Run flutter tests through mini test engine when run directly (flutter run -t test_file) (#24930) 2018-12-12 12:51:16 -08:00
engine-flutter-autoroll
f198d66332
e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)
abb1d3a6c0...e5195ee479

git log abb1d3a6c0b2..e5195ee479c4 --no-merges --oneline
e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-12 13:28:28 -05:00
Justin McCandless
9a8e2f0c4b
Validate style in TextField (#24587)
* Validate style in TextField

* Fix analyze problems

* Use assert and move to top

* Simplified assertion
2018-12-12 09:44:43 -08:00
Janice Collins
4a110b6227
Allow snippets tool to be run from arbitrary CWDs (#25243)
* Allow snippets tool to be run from arbitrary CWDs

* Drop use of absolute when using Platform.executable (path is not relative, might require PATH resolution)

* canonicalize paths

* Use path.fromUri consistently to resolve file URIs

* Force commit to try to kick Cirrus

* Force commit to kick Cirrus, again
2018-12-12 09:40:18 -08:00
Danny Tuppeny
e29b023a6b
Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)
* Update VS Code validator to match Android Studio

- Now shows a tick (instead of partial) if installed
- Now shows a cross (instead of dot) if extension is not installed

Fixes #22931.
2018-12-12 17:36:42 +00:00
David Shuckerow
9150b3f031 Add ipv6 and observatory port support to the attach command. (#24537) 2018-12-12 08:28:02 -08:00
Danny Tuppeny
2994d3562a
Add some a basic debug stepping tests (#24515) 2018-12-12 10:56:54 +00:00
engine-flutter-autoroll
cc23a7b4a2 Roll engine 25b58c0c67dc..abb1d3a6c0b2 (3 commits) (#25258)
* 31e6861d4  Reland "Compile libcxx and libcxxabi for Android (#6886)" (flutter/engine#7160)

* 648b844b7 Roll buildroot to 4cb5a74c9612b71b917997f46e97da6d1051eab4 (flutter/engine#7194)

* abb1d3a6c Roll buildroot to 8e538639660413490ea9261eee84864005e240f4 (flutter/engine#7195)
2018-12-12 01:17:27 -08:00
Trevor Wang
114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
xster
65df90d8b5
Add navigatorKey to CupertinoTabView (#25183) 2018-12-11 19:29:13 -08:00
Michael Goderbauer
8ca8dbf062
Do not fade out text for pinned & floating AppBar (#25051) 2018-12-11 19:24:00 -08:00
engine-flutter-autoroll
390ded9340 Roll engine 7375a0f414bd..25b58c0c67dc (198 commits) (#25236) 2018-12-11 18:33:26 -08:00
Jonah Williams
c461e93363
Revert "Ensure that cache dirs and files have appropriate permissions" (#25240) 2018-12-11 15:33:57 -08:00
Hans Muller
234855ca3d
Handle a TabBarView special case: last tab deleted before animation ends (#24892) 2018-12-11 14:22:27 -08:00
Jimmy Casey
3cca1a2ec3 Fixed Spelling. (#25217) 2018-12-11 10:50:51 -08:00
Justin McCandless
6901cd4625
TextFormField cursor params (#24635)
* cursor fields on textformfield

* Test pass-through of cursor properties
2018-12-11 10:42:10 -08:00
Hans Muller
f14055529b
Fixed an InheritedWidget doc typo (#25168) 2018-12-11 09:53:45 -08:00
Greg Spencer
625a37b86a
Adds favicon to Dash/Zeal docset, adds OpenSearch metadata. (#25178)
This sets the favicon for the offline Dash/Zeal docs.

Also, sets up the OpenSearch Description metadata file so that people can create custom search shortcuts for the API docs site.

Fixes #6412
2018-12-11 09:53:33 -08:00
Jonah Williams
b080a476c8
Fuchsia multiple devices and target (#24953) 2018-12-11 09:18:21 -08:00
Hans Muller
f8a7abb6b8
Add a check for build methods that return context.widget (#25046) 2018-12-11 08:59:28 -08:00
Danny Tuppeny
3f1c308e58
Don't require the AVD folder to exist in order to run flutter emulators (#25154)
Fixes #24750.
2018-12-11 15:27:25 +00:00
Michael Goderbauer
7120dab553
Don't crash if pinned & floating AppBar has less than minExtent remainingPaintExtent (#25048)
Fixes https://github.com/flutter/flutter/issues/21887
2018-12-11 07:18:53 -08:00