Hans Muller
d5a8fa6271
Revert "Update chip.dart to use set of MaterialState" ( #128607 )
...
Reverts flutter/flutter#128507
This PR caused some internal failures (Google internal link b/286503764). Will need to investigate before we can re-land these changes.
2023-06-09 18:52:14 +00:00
ZhulanovAA
e84fa2ce47
Add tooltips for SegmentedButton ( #128501 )
2023-06-09 11:06:21 -07:00
Jason Simmons
a08a211040
Ignore app.stop events received before the app.detach response in attach integration tests ( #128593 )
...
The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach.
See https://github.com/flutter/flutter/issues/128546
2023-06-09 17:50:03 +00:00
Devin
5047690b53
ExpansionPanel isExpanded callback parameter (Ticket 74114) ( #128082 )
...
Fixes https://github.com/flutter/flutter/issues/74114
This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened.
I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen.
Pre-launch Checklist
[ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview ) and followed the process outlined there for submitting PRs.
[ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene ) wiki page, which explains my responsibilities.
[ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo ), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement ).
[ X] I signed the [CLA](https://cla.developers.google.com/ ).
[ X] I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests ).
[ X] All existing and new tests are passing.
2023-06-09 17:47:59 +00:00
engine-flutter-autoroll
38406ff85f
Roll Flutter Engine from 93afba901b3b to bc6e047570f6 (3 revisions) ( #128594 )
...
93afba901b...bc6e047570jonahwilliams@google.com [Impeller] disable buffer to texture blit for Vulkan. (flutter/engine#42686 )
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 980896406d12 to a185cb8c8924 (1 revision) (flutter/engine#42697 )
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from e9493542672c to 980896406d12 (1 revision) (flutter/engine#42696 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 17:36:14 +00:00
Hans Muller
9c3bfde5c0
Updated flutter_localizations tests for Material3; ( #128521 )
...
Updated the localization tests so that they'll DTRT when useMaterial3:true becomes the default for ThemeData. In a few cases there are M2 and M3 tests now, to check features that are significantly different in Material3, notably the double ring for the 24 hour input dial.
| Material 2 | Material 3|
|---------|---------|
| <img width="250" alt="Screenshot 2023-06-08 at 10 47 37 AM" src="https://github.com/flutter/flutter/assets/1377460/6ca95e22-b3f1-4f6b-9e39-79c888ba58f1 "> | <img width="257" alt="Screenshot 2023-06-08 at 10 47 13 AM" src="https://github.com/flutter/flutter/assets/1377460/19b685bf-c812-4c87-baed-70fa56efaad8 "> |
In M3, most aspects of the ideographic text styles are the same as for alphabetic styles, so there are some tweaks here to account for that.
2023-06-09 17:11:23 +00:00
hangyu
63f4174638
Paint SelectableFragments before text ( #128375 )
...
fixes : #104703
2023-06-09 17:00:14 +00:00
engine-flutter-autoroll
f65584317e
Roll Packages from e13b8c43386a to afe2f05c1adb (7 revisions) ( #128582 )
...
e13b8c4338...afe2f05c1astuartmorgan@google.com [image_picker] Add desktop support - platform interface (flutter/packages#4161 )
2023-06-08 nils@reichardt.io [go_router] Update link to example for query and path parameters (flutter/packages#3994 )
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839 )
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768 )
2023-06-08 stuartmorgan@google.com [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166 )
2023-06-08 engine-flutter-autoroll@skia.org Roll Flutter from 8a5c22e282db to 6e254a3f9fb7 (12 revisions) (flutter/packages#4165 )
2023-06-08 banasco@gmail.com Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 15:44:09 +00:00
Hans Muller
da127f15ad
Updated material button theme tests for Material3 ( #128543 )
2023-06-09 06:57:21 -07:00
engine-flutter-autoroll
befd86d6b1
Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) ( #128573 )
...
cb93477008...93afba901bskia-flutter-autoroll@skia.org Roll ANGLE from 8a62b4c44fc9 to e9493542672c (1 revision) (flutter/engine#42695 )
2023-06-09 leroux_bruno@yahoo.fr [Linux] Return keyboard pressed state (flutter/engine#42346 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 13:26:35 +00:00
Pierre-Louis
66cda5917d
Improve defaults generation with logging, stats, and token validation ( #128244 )
...
## Description
This improves defaults generation with logging, stats, and token validation.
This PR includes these changes:
* introduce `TokenLogger`, with a verbose mode
* prints versions and tokens usage to the console
* outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google
* find token files in `data` automatically
* hide tokens `Map`
* tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`.
* tokens can be checked for existence with `tokenAvailable`
* remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version
* improve documentation
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/122602
## Tests
- Added tests for `TokenLogger`
- Regenerated tokens, no-op except version removal
## Future work
A future PR should replace or remove the following invalid tokens usages
<img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00 ">
2023-06-09 11:28:18 +00:00
William Hesse
0d39f6466d
[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal ( #128335 )
...
Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
Bug: #127683
- [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [X ] I signed the [CLA].
- [X ] I listed at least one issue that this PR fixes in the description above.
- [X ] I updated/added relevant documentation (doc comments with `///`).
2023-06-09 11:06:13 +00:00
Danny Tuppeny
46007d61d2
[flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet ( #128267 )
...
The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error:
Failed to Hot Reload: app 'null' not found
This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.
2023-06-09 09:41:07 +00:00
engine-flutter-autoroll
6d4c4d75bf
Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) ( #128568 )
...
8f9e608d39...cb93477008skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... (flutter/engine#42694 )
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from d8339e78db54 to 8a62b4c44fc9 (1 revision) (flutter/engine#42691 )
2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ukXXOXtI7uRIukzF5... to romfKfKwgjzAXQSxt... (flutter/engine#42689 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lPCv1NshK-tv to xqQPG9jnWgD1
fuchsia/sdk/core/mac-amd64 from ukXXOXtI7uRI to romfKfKwgjzA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 09:37:32 +00:00
Taha Tesser
192b06405b
Replace MaterialButton from test classes ( #128466 )
...
fixes https://github.com/flutter/flutter/issues/128465
2023-06-09 08:04:07 +00:00
Taha Tesser
8600eb129c
Fix showBottomSheet doesn't remove scrim when draggable sheet is dismissed ( #128455 )
...
fixes https://github.com/flutter/flutter/issues/128367
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true),
home: Scaffold(
floatingActionButton: Builder(
builder: (BuildContext context) => FloatingActionButton(
child: const Icon(Icons.add),
onPressed: () {
Scaffold.of(context).showBottomSheet<void>(
(_) {
return DraggableScrollableSheet(
expand: false,
builder: (_, ScrollController scrollController) =>
ListView.builder(
controller: scrollController,
itemCount: 25,
itemBuilder: (BuildContext context, int index) {
return ListTile(
title: Text('Item $index - tap to close'),
onTap: () {
Navigator.of(context).pop();
},
);
},
),
);
},
);
},
),
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/fa87feb9-54f2-4e50-bf71-c81d9e54ff61
### After
https://github.com/flutter/flutter/assets/48603081/7d192059-7600-4d65-ae84-6321f3598133
2023-06-09 07:06:49 +00:00
engine-flutter-autoroll
80b9ac2cfb
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) ( #128554 )
...
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)
Manual roll requested by zra@google.com
a5f7d5d75f...8f9e608d39zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688 )
2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667 )
2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687 )
2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682 )
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684 )
2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683 )
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680 )
2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679 )
2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677 )
2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678 )
2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676 )
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673 )
2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648 )
2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409 )
2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675 )
2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671 )
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668 )
2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664 )
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662 )
2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660 )
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651 )
2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645 )
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646 )
2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
...
2023-06-09 04:01:08 +00:00
Chris Yang
e25eabd263
Revert "test owners: cyanglaz -> vashworth" ( #128462 )
...
Reverts flutter/flutter#127391
I'm back from OOO so change the test owners back.
2023-06-09 01:57:25 +00:00
Camille Simon
0a6969808a
[Android] Bump integration tests using compileSdkVersion 31 to 33 ( #128072 )
...
Bumps integration tests (that are not run manually only) using `compileSdkVersion` 31 to 33.
2023-06-09 01:54:22 +00:00
Tong Mu
ab3c5bfc7b
Remove single view assumption from MouseTracker, and unify its hit testing code flow ( #127060 )
...
This is a refactor to make `MouseTracker` use the same callback for both kinds of device update. Instead of using two different callbacks for the two device updating methods, `MouseTracker` now receives a hit testing callback at construction, which is the same hit testing method as the one used for other gestures.
This PR not only makes the code cleaner, but also removes the single view assumption from `MouseTracker`, whose code no longer refers to `RendererBinding.renderView`. In the future, we only need to modify `hitTest` (which we will have to do to support gestures for multi-view anyway) to make mouse tracker support multi-view.
2023-06-09 01:51:26 +00:00
Christopher Fujino
0d95243fb2
[flutter_tools] Precache after channel switch ( #118129 )
...
Fixes https://github.com/flutter/flutter/issues/44118
2023-06-09 01:46:24 +00:00
Leigha Jarett
574a71817e
Adding migration guide for Material 3 colors ( #128429 )
...
Fixes: https://github.com/flutter/flutter/issues/127228
2023-06-08 23:00:41 +00:00
Greg Spencer
a280346193
Add AppLifecycleListener, with support for application exit handling ( #123274 )
...
## Description
This adds `AppLifecycleListener`, a class for listening to changes in the application lifecycle, and responding to requests to exit the application.
It depends on changes in the Engine that add new lifecycle states: https://github.com/flutter/engine/pull/42418
Here's a diagram for the lifecycle states. I'll add a similar diagram to the documentation for these classes.
## Related Issues
- https://github.com/flutter/flutter/issues/30735
## Tests
- Added tests for new lifecycle value, as well as for the `AppLifecycleListener` itself.
2023-06-08 22:57:19 +00:00
Tae Hyung Kim
f2351f61d4
Sliver Main Axis Group ( #126596 )
...
This widget implements the ability to place slivers one after another in
a single ScrollView in a way that all child slivers are drawn within the
bounds of the group itself (i.e. SliverPersistentHeaders aren't drawn
outside of the scroll extent provided by all of the child slivers). The
design document for SliverMainAxisGroup can be found
[here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA ).
Fixes https://github.com/flutter/flutter/issues/33137 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
2023-06-08 15:54:09 -07:00
LongCatIsLooong
d4733a3fd4
Reduce _DoubleClampVisitor false positives ( #128539 )
...
I'm getting a few false positives in https://github.com/flutter/flutter/pull/128522/checks from the `num.clamp` checker since I introduced a class with a `clamp` method.
2023-06-08 22:42:35 +00:00
Leigha Jarett
0b8fe01738
Advise developers to use OverflowBar instead of ButtonBar ( #128437 )
...
Fixes https://github.com/flutter/flutter/issues/128430
2023-06-08 22:28:10 +00:00
Jackson Gardner
7c15a26eab
Reland "Migrate benchmarks to package:web" ( #128266 )
...
This attempts to reland https://github.com/flutter/flutter/pull/126848
This was reverted because it made some unexpected changes to our perf measurements. After landing https://github.com/flutter/flutter/pull/127900 , we have much less noise in our benchmarks, so I'd like to reland this and see if there is still a significant measurement difference.
2023-06-08 22:25:40 +00:00
Mahdi Bagheri
4e9869b925
Navigator.pop before PopupMenuItem onTap call ( #127446 )
...
*The order of calling Navigator.pop and PopupMenuItem.onTap has been changed so before calling PopupMenuItem onTap method, PopupMenuBotton onSelect method is going to be called.*
*Solves #127443*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-08 22:25:38 +00:00
Bruno Leroux
ceeaf98e64
Fix navigation rail with long labels misplaced highlights ( #128324 )
2023-06-08 13:32:27 -07:00
Taha Tesser
ddfe8a358c
Update chip.dart to use set of MaterialState ( #128507 )
2023-06-08 13:27:09 -07:00
Janice Collins
29c858adc7
Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages ( #128442 )
...
This updates dartdoc to 6.3.0. Release notes are available, here:
https://github.com/dart-lang/dartdoc/releases/tag/v6.3.0
Most important for Flutter are the reduction in the size of generated HTML files (dart-lang/dartdoc#3384 ) and a new dartdoc directive to hide constant implementations from indicated classes (dart-lang/dartdoc#3398 ), which fixes the longstanding issue (dart-lang/dartdoc#2657 ).
I've also added the api documentation zip to `.gitignore` and the `{@hideConstantImplementations}` dartdoc directive to the motivating example. A screenshot:
I assert that this change to icons.dart should be test-exempt as existing tests cover whether or not dartdoc directives are recognized or are leaking into HTML, and the impact of adding the directive was tested in dart-lang/dartdoc#3398 .
2023-06-08 20:14:23 +00:00
LongCatIsLooong
37f20c268b
Disable blinking cursor when EditableText.showCursor is false ( #127562 )
...
Fixes https://github.com/flutter/flutter/issues/108187
2023-06-08 20:07:23 +00:00
hellohuanlin
9707001c02
[floating_cursor_selection]add more comments on the tricky part ( #127227 )
...
Many parts of the floating cursor selection feature is pretty tricky. Some took me a while to figure out. So I added some comments to explain a bit for future readers.
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/30476
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-08 20:03:49 +00:00
Michael Goderbauer
83af943351
Move RenderObjectElement.updateChildren to Element ( #128458 )
...
This method lived on RenderObjectElement because traditionally, it would be the only one that had to deal with multiple children. The method itself has nothing RenderObjectElement specific, though, and can also be used by any other Element subclass that has multiple children. We are introducing one of those in the near future to handle multiple top-level views.
This is a straight up copy&paste move, no changes have been applied to the code itself.
2023-06-08 19:44:45 +00:00
Michael Goderbauer
1a6174365c
Fix PointerEventConverter doc ( #128452 )
...
Follow-up to https://github.com/flutter/flutter/pull/128287 .
2023-06-08 19:36:55 +00:00
engine-flutter-autoroll
11c8a626b1
Roll Packages from a84b2c2ac344 to e13b8c43386a (9 revisions) ( #128508 )
...
a84b2c2ac3...e13b8c4338stuartmorgan@google.com [tool] Only run unit tests in Chrome for inline web (flutter/packages#4153 )
2023-06-08 jason-simmons@users.noreply.github.com [in_app_purchase] Make the _FeatureCard constructor const in the Android example app (flutter/packages#4162 )
2023-06-08 stuartmorgan@google.com [shared_preferences] Fix initialization race (flutter/packages#4159 )
2023-06-07 47866232+chunhtai@users.noreply.github.com [go_router] Refactors imperative APIs and browser history (flutter/packages#4134 )
2023-06-07 stuartmorgan@google.com [various] Add `http` 1.0 compatibility (flutter/packages#4147 )
2023-06-07 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Accept required parameters not in path (flutter/packages#4039 )
2023-06-07 engine-flutter-autoroll@skia.org Roll Flutter from 0b7415356e07 to 8a5c22e282db (46 revisions) (flutter/packages#4160 )
2023-06-07 scheglov@google.com [pigeon] Require analyzer 5.13.0, prepare for NamedType refactoring. (flutter/packages#4127 )
2023-06-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f92f44110e87 to 682aa387cfe4 (1 revision) (flutter/packages#4157 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-08 15:50:12 +00:00
Casey Hillers
6e254a3f9f
[labeler] Set sync labels to false to stop removing labels ( #128446 )
...
https://github.com/flutter/flutter/issues/128440
The current version of the action has a bug where the sync-labels default value is not read correctly. Explicitly setting to see if that stops the removals.
2023-06-08 15:44:37 +00:00
Jackson Gardner
54e27e3ed5
Update Chrome version for testing ( #128447 )
...
Most of the tests are using Chrome 96.2, which is quite old. Update to Chrome 114.
2023-06-08 15:37:06 +00:00
Zachary Anderson
c8bcff4161
Revert "Redo make inspector weakly referencing the inspected objects." ( #128506 )
...
Reverts flutter/flutter#128471
It looks like one of the tests modified by this PR is still failing: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_widgets/11385/overview
2023-06-08 13:28:04 +00:00
Tess Strickland
840d7dd68a
Use --target-os for appropriate precompiled targets. ( #127567 )
...
This PR adds uses of the `--target-os` command line argument when
building kernel sources for precompiled applications for supported
target operating systems. The Dart CFE then:
* treats `Platform.operatingSystem` as if it were defined as the
constant string provided as an argument to the flag,
* treats `Platform.pathSeparator` as the appropriate separator for that
operating system,
* attempts to constant evaluate the initializer for any field annotated
with the `vm:platform-const` pragma, and
* attempts to constant evaluate all calls to a method annotated with the
`vm:platform-const` pragma.
The `vm:platform-const` pragma can appear in either library or user
code. If the attempt to constant evaluate the field initializer or
method call fails, then an error is thrown at kernel compilation time.
Addresses #14233 .
The tests in
`packages/flutter_tools/test/general.shard/build_system/targets/common_test.dart`
have been adjusted properly to account for the new passed command line
arguments.
2023-06-08 13:17:18 +02:00
Polina Cherkasova
1bd1b5014c
Redo make inspector weakly referencing the inspected objects. ( #128471 )
2023-06-07 18:16:30 -07:00
engine-flutter-autoroll
3f7531db33
Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) ( #128473 )
...
1089ce6874...a5f7d5d75fskia-flutter-autoroll@skia.org Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (flutter/engine#42641 )
2023-06-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 7.3.0 (flutter/engine#42629 )
2023-06-07 zhangzhijian.123@bytedance.com [Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' (flutter/engine#42619 )
2023-06-07 aam@google.com Roll dart to 3.1.0-171.0.dev (flutter/engine#42636 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) (flutter/engine#42633 )
2023-06-07 godofredoc@google.com Add global test docs. (flutter/engine#42531 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ojwVlxZWrbsG4WGSE... to DL1QQ5eZRVNARqLx-... (flutter/engine#42632 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sEHtHM1iFt79roP-x... to aMTaMP0DdKdJnxSbc... (flutter/engine#42631 )
2023-06-07 chillers@google.com [labeler] Fix to run on flutter/engine (flutter/engine#42634 )
2023-06-07 leroux_bruno@yahoo.fr [iOS] Fix TextInputAction.continueAction sends wrong action to framework (flutter/engine#42615 )
2023-06-07 jonahwilliams@google.com [Impeller] fix missing assignment of embedder render target. (flutter/engine#42630 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from sEHtHM1iFt79 to aMTaMP0DdKdJ
fuchsia/sdk/core/mac-amd64 from ojwVlxZWrbsG to DL1QQ5eZRVNA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 23:54:05 +00:00
Greg Spencer
36f73cf645
Disable context menu ( #128365 )
...
## Description
Changes the context menu example for `MenuAnchor` so that it uses right-click, or (on macOS and iOS only) ctrl-left-click, for the context menu. Also disables the browser context menu on web platforms.
## Tests
- Updated test to reflect new triggers.
2023-06-07 23:40:17 +00:00
chunhtai
5328bd9ae0
Adds vmservices to retrieve android applink settings ( #125998 )
...
fixes https://github.com/flutter/flutter/issues/120408
Added two gradle tasks, one for grabing the application id, one for grabbing app link domains.
Added a new vmservices to call these two gradle tasks and return the result.
The expected work flow is that the devtool will first call a vmservices to grab all avaliable build variants. It will then choose one of the build variant and call this new services to get application id and app link domains.
2023-06-07 22:43:11 +00:00
engine-flutter-autoroll
2754514ce2
Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) ( #128460 )
...
4f4486b00b...1089ce6874jonahwilliams@google.com [Impeller] Add buffer to texture
blit for Vulkan. (flutter/engine#41706 )
2023-06-07 chris@bracken.jp [macOS] Add platformview creation parameter
support (flutter/engine#42607 )
2023-06-07 30870216+gaaclarke@users.noreply.github.com [Impeller] Added
a switch to turn on vulkan (flutter/engine#42585 )
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from f8220fa3a729
to 15a29438b099 (1 revision) (flutter/engine#42627 )
2023-06-07 jacksongardner@google.com Bump Chrome version to 114 for
testing (flutter/engine#42623 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from d607cbb0db78 to
773765ca1dd2 (7 revisions) (flutter/engine#42624 )
2023-06-07 jpnurmi@gmail.com [Linux][a11y] implement
AtkText::get_text/string_at_offset() (flutter/engine#38144 )
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 176989ad00cc
to f8220fa3a729 (1 revision) (flutter/engine#42621 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from ee90e9ae2e62 to
d607cbb0db78 (1 revision) (flutter/engine#42618 )
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 1ad4ae4d63bf
to 176989ad00cc (1 revision) (flutter/engine#42617 )
2023-06-07 dkwingsmt@users.noreply.github.com Revert "[Android] Return
keyboard pressed state" (flutter/engine#42616 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from bde894438f29 to
ee90e9ae2e62 (1 revision) (flutter/engine#42614 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... (flutter/engine#42613 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from cd3e1665dcd1 to
bde894438f29 (1 revision) (flutter/engine#42612 )
2023-06-07 skia-flutter-autoroll@skia.org Roll ANGLE from 16841d6256da
to 1ad4ae4d63bf (1 revision) (flutter/engine#42611 )
2023-06-07 bdero@google.com [Impeller] Reland 2: Add Impeller Metal
support in the embedder API (#42411 ) (flutter/engine#42597 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from a01f49f539ab to
cd3e1665dcd1 (1 revision) (flutter/engine#42610 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... (flutter/engine#42609 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 521b8c4bb011 to
a01f49f539ab (4 revisions) (flutter/engine#42608 )
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from cef18d10b363 to
521b8c4bb011 (1 revision) (flutter/engine#42605 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lpbkSRJBMkPs to sEHtHM1iFt79
fuchsia/sdk/core/mac-amd64 from atrYtfHWi2cm to ojwVlxZWrbsG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 15:34:28 -07:00
Bruno Leroux
f18cb2d064
Fix typos 'wether' -> 'whether' ( #128392 )
...
## Description
Fix two typos where 'wether' was used instead of 'whether'.
## Tests
Documentation only.
2023-06-07 20:16:53 +00:00
Alexander Aprelev
09c0706734
Roll engine, patch expression evaluation ( #128255 )
...
Roll to engine to 4f4486b00be28183b482bbb74bbed25f4db153fe pick up dart to 3.1.0-169.0.dev.
Changes since last roll
```
4f4486b00b Roll dart to 3.1.0-169.0.dev (#42602 )
```
Manual roll since rolling to dart 3.1.0-169.0.dev requires patching to expression evaluation in flutter tools
2023-06-07 19:48:42 +00:00
engine-flutter-autoroll
848d4f0e7e
Roll Packages from da72219048fc to a84b2c2ac344 (1 revision) ( #128444 )
...
da72219048...a84b2c2ac3stuartmorgan@google.com [ci] Exclude maps unit tests on Windows (flutter/packages#4152 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 18:27:25 +00:00
fzyzcjy
8a5c22e282
Super tiny MediaQuery doc update ( #127904 )
...
Just now I see some good news: https://www.reddit.com/r/FlutterDev/comments/13vo5a2/the_most_important_flutter_310_feature_that/ (ignore the title though...). It was a performance problem in the old days, so it was great that the problem disappears. However, it seems that the doc is not updated yet, so everyone reading MediaQuery page will still use the old way. Thus I create this super-tiny PR :)
2023-06-07 17:04:03 +00:00
Jackson Gardner
2830f0734d
Revert "Make inspector weakly referencing the inspected objects." ( #128436 )
...
Reverts flutter/flutter#128095
We have a tree closure related to the `widget_inspector_test.dart`. I'd
like to see if reverting this resolves the issue.
2023-06-07 09:38:42 -07:00
