9552 Commits

Author SHA1 Message Date
Mikkel Nygaard Ravn
a836201a74
Raise timeout limit for tests that call pub (#12968) 2017-11-10 12:33:34 +01:00
Mikkel Nygaard Ravn
46b2d6462e
Update timeouts for flutter create tests (#12965) 2017-11-10 09:35:11 +01:00
Mikkel Nygaard Ravn
7298f9ca0b
Expose isMethodCall matcher in flutter_test (#12942) 2017-11-10 08:09:14 +01:00
Alexandre Ardhuin
aefc62f8f3
try some lints (#12719)
* try some lints

* remove avoid_returning_this rule
2017-11-10 07:49:44 +01:00
Todd Volkert
454db9d47c
Re-organize flutter_tools code to better support proper layering. (#12957)
* executable.dart#main() depends on runner.dart#run()
* Refactor code such that non-commands don't depend on commands.

No code was actually changed in this PR - code was merely moved from
point A to point B.
2017-11-09 21:45:31 -08:00
Alexander Aprelev
5af7b423dd Roll engine with rolled dart (#12936) 2017-11-09 16:59:21 -08:00
xster
9038cb3c1c
Revert to previously working font file for material icons (#12954) 2017-11-09 16:41:03 -08:00
Chris Bracken
93c81ffc76
Revert "Roll engine to 45464c0a31e143055d6109c89b2f818d3fc819e5 (#12950)" (#12952)
This reverts commit 5939ff45bf04792c552f1ffc2bfb41a41c56f48b.
2017-11-09 12:51:45 -08:00
Yegor
d1c45f171e
fix the flavors test (#12949) 2017-11-09 10:20:03 -08:00
Alexander Markov
5939ff45bf
Roll engine to 45464c0a31e143055d6109c89b2f818d3fc819e5 (#12950) 2017-11-09 10:15:36 -08:00
Mikkel Nygaard Ravn
177e99b382
Support unpacking platform error events (#12938) 2017-11-09 17:16:48 +01:00
Alexandre Ardhuin
436aa93086
enable lint avoid_classes_with_only_static_members (#12602) 2017-11-09 07:12:36 +01:00
Greg Spencer
3541ad0a64
Add an UnconstrainedBox and factor out debug overflow indicator. (#12856)
UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning.

I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
2017-11-08 20:15:06 -08:00
Adam Barth
fb86a0338c
Document MaterialApp's _errorTextStyle (#12842) 2017-11-08 19:46:51 -08:00
Devon Carew
30ff005456
fix an issue reported by the public_member_api_docs lint (#12889) 2017-11-08 19:05:12 -08:00
Chris Bracken
50decbcdce
Roll engine to bc2acf7bddd855898ceb245a8a2ecf83c634ec8d (#12933) 2017-11-08 18:08:59 -08:00
xster
152f5258b0
Let RenderSliverFixedExtentBoxAdapter handle disappearing top items (#12919)
* fix with first part of test

* Test without reshifting

* Let sliver fixed extend list also handle disappearing top items.
2017-11-08 17:06:46 -08:00
Ian Hickson
97b3742f63
Automatically flip material icons in RTL. (#12876)
I'm not really sure how to test this without a reference test, since
eventually we want to move this to a font feature and thus the obvious
test (looking for the Transform widget) isn't really valid.
2017-11-08 14:22:14 -08:00
Devon Carew
b6bd628bcd
address unused element issues and new warnings (#12890)
* address unused element issues and new warnings

* add a missing return
2017-11-08 14:06:55 -08:00
Alexandre Ardhuin
15601fe55c
Enable lint prefer asserts in initializer lists (#12903)
* enable lint prefer_asserts_in_initializer_lists

* enable --assert-initializer
2017-11-08 22:59:49 +01:00
Yegor
a75f003b9c
add within matcher for comparing metric-space values (#12908) 2017-11-08 13:36:16 -08:00
Mikkel Nygaard Ravn
b04b89ac95
Clarify documented semantics of StatefulWidget (#12880) 2017-11-08 20:39:05 +01:00
Ulf Sauer
7837fe6ebb Fix duplicate word in documentation (#12874) 2017-11-08 11:24:16 -08:00
Yegor
d4830fcf1b
smoke test VM service connection before returning VMService object (#12914) 2017-11-08 10:43:47 -08:00
Chris Bracken
e1cbbc1c18
Roll engine to dd6585bb9a5d74dd3c7378e80086d39f378e02a6 (#12918) 2017-11-07 19:28:42 -08:00
amirh
48d48e2611
roll engine to 179bd4a79913df6c23f97c1940388f4b78aa7476 (#12916) 2017-11-07 18:14:22 -08:00
Hans Muller
c4cdbf86eb
Transform Widget alignment is AlignmentGeometry (#12870)
* a => an
2017-11-07 14:43:57 -08:00
Todd Volkert
16c363ac07
Clarify docs in FlutterDriver.requestData() (#12909) 2017-11-07 14:43:41 -08:00
xster
8f79643680
Error message for unregistered phone (#12911) 2017-11-07 13:23:43 -08:00
Ryan Macnak
cc5902b9d8
Fix some tests to be happy with proper microtask scheduling. (#12900)
(I suspect this accounts the sets of microtasks from scheduleWarmUpFrame now running separately.)

Issue https://github.com/flutter/flutter/issues/9998
2017-11-07 09:26:45 -08:00
Sebastiano Poggi
dfd1ffa7c5 Surface elevation shadow colour on Material (#12881)
* Surface shadowColor from RenderPhysicalModel to Material

* Fix typo in material_test

* Add nullability info to documentation

* Add support for animating elevation shadow color

* Add shadowColor to Material's debugFillProperties()

* Add missing default value for elevation in Material debugFillProperties()

* Add missing non-null asserts for animate flags in AnimatedPhysicalModel

* Add test for shadow color animating smoothly
2017-11-06 17:40:13 -08:00
Yegor
91bd9bc4f8
delay taking screenshot to allow GPU thread to render the frame (#12896)
* delay taking screenshot to allow GPU thread to render the frame

* address comments
2017-11-06 17:33:48 -08:00
amirh
289ff9d549
roll engine to d8a0dd295828fa1cf2a989655ecbbb9983e88178 (#12893) 2017-11-06 15:09:32 -08:00
amirh
700d7b9da6
Typo fix (ImageProvider) (#12887) 2017-11-06 10:55:01 -08:00
Chris Bracken
4e2e69797a
Eliminate MethodCall hashCode and equals (#12277)
Since MethodCall equality checks are limited to test scenarios, this
patch replaces them with an equivalent test matcher. At present
MethodCalls are always used in scenarios where indentity-based
equality/hashing is appropriate.

This change avoids an assertion failure when MethodCall args are
Iterable (possible since args are of type dyanmic), and hashValue() from
dart:ui asserts that its input is not an Iterable.

The alternative of implementing support for deep equality in dart:ui was
rejected on the basis that if we're to encourage performant code,
expensive checks should be obviously-expensive to the author.
2017-11-06 09:52:57 -08:00
Mikkel Nygaard Ravn
354ab0ce7b
Add missing word in dartdoc for StatelessWidget (#12879) 2017-11-06 17:16:18 +01:00
Ian Hickson
e064d6cbc9
RenderFlex with MainAxisSize.min RTL (#12875)
There was a left-bias when MainAxisSize.min couldn't be honoured.
2017-11-03 17:50:11 -07:00
Chris Bracken
61373fd03a
Roll engine to e059cc02581ebf5f27a5c0596a5e1ad24bd9fda1 (#12873) 2017-11-03 15:15:18 -07:00
Ian Hickson
87e8505f69
Test of bidi with formatting (#12860) 2017-11-03 10:55:45 -07:00
Ian Hickson
fa6f9a0341
Various documentation improvements (#12855) 2017-11-03 10:55:26 -07:00
xster
c17099f474
Leave a version tag when creating project (#12846)
* Leave a version tag when creating project

* Generalize .version to .metadata
2017-11-03 10:07:57 -07:00
Jason Simmons
b865b0eb2f
Use TextPainter.preferredLineHeight to estimate line height for Cupertino selection handles (#12833)
Fixes https://github.com/flutter/flutter/issues/12046
2017-11-03 09:47:46 -07:00
xster
89405002bc
Add an iOS style demo to the gallery (#12651)
* Built first tab

* Small additions

* started tab 3

* Need color arithmetics

* tab 2 built

* finalize

* lint and tests

* review

* Reapply docs after rebase

* use color.computeLuminance

* linter

* nit
2017-11-03 08:50:29 -07:00
xster
015c738318
Remove extracted luminance calculations from Material (#12718)
* remove extracted methods

* lint
2017-11-03 06:14:40 -07:00
Yegor
35bb855c0d
make microbenchmark logging verbose (#12858)
* make microbenchmark logging verbose

* prefix JSON so it can be parsed in verbose mode
2017-11-02 18:11:34 -07:00
amirh
616a2ad6da
Move semantics stuff from rendering to a top-level semantics/ library (#12793) 2017-11-02 17:38:28 -07:00
Greg Spencer
79862a7262
Fixing assumption that baseStyle is a complete style. (#12836)
This fixes the assumption that InputDecorator had where it expected baseStyle to be a complete style. Now it merges the baseStyle with the subhead style instead of substituting it entirely.

This fixes #12832.
2017-11-02 16:42:02 -07:00
Chris Bracken
332d3db8f8
Roll engine to 3021e8f6c3251712dbac7d15ad1538e287c10f49 (#12853) 2017-11-02 16:08:53 -07:00
Michael Goderbauer
67ed7807d4
Add new line after "see also" (#12850) 2017-11-02 15:48:10 -07:00
Yegor
c027aa159b
remove flaky flag from stable benchmarks; reintroduce iOS benchmarks (#12851) 2017-11-02 14:20:14 -07:00