engine-flutter-autoroll
d8ae99a790
Roll Packages from 56df73e3c54c to b4e0fc1bc117 (1 revision) ( #154824 )
...
56df73e3c5...b4e0fc1bc1engine-flutter-autoroll@skia.org Roll Flutter from 45ef8f36ff41 to 2e221e7308ba (20 revisions) (flutter/packages#7599 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 15:45:38 +00:00
engine-flutter-autoroll
fb24721a22
Roll Flutter Engine from 117a7d0859ed to 7e6d5c897a5a (1 revision) ( #154820 )
...
117a7d0859...7e6d5c897askia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Dxly0DC9pQXTXVNm0... to kIWQ460iagZLxVRPc... (flutter/engine#55039 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Dxly0DC9pQXT to kIWQ460iagZL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 13:44:25 +00:00
engine-flutter-autoroll
f566016ed3
Roll Flutter Engine from 331fd5af8217 to 117a7d0859ed (1 revision) ( #154794 )
...
331fd5af82...117a7d0859jonahwilliams@google.com [engine] dispatch platform channel messages through event loop, except navigation on start. (flutter/engine#55027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 19:06:24 +00:00
engine-flutter-autoroll
7a685ad072
Roll Flutter Engine from 51d4402f17b4 to 331fd5af8217 (2 revisions) ( #154791 )
...
51d4402f17...331fd5af82skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BF-8UyvqW5l52-hP2... to Dxly0DC9pQXTXVNm0... (flutter/engine#55033 )
2024-09-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0f783bdb7a4d to b6c3cd9b93f1 (1 revision) (flutter/engine#55031 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BF-8UyvqW5l5 to Dxly0DC9pQXT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 10:42:38 +00:00
hgraceb
0139761878
Fix TabBar crash with SliverAppBar ( #154485 )
...
Fixes #154484
Similar to #104998 . Cause with updated at different phases of the same frame.
2024-09-08 03:57:20 +00:00
engine-flutter-autoroll
cede6ba628
Roll Flutter Engine from 7bf1169715d6 to 51d4402f17b4 (2 revisions) ( #154782 )
...
7bf1169715...51d4402f17jonahwilliams@google.com [Impeller] Disable exp canvas. (flutter/engine#55026 )
2024-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PBeI0gGvgFdXV6hCg... to BF-8UyvqW5l52-hP2... (flutter/engine#55024 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PBeI0gGvgFdX to BF-8UyvqW5l5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 19:25:35 +00:00
engine-flutter-autoroll
04d64d9c2f
Roll Flutter Engine from 419fb8c0ab3e to 7bf1169715d6 (14 revisions) ( #154769 )
...
419fb8c0ab...7bf1169715#55006 )" (flutter/engine#55022 )
2024-09-07 magder@google.com Turn off software rendering in iOS scenario golden tests (flutter/engine#55016 )
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 04:39:25 +00:00
auto-submit[bot]
07230960c1
Reverts "Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )" ( #154765 )
...
Reverts: flutter/flutter#154764
Initiated by: jonahwilliams
Reason for reverting: failing post submit on mac module test.
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
419fb8c0ab...b9f9015ff9#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 03:04:25 +00:00
engine-flutter-autoroll
8e360edc38
Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )
...
419fb8c0ab...b9f9015ff9#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 02:08:16 +00:00
Siva
d7a658d705
Roll Flutter Engine from c50eb8a65097 to 419fb8c0ab3e ( #154734 )
...
c50eb8a650...419fb8c0abhttps://github.com/flutter/flutter/issues/54975 )"
(https://github.com/flutter/engine/pull/55000 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions)
(https://github.com/flutter/engine/pull/54999 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to
5dqcFlKzRjJb6V95W... (https://github.com/flutter/engine/pull/54998 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions)
(https://github.com/flutter/engine/pull/54997 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision)
(https://github.com/flutter/engine/pull/54995 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions)
(https://github.com/flutter/engine/pull/54992 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg...
(https://github.com/flutter/engine/pull/54990 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions)
(https://github.com/flutter/engine/pull/54988 )
2024-09-06
[30870216+gaaclarke@users.noreply.github.com ](mailto:30870216+gaaclarke@users.noreply.github.com)
Removes the int storage from Color
(https://github.com/flutter/engine/pull/54714 )
2024-09-06 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: Add
logging of duplicate codesign binaries
(https://github.com/flutter/engine/pull/54987 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to
D9INMR2u4wcyiZ750... (https://github.com/flutter/engine/pull/54984 )
2024-09-05
[a-siva@users.noreply.github.com ](mailto:a-siva@users.noreply.github.com)
Manual roll of Dart. (https://github.com/flutter/engine/pull/54983 )
2024-09-05 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: add
unsigned_binaries.txt (https://github.com/flutter/engine/pull/54977 )
2024-09-05
[jason-simmons@users.noreply.github.com ](mailto:jason-simmons@users.noreply.github.com)
Manual Skia roll to 809f868ded1c
(https://github.com/flutter/engine/pull/54972 )
2024-09-05
[1961493+harryterkelsen@users.noreply.github.com ](mailto:1961493+harryterkelsen@users.noreply.github.com)
[canvaskit] Fix incorrect calculation of ImageFilter paint bounds
(https://github.com/flutter/engine/pull/54980 )
2024-09-05 [jonahwilliams@google.com ](mailto:jonahwilliams@google.com)
[engine] always force platform channel responses to schedule a task.
(https://github.com/flutter/engine/pull/54975 )
2024-09-05
[tugorez@users.noreply.github.com ](mailto:tugorez@users.noreply.github.com)
Fix unexpected ViewFocus events when Text Editing utilities change focus
in the middle of a blur call.
(https://github.com/flutter/engine/pull/54965 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX
---------
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-09-06 15:42:07 -07:00
Taha Tesser
755cf0bd3f
Fix Material 3 AppBar.leading action IconButtons ( #154512 )
...
Fixes [`AppBar` back button focus/hover circle should not fill up whole height](https://github.com/flutter/flutter/issues/141361 )
Fixes [[Material 3] Date Range Picker close button has incorrect shape](https://github.com/flutter/flutter/issues/154393 )
This updates the leading condition added in https://github.com/flutter/flutter/pull/110722
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: SingleChildScrollView(
child: Column(
children: [
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with BackButton'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with CloseButton'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with DrawerButton'),
),
],
),
const Divider(),
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
],
),
],
),
),
),
);
}
}
```
</details>
### Before
<img width="912" alt="Screenshot 2024-09-04 at 12 38 05" src="https://github.com/user-attachments/assets/25a6893c-89c9-4b45-a5bb-8da0eee71cd2 ">
### After
<img width="912" alt="Screenshot 2024-09-04 at 12 38 28" src="https://github.com/user-attachments/assets/49727183-568c-412e-9fa1-1eefd0cd87a7 ">
2024-09-06 21:10:35 +00:00
Rajesh Malviya
6ad6641f0f
Remove allowoptimization modifier from FlutterPlugin proguard rules ( #154715 )
...
Fixes : #154580
Previous PR: #154677
More info: https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620
The errors described in the original issue [are still occurring](https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620 ) after #154677 . Before this change, the repro [broken_demo](https://github.com/rajveermalviya/broken_demo ) mentioned in the original issue logs:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 14.5s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 739ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7).
E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null)
E/flutter (13284): #0 PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #1 getApplicationSupportDirectory (package:path_provider/path_provider.dart:78)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #2 _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284):
```
After this change:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 15.2s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 857ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files'
```
2024-09-06 20:37:23 +00:00
Chris Bobbe
84757af9f8
Adjust ButtonStyle.{foreground,icon}Color dartdocs for new behavior ( #154646 )
...
Fixes #154644 .
This aligns these dartdocs with the new behavior introduced in PR #143501 / 51ed348f3, where passing `iconColor: null` would cause the icon to be colored with a hard-coded default instead of with `foregroundColor`.
2024-09-06 19:22:33 +00:00
auto-submit[bot]
8c6513ddd1
Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )" ( #154743 )
...
Reverts: flutter/flutter#154048
Initiated by: nate-thegrate
Reason for reverting: using `AnimationStyle` instead would allow for complete animation duration and curve customization.
Original PR Author: nploi
Reviewed By: {piedcipher, nate-thegrate}
This change reverts the following previous change:
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 19:13:17 +00:00
Bruno Leroux
2e221e7308
Fix DropdownMenu focused item styles ( #153159 )
...
## Description
This PR fixes the style resolution for selected dropdown menu items (make it possible to provide a custom style and avoid hardcoded values when possible).
For the moment, I kept the default selected background which was previously set (`onSurface.withOpacity(0.12)`) to keep this PR focused on its goal which is to make it possible to overrides the defaults item style by providing a custom button style at the theme level or at the menu entry level.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123736 .
## Tests
Adds 4 tests.
2024-09-06 18:50:06 +00:00
Nguyen Phuc Loi
0eaeb0d1c5
Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )
...
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 18:42:36 +00:00
Mikhail Novoseltsev
d9321159bf
[tool] Add dartFileName setting for platform plugins ( #153099 )
...
This PR introduces the `dartFileName` parameter for platform plugin configurations with Dart platform implementations. This new parameter allows plugin developers to specify a custom path to the file where the `dartPluginClass` is defined.
**Implementation is opt-in**. `dartFileName` is completely optional and is taken in account only with `dartClassName`. Possibility to set `dartClassName` without `dartFileName` remains.
**Implementation is backward compatible** â existing configurations using only `dartClassName` remain fully supported. If `dartFileName` is omitted, the system falls back to the previous behavior of deriving the file name from the plugin name.
## Example
```yaml
flutter:
plugin:
platforms:
some_platform:
dartPluginClass: MyPlugin
dartFileName: 'src/my_plugin_implementation.dart'
```
fixes #152833
2024-09-06 18:27:09 +00:00
Reid Baker
9d9ec70b4e
[Conductor] Add ability to override mirror, add tests for default arg parsing and custom arg parsing ( #154363 )
...
fixes #154342
2024-09-06 18:07:09 +00:00
davidhicks980
35b0349294
Improve CupertinoPopupSurface appearance ( #151430 )
...
This PR makes the CupertinoPopupSurface more vibrant. Also, the gaussian kernel was switched to 30 from 20 based on comparisons.
@dkwingsmt - Looking forward to your dialog and fixes!
After is on bottom:
<img width="939" alt="image" src="https://github.com/flutter/flutter/assets/59215665/bd020c9b-af87-4342-9a9f-c9f8f7693456 ">
Notably, because the borders are very transparent, the new version looks more colorful in the sample screencap than it actually is. As such, focus on the individual colors to get a feel for the change.
| actual | old | new
|--|--|--|
| <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7de2801d-a2cc-44a4-a660-2692889fed63 "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/48689d82-af15-4612-b4ab-75d584e9b094 "> | <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7c1075ec-b815-47e0-b822-65a2b63497a0 "> |
| <img width="24" alt="image" src="https://github.com/flutter/flutter/assets/59215665/2eeefe25-2e1d-4a79-b748-4925d950b9a2 "> | <img width="26" alt="image" src="https://github.com/flutter/flutter/assets/59215665/68a2694c-d943-4563-9b5e-9e86e2ee1d58 "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/1932b90a-1719-40f5-828e-41ceafd59e26 "> |
<img width="22" alt="image" src="https://github.com/flutter/flutter/assets/59215665/0bd22c64-dd37-4262-a7e8-ed610151ab7a "> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/e1738bd2-98d2-491b-9a4a-d2c7cbc5a080 "> | <img width="25" alt="image" src="https://github.com/flutter/flutter/assets/59215665/c245d786-19aa-4a14-8df3-029591d1debd "> |
Partially addresses https://github.com/flutter/flutter/issues/29483
This will need tests, which I will add once I know which tests break due to this commit.
Blockers:
* https://github.com/flutter/flutter/issues/152026
2024-09-06 15:47:11 +00:00
engine-flutter-autoroll
c56ab6b947
Roll Packages from 71e827e7df68 to 56df73e3c54c (1 revision) ( #154725 )
...
71e827e7df...56df73e3c510687576+bparrishMines@users.noreply.github.com [extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests (flutter/packages#7571 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 15:45:07 +00:00
Michael Goderbauer
c6b0876a2f
Quick access to style guide ( #154689 )
2024-09-06 15:45:04 +00:00
auto-submit[bot]
3d53d1ae95
Reverts "Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions) ( #154691 )" ( #154726 )
...
Reverts: flutter/flutter#154691
Initiated by: jtmcdole
Reason for reverting: breaking flutter-dashboard
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
c50eb8a650...015f3b1decjonahwilliams@google.com [engine] always force platform channel responses to schedule a task. (flutter/engine#54975 )
2024-09-05 tugorez@users.noreply.github.com Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 15:24:26 +00:00
Loïc Sharma
aea84342eb
Improve iOS unpack target's error messages ( #154649 )
...
Improves the formatting and error messages of the target that unpacks the Flutter framework in Flutter iOS builds.
Follow up to: https://github.com/flutter/flutter/pull/154645
Part of https://github.com/flutter/flutter/issues/151567
2024-09-05 23:46:22 +00:00
gaaclarke
9e99675dbe
Made some pixel tests fuzzy ( #154680 )
...
This is a forward fix for the failures seen in https://github.com/flutter/engine/pull/54714/checks?check_run_id=29742599916 on https://github.com/flutter/engine/pull/54714
issue: https://github.com/flutter/flutter/issues/127855
2024-09-05 23:11:03 +00:00
engine-flutter-autoroll
b0ed1cb4f4
Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions) ( #154691 )
...
c50eb8a650...015f3b1decjonahwilliams@google.com [engine] always force platform channel responses to schedule a task. (flutter/engine#54975 )
2024-09-05 tugorez@users.noreply.github.com Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 22:41:27 +00:00
dependabot[bot]
57faab2d11
Bump peter-evans/create-pull-request from 7.0.0 to 7.0.1 ( #154690 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 7.0.0 to 7.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.1</h2>
<p>âï¸ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311 ">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283 ">peter-evans/create-pull-request#3283</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288 ">peter-evans/create-pull-request#3288</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289 ">peter-evans/create-pull-request#3289</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3290 ">peter-evans/create-pull-request#3290</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3291 ">peter-evans/create-pull-request#3291</a></li>
<li>fix: handle ambiguous argument failure on diff stat by <a href="https://github.com/peter-evans "><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3312 ">peter-evans/create-pull-request#3312</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8867c4aba1https://redirect.github.com/peter-evans/create-pull-request/issues/3312 ">#3312</a>)</li>
<li><a href="6073f5434bhttps://redirect.github.com/peter-evans/create-pull-request/issues/3291 ">#3291</a>)</li>
<li><a href="6d01b5601chttps://redirect.github.com/peter-evans/create-pull-request/issues/3290 ">#3290</a>)</li>
<li><a href="25cf8451c3https://redirect.github.com/peter-evans/create-pull-request/issues/3289 ">#3289</a>)</li>
<li><a href="d87b980a0ehttps://redirect.github.com/peter-evans/create-pull-request/issues/3288 ">#3288</a>)</li>
<li><a href="119d131ea9https://redirect.github.com/peter-evans/create-pull-request/issues/3283 ">#3283</a>)</li>
<li><a href="73e6230af4c0348e860f4320041ed3...8867c4aba1https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=7.0.0&new-version=7.0.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-09-05 22:17:06 +00:00
Qun Cheng
6dd929ab28
Normalize Dialog theme ( #153982 )
...
This PR is to make preparations to make `DialogTheme` conform to Flutter's conventions for component themes:
* Added a `DialogThemeData` class which defines overrides for the defaults for `Dialog` properties.
* Added 2 `DialogTheme` constructor parameters: `DialogThemeData? data` and `Widget? child`. This is now the preferred way to configure a `DialogTheme`:
```
DialogTheme(
data: DialogThemeData(color: xxx, elevation: xxx, ...),
child: Dialog(...)
)
```
These two properties are made nullable to not break existing apps which has customized `ThemeData.dialogTheme`.
* Changed the type of theme defaults from `DialogTheme` to `DialogThemeData`.
TODO:
* Fix internal failures.
* Change the type of `ThemeData.dialogTheme` from `DialogTheme` to `DialogThemeData`. This may cause breaking changes, a migration guide will be created.
Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-09-05 22:00:23 +00:00
Chris Bracken
4d17998755
iOS,macOS: Do not copy unsigned_binaries.txt to build outputs ( #154684 )
...
There are three categories of binaries produced as part of the framework artifacts:
* Those that use APIs that require entitlements and must be code-signed; e.g. gen_snapshot
* Those that do not use APIs that require entitlements and must be code-signed; e.g. Flutter.framework dylib.
* Those that do not need to be code-signed; e.g. Flutter.dSYM symbols.
We are adding the third category in https://github.com/flutter/engine/pull/54977 . The Cocoon code signing aspect of this was handled in https://github.com/flutter/cocoon/pull/3890 .
This ensures these files don't get copied into the build output should they appear in the artifact cache.
Issue: https://github.com/flutter/flutter/issues/154571
2024-09-05 21:37:28 +00:00
engine-flutter-autoroll
6dc88205de
Roll Flutter Engine from e042ff5df7af to c50eb8a65097 (1 revision) ( #154679 )
...
e042ff5df7...c50eb8a650jonahwilliams@google.com [Impeller] migrate last color wheel test to DisplayList. (flutter/engine#54964 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 19:35:26 +00:00
Gray Mackall
a621b8a2e3
Add proguard rule to keep the class for all implementations of FlutterPlugin ( #154677 )
...
Fixes https://github.com/flutter/flutter/issues/154580 , for the time being.
We should follow up to determine why this is necessary, but I think it is important to un-break these specific plugins for now.
2024-09-05 19:31:06 +00:00
Bruno Leroux
2b8072e9bb
Fix DropdownMenu menu does not follow the text field ( #154667 )
...
## Description
This PR fixes the `DropdownMenu` menu position when the keyboard appear on mobile device.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/149037 .
## Tests
Adds 2 tests.
2024-09-05 19:15:21 +00:00
engine-flutter-autoroll
fea5d1ec03
Roll Flutter Engine from a156e713f4dc to e042ff5df7af (1 revision) ( #154678 )
...
a156e713f4...e042ff5df7flar@google.com [DisplayList] Remove unnecessary DisplayListBuilder as DlOpReceiver accesses (flutter/engine#54969 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 18:29:11 +00:00
dy0gu
834566f05d
Fix ZoomPageTransitionsBuilder hardcoded fill color ( #154057 )
...
Fixes : #115275
Fixes : #116127
Fixes : #126682
Continuing on: #139078 (Credits to @LowLevelSubmarine for his initial
work!)
When using `ZoomPageTransitionsBuilder`, which is the default for
`ThemeData` with a `MaterialApp`, dark edges would show around the
exiting page that was being zoomed out in the background. Other times, a
scrim (what looked like a slightly transparent dark overlay over the
page) would appear.
After some experimenting it was concluded that, in the first case, this
was because both pages don't fully fill the enclosing scaffold area
during the transition and the color for filling the remaining space was
set hard coded as `Colors.black`. The second case (scrim) happens when
navigating from a page with an enclosing scaffold to a nested one,
without a scaffold, unlike the first case that happens when both pages
have a (different) enclosing scaffold, except this time it would be the
hard coded color covering the page with a slight opacity reduction.
### Changes
- Replaced the hard coded color for transition filling with the current
`ThemeData.colorScheme.surface`
- Added a RenderBox based test to verify the correct color is being used
in the transition.
## Preview
**Before, notice the dark outline flash when navigating to the first
page and the scrim when navigating to the second:**
https://github.com/user-attachments/assets/b4cc8658-1008-49f4-8553-abd5fcc72989
**After, using the theme relative color (in this case the default white)
to replace the hard coded value:**
https://github.com/user-attachments/assets/b70f42d2-6246-4964-99d1-34ff8051ab06
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-05 10:57:17 -07:00
engine-flutter-autoroll
a3301cecae
Roll Flutter Engine from 34b61eb53b99 to a156e713f4dc (1 revision) ( #154672 )
...
34b61eb53b...a156e713f4skia-flutter-autoroll@skia.org Roll Skia from 0b24a6d3c514 to 655699edfc97 (4 revisions) (flutter/engine#54958 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 17:04:12 +00:00
engine-flutter-autoroll
45ef8f36ff
Roll Packages from e93995a89a7e to 71e827e7df68 (2 revisions) ( #154669 )
...
e93995a89a...71e827e7dfengine-flutter-autoroll@skia.org Roll Flutter (stable) from 5874a72aa4c7 to 4cf269e36de2 (8 revisions) (flutter/packages#7578 )
2024-09-04 49699333+dependabot[bot]@users.noreply.github.com [google_maps]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#7033 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 15:53:25 +00:00
engine-flutter-autoroll
a7cd788d80
Roll Flutter Engine from 4844cb489b3f to 34b61eb53b99 (1 revision) ( #154661 )
...
4844cb489b...34b61eb53bskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qS4FRrP_KI7czLMKv... to xNv47d1TZmK9XgTxu... (flutter/engine#54968 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from qS4FRrP_KI7c to xNv47d1TZmK9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 09:57:40 +00:00
engine-flutter-autoroll
b3c1c28f7f
Roll Flutter Engine from 652a43bc4055 to 4844cb489b3f (1 revision) ( #154655 )
...
652a43bc40...4844cb489b1961493+harryterkelsen@users.noreply.github.com Add `crossOrigin` property to <img> tag used for decoding (flutter/engine#54961 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 02:33:35 +00:00
engine-flutter-autoroll
57c4bd0d85
Roll Flutter Engine from 4a01a3a04e32 to 652a43bc4055 (3 revisions) ( #154653 )
...
4a01a3a04e...652a43bc40skia-flutter-autoroll@skia.org Manual roll Dart SDK from 139867e57ba9 to 1a6246225b75 (18 revisions) (flutter/engine#54962 )
2024-09-04 30870216+gaaclarke@users.noreply.github.com Framework wide color linear gradients (flutter/engine#54748 )
2024-09-04 matanlurey@users.noreply.github.com Add more `package:test` (removing usages of `package:litetest`) (flutter/engine#54882 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-05 01:29:38 +00:00
Loïc Sharma
3bda455f4e
Improve 'flutter downgrade' error message ( #154434 )
...
`flutter downgrade` fails if you haven't used `flutter upgrade`:
```
$ flutter downgrade
There is no previously recorded version for channel "stable".
```
It's not clear what actions a user should take from this error message. Here's the new error message:
```
$ flutter downgrade
It looks like you haven't run "flutter upgrade" on channel "stable".
"flutter downgrade" undoes the last "flutter upgrade".
To switch to a specific Flutter version, see: https://flutter.dev/to/switch-flutter-version
```
Depends on https://github.com/flutter/website/pull/11098
2024-09-04 22:06:31 +00:00
Rexios
6abef22251
[tool] Update .gitignore templates to include .flutter-plugins files ( #152950 )
...
Fixes https://github.com/flutter/flutter/issues/152793
2024-09-04 20:54:24 +00:00
engine-flutter-autoroll
b9ae1f1bd3
Roll Flutter Engine from 8395337ff43f to 4a01a3a04e32 (1 revision) ( #154642 )
...
8395337ff4...4a01a3a04eskia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from p5MYp7o9Tt0sossYJ... to k4lKsecg0pdIp-U7c... (flutter/engine#54960 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 20:16:14 +00:00
miechoo
6d38831fc8
Test of AppBarMediumApp and AppBarLargeApp ( #153973 )
...
Part of https://github.com/flutter/flutter/issues/130459
This are tests of snippets used in [SliverAppBar.medium const constructor](https://api.flutter.dev/flutter/material/SliverAppBar/SliverAppBar.medium.html ) and [SliverAppBar.large const constructor](https://api.flutter.dev/flutter/material/SliverAppBar/SliverAppBar.large.html ) Flutter API reference documentation.
The only way I've found to distinguish the SliverAppBar.medium and SliverAppBar.large constructors from the regular SliverAppBar is to check if the title is styled according to the [Material Design 3](https://m3.material.io/components/top-app-bar/specs ) specification.
2024-09-04 19:46:16 +00:00
engine-flutter-autoroll
b99322ef66
Roll Flutter Engine from d6be2ac8ec01 to 8395337ff43f (3 revisions) ( #154638 )
...
d6be2ac8ec...8395337ff4jonahwilliams@google.com [Impeller] fix NPE when checking known bad driver. (flutter/engine#54959 )
2024-09-04 skia-flutter-autoroll@skia.org Roll Skia from d1121ff583c4 to 0b24a6d3c514 (1 revision) (flutter/engine#54957 )
2024-09-04 kjlubick@users.noreply.github.com Use moved Skia Ganesh header files (flutter/engine#54833 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 19:18:59 +00:00
engine-flutter-autoroll
5754e1762e
Roll Packages from 848d7e915e21 to e93995a89a7e (8 revisions) ( #154637 )
...
848d7e915e...e93995a89a109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `JointType` to an enum (flutter/packages#7558 )
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Go router sample for AdaptiveScaffold (flutter/packages#7452 )
2024-09-04 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables (flutter/packages#7549 )
2024-09-03 34871572+gmackall@users.noreply.github.com [google_sign_in_android] Downgrade Guava version from `33.3.0` to `32.0.1` (flutter/packages#7573 )
2024-09-03 magder@google.com [google_maps_flutter] Remove unused MapKit imports from iOS example apps (flutter/packages#7522 )
2024-09-03 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad (flutter/packages#7285 )
2024-09-03 34871572+gmackall@users.noreply.github.com [rfw] Upgrade missed example app (flutter/packages#7545 )
2024-09-03 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.4.0 to 1.4.1 in /packages/video_player/video_player_android/android (flutter/packages#7564 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 19:15:00 +00:00
Mansour Alhaddad
4e8df8be31
Add minimum height for MaterialBanner ( #153951 )
...
This pr allows defining custom minimum height for material banner
fixes this https://github.com/flutter/flutter/issues/153666
2024-09-04 18:35:23 +00:00
Chris Bracken
07fcfd1776
iOS,macOS: Add list of expected-unsigned binaries ( #154591 )
...
This updates the codesigning test to account for iOS and macOS binaries in the artifact cache that are _expected_ to not be codesigned.
In https://github.com/flutter/engine/pull/54414 we started bundling dSYM (debugging symbols) within Flutter.xcframework, a requirement for App Store verification using Xcode 16.
We did the same for macOS in https://github.com/flutter/engine/pull/54696 .
Unlike the framework dylib, dSYM contents are not directly codesigned (though the xcframework containing them is).
Issue: https://github.com/flutter/flutter/issues/154571
2024-09-04 18:27:06 +00:00
Gianluca Bettega
ce15e3bcb5
added enabled to search anchor ( #153256 )
...
Added the same parameter from #137388 to the `SearchAnchor`
This PR will fix : #150331
2024-09-04 18:25:06 +00:00
Mairramer
d9dda9d08f
Fixes an issue where itemExtent was incorrectly assigned to renderObject.minExtent ( #153805 )
...
Fixes #153694 .
Previously, when state was updated, the updateRenderObject method incorrectly assigned itemExtent to renderObject.minExtent, which unintentionally overrode the intended default behavior.
2024-09-04 18:19:51 +00:00
Gray Mackall
056c40f55b
Make the Flutter Gradle Plugin apply FlutterExtension to (flutter) plugins ( #151861 )
...
Makes the Flutter Gradle Plugin apply the `FlutterExtension` (the class that vends `flutter.minSdkVersion`, etc) to Flutter plugins.
This allows plugin authors to use `flutter.compileSdkVersion` and the like in plugin `build.gradle` files.
Doesn't use it in templates yet - holding off till we can see how this works in the plugins repo (which will sadly have to wait till this makes the next stable ð¢ )
2024-09-04 17:47:59 +00:00
Reid Baker
40f763aeaa
Update changelog from 3.24.2 to master ( #154625 )
...
Following go/flutter-release-workflow#notify update changelog in master from latest stable release.
2024-09-04 17:22:05 +00:00
