37993 Commits

Author SHA1 Message Date
Srujan Gaddam
d8ffc7390c
Pin package:web 0.4.0 (#138428)
This version is needed so that dart:js_interop can move to extension
types. Also adds some code to handle some breaking changes:

- Body -> Response. Body was an IDL interface mixin type we exposed in
dart:html. Going forward, users should either use Request or Response.
- Casts to JSAny. These are temporary until we move package:web types to
extension types. Currently, package:web types can't implement JSObject
as JSObject will move to be an extension type itself.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
2023-11-15 15:03:21 -08:00
auto-submit[bot]
82a7a62b45
Reverts "Reland VelocityTracker update (#132291)" (#138512)
Reverts flutter/flutter#137381
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728
2023-11-15 21:22:19 +00:00
Yegor
465288588f
[web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (#138498)
Skipping the test due to
https://github.com/flutter/flutter/issues/137669. It's not clear which
PR started it, so we can't revert anything, and the fix is not yet clear
either. However, the flakiness is very high and is disruptive to the
Flutter team.
2023-11-15 12:58:53 -08:00
engine-flutter-autoroll
ca31aa17b2
Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (#138502)
7c2b8d520b...30327eae08

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) (flutter/engine#48075)
2023-11-15 gspencergoog@users.noreply.github.com Update keycode output (flutter/engine#47988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 19:48:18 +00:00
Kate Lovett
1ac73332bc
Reland VelocityTracker update (#132291) (#137381)
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728
2023-11-15 19:31:48 +00:00
engine-flutter-autoroll
7f3f52f00c
Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (#138499)
f58dac64ad...7c2b8d520b

2023-11-15 jason-simmons@users.noreply.github.com In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 18:51:38 +00:00
Kate Lovett
cf18d250ad
Fix 2D tap to stop scrolling (#138442)
Adopted from https://github.com/flutter/flutter/pull/133750
That PR was abandoned. This finishes it up so we can land it.
Fixes https://github.com/flutter/flutter/issues/133529

Moves the `PanGestureRecognizer` used to drag the content along both axis to the outer vertical `Scrollable` subclass instead of the inner horizontal `Scrollable` subclass.

- This solves the issue of the inner `Scrollable` gestures being disabled while the outer `Scrollable` is scrolling
- Enables the user to stop the scroll movement by dragging the content again
2023-11-15 18:29:40 +00:00
engine-flutter-autoroll
4720750650
Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (#138494)
d22d063ac9...f58dac64ad

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 3b7a62e2ac3f to 1f23a0b74619 (1 revision) (flutter/engine#48074)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) (flutter/engine#48071)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 18:11:54 +00:00
Binni Goel
684980e97d
SemanticOwner should dispatch creation and disposal events (#138388) 2023-11-15 09:27:55 -08:00
engine-flutter-autoroll
0f42d19477
Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (#138489)
ecaf944203...d22d063ac9

2023-11-15 zanderso@users.noreply.github.com Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070)
2023-11-15 mdebbar@google.com [web] Move `EmbeddingStrategy` and `DimensionsProvider` out of `FlutterViewEmbedder` (flutter/engine#48025)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from d0e4a53f56f5 to 1abce6b0a763 (3 revisions) (flutter/engine#48067)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 17:14:07 +00:00
engine-flutter-autoroll
cffa654902
Roll Packages from 428ba3e24532 to 0cd23780741d (1 revision) (#138482)
428ba3e245...0cd2378074

2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter from f66215027e14 to e8c2bb135659 (66 revisions) (flutter/packages#5399)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 15:43:34 +00:00
Flutter GitHub Bot
defa2b7443
Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (#138472)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/138072 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20hot_mode_dev_cycle__benchmark%22).
This test can be marked as unflaky.
2023-11-15 11:32:08 +00:00
engine-flutter-autoroll
bf38935701
Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (#138468)
a7a48a68e6...ecaf944203

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 2f2c74633e0f to d0e4a53f56f5 (1 revision) (flutter/engine#48059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 09:13:13 +00:00
engine-flutter-autoroll
35132072d8
Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (#138463)
976edd5192...a7a48a68e6

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from a701a64f1ba9 to 2f2c74633e0f (1 revision) (flutter/engine#48058)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f1322227bdf to 65819963fb17 (2 revisions) (flutter/engine#48056)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 5778a54af88d to a701a64f1ba9 (1 revision) (flutter/engine#48055)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 07:38:18 +00:00
engine-flutter-autoroll
68633f7048
Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (#138462)
a7f2267dd1...976edd5192

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 0d9175bb5cfa to 5778a54af88d (1 revision) (flutter/engine#48052)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 06:01:26 +00:00
engine-flutter-autoroll
a930fd8e4a
Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (#138459)
bc5bbd3b9e...a7f2267dd1

2023-11-15 chris@bracken.jp [macOS] Clean up allocations in key responder tests (flutter/engine#48048)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 05:03:08 +00:00
engine-flutter-autoroll
cfdc6c58a5
Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (#138457)
d7ca057b89...bc5bbd3b9e

2023-11-15 ditman@gmail.com [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939)
2023-11-15 jonahwilliams@google.com [Impeller] Simplify convex tessellation (flutter/engine#47957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 03:35:33 +00:00
engine-flutter-autoroll
3f910e8988
Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (#138456)
1347413470...d7ca057b89

2023-11-15 jacksongardner@google.com Use flutter.js in the actual test harness. (flutter/engine#47670)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 02:52:24 +00:00
engine-flutter-autoroll
961f955af2
Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (#138452)
c5a067b637...1347413470

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 0f6a4e6a3b51 to 0d9175bb5cfa (1 revision) (flutter/engine#48045)
2023-11-15 godofredoc@google.com Migrate fuchsia to engine v2 builds. (flutter/engine#48042)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from bd8546dab41c to 0f6a4e6a3b51 (2 revisions) (flutter/engine#48043)
2023-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 6219f11bf0fb to 6f1322227bdf (6 revisions) (flutter/engine#48039)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 15a2577b12c1 to bd8546dab41c (1 revision) (flutter/engine#48037)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 01:35:56 +00:00
xubaolin
c3f4524061
Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (#136871)
Reland https://github.com/flutter/flutter/pull/136239 which was reverted by https://github.com/flutter/flutter/pull/136744
Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865

Do not merge before the customer finish the migration. @Piinks
2023-11-15 01:06:23 +00:00
Kate Lovett
98827bb569
Add to TableCell docs (#138258)
Fixes https://github.com/flutter/flutter/issues/42523
Came across a trivial doc issue - now it will be fixed. 😁
2023-11-14 23:20:33 +00:00
engine-flutter-autoroll
ec16ef78d0
Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (#138441)
f15b259fe9...c5a067b637

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 650913eacd01 to 15a2577b12c1 (1 revision) (flutter/engine#48036)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 6feae2c274ce to 650913eacd01 (1 revision) (flutter/engine#48034)
2023-11-14 chris@bracken.jp [macOS] Eliminate unused OCMock includes (flutter/engine#48031)
2023-11-14 41930132+hellohuanlin@users.noreply.github.com [ios17][text_input]fix ios 17.0 keyboard freeze when switching languages (without relying on text affinity) (flutter/engine#47566)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 22:49:15 +00:00
dependabot[bot]
391908929a
Bump dessant/lock-threads from 4.0.1 to 5.0.0 (#138437)
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 4.0.1 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/absolute-version/commit-and-tag-version">commit-and-tag-version</a> for commit guidelines.</p>
<h2><a href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a> (2023-11-14)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a href="0a0976f3de">0a0976f</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="5a25b54eae">5a25b54</a>)</li>
</ul>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="1618e91da6">1618e91</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a> (2022-12-04)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="38e9185581">38e9185</a>)</li>
<li>update docs (<a href="32986e2696">32986e2</a>)</li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a> (2021-09-27)</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d42e5f4980"><code>d42e5f4</code></a> chore(release): 5.0.0</li>
<li><a href="d8da6c1485"><code>d8da6c1</code></a> chore: update package</li>
<li><a href="c1eab4b45f"><code>c1eab4b</code></a> chore: update workflow</li>
<li><a href="0a0976f3de"><code>0a0976f</code></a> feat: lock discussions</li>
<li><a href="53f3f0c0b9"><code>53f3f0c</code></a> chore: migrate package to ESM</li>
<li><a href="5a25b54eae"><code>5a25b54</code></a> fix: update dependencies</li>
<li>See full diff in <a href="be8aa5be94...d42e5f4980">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=4.0.1&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-11-14 22:40:06 +00:00
dependabot[bot]
72080e6048
Bump github/codeql-action from 2.22.5 to 2.22.6 (#138438)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.5 to 2.22.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="689fdc5193"><code>689fdc5</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1990">#1990</a> from github/update-v2.22.6-8c8c7b4d8</li>
<li><a href="33bfd1de92"><code>33bfd1d</code></a> Update changelog for v2.22.6</li>
<li><a href="8c8c7b4d80"><code>8c8c7b4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1979">#1979</a> from github/aeisenberg/python-on-mac</li>
<li><a href="64981bbb5a"><code>64981bb</code></a> Merge branch 'main' into aeisenberg/python-on-mac</li>
<li><a href="e280207df7"><code>e280207</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1978">#1978</a> from github/update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="e46740a99e"><code>e46740a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="6abf8569a1"><code>6abf856</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1984">#1984</a> from github/aeisenberg/fix-debug-integration-tests</li>
<li><a href="59252d9bfb"><code>59252d9</code></a> Update setup-swift deficiency compensation</li>
<li><a href="dcf348a0d3"><code>dcf348a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="82284f1b28"><code>82284f1</code></a> Fix failing workflows</li>
<li>Additional commits viewable in <a href="74483a38d3...689fdc5193">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.5&new-version=2.22.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-11-14 22:25:00 +00:00
engine-flutter-autoroll
dfa694ec8f
Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (#138429)
eba757803a...f15b259fe9

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 63037925e344 to 6feae2c274ce (1 revision) (flutter/engine#48033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 21:10:17 +00:00
engine-flutter-autoroll
3df477d087
Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (#138425)
603bdd48df...eba757803a

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 5fbacd5d68a5 to 63037925e344 (1 revision) (flutter/engine#48028)
2023-11-14 john@johnmccutchan.com Revert "Add an AndroidManifest.xml flag to disable ImageReader backend Platform Views (#46430)" (flutter/engine#48024)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ce88be2adf67 to 5fbacd5d68a5 (1 revision) (flutter/engine#48026)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 20:27:26 +00:00
Elias Yishak
d5b67035b0
Unified analytics migration for CodeSizeAnalysis (#138351)
Part of tracker issue:
- https://github.com/flutter/flutter/issues/128251

This migrates the event being sent when the "--analyze-size" is used in a flutter invocation

The only file that had this event being sent from is `packages/flutter_tools/lib/src/base/analyze_size.dart`
2023-11-14 20:23:40 +00:00
engine-flutter-autoroll
449908670a
Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (#138421)
777dcb99f6...603bdd48df

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from a811132be321 to ce88be2adf67 (1 revision) (flutter/engine#48022)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 18:49:26 +00:00
Michael Goderbauer
0a0adf7c7f
Run all tests in examples/ (#138374)
https://github.com/flutter/flutter/pull/138253 demonstrated that the tests for the textures example weren't actually running on CI. This changes the testing script to execute the tests for everything inside the `examples` directory.
2023-11-14 18:22:03 +00:00
engine-flutter-autoroll
7f6842cde7
Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (#138420)
1b3fd80812...777dcb99f6

2023-11-14 mdebbar@google.com [web] Explicit initialization of the implicit view (flutter/engine#47921)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from b7d581997f2b to a811132be321 (1 revision) (flutter/engine#48019)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 18:01:08 +00:00
Taha Tesser
e8c2bb1356
Reland "Update framework_test.dart to remove ButtonBar usage and remove references from other clases (#137550) (#137753)
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to https://github.com/flutter/flutter/issues/127955

reland https://github.com/flutter/flutter/pull/137550
2023-11-14 17:55:05 +00:00
Jackson Gardner
07d73630fb
Consume flutter.js from the engine artifacts. (#137113)
Work in progress... currently testing against presubmit.
2023-11-14 17:00:29 +00:00
engine-flutter-autoroll
463c02daaf
Roll Flutter Engine from 995ebcefb0d4 to 1b3fd80812c3 (1 revision) (#138415)
995ebcefb0...1b3fd80812

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from f22c71596039 to b7d581997f2b (1 revision) (flutter/engine#48018)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 16:11:33 +00:00
engine-flutter-autoroll
ff72804498
Roll Packages from 17bd92e8a37d to 428ba3e24532 (2 revisions) (#138412)
17bd92e8a3...428ba3e245

2023-11-13 stuartmorgan@google.com [pigeon] Remove semicolons from Kotlin generation (flutter/packages#5375)
2023-11-13 stuartmorgan@google.com [tool] Add Kotlin autoformatting (flutter/packages#5374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 15:43:22 +00:00
engine-flutter-autoroll
b356bb387f
Roll Flutter Engine from 712094481217 to 995ebcefb0d4 (1 revision) (#138409)
7120944812...995ebcefb0

2023-11-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UaodAPcg8HCGdDb-C... to AuDKY8ob6GrGwDlmk... (flutter/engine#48016)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from UaodAPcg8HCG to AuDKY8ob6GrG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 13:21:42 +00:00
engine-flutter-autoroll
e4bf14e35b
Roll Flutter Engine from 2c54b5f70c94 to 712094481217 (1 revision) (#138401)
2c54b5f70c...7120944812

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ab1b506c68a2 to f22c71596039 (3 revisions) (flutter/engine#48009)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 09:50:21 +00:00
engine-flutter-autoroll
9131d5de20
Roll Flutter Engine from d100e8912eb0 to 2c54b5f70c94 (4 revisions) (#138399)
d100e8912e...2c54b5f70c

2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" (flutter/engine#48011)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 9a45d3d77b31 to ab1b506c68a2 (1 revision) (flutter/engine#48007)
2023-11-14 zanderso@users.noreply.github.com Move Skia to //flutter/third_party/skia (flutter/engine#47913)
2023-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) (flutter/engine#48006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 08:31:23 +00:00
engine-flutter-autoroll
6e9d4ccc25
Roll Flutter Engine from 74a9de45f128 to d100e8912eb0 (3 revisions) (#138383)
74a9de45f1...d100e8912e

2023-11-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 370145bbbd4f to 6219f11bf0fb (7 revisions) (flutter/engine#47998)
2023-11-14 matanlurey@users.noreply.github.com Make `display_list/...` compatible with `.clang_tidy`. (flutter/engine#47993)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from c5aef650e2b2 to 9a45d3d77b31 (1 revision) (flutter/engine#47997)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 02:46:14 +00:00
engine-flutter-autoroll
c34e637b66
Roll Flutter Engine from 77b952f3add4 to 74a9de45f128 (3 revisions) (#138382)
77b952f3ad...74a9de45f1

2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `fml/...` compatible with `.clang_tidy`." (flutter/engine#48004)
2023-11-13 matanlurey@users.noreply.github.com Make `fml/...` compatible with `.clang_tidy`. (flutter/engine#47992)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9ac5cad143ec to c5aef650e2b2 (3 revisions) (flutter/engine#47991)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 01:51:25 +00:00
Peter Abraham
2189d4fd3d
Fixing typo (#138253) 2023-11-13 16:36:23 -08:00
engine-flutter-autoroll
924889c91b
Roll Flutter Engine from 046ec85dffc6 to 77b952f3add4 (1 revision) (#138377)
046ec85dff...77b952f3ad

2023-11-13 mdebbar@google.com [web] Cleanup touch and mouse event adapters (flutter/engine#43697)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 00:08:30 +00:00
engine-flutter-autoroll
87c32cee5f
Roll Flutter Engine from db6da000a17e to 046ec85dffc6 (5 revisions) (#138375)
db6da000a1...046ec85dff

2023-11-13 godofredoc@google.com Fix fuchsia upload symbols. (flutter/engine#47938)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 1a39bd56cda2 to 9ac5cad143ec (3 revisions) (flutter/engine#47984)
2023-11-13 110993981+htoor3@users.noreply.github.com [web] - fix Safari textfield selection bug (flutter/engine#47917)
2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 17b6555a1551 to 1a39bd56cda2 (2 revisions) (flutter/engine#47980)
2023-11-13 jason-simmons@users.noreply.github.com Add a libcxxabi module that provides support for C++ thread-local storage (flutter/engine#47886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-13 23:25:52 +00:00
Michael Goderbauer
c4b706cd58
Finally remove analysis_options_user.yaml (#138261)
🫡

This was terribly outdated and has long been superseded by `package:flutter_lints`. Also, as of c033718da0 support for this was removed from the analyzer and this file is now even more useless, if that's even possible.

Fixes https://github.com/flutter/flutter/issues/82948.
2023-11-13 22:13:08 +00:00
Kenzie Davisson
398590fe44
Add a DevTools section to CONTRIBUTING.md (#137193)
Mirrored change in the .github/ repo: https://github.com/flutter/.github/pull/34
2023-11-13 21:51:07 +00:00
huycozy
61c007a3f7
Update DraggableScrollableSheet docs to reflect API change (#136471)
### Description

This PR intends to update `DraggableScrollableSheet` docs for Web and Desktop platforms. On these platforms, the vertical dragging gesture does not provide natural behavior similar to other desktop applications. 

By adding a note before the sample code so users are aware that the sample code will not work as expected on Desktop and Web. Also, refer to the instructions if they still want to implement it on these platforms.

### Related issue

Fixes https://github.com/flutter/flutter/issues/111372
2023-11-13 21:48:03 +00:00
Greg Spencer
1b9cab7138
Clean up synonyms, key code generation. (#138192)
## Description

This cleans up how synonyms are calculated, and adds a reverse mapping from pseudo keys to the real keys they are synonyms of.

Updates the `layout_goals.json` to include the "Space" key, since that was added in the engine without updating the generation configuration.
2023-11-13 20:13:00 +00:00
engine-flutter-autoroll
5980342ead
Roll Flutter Engine from 74ba6c17a488 to db6da000a17e (2 revisions) (#138364)
74ba6c17a4...db6da000a1

2023-11-13 jonahwilliams@google.com [Impeller] Add convex tess benchmark. (flutter/engine#47956)
2023-11-13 jonahwilliams@google.com [engine] request frame rate once per frame. (flutter/engine#47954)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-13 19:31:12 +00:00
engine-flutter-autoroll
a36821b573
Roll Flutter Engine from 5d62f1a2392a to 74ba6c17a488 (1 revision) (#138362)
5d62f1a239...74ba6c17a4

2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9c369abd687d to 17b6555a1551 (5 revisions) (flutter/engine#47975)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-13 18:52:06 +00:00
engine-flutter-autoroll
a681ff618c
Roll Flutter Engine from 7de793d2bb68 to 5d62f1a2392a (1 revision) (#138358)
7de793d2bb...5d62f1a239

2023-11-13 dacoharkes@google.com Revert "[deps] Stop moving NDK folder inside Android SDK (#47454)" (flutter/engine#47905)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-13 18:01:29 +00:00
Polina Cherkasova
793827d98a
Upgrade leak tracker. (#138283) 2023-11-13 09:47:55 -08:00