firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,387 Commits 1 Branch 0 Tags
Commit Graph

3387 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Hickson
7dad780f13 Merge pull request #946 from Hixie/pointerExceptions 
Catch exceptions in pointer handling
 2015-12-16 09:42:15 -08:00
Ian Hickson
7ea5879e88 Merge pull request #920 from Hixie/renderView-non-null 
Be clearer about whether renderView can be null.
 2015-12-16 09:42:04 -08:00
Ian Hickson
7151fdd054 Move flutter tests from packages/unit to packages/flutter/test 2015-12-16 08:00:57 -08:00
Ian Hickson
1d39db6959 Merge pull request #950 from Hixie/dropdown-asserts 
Aggressively try to catch misuse of DropDownButton
 2015-12-15 21:54:17 -08:00
Ian Hickson
b378d9670b Merge pull request #951 from Hixie/dropdown-cancel 
Canceling a dropdown menu selects null value
 2015-12-15 17:09:12 -08:00
Hixie
0c6e3416d8 Canceling a dropdown menu selects null value 
Previously we didn't distinguish between canceling the menu (which
popped the route with no return value, i.e. null) and explicitly
selecting an item whose value is null (pop with value null). Both fired
onChange(null).

Now we box the return value so we can distinguish the two cases.

I would have preferred to just disallow "null" as a value but it turns
out people like being able to use "null" as a value for much the same
reason we do, and it seems best for us to pay the complexity cost of
boxing than having everyone else do it. :-)
 2015-12-15 16:52:58 -08:00
Hans Muller
09ab80502f Merge pull request #947 from HansMuller/bottom_sheet_demo 
Added BottomSheet demos to the Material Gallery
 2015-12-15 16:35:54 -08:00
Hixie
a87351ad88 Aggressively try to catch misuse of DropDownButton 
Fixes https://github.com/flutter/flutter/issues/948.
I hope.
 2015-12-15 16:30:04 -08:00
Hans Muller
04162cffee Added bottom sheet demos to the Material gallery 2015-12-15 16:27:22 -08:00
Hans Muller
fce3a244d3 Merge pull request #943 from HansMuller/tab_scrolling_fix 
Tabs should only scroll on a horizontal TabBarView fling
 2015-12-15 15:45:37 -08:00
Hixie
4e23ecd668 Catch exceptions in pointer handling 
If we don't catch these exceptions, we get confused about what's going
on with the pointers, and the app basically stops working.
 2015-12-15 15:24:56 -08:00
Hans Muller
bcbfdf8f59 Tabs should only scroll on a horizontal TabBarView fling 2015-12-15 14:38:30 -08:00
Ian Hickson
ff2c8b4805 Merge pull request #942 from Hixie/wacky 
Workaround to re-enable test
 2015-12-15 14:07:10 -08:00
Hixie
6047c6da37 Be clearer about whether renderView can be null. 2015-12-15 13:49:04 -08:00
Hixie
768268ad3f Workaround to re-enable test 
This is a workaround for:
   https://github.com/dart-lang/sdk/issues/25246
 2015-12-15 13:38:45 -08:00
Seth Ladd
7dd28659b2 Merge pull request #937 from flutter/sethladd-patch-1 
Use a newer version of dartdoc
 2015-12-15 13:21:12 -08:00
Hans Muller
863b5b8b1b Merge pull request #924 from HansMuller/custom_layout 
Custom layouts use shouldRelayout() delegate methods instead of tokens

CustomMultiChildLayout and CustomOneChildLayout now use their delegate's shouldRelayout() method instead of a "token" to decide if layout is needed.

MultiChildLayoutDelegate and OnChildLayoutDelegate are now expected to be stateless, i.e. they'll typically be built each time their custom layout widget is built. If the identical layout delegate is provided to a new custom layout, layout will not happen.

Revised the bottom sheet implementation per the new custom layout classes. Removed a SizeObserver.

Fixes #899
 2015-12-15 12:45:13 -08:00
Hans Muller
0d983cd87a CustomMultiChildLayout and CustomOneChildLayout now use their delegate's shouldRelayout() method instead of a "token" to decide if layout is needed. 
MultiChildLayoutDelegate and OnChildLayoutDelegate are now expected to be stateless, i.e. they'll typically be built each time their custom layout widget is built. If the identical layout delegate is provided to a new custom layout, layout will not happen.

Revised the bottom sheet implementation per the new custom layout classes. Removed a SizeObserver.

Fixes #899
 2015-12-15 12:37:42 -08:00
Seth Ladd
070b227b12 call dartdoc with a more explicit path 2015-12-15 12:18:30 -08:00
Devon Carew
d9cab80c8a Merge pull request #939 from devoncarew/update_service_extensions 
remove todos for service extension params
 2015-12-15 11:57:47 -08:00
krisgiesing
b641d93be3 Merge pull request #940 from krisgiesing/doc_tweaks 
Export dependent class from newton package
 2015-12-15 11:17:01 -08:00
Kris Giesing
54cec3f13f Export dependent class from newton package 2015-12-15 11:09:33 -08:00
Devon Carew
4226b6008e remove todos for service extension params 2015-12-15 11:08:42 -08:00
Devon Carew
7d651af4f5 Merge pull request #911 from devoncarew/service_extensions 
expose flutter debug functionality using VM service extensions
 2015-12-15 10:53:50 -08:00
Devon Carew
ed3fa38277 Merge pull request #938 from flutter/devoncarew-patch-2 
Update test.sh
 2015-12-15 10:41:17 -08:00
Devon Carew
46bac6b78f Update test.sh 
Add the -q (quiet) flag to gsutil uploads.
 2015-12-15 10:10:24 -08:00
Seth Ladd
219e1318bb Use a newer version of dartdoc 2015-12-15 09:24:13 -08:00
Devon Carew
2ab40e63ba Merge pull request #931 from flutter/devoncarew-patch-1 
Update test.sh
 2015-12-14 21:37:21 -08:00
Devon Carew
1ef12a21d4 Update test.sh 
gen dartdoc using the flutter styles
 2015-12-14 21:31:13 -08:00
Adam Barth
6225bfa117 Merge pull request #930 from abarth/docs_flutter_io 
Switch docs to docs.flutter.io
 2015-12-14 20:02:42 -08:00
Adam Barth
f23035b0fe Switch docs to docs.flutter.io 
That site is now live.
 2015-12-14 19:55:08 -08:00
Eric Seidel
a2730e791e Merge pull request #929 from flutter/travis_indent 
See if fixing indent fixes our missing caching
 2015-12-14 19:46:18 -08:00
Eric Seidel
086cb5d2df See if fixing indent fixes our missing caching 
@abarth
 2015-12-14 19:40:37 -08:00
Devon Carew
cde14ab649 more checked mode guards; more types; fewer todos 2015-12-14 19:04:34 -08:00
Jason Simmons
afb35f1cc0 Merge pull request #926 from jason-simmons/engine_release_1214a 
rev engine
 2015-12-14 18:06:54 -08:00
Jason Simmons
fb281635bd rev engine 2015-12-14 17:52:14 -08:00
krisgiesing
ac2ad62cce Merge pull request #925 from krisgiesing/doc_tweaks 
Fix formatting issue
 2015-12-14 16:41:01 -08:00
Kris Giesing
a145490730 Fix formatting issue 2015-12-14 16:35:00 -08:00
Eric Seidel
e04de975ab Merge pull request #922 from eseidelGoogle/pub_is_slow 
Add nicer logging/reporting to dev/update_packages.dart
 2015-12-14 16:19:14 -08:00
Eric Seidel
d8e4fee9a0 Add nicer logging/reporting to dev/update_packages.dart 
Makes it more obvious where we are spending our time on Travis.

Also added travis caching for the global pub cache to
speed this up!  Modeled what dartdoc does:
https://github.com/dart-lang/dartdoc/blob/master/.travis.yml#L13

@Hixie
 2015-12-14 15:30:09 -08:00
Eric Seidel
e1fefc061c Merge pull request #921 from eseidelGoogle/stocks_test 
Rename stocks/tests to stocks/test
 2015-12-14 15:17:26 -08:00
Eric Seidel
520ceb5859 Rename stocks/tests to stocks/test 
This matches the naming pattern expected from package:test
`flutter test` doesn't care, since it finds all _test.dart
files and runs them regardless of directory.

@Hixie
 2015-12-14 14:56:22 -08:00
Ian Hickson
07ceefd612 Merge pull request #919 from Hixie/crash 
Fix build breakage
 2015-12-14 14:33:38 -08:00
Hixie
7a12d70df2 Fix build breakage 2015-12-14 14:31:56 -08:00
Eric Seidel
28c3b5581e Merge pull request #917 from eseidelGoogle/instrument 
Split out Instrumentation logic from WidgetTester
 2015-12-14 13:54:32 -08:00
Eric Seidel
3053c0ad72 Split out Instrumentation logic from WidgetTester 
This will allow writing tests/benchmark which want to use
the engine's default beginFrame and normal passage of time.

@Hixie
 2015-12-14 13:54:15 -08:00
Ian Hickson
0f9d8bc2c1 Merge pull request #916 from Hixie/analyze 
Always import our packages when analyzing.
 2015-12-14 13:45:19 -08:00
Hans Muller
81ab91a6e1 Merge pull request #914 from HansMuller/null_fling_simulation 
Only set tolerance if simulation is non-null

Fixes #898
 2015-12-14 13:10:26 -08:00
Hixie
0a6b0f9b0b Always import our packages when analyzing. 2015-12-14 12:56:31 -08:00
Devon Carew
211aeabb87 review comments 2015-12-14 12:51:39 -08:00