firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,387 Commits 1 Branch 0 Tags
Commit Graph

3387 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Hickson
d9d3114d14 Material baseline grid 
See https://www.google.com/design/spec/layout/metrics-keylines.html#
 2016-01-08 11:18:15 -08:00
Ian Hickson
99112425e2 Merge pull request #1143 from Hixie/GridPaper 
GridPaper updates
 2016-01-08 11:03:23 -08:00
Hans Muller
8899fe5ab3 Merge pull request #1142 from HansMuller/tabs_typo 
Fixed a tabs scrolling typo
 2016-01-08 10:36:49 -08:00
Hans Muller
d71afc3445 Fixed a typo 2016-01-08 10:29:10 -08:00
Ian Hickson
d502d2376c GridPaper updates 
Change how GridPaper works so that it's easier to plug in anywhere.
It now takes a child that it will paint the grid over.
It defaults to semi-transparent grid-paper-blue.
The line spacing is also more configurable now.
 2016-01-08 10:27:43 -08:00
Adam Barth
d8fd537ce3 Merge pull request #1136 from abarth/optimize_scaffold 
Optimize repainting in Scaffold
 2016-01-08 09:06:35 -08:00
Hans Muller
606887a12c Merge pull request #1127 from HansMuller/fix_tabs 
Fix tab fling scrolling when the last tab is selected
 2016-01-08 07:58:48 -08:00
Adam Barth
ee88a685f8 Optimize repainting in Scaffold 
Previously, we triggered a layout (and hence a repaint) when sliding the
draw because we gave the draw loose constraints. The drawer uses an
Align to move itself to the proper side of the screen, so it can have
tight constraints, which makes it a layout boundary.

Also, don't trigger a layout just because the Scaffold rebuilds. There
isn't any state in the scaffold custom layout, so it doesn't need to
repaint just because we created a new instance of the delegate.

Finally, add the debugging infrastructure I used to find these issues.
 2016-01-08 01:57:30 -08:00
Adam Barth
39ad22c8bd Merge pull request #1124 from sethladd/gen-docs-for-sprites 
generate docs for sprites
 2016-01-07 23:26:34 -08:00
Ian Hickson
60ef3836a5 Merge pull request #1133 from Hixie/TabBarSelectionState.of 
Reimplement TabBarSelectionState.of() using new methods
 2016-01-07 23:12:10 -08:00
Ian Hickson
892cc272a6 Reimplement TabBarSelectionState.of() using new methods 2016-01-07 22:09:36 -08:00
Hans Muller
5966f67627 fix #1126 2016-01-07 16:31:30 -08:00
Seth Ladd
ef4ea9b776 generate docs for sprites 2016-01-07 15:55:41 -08:00
Adam Barth
51d066473f Merge pull request #1122 from abarth/fix_tabs 
Tabs don't display items other than 0 and 1
 2016-01-07 14:22:22 -08:00
Adam Barth
5e2badad40 Tabs don't display items other than 0 and 1 
The TabBarView wants to remap page indices during tab transitions, which
I broke when I refactored TabBarView.

Fixes #1119
 2016-01-07 13:04:31 -08:00
Adam Barth
1cee346ac9 Merge pull request #1118 from abarth/limit_image_cache 
Limit the size of the image cache
 2016-01-07 12:44:27 -08:00
Adam Barth
52a7479dd1 Limit the size of the image cache 
Fixed #1009
 2016-01-07 12:07:17 -08:00
Adam Barth
4e9762784a Merge pull request #1116 from abarth/upgrade_with_no_upstream 
Handle trying to upgrade Flutter with no upstream
 2016-01-07 11:25:55 -08:00
Adam Barth
dfcc0c71ba Merge pull request #1110 from abarth/widgets_back 
Move default back behavior to FlutterWidgetBinding
 2016-01-07 10:59:03 -08:00
Adam Barth
2303188614 Handle trying to upgrade Flutter with no upstream 
Fixes #1084
 2016-01-07 10:57:48 -08:00
Adam Barth
c44f0a57e8 Merge pull request #1114 from abarth/rm_block_direction 
Remove BlockDirection in favor of ScrollDirection
 2016-01-07 10:47:11 -08:00
Ian Hickson
95092bb41f Merge pull request #1109 from Hixie/scrollable-of 
Fix Scrollable.of()
 2016-01-07 10:45:56 -08:00
Adam Barth
e3668470c7 Merge pull request #1113 from abarth/handle_port_error 
`flutter start` crashes when port 8181 is in use
 2016-01-07 10:12:31 -08:00
Adam Barth
76dd6228b4 Remove BlockDirection in favor of ScrollDirection 
We'll probably renaming ScrollDirection to Axis in a future patch.

Fixes #151
 2016-01-07 10:11:39 -08:00
Adam Barth
3615827f0e flutter start crashes when port 8181 is in use 
Catch the error and log a warning.

Fixes #1050
 2016-01-07 09:56:44 -08:00
Hans Muller
06b566bdea Merge pull request #1106 from HansMuller/tab_view_demo 
TabBarView material gallery demo
 2016-01-07 09:27:23 -08:00
Adam Barth
e3d587ea52 Move default back behavior to FlutterWidgetBinding 
Previously MaterialApp was responsible for ending the activity when the
back stack was empty. However, this behavior is more general than
material. This patch moves the behavior to FlutterWidgetBinding, which
has a global view of all the binding observers.

Fixes #1086
 2016-01-07 09:24:51 -08:00
Hans Muller
1b11336ee6 Page Selector gallery demo 2016-01-07 08:27:13 -08:00
Ian Hickson
ea3864b1e4 Fix Scrollable.of() 
Make ancestorStateOfType() and ancestorRenderObjectOfType() support
subclassing.

Fixes https://github.com/flutter/flutter/issues/1087
 2016-01-06 23:12:37 -08:00
Ian Hickson
19fb068d83 Merge pull request #1108 from Hixie/canFlex-error 
Rationalise all our exception catching and reporting code
 2016-01-06 22:03:38 -08:00
Ian Hickson
13d6cc3273 Rationalise all our exception catching and reporting code 
- make them all have the same style
- make them all include the stack trace last
- make them all stop printing if their callback is set (if
  appropriate, they don't yet all have callbacks)
 2016-01-06 21:49:23 -08:00
Ian Hickson
07ed3fbf38 Merge pull request #1107 from Hixie/debugDoesLayoutWithCallback 
Remove unreferenced getter "debugDoesLayoutWithCallback".
 2016-01-06 19:42:51 -08:00
Ian Hickson
94833b24bf Remove unreferenced getter "debugDoesLayoutWithCallback". 
I think I wanted to use this at some point but ended up going a
different direction. Instead, object.dart has a private field that
serves a similar purpose.
 2016-01-06 19:14:45 -08:00
Adam Barth
f17f1ba1e5 Merge pull request #1102 from abarth/animated_container 
AnimatedContainer has an issue with one config value change and not another
 2016-01-06 18:04:19 -08:00
Eric Seidel
d8edf1c27b Merge pull request #1104 from flutter/revert-1103-listen_exit 
Revert "Make `flutter listen` exit nicely when missing dependencies"
 2016-01-06 17:17:28 -08:00
Eric Seidel
330c08199e Revert "Make flutter listen exit nicely when missing dependencies" 2016-01-06 17:17:16 -08:00
Eric Seidel
43cd6a0946 Merge pull request #1103 from eseidelGoogle/listen_exit 
Make `flutter listen` exit nicely when missing dependencies
 2016-01-06 17:09:56 -08:00
Adam Barth
79c797a115 AnimatedContainer has an issue with one config value change and not another 
If we're already at the target value, we fail to configure the variable. If
another variable animates, we re-animate the other variable.

Fixes #958
 2016-01-06 17:09:39 -08:00
Eric Seidel
3a2aa89064 Make flutter listen exit nicely when missing dependencies 
Previously it died with a confusing exception.

@chinmaygarde
 2016-01-06 17:07:36 -08:00
Adam Barth
8694fada8f Merge pull request #1101 from abarth/lockdown_virtual_viewport 
Enable more asserts when building with virtual viewports
 2016-01-06 16:13:46 -08:00
Adam Barth
0033a8fcdf Enable more asserts when building with virtual viewports 2016-01-06 16:03:26 -08:00
Adam Barth
d46f0cebb5 Merge pull request #1098 from abarth/pageable_list2 
Switch PageableList over to using RenderList
 2016-01-06 16:02:34 -08:00
Adam Barth
e64d93a520 Switch PageableList over to using RenderList 
This patch moves PageableList off HomogeneousViewport and onto RenderList and
friends, making it match the new ScrollableList.
 2016-01-06 15:28:01 -08:00
Chinmay Garde
e1b16729bf Merge pull request #1093 from chinmaygarde/master 
Download the Xcode artifacts for the current engine revision
 2016-01-06 13:40:35 -08:00
Devon Carew
854f9f717d Merge pull request #1090 from devoncarew/log_stderr 
have flutter logs log stderr
 2016-01-06 13:39:11 -08:00
Chinmay Garde
f5f9440a2d Download the Xcode artifacts for the current engine revision 2016-01-06 13:38:43 -08:00
Eric Seidel
d7d4a46d36 Merge pull request #1091 from eseidelGoogle/device_time 
Teach `flutter trace stop` to use time on the device.
 2016-01-06 13:38:39 -08:00
Eric Seidel
0d783718ba Teach flutter trace stop to use time on the device. 
This is yet another hack on top of adb log handling.
This is fragile, but w/o this if you device time is out
of sync, you can't trace.

@abarth
 2016-01-06 13:29:32 -08:00
Devon Carew
ed215fb842 have flutter logs log stderr 2016-01-06 13:29:24 -08:00
Adam Barth
a271eb5612 Merge pull request #1081 from abarth/ship_scrollable_list2 
Replace ScrollableList with ScrollableList2
 2016-01-06 11:26:16 -08:00