12204 Commits

Author SHA1 Message Date
Dan Field
79c4c38cc9 Make analyze once test not depend on test order or flutter create command (#48003) 2020-01-06 16:33:01 -08:00
Mouad Debbar
f6a88d0309
Registering multiple transformed events should work (#48149) 2020-01-06 14:24:52 -08:00
Jonah Williams
2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250)
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
2020-01-06 13:57:13 -08:00
Dan Field
ea799d97f4
.. (#48263) 2020-01-06 13:30:21 -08:00
Ben Konyi
a0e5621956
Added showCheckboxColumn parameter to DataTable and PaginatedDataTable (#47552)
`showCheckboxColumn` will determine whether or not selectable rows in
DateTable or PaginatedDataTable will contain a leading CheckBox.
2020-01-06 16:29:36 -05:00
Jacob MacDonald
c3f590a872
update dependencies for flutter_tool (#48260) 2020-01-06 13:08:06 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Dan Field
19c7550540 fix mockStopWatch creation (#48098) 2020-01-06 11:03:01 -08:00
神楽坂花火
80ee2ff04f Add Border.symmetric constructor (#47523) 2020-01-06 09:48:02 -08:00
Phil Quitslund
7fee0c52d3 mark widget == and hashCode as nonVirtual (#46900) 2020-01-06 09:43:02 -08:00
Alexandre Ardhuin
1fc43d9330
add key to constructors of public widgets (#47884)
* add key to constructors of public widgets

* fix a test

* fix a test
2020-01-06 17:41:54 +01:00
Jenn Magder
0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Shi-Hao Hong
fa1ebab88e
Added API docs on opening a Scaffold's drawer programmatically (#48152)
* Added docs on how to set drawer to open only programmatically
2020-01-03 15:20:48 -08:00
LongCatIsLooong
adc6482784
Implement CupertinoDatepicker time/dateTime constraints (#44628) 2020-01-03 14:50:41 -08:00
LongCatIsLooong
7511d8c06a
fix MediaQuery override in CupertinoDatePicker (#48001) 2020-01-03 11:05:50 -08:00
Devon Carew
c924f499f5
ignore a (potentially) unused import in generated code (#47593) 2020-01-03 11:04:03 -08:00
creativecreatorormaybenot
b383bdfd1f Initial (#47831) 2020-01-03 10:53:32 -08:00
Shi-Hao Hong
62e436f049
Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding (#47709)
* Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding
2020-01-03 08:18:21 -08:00
Dan Field
7b69d137c8 reset state between runs of devFS tests (#48101) 2020-01-03 08:18:02 -08:00
Dan Field
d7c347f027 make pub get test shufflable (#48095) 2020-01-03 08:13:03 -08:00
Dan Field
5ff7225450 fix io_test (#48097) 2020-01-02 19:53:02 -08:00
Angjie Li
9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
chunhtai
57a93419b4
EditableText should not update textinput style when the textinput is … (#47904) 2020-01-02 16:19:52 -08:00
Jenn Magder
dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Jenn Magder
a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce67c62def5852a5c2615e38188195ca.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc6cf8bf4e1814ef950a6092bbb6f658.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Kate Lovett
4fbef2a4a9
Revert "Testing tryjob triage (#47893)" (#47985)
This reverts commit 659dc8129d4edb9166e9a0d600439d135740933f.
2019-12-30 13:09:14 -08:00
Kate Lovett
659dc8129d
Testing tryjob triage (#47893) 2019-12-30 09:24:47 -08:00
Devon Carew
43a8c24344
fix an analysis ignore for the missing_required_param hint (#47956) 2019-12-29 12:28:57 -08:00
神楽坂花火
b28dd0c296 Reland "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47855) 2019-12-27 18:33:01 -08:00
Francisco Magdaleno
bc0d35c34e
Reland "fix duration event of timeline summary (#47742)" (#47889)
This reverts commit 50d421224d6b4e48589525be5d9eb036fa20a5c8.
2019-12-27 11:15:48 -08:00
Francisco Magdaleno
50d421224d
Revert "fix duration event of timeline summary (#47742)" (#47888)
This reverts commit e43fd1c54d7b855b7e2065c4a2e135f75421af23.
2019-12-27 10:26:49 -08:00
Gityuan
e43fd1c54d fix duration event of timeline summary (#47742)
* fix duration event of timeline summary

* Revert "fix duration event of timeline summary"

This reverts commit 699aa45ed3d115f8bbea95cf6d37116b442db399.

* fix duration event of timeline summary
2019-12-27 09:36:59 -08:00
LongCatIsLooong
ae24f18414
Reland 39919 CupertinoPicker (#47837) 2019-12-26 17:26:55 -08:00
Jonathan White
1fe05983e6 Fix typos in DefaultTabController.of documentation (#46907)
Fix error in `DefaultTabController.of` documentation

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
2019-12-26 09:45:25 -08:00
LongCatIsLooong
b7af5e714d
Revert "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47805) 2019-12-25 23:49:55 -08:00
神楽坂花火
2cbf126fe8 Add brightness to CupertinoNavigationBar (fixes #46216) (#47521) 2019-12-25 21:54:12 -08:00
Shi-Hao Hong
6e72facad1
Fix Icon.color docs (#47691) 2019-12-24 10:54:04 -08:00
Chen Yumin
0265cb6849 Make tab's icon margin configurable (Fix #47363) (#47364)
Adds the `iconMargin` parameter to Tab
2019-12-23 15:37:16 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4d97793829aafbb768e73c6e4805302.
2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Alexandre Ardhuin
4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jim Graham
fcaf9c4070 Support for ImageFiltered widget to apply ImageFilter to children. (#47489) 2019-12-21 14:03:01 -08:00
Lau Ching Jun
ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
Jenn Magder
85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568)
This reverts commit 648a5d8a1ebbe95a6f0fa1c41ed34195c11c4d64.
2019-12-20 17:45:16 -08:00
Greg Spencer
19b9206add
Add variant testing to testWidgets (#45646)
This adds the ability to define variants of tests with different environmental values for a particular testWidgets test.

This allows you to run the same test multiple times with a different test environment. One test variant has been implemented that allows running a test with different settings of the TargetPlatform.
2019-12-20 15:00:16 -08:00
gaaclarke
72a3d914ee
Added a code sample for replacing the image cache. (#47467) 2019-12-20 08:50:42 -08:00
Dan Field
93f718b386 Fix requestExistingInputState response (#47472) 2019-12-20 03:33:01 -08:00