firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,998 Commits 1 Branch 0 Tags
Commit Graph

37998 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brandon DeRosier
ea026548ce [Flutter GPU] Add golden test for rendering a triangle. (flutter/engine#55262) 
Resolves https://github.com/flutter/flutter/issues/144640.

New golden:
![flutter_gpu_test_triangle](https://github.com/user-attachments/assets/0b39380e-1aa5-4369-ae5b-a8764d5701cb)
 2024-09-17 20:00:33 +00:00
skia-flutter-autoroll
e2d27fca19 Roll Dart SDK from de4a3d63671c to 84fac36df65a (2 revisions) (flutter/engine#55255) 
https://dart.googlesource.com/sdk.git/+log/de4a3d63671c..84fac36df65a

2024-09-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-257.0.dev
2024-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-256.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 17:57:04 +00:00
skia-flutter-autoroll
4405e163f8 Roll Skia from ad08229fd016 to de3717fe550e (5 revisions) (flutter/engine#55261) 
https://skia.googlesource.com/skia.git/+log/ad08229fd016..de3717fe550e

2024-09-17 sharaks@google.com Merge 8 release notes into RELEASE_NOTES.md
2024-09-17 sharaks@google.com Update Skia milestone to 131
2024-09-17 jsimmons@google.com Handle premultiplied alpha in PNG encoding of images using kBGRA_10101010_XR_SkColorType
2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f6d9b179eb83 to 1b4d6185c4de (14 revisions)
2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 114623e12d3f to eb05ef4cb7a7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 17:34:12 +00:00
Reid Baker
0f03db48fe FlutterViewTest add back part 4 and 5 (flutter/engine#55243) 
- **Add light and dark test back to FlutterView.java**
- **Migrate some but not all usages of Robolectric.setupActivity in FlutterViewTest.java**
- **Remove suppress warnings on tests that no longer need it, update documentation for ones that still need the suppression**
Fixes https://github.com/flutter/flutter/issues/154746 
Partial work on https://github.com/flutter/flutter/issues/133151
 2024-09-17 15:58:59 +00:00
skia-flutter-autoroll
8e6b04a24d Roll Skia from be871a37a154 to ad08229fd016 (1 revision) (flutter/engine#55252) 
https://skia.googlesource.com/skia.git/+log/be871a37a154..ad08229fd016

2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2e8afd5a4962 to ef559d79bda9 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 07:40:24 +00:00
skia-flutter-autoroll
740a3d2179 Roll Skia from 0409718f34c6 to be871a37a154 (1 revision) (flutter/engine#55250) 
https://skia.googlesource.com/skia.git/+log/0409718f34c6..be871a37a154

2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 656a4790c599 to df2251eb6f2a (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 06:18:24 +00:00
skia-flutter-autoroll
ce2f00fc26 Roll Skia from d78293574d12 to 0409718f34c6 (1 revision) (flutter/engine#55248) 
https://skia.googlesource.com/skia.git/+log/d78293574d12..0409718f34c6

2024-09-17 michaelludwig@google.com [graphite] Bind dstCopy texture in VulkanCommandBuffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 03:34:32 +00:00
skia-flutter-autoroll
1bb416acc3 Roll Skia from 68eeaa5e20dc to d78293574d12 (2 revisions) (flutter/engine#55245) 
https://skia.googlesource.com/skia.git/+log/68eeaa5e20dc..d78293574d12

2024-09-16 kjlubick@google.com Add additional link for ios development
2024-09-16 nscobie@google.com Ensure CtsSkQPTestCases in Android Framework uses external Vk headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 23:21:06 +00:00
Robert Ancell
3443af6a5c Delay the window until the first frame is received from the Flutter engine (flutter/engine#54703) 
Fixes https://github.com/flutter/flutter/issues/151098
 2024-09-17 10:48:43 +12:00
Chinmay Garde
f64f4e4188 [Embedder] Warn when embedders try to enable an unsupported renderer. (flutter/engine#55240) 
Today, only a generic "internal inconsistency" error returned. But custom builds that selectively disable rendering backends may find this error to be too vague.
 2024-09-16 22:29:24 +00:00
Reid Baker
1030f3b153 flutter view add test 2 (flutter/engine#55188) 
- **add test back with no other changes**
- **Add legacy test and setup shadow**
2 and 3 of 5 flutter/flutter/issues/154746

Improved legacy testing by validating a fullscreen and non fullscreen codepaths. 

Added `.git-blame-ignore-revs` because git was failing to give blame values with that file missing. I dont think I added a global config anywhere but adding an empty file should not cause a problem.
 2024-09-16 20:40:19 +00:00
skia-flutter-autoroll
e91b8b8d60 Roll Skia from 87ba10cbfad3 to 68eeaa5e20dc (1 revision) (flutter/engine#55239) 
https://skia.googlesource.com/skia.git/+log/87ba10cbfad3..68eeaa5e20dc

2024-09-16 danieldilan@google.com Make SkImageGeneratorWIC apply encoded origin.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 20:36:11 +00:00
skia-flutter-autoroll
3a89f4d486 Roll Skia from ee5e413fe436 to 87ba10cbfad3 (5 revisions) (flutter/engine#55233) 
https://skia.googlesource.com/skia.git/+log/ee5e413fe436..87ba10cbfad3

2024-09-16 arthursonzogni@chromium.org Reland "MiraclePtr: Fetch partition_alloc."
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 4a9e92f23d7f to 0417970a971e
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4a69b8e2bcdd to 114623e12d3f (2 revisions)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 20f5d28635bd to 2814735474b8
2024-09-16 ashwinpv@google.com Create Bazel Toolchain for running iOS builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 18:55:08 +00:00
skia-flutter-autoroll
0d4ad367bd Roll Skia from 3ebf0a14bbdd to ee5e413fe436 (1 revision) (flutter/engine#55229) 
https://skia.googlesource.com/skia.git/+log/3ebf0a14bbdd..ee5e413fe436

2024-09-16 drott@chromium.org [Fontations] Round advances when hinting is requested

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 17:01:05 +00:00
gaaclarke
1b7cc18cfc Added .vscode back to being ignored (flutter/engine#55195) 
https://github.com/flutter/engine/pull/53974 stopped ignoring the
.vscode directory, this created a situation where people's vscode
settings are prone to getting checked in or nuked. I added a specific
exception for the one file we did check in.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-09-16 09:35:56 -07:00
skia-flutter-autoroll
e0fd93ba23 Roll Skia from 80583104076d to 3ebf0a14bbdd (1 revision) (flutter/engine#55228) 
https://skia.googlesource.com/skia.git/+log/80583104076d..3ebf0a14bbdd

2024-09-16 drott@chromium.org [Fontations] Add suffix to comparison tests with none hint mode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 15:32:37 +00:00
skia-flutter-autoroll
5008a4130e Roll Skia from efd841820b09 to 80583104076d (1 revision) (flutter/engine#55223) 
https://skia.googlesource.com/skia.git/+log/efd841820b09..80583104076d

2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e90de4b2873f to f6d9b179eb83 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 08:36:26 +00:00
skia-flutter-autoroll
0a1dab16ef Roll Skia from 2d4c662c2cab to efd841820b09 (3 revisions) (flutter/engine#55221) 
https://skia.googlesource.com/skia.git/+log/2d4c662c2cab..efd841820b09

2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3239872f9c5f to 2afc8c97882a (1 revision)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac44b70a9831 to 656a4790c599 (6 revisions)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7c4fe83768b1 to 2e8afd5a4962 (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 06:22:22 +00:00
skia-flutter-autoroll
938003faad Roll Skia from 2238d45e670e to 2d4c662c2cab (1 revision) (flutter/engine#55219) 
https://skia.googlesource.com/skia.git/+log/2238d45e670e..2d4c662c2cab

2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 09504140f88a to 4a69b8e2bcdd (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 04:54:37 +00:00
Robert Ancell
e3f49a5875 Match Windows logic for picking RGB/BGR textures. (flutter/engine#55121) 
The existing code had a lot of additional checks that didn't seem to
need to be there.

BGR could be passed back to Flutter, but this was never used in creating
the texture.

There has been a report of a Flutter app on Linux with swapped red and
blue color channels, so this seems like it is likely not working on some
drivers.

The original logic was introduced in
87509d8518cea0e90912cc30b08192b1dd4da760
 2024-09-16 12:17:57 +12:00
skia-flutter-autoroll
5d553bb416 Roll Skia from 175815a3feac to 2238d45e670e (1 revision) (flutter/engine#55213) 
https://skia.googlesource.com/skia.git/+log/175815a3feac..2238d45e670e

2024-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3fb3d06f7a14 to 09504140f88a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-15 16:08:32 +00:00
skia-flutter-autoroll
75016098c5 Roll Skia from 0ec9b089fa9e to 175815a3feac (1 revision) (flutter/engine#55205) 
https://skia.googlesource.com/skia.git/+log/0ec9b089fa9e..175815a3feac

2024-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e08047d8cf54 to 3fb3d06f7a14 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-15 01:38:49 +00:00
skia-flutter-autoroll
b6f5d6e073 Roll Skia from 2b8e33aa4824 to 0ec9b089fa9e (1 revision) (flutter/engine#55201) 
https://skia.googlesource.com/skia.git/+log/2b8e33aa4824..0ec9b089fa9e

2024-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b747b6f853ad to e08047d8cf54 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-14 12:31:23 +00:00
skia-flutter-autoroll
0c1cae9b0c Roll Dart SDK from c0f7e399ff4a to de4a3d63671c (1 revision) (flutter/engine#55199) 
https://dart.googlesource.com/sdk.git/+log/c0f7e399ff4a..de4a3d63671c

2024-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-255.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-14 05:49:23 +00:00
Brandon DeRosier
07fce2f8f4 [Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. (flutter/engine#55197) 2024-09-13 22:34:55 -07:00
Jenn Magder
8706638baf Add xcprivacy privacy manifest to macOS framework (flutter/engine#55078) 
Create a `PrivacyInfo.xcprivacy` (this name is required) plist and move it to the top-level of the macOS framework bundle.  `NSPrivacyTracking*` and `NSPrivacyCollectedDataTypes` keys are required, but the values are blank.  macOS explicitly does not need the `NSPrivacyAccessedAPITypes` (see more info in https://github.com/flutter/flutter/issues/143381)

You can see on this PR it's copied to the correct path in the framework https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737163270670636097/+/u/Global_generators/Release-FlutterMacOS.framework/stdout:

```
  adding: FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/PrivacyInfo.xcprivacy (deflated 35%)
```

There's no way to test this except to submit a macOS app with this framework to TestFlight.

I can't find a good spot in the engine to validate the structure of the framework output.  I hereby pledge to add a macOS test to the framework post-roll https://github.com/flutter/flutter/pull/155189 ✋ 

iOS framework variant of this PR https://github.com/flutter/engine/pull/48951
Fixes https://github.com/flutter/flutter/issues/131494

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-14 02:44:18 +00:00
Gray Mackall
fde6227383 Synthesize remove events on PointerChange.ACTION_UP and PointerChange.ACTION_POINTER_UP (flutter/engine#55157) 
... when the input device type is touch.

Fixes (partially) https://github.com/flutter/flutter/issues/154842 for touch events. Does not fix when using a stylus, that case will require a follow up PR.

Without fix:

https://github.com/user-attachments/assets/10a8ac73-7b27-498b-a76e-0f2cfc3050d7

With fix:

https://github.com/user-attachments/assets/18656f3a-d45a-4b08-9227-cc0abe8c73f7

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-14 01:02:23 +00:00
skia-flutter-autoroll
0193501b61 Roll Skia from bdc5e73cb6c9 to 2b8e33aa4824 (1 revision) (flutter/engine#55192) 
https://skia.googlesource.com/skia.git/+log/bdc5e73cb6c9..2b8e33aa4824

2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 788001a1cbae to b747b6f853ad (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 23:16:23 +00:00
skia-flutter-autoroll
97078dd53a Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (flutter/engine#55191) 
https://dart.googlesource.com/sdk.git/+log/302b6472b849..c0f7e399ff4a

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 22:23:26 +00:00
auto-submit[bot]
86d1435a0d Reverts "[skwasm] Scene builder optimizations for platform view placement (#54949)" (flutter/engine#55193) 
Reverts: flutter/engine#54949
Initiated by: eyebrowsoffire
Reason for reverting: Incorrect golden diffs on engine roll, see https://github.com/flutter/flutter/pull/155181
Original PR Author: eyebrowsoffire

Reviewed By: {harryterkelsen}

This change reverts the following previous change:
This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: https://github.com/flutter/flutter/issues/149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
 2024-09-13 22:21:47 +00:00
Jim Graham
7da9ad1862 Delete VolatilePathTracker in favor of Dispatch tracking (flutter/engine#55125) 
ui.Canvas and ui.SceneBuilder now use the DlPath object directly from the ui.Path object. This results in increased sharing of the wrapper objects which then increases the sharing of both the converted Impeller paths and Skia's volatile flag.

The VolatilePathTracker mechanism is deleted and rather than count the number of frames that a path is stable for, instead we count the number of times it is used for rendering. If a path is used 100 times in a single frame, it will become non-volatile and start being cached almost immediately. The cached Impeller paths are now also tracked for all instances of the same path, rather than for each call site that originated from a DisplayList dispatch.
 2024-09-13 21:49:09 +00:00
skia-flutter-autoroll
d066010b18 Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK... (flutter/engine#55190) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 21:47:02 +00:00
skia-flutter-autoroll
efa6ccfc58 Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (flutter/engine#55189) 
https://skia.googlesource.com/skia.git/+log/9877f459399a..bdc5e73cb6c9

2024-09-13 jvanverth@google.com Revert "Reland "[graphite] Add purge() method to DrawAtlas.""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 21:43:12 +00:00
Jonah Williams
9235fbb695 [impeller] add Android flag for disabling surface control for debugging. (flutter/engine#55185) 
I've found a few instances where Vulkan worked correctly but surface control did not. lets add a debugging flag we can ask folks to try to narrow down the issue.
 2024-09-13 21:39:20 +00:00
skia-flutter-autoroll
ebd65bf755 Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (flutter/engine#55187) 
https://skia.googlesource.com/skia.git/+log/a5a6d12b3642..9877f459399a

2024-09-13 bungeman@google.com Rename our_vulkan_headers use_skia_vulkan_headers
2024-09-13 fmalita@google.com [bazel] Initial dm support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 20:23:23 +00:00
skia-flutter-autoroll
4786f5058f Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (flutter/engine#55182) 
https://dart.googlesource.com/sdk.git/+log/eb664303c5ff..302b6472b849

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-253.0.dev
2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-252.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 18:05:55 +00:00
Jackson Gardner
0cc27b4e22 [skwasm] Scene builder optimizations for platform view placement (flutter/engine#54949) 
This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: https://github.com/flutter/flutter/issues/149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
 2024-09-13 17:55:07 +00:00
Reid Baker
415f89e20a add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics (flutter/engine#55110) 
Part 1/5 for re adding tests documented in flutter/flutter/issues/154746

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-09-13 13:45:37 -04:00
skia-flutter-autoroll
bb9035e847 Roll Skia from 7cba76a07795 to a5a6d12b3642 (3 revisions) (flutter/engine#55179) 
https://skia.googlesource.com/skia.git/+log/7cba76a07795..a5a6d12b3642

2024-09-13 drott@chromium.org [Fontations] Activate usage of autohinting
2024-09-13 brianosman@google.com Remove brianosman references from OWNERS and TODO
2024-09-13 michaelludwig@google.com [graphite] Append DawnCommandBuffer's dstCopy intrinsic to BindGroup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 17:13:55 +00:00
Reid Baker
f6b728f86f Add copyright notices to java test files (flutter/engine#55155) 
Fixes flutter/flutter/issues/155118
 2024-09-13 15:31:52 +00:00
skia-flutter-autoroll
5b9ab3f03e Roll Skia from abb4eeac59c2 to 7cba76a07795 (1 revision) (flutter/engine#55174) 
https://skia.googlesource.com/skia.git/+log/abb4eeac59c2..7cba76a07795

2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bc0954c735ac to 788001a1cbae (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 10:18:40 +00:00
skia-flutter-autoroll
3734302bfe Roll Dart SDK from 6c1e919a85f2 to eb664303c5ff (2 revisions) (flutter/engine#55173) 
https://dart.googlesource.com/sdk.git/+log/6c1e919a85f2..eb664303c5ff

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-251.0.dev
2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-250.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 10:04:33 +00:00
skia-flutter-autoroll
34e82924a1 Roll Skia from c8a493c589d6 to abb4eeac59c2 (2 revisions) (flutter/engine#55172) 
https://skia.googlesource.com/skia.git/+log/c8a493c589d6..abb4eeac59c2

2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f0919be383d0 to e90de4b2873f (6 revisions)
2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from be2b58e20037 to ac44b70a9831 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 08:59:37 +00:00
skia-flutter-autoroll
a249f4eb12 Roll Skia from 515a23f3cbe1 to c8a493c589d6 (1 revision) (flutter/engine#55169) 
https://skia.googlesource.com/skia.git/+log/515a23f3cbe1..c8a493c589d6

2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2f71cb364e4e to 7c4fe83768b1 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 06:04:32 +00:00
skia-flutter-autoroll
a50401125b Roll Dart SDK from 23fc7751b8b2 to 6c1e919a85f2 (1 revision) (flutter/engine#55167) 
https://dart.googlesource.com/sdk.git/+log/23fc7751b8b2..6c1e919a85f2

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-249.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 03:05:25 +00:00
Matan Lurey
c53db189c1 Remove now unused extra args/opts/env from run_tests.py. (flutter/engine#55164) 
As a result of https://github.com/flutter/flutter/issues/133569, Dart tests all use the standard `dart test` runner _or_ `engine_repo_tools` to find paths.
 2024-09-13 01:22:18 +00:00
Matan Lurey
02d5118165 Remove assert(() {... }) and other unnecessary patterns in dart:ui tests (flutter/engine#55165) 
Closes https://github.com/flutter/flutter/issues/155054, where we
decided this was correct to do.

As a bonus I improved an `assert` message :)
 2024-09-12 17:40:52 -07:00
Robert Ancell
420b1b5d44 Filter out bad locales returned by g_get_language_names (flutter/engine#55091) 
We're seeing issues with and "und" (undefined) locale and exceptions in
applications (see https://github.com/ubuntu/app-center/issues/1659). It
seems the GLib method for getting the language names doesn't clean up
invalid values, so we should do that.
 2024-09-13 11:40:52 +12:00
Matan Lurey
425e6c707d Remove all references to litetest from the engine repo. (flutter/engine#55163) 
Closes https://github.com/flutter/flutter/issues/133569.
 2024-09-12 16:26:25 -07:00
skia-flutter-autoroll
cf2deecf07 Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160) 
https://dart.googlesource.com/sdk.git/+log/aa27c61f5859..23fc7751b8b2

2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-248.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 22:39:55 +00:00