Jonah Williams
3d1eb66164
[Impeller] reland experimental canvas. ( flutter/engine#55047 )
...
Corruption should be fixed by https://github.com/flutter/engine/pull/55036
2024-09-10 20:50:06 +00:00
Jenn Magder
5c93837e27
Fix 'dart --enable-asserts' typo in license check script ( flutter/engine#55082 )
...
`dart -enable-asserts` should be `--enable-asserts` with two `-`s.
License script is complaining:
```
Could not find an option with short name "-e".
```
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737159074465654417/+/u/test:_licenses_check/stdout
Typo from:
https://github.com/flutter/engine/pull/54845/files#diff-0845c01add635bd6976b8aefd761c14899002c53f9d0ff596cc7f4667cd49f71R84
Fixes https://github.com/flutter/flutter/issues/154942
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-09-10 20:12:07 +00:00
skia-flutter-autoroll
deac8c28f2
Roll Dart SDK from af7460619b2b to 741512e72e92 (1 revision) ( flutter/engine#55080 )
...
https://dart.googlesource.com/sdk.git/+log/af7460619b2b..741512e72e92
2024-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-236.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 20:08:24 +00:00
skia-flutter-autoroll
f9157edf80
Roll Skia from 4815ec808aa5 to 82d2e4033333 (8 revisions) ( flutter/engine#55079 )
...
https://skia.googlesource.com/skia.git/+log/4815ec808aa5..82d2e4033333
2024-09-10 robertphillips@google.com Protected bug fix
2024-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 61c26fd6930a to 501887159116 (20 revisions)
2024-09-10 bungeman@google.com Roll HarfBuzz from b74a7ecc to a070f9eb (268 commits)
2024-09-10 kjlubick@google.com Reland "Update to Bazel 7"
2024-09-10 bungeman@google.com Roll Expat from 441f98d0 to 624da0f5 (120 commits)
2024-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b339ed4daf66 to bda245ad94ff (25 revisions)
2024-09-10 borenet@google.com [bazel] Inline //bazel/external/win_toolchain/BUILD.bazel
2024-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 145442b950ac to f0364692215e (16 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 18:26:17 +00:00
Ryan Macnak
d3062f6a4d
Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. ( flutter/engine#55051 )
...
- Report the exit code for failed build-time executions.
Bug: https://github.com/dart-lang/sdk/issues/56529
2024-09-10 10:12:34 -07:00
skia-flutter-autoroll
a3fa3c67de
Roll Skia from 5dc067350ab5 to 4815ec808aa5 (2 revisions) ( flutter/engine#55074 )
...
https://skia.googlesource.com/skia.git/+log/5dc067350ab5..4815ec808aa5
2024-09-10 borenet@google.com [bazel] Add missing newline in download_toolchains.bzl
2024-09-10 kjlubick@google.com Move SkFourByteTag to its own file
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 15:15:06 +00:00
skia-flutter-autoroll
830b668a93
Roll Dart SDK from d59138eb6ec2 to af7460619b2b (1 revision) ( flutter/engine#55073 )
...
https://dart.googlesource.com/sdk.git/+log/d59138eb6ec2..af7460619b2b
2024-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-235.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 14:17:13 +00:00
skia-flutter-autoroll
8a1d2b1e8f
Roll Skia from c62380453c72 to 5dc067350ab5 (1 revision) ( flutter/engine#55072 )
...
https://skia.googlesource.com/skia.git/+log/c62380453c72..5dc067350ab5
2024-09-10 robertphillips@google.com Revert "MiraclePtr: Fetch partition_alloc."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 13:33:15 +00:00
skia-flutter-autoroll
b1a31b9b61
Roll Fuchsia Linux SDK from kIWQ460iagZLxVRPc... to 8XJTJm4D4Go1dBaTi... ( flutter/engine#55071 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 13:21:26 +00:00
skia-flutter-autoroll
ceb7015255
Roll Skia from 9bea95918e69 to c62380453c72 (1 revision) ( flutter/engine#55070 )
...
https://skia.googlesource.com/skia.git/+log/9bea95918e69..c62380453c72
2024-09-10 arthursonzogni@chromium.org MiraclePtr: Fetch partition_alloc.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 12:14:35 +00:00
skia-flutter-autoroll
fcabcc1a10
Roll Dart SDK from a60078a23978 to d59138eb6ec2 (2 revisions) ( flutter/engine#55068 )
...
https://dart.googlesource.com/sdk.git/+log/a60078a23978..d59138eb6ec2
2024-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-234.0.dev
2024-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-233.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 10:04:22 +00:00
Yegor
d7e52c7710
[skwasm] use temporary RawPaint objects (attempt #2 ) ( flutter/engine#55035 )
...
Relands https://github.com/flutter/engine/pull/54917 . The change is the same as before, except now the native resources for `SkwasmColorFilter` and `SkwasmImageFilter` classes are no longer GC'd. Instead, we use manually managed native handles (vended and scoped by `withRawColorFilter` and `withRawImageFilter`). The bug in the previous PR was that filter objects were disposed with the paint while the framework continued holding onto them. When GC kicked the finalization registry, it attempted to double-free the filters.
2024-09-10 04:10:26 +00:00
skia-flutter-autoroll
4d39ebc0df
Roll Dart SDK from b6c3cd9b93f1 to a60078a23978 (14 revisions) ( flutter/engine#55059 )
...
https://dart.googlesource.com/sdk.git/+log/b6c3cd9b93f1..a60078a23978
2024-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-232.0.dev
2024-09-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-231.0.dev
2024-09-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-230.0.dev
2024-09-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-229.0.dev
2024-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-228.0.dev
2024-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-227.0.dev
2024-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-226.0.dev
2024-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-225.0.dev
2024-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-224.0.dev
2024-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-223.0.dev
2024-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-222.0.dev
2024-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-221.0.dev
2024-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-220.0.dev
2024-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-219.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 03:52:38 +00:00
Jason Simmons
2b0b252f06
Add missing include to fml/hex_codec.h ( flutter/engine#55034 )
2024-09-09 23:55:14 +00:00
skia-flutter-autoroll
2b9f1fc6c8
Roll Skia from 7e659d5538fa to 9bea95918e69 (3 revisions) ( flutter/engine#55052 )
...
https://skia.googlesource.com/skia.git/+log/7e659d5538fa..9bea95918e69
2024-09-09 kjlubick@google.com Update assertion in SkParagraph JS test
2024-09-09 michaelludwig@google.com [graphite] Clean up PaintParamsKey printing
2024-09-09 michaelludwig@google.com [graphite] Remember DstReadRequirement on GraphicsPipelines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 22:57:23 +00:00
Jenn Magder
0a26313116
Unskip Impeller iOS scenario tests ( flutter/engine#55012 )
...
The iOS golden scenario tests are supposed to run on Skia and Impeller, but are actually running on Skia twice.
#### Issue 1: script-side
Regression from https://github.com/flutter/engine/pull/46329 .
Currently, the tests log "Running simulator tests with Impeller" but then you see that it's not:
```
Running simulator tests with Impeller
...
2024-09-06 13:38:07.692810-0700 Scenarios[73857:470266] [IMPORTANT:flutter/shell/common/shell.cc(456)] [Action Required] The application opted out of Impeller by either using the --no-enable-impeller flag or FLTEnableImpeller=false plist flag. This option is going to go away in an upcoming Flutter release. Remove the explicit opt-out. If you need to opt-out, report a bug describing the issue.
```
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737514337106072353/+/u/test:_Scenario_App_Integration_Tests/stdout
`INFOPLIST_FILE="Scenarios/Info_Impeller.plist"` isn't passed into the xcodebuild any more. I confirmed #46329 caused this by inserting a comment in the middle of the `xcodebuild` command, which caused the last argument after the comment to not be passed in.
#### Issue 2: test-side
Regression from https://github.com/flutter/engine/pull/45093 .
[The logic deciding whether to use Skia or Impeller goldens is incorrect](1da5dd68fd/testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenTestManager.m (L84-L90)https://github.com/flutter/engine/pull/55016 merges (edit: done), these tests will no longer be running with the software renderer. Remove all the test skips so they all run on Impeller.
2. Add the missing Impeller golden screenshots.
3. Update the default Info.plist to use Impeller, so if another script mishap happens, it will default to testing Impeller twice, and not Skia. Add a Skia Info.plist variant instead.
4. Update the test logic to check the right bundle ID Info.plist to decide whether to compare against the Skia or Impeller screenshots. Prefer Impeller so if another test-side mishap happens, it will also default to testing Impeller and not Skia. It will only use the Skia goldens if the bool is set in the Info.plist, and that bool is NO (not just if it's missing).
5. All this made the now-default Impeller tests pass, but when passing in `INFOPLIST_FILE="Scenarios/Info_Skia.plist"` the app wasn't launching, with the error:
> Scenarios encountered an error (Failed to install or launch the test runner. (Underlying Error: Simulator device returned an error for the requested operation. Failed to create promise. (Underlying Error: Failed to create app extension placeholder for /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Scenarios-aypjgouuxctxctfazxalyegcximf/Build/Products/Debug-iphonesimulator/Scenarios.app/PlugIns/ScenariosShare.appex. Failed to create promise. (Underlying Error: Failed to set placeholder attributes dev.flutter.Scenarios.ScenariosShare. Failed to create promise. (Underlying Error: extensionDictionary must be set in placeholder attributes for an app extension placeholder. Invalid placeholder attributes.)))))
This is identical to the error in https://github.com/flutter/engine/pull/53717 . I finally realized it was because the ScenariosShare app extension requires specific extension keys in its plist, which weren't present in the app Info.plist at `Scenarios/Info_Skia.plist`. So I changed the `INFOPLIST_FILE` path to `$(TARGET_NAME)/Info_Skia.plist` so it would resolve to target-specific copies like `Scenarios/ScenariosShare/Info_Skia.plist`. That meant I had to add a few more copies where they didn't exist in the target path.
Dependent on https://github.com/flutter/engine/pull/55016 landing.
Fixes https://github.com/flutter/flutter/issues/131888
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-09-09 21:47:04 +00:00
skia-flutter-autoroll
3bb536e5a4
Roll Skia from 7ad1252da14f to 7e659d5538fa (2 revisions) ( flutter/engine#55050 )
...
https://skia.googlesource.com/skia.git/+log/7ad1252da14f..7e659d5538fa
2024-09-09 borenet@google.com [bazel] Move win_toolchain dep into download_toolchains_for_skia
2024-09-09 kjlubick@google.com Remove unneeded SK_GRAPHITE guards
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 21:35:59 +00:00
skia-flutter-autoroll
e8b316d2ea
Roll Skia from 8103f53635fd to 7ad1252da14f (3 revisions) ( flutter/engine#55046 )
...
https://skia.googlesource.com/skia.git/+log/8103f53635fd..7ad1252da14f
2024-09-09 jsimmons@google.com Include the ellipsis when computing the width of the longest line
2024-09-09 bungeman@google.com SkFontMgr_android should not crash if no fonts
2024-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ae6e9c9c9202 to 145442b950ac (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 20:15:59 +00:00
Jonah Williams
f679a6aa54
[Impeller] fix obvious memory leak. ( flutter/engine#55036 )
...
Fixes https://github.com/flutter/flutter/issues/154549
Each overlay surface gets its own content context and each cc gets its own transient buffer. So not reseting the overlay surfaces causes a memory leak. The overlay surfaces would just continue to allocate into the same buffer which would allocate endlessly
2024-09-09 18:18:02 +00:00
Jonah Williams
b8ae2f24af
[Impeller] add herustic for ignoring coverage limit w/ image filters. ( flutter/engine#55030 )
...
Switching to save_layer_utils regressed perf/memory usage on several devicelab benchmarks, see https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_gpu_memory_mb%26sub_result%3Daverage_gpu_memory_mb%26test%3Dnew_gallery_impeller_old_zoom__transition_perf&selected=commit%3D42418%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D90th_percentile_gpu_memory_mb%252Ctest%253Dnew_gallery_impeller_old_zoom__transition_perf%252C
The reason is that the source_coverage_limit [intersection](https://github.com/flutter/engine/blob/main/impeller/entity/save_layer_utils.cc#L67-L68 ) is highly unstable from frame to frame if there is an animated blur and/or image filter.
This change mostly matches the old entity pass behavior. . In cases where the difference between the intersected coverage result is small (< 20% in both dimensions), we just use the transformed content coverage.
The old behavior would _always_ use the transformed content coverage even if it was substantially large than the coverage limit. This posed problems if folks drew content larger than the max texture size. This herustic attempts to prevent that by allowing the source coverage limit to kick in once the difference is larger than 20% in either direction
2024-09-09 18:17:59 +00:00
skia-flutter-autoroll
96b03463c1
Roll Skia from f7e4ddabb754 to 8103f53635fd (1 revision) ( flutter/engine#55043 )
...
https://skia.googlesource.com/skia.git/+log/f7e4ddabb754..8103f53635fd
2024-09-09 nscobie@google.com Revert "Move SkMSec out of public API"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 17:36:16 +00:00
Jackson Gardner
4a1b51bdda
Revert "Add crossOrigin property to <img> tag used for decoding ( #54961 )" ( flutter/engine#55042 )
...
This reverts commit acf6660982dff1f924f3438f05a41bcdba649105.
Reason for revert: We broke users (including a Google internal customer) that depend on credentialed image requests. See https://github.com/flutter/flutter/issues/154809
Fixes https://github.com/flutter/flutter/issues/154809
2024-09-09 17:22:02 +00:00
skia-flutter-autoroll
2783af7183
Roll Skia from 06cd203d0607 to f7e4ddabb754 (2 revisions) ( flutter/engine#55041 )
...
https://skia.googlesource.com/skia.git/+log/06cd203d0607..f7e4ddabb754
2024-09-09 fmalita@google.com [skottie] Allow conincident keyframes
2024-09-09 kjlubick@google.com Revert "Update to Bazel 7"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 16:17:04 +00:00
skia-flutter-autoroll
7d6bb315bc
Roll Fuchsia Linux SDK from Dxly0DC9pQXTXVNm0... to kIWQ460iagZLxVRPc... ( flutter/engine#55039 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 12:10:38 +00:00
Jonah Williams
0a0883219e
[engine] dispatch platform channel messages through event loop, except navigation on start. ( flutter/engine#55027 )
...
This is a re-land of https://github.com/flutter/engine/pull/55006 , except that we special case the navigation channel to immediately dispatch its message if the isolate is not yet running.
This preserves the existing behavior relied upon by several iOS add2app tests, as well as the still used embedder v1 - and potentially undicovered future embedders.
2024-09-08 17:38:18 +00:00
skia-flutter-autoroll
dd4387264c
Roll Fuchsia Linux SDK from BF-8UyvqW5l52-hP2... to Dxly0DC9pQXTXVNm0... ( flutter/engine#55033 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 09:02:23 +00:00
skia-flutter-autoroll
c70a8bb1dd
Manual roll Dart SDK from 0f783bdb7a4d to b6c3cd9b93f1 (1 revision) ( flutter/engine#55031 )
...
Manual roll requested by asiva@google.com
https://dart.googlesource.com/sdk.git/+log/0f783bdb7a4d..b6c3cd9b93f1
2024-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-218.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com ,codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 06:19:30 +00:00
Jonah Williams
5b3c9eb175
[Impeller] Disable exp canvas. ( flutter/engine#55026 )
...
Speculative revert for current devicelab failures.
2024-09-07 17:37:09 +00:00
skia-flutter-autoroll
4059a08e64
Roll Fuchsia Linux SDK from PBeI0gGvgFdXV6hCg... to BF-8UyvqW5l52-hP2... ( flutter/engine#55024 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 07:41:23 +00:00
auto-submit[bot]
f84f9c92b5
Reverts "[engine] reland: always post tasks for platform channel responses. ( #55006 )" ( flutter/engine#55022 )
...
Reverts: flutter/engine#55006
Initiated by: jonahwilliams
Reason for reverting: still failling mac module test
Original PR Author: jonahwilliams
Reviewed By: {jason-simmons}
This change reverts the following previous change:
Reland of https://github.com/flutter/engine/pull/54975
Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
2024-09-07 02:56:46 +00:00
Jenn Magder
64437a0b8f
Turn off software rendering in iOS scenario golden tests ( flutter/engine#55016 )
...
Follow-up to https://github.com/flutter/engine/pull/45093 . Remove software rendering for the golden/screenshot compare iOS scenario tests. Throw an exception if this flag is passed into the test app. Delete `RenderingSelectionTest`.
This did require updating some screenshots, so there are changes.
Note, these golden tests are still not running on Impeller, but I'm going to follow-up in https://github.com/flutter/engine/pull/55012 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-09-07 02:44:26 +00:00
auto-submit[bot]
a16be84457
Reverts "[skwasm] use temporary RawPaint objects ( #54917 )" ( flutter/engine#55018 )
...
Reverts: flutter/engine#54917
Initiated by: jonahwilliams
Reason for reverting: failing on framework -> engine roll https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_skwasm_tests_7_last/10571/overview
Original PR Author: yjbanov
Reviewed By: {eyebrowsoffire}
This change reverts the following previous change:
Same as https://github.com/flutter/engine/pull/54818 , but for Skwasm.
Addresses the `Paint` issue in https://github.com/flutter/flutter/issues/153678 in Skwasm
2024-09-07 00:19:45 +00:00
Jonah Williams
8ca7e1cd90
[engine] reland: always post tasks for platform channel responses. ( flutter/engine#55006 )
...
Reland of https://github.com/flutter/engine/pull/54975
Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
2024-09-06 23:48:09 +00:00
skia-flutter-autoroll
e81422cd4c
Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) ( flutter/engine#55014 )
...
https://skia.googlesource.com/skia.git/+log/4786936b4c0c..06cd203d0607
2024-09-06 kjlubick@google.com Move SkMSec out of public API
2024-09-06 bungeman@google.com Replace "exec_tools" with "tools"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 22:47:24 +00:00
Paul Berry
92e2915b51
[multiple] Avoid new unreachable_switch_default warning. ( flutter/engine#54996 )
...
The Dart analyzer will soon be changed so that if the `default` clause
of a `switch` statement is determined to be unreachable by the
exhaustiveness checker, a new warning of type
`unreachable_switch_default` will be issued. This parallels the behavior
of the existing `unreachable_switch_case` warning, which is issued
whenever a `case` clause of a `switch` statement is determined to be
unreachable.
Before adding the new warning to the analyzer, code in the engine needs
to first be updated to eliminate these unreachable `default` clauses, so
that the warning won't cause builds to break.
For more information, see
https://github.com/dart-lang/sdk/issues/54575 .
2024-09-06 15:24:36 -07:00
Yegor
adfd4c03de
[skwasm] use temporary RawPaint objects ( flutter/engine#54917 )
...
Same as https://github.com/flutter/engine/pull/54818 , but for Skwasm.
Addresses the `Paint` issue in https://github.com/flutter/flutter/issues/153678 in Skwasm
2024-09-06 22:21:54 +00:00
Jim Graham
6d0f7279e2
[DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods ( flutter/engine#54982 )
...
Wean the DlOpReceiver interface and implementations off of using the SkScalar, Sk[I]Rect, and SkPoint objects in favor of our own DL/Impeller versions.
The start of an ongoing effort to eventually compartmentalize all use of Skia interfaces into a single backend rendering module that is one of 2 semi-pluggable renderers.
2024-09-06 22:16:05 +00:00
skia-flutter-autoroll
199369b902
Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) ( flutter/engine#55013 )
...
https://skia.googlesource.com/skia.git/+log/f38ea0134dba..4786936b4c0c
2024-09-06 jvanverth@google.com Revert "[graphite] Swap shape inversion for ClipOps."
2024-09-06 kjlubick@google.com Update to Bazel 7
2024-09-06 lukasza@chromium.org [rust png] Implement `SkPngRustCodec::onGetRepetitionCount`.
2024-09-06 michaelludwig@google.com [graphite] Add replayTranslation and dstCopyOffset to intrinsic uniforms
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 21:34:35 +00:00
Jonah Williams
1da5dd68fd
[Impeller] opt into exp canvas. ( flutter/engine#54913 )
...
Switch back to new canvas implementation, which allows us to complete the display list/impeller interop arc of work. While we're at it, switch the subpass size rounding logic to round out if there is no image filter.
Fixes https://github.com/flutter/flutter/issues/152366
Part of https://github.com/flutter/flutter/issues/142054
2024-09-06 20:33:22 +00:00
skia-flutter-autoroll
04fffd2fbe
Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) ( flutter/engine#55008 )
...
https://skia.googlesource.com/skia.git/+log/8f62a6a4a299..f38ea0134dba
2024-09-06 michaelludwig@google.com [graphite] Centralize handling of viewport/rtAdjust values
2024-09-06 egdaniel@google.com [Vulkan] Fix deletion of fences on failed submits.
2024-09-06 egdaniel@google.com [Vulkan] Add AHARDWAREBUFFER_FORMAT_R10G10B10A10_UNORM checks to switch statements.
2024-09-06 robertphillips@google.com [graphite] Move lingering Viewer flag handling to SetTestOptions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 19:39:52 +00:00
Jonah Williams
547dbe4c4c
[impeller] fake image for fake tests. ( flutter/engine#54974 )
...
Simulator only change to allow toImage and toByteData to not fail when there is no metal context w/ impeller.
2024-09-06 18:53:53 +00:00
skia-flutter-autoroll
ac26f2ceb4
Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) ( flutter/engine#55001 )
...
https://skia.googlesource.com/skia.git/+log/6ad117bd2efe..8f62a6a4a299
2024-09-06 michaelludwig@google.com [graphite] Move SkSL compilation into MtlGraphics|ComputePipeline::Make
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 17:03:27 +00:00
davidhicks980
6674a4c33b
Change "there own" to "their own" in Flutter-GPU docs ( flutter/engine#54921 )
...
Changed the word "there" to "their" in Flutter GPU doc... which I think is correct, but I could be wrong. Thanks!
- [] I listed at least one issue that this PR fixes in the description above.
- [] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-09-06 16:49:18 +00:00
auto-submit[bot]
f3c121ecb5
Reverts "[engine] always force platform channel responses to schedule a task. ( #54975 )" ( flutter/engine#55000 )
...
Reverts: flutter/engine#54975
Initiated by: jtmcdole
Reason for reverting: I believe this change caused flutter/flutter to break in an engine roll. It was one of two changes - the other being a webui change.
Tests broken:
module_test_ios: testDualCold
router test:
```
[2024-09-05 17:43:20.837343] [STDOUT] stderr: [ +135 ms] VMServiceFlutterDriver: Connected to Flutter application.
[2024-09-05 17:43:20.841927] [STDOUT] stdout: [ +4 ms] 00:00 [32m+0[0m:
Original PR Author: jonahwilliams
Reviewed By: {jason-simmons, johnmccutchan}
This change reverts the following previous change:
If we use runNowOrPostTask on platform channel responses, then we may not wake up the dart message loop. If nothing else wakes it up, then the embedder may hang on platform channel responses.
This fixes several google3 integration tests when run in merged thread mode.
2024-09-06 15:54:46 +00:00
skia-flutter-autoroll
4363170f96
Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions) ( flutter/engine#54999 )
...
https://skia.googlesource.com/skia.git/+log/b6bab0fde426..6ad117bd2efe
2024-09-06 michaelludwig@google.com [graphite] Simplify Dawn bound uniform tracking
2024-09-06 michaelludwig@google.com [graphite] Refactor Dawn intrinsic uniforms handling into helper class
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 15:39:50 +00:00
skia-flutter-autoroll
6c95276442
Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to 5dqcFlKzRjJb6V95W... ( flutter/engine#54998 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,codefu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 14:49:37 +00:00
skia-flutter-autoroll
2663a35787
Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions) ( flutter/engine#54997 )
...
https://skia.googlesource.com/skia.git/+log/a09312b70d37..b6bab0fde426
2024-09-06 kjlubick@google.com Add debugging to fiddler-backend Docker creation
2024-09-06 kjlubick@google.com Make skia-client-search more public friendly
2024-09-06 kjlubick@google.com Add release_tag script for fiddler image
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 14:18:04 +00:00
skia-flutter-autoroll
ab9ebe1fd0
Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision) ( flutter/engine#54995 )
...
https://skia.googlesource.com/skia.git/+log/368f209ccca5..a09312b70d37
2024-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a0dffec9be81 to ae6e9c9c9202 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 12:59:13 +00:00
skia-flutter-autoroll
5dbb04ad1e
Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions) ( flutter/engine#54992 )
...
https://skia.googlesource.com/skia.git/+log/aec11ae18bb6..368f209ccca5
2024-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 59eff3660f81 to 61c26fd6930a (3 revisions)
2024-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f982e0beb5db to b96a50f0c8f0 (11 revisions)
2024-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d3b7a448690d to b339ed4daf66 (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 08:33:38 +00:00
skia-flutter-autoroll
9975d42922
Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg... ( flutter/engine#54990 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-06 06:27:04 +00:00
